Bug 1501381 - Fixes to the updater's plist metadata. r=spohl
authorRobert Strong <robert.bugzilla@gmail.com>
Tue, 23 Oct 2018 14:33:59 -0700
changeset 490919 969fc88ef9a4aa881650668a1ddc16318802ce5c
parent 490918 918d2aeb31eb7d18603be0c5f6ae9b27c12b6fc2
child 490920 083f0be93a9f9da00b886cba36ca1e48fc168f5b
push id247
push userfmarier@mozilla.com
push dateSat, 27 Oct 2018 01:06:44 +0000
reviewersspohl
bugs1501381
milestone65.0a1
Bug 1501381 - Fixes to the updater's plist metadata. r=spohl Change the value of CFBundleName in Info.plist.in to 'updater' so it is less than 16 characters long per the spec Change the value of CFBundleName in InfoPlist.strings.in to 'Software Update' so it is less than 16 characters long per the spec and a generic string for the updater can be displayed Add a short version of CFBundleDisplayName to Info.plist.in to 'updater' Add a long version of CFBundleDisplayName to InfoPlist.strings.in to '%APP_NAME% Software Update' so a more detailed string for the updater can be displayed Add LSHasLocalizedDisplayName to Info.plist.in so the localized display name will be used Remove LSMinimumSystemVersion and LSMinimumSystemVersionByArchitecture in InfoPlist.strings.in since they are no longer needed
toolkit/mozapps/update/updater/macbuild/Contents/Info.plist.in
toolkit/mozapps/update/updater/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in
--- a/toolkit/mozapps/update/updater/macbuild/Contents/Info.plist.in
+++ b/toolkit/mozapps/update/updater/macbuild/Contents/Info.plist.in
@@ -1,41 +1,38 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
 	<key>CFBundleDevelopmentRegion</key>
 	<string>English</string>
+	<key>CFBundleDisplayName</key>
+	<string>updater</string>
 	<key>CFBundleExecutable</key>
 	<string>org.mozilla.updater</string>
 	<key>CFBundleIconFile</key>
 	<string>updater.icns</string>
 	<key>CFBundleIdentifier</key>
 	<string>org.mozilla.updater</string>
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
+	<key>CFBundleName</key>
+	<string>updater</string>
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
 	<string>1.0</string>
+	<key>LSHasLocalizedDisplayName</key>
+	<true/>
 	<key>NSMainNibFile</key>
 	<string>MainMenu</string>
 	<key>NSPrincipalClass</key>
 	<string>NSApplication</string>
-	<key>LSMinimumSystemVersion</key>
-	<string>10.5</string>
-	<key>LSMinimumSystemVersionByArchitecture</key>
-	<dict>
-		<key>i386</key>
-		<string>10.5.0</string>
-		<key>x86_64</key>
-		<string>10.6.0</string>
-	</dict>
 	<key>LSUIElement</key>
 	<true/>
 	<key>SMAuthorizedClients</key>
 	<array>
 		<string>identifier "%MOZ_MACBUNDLE_ID%" and ((anchor apple generic and certificate leaf[field.1.2.840.113635.100.6.1.9]) or (anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] and certificate leaf[field.1.2.840.113635.100.6.1.13] and certificate leaf[subject.OU] = "43AQ936H96"))</string>
 	</array>
 </dict>
 </plist>
--- a/toolkit/mozapps/update/updater/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in
+++ b/toolkit/mozapps/update/updater/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in
@@ -1,7 +1,8 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* Localized versions of Info.plist keys */
 
-CFBundleName = "%APP_NAME% Software Update";
+CFBundleName = "Software Update";
+CFBundleDisplayName = "%APP_NAME% Software Update";