Bug 972284 - "Remove the "→" from networkMenu.totalMS" r=vporof
authorAriel Burone <aburone>
Sat, 06 Oct 2018 00:28:00 +0300
changeset 488550 9293f334a9949164ac1b0dea5ad40eaeb44ef2da
parent 488549 454acf410953fed760707f29b7f1594ceeeb0cdd
child 488551 d49a5d674e007fc79beda9437889ca5a1eec4aa2
child 488574 77491723486d3fb28d0001d2c603145696560ce7
push id246
push userfmarier@mozilla.com
push dateSat, 13 Oct 2018 00:15:40 +0000
reviewersvporof
bugs972284
milestone64.0a1
Bug 972284 - "Remove the "→" from networkMenu.totalMS" r=vporof
devtools/client/locales/en-US/netmonitor.properties
devtools/client/netmonitor/src/components/RequestListColumnWaterfall.js
devtools/client/netmonitor/src/components/TimingsPanel.js
devtools/client/netmonitor/test/browser_net_prefs-and-l10n.js
--- a/devtools/client/locales/en-US/netmonitor.properties
+++ b/devtools/client/locales/en-US/netmonitor.properties
@@ -215,19 +215,19 @@ networkMenu.sizeUnavailable.title=Transf
 # cached.
 networkMenu.sizeCached=cached
 
 # LOCALIZATION NOTE (networkMenu.sizeServiceWorker): This is the label displayed
 # in the network menu specifying the transferred of a request computed
 # by a service worker.
 networkMenu.sizeServiceWorker=service worker
 
-# LOCALIZATION NOTE (networkMenu.totalMS): This is the label displayed
+# LOCALIZATION NOTE (networkMenu.totalMS2): This is the label displayed
 # in the network menu specifying the time for a request to finish (in milliseconds).
-networkMenu.totalMS=→ %S ms
+networkMenu.totalMS2=%S ms
 
 # This string is used to concatenate tooltips (netmonitor.waterfall.tooltip.*)
 # in the requests waterfall for total time (in milliseconds). \\u0020 represents
 # a whitespace. You can replace this with a different character, e.g. an hyphen
 # or a period, if a comma doesn't work for your language.
 netmonitor.waterfall.tooltip.separator=,\u0020
 
 # LOCALIZATION NOTE (netmonitor.waterfall.tooltip.total): This is part of the tooltip
--- a/devtools/client/netmonitor/src/components/RequestListColumnWaterfall.js
+++ b/devtools/client/netmonitor/src/components/RequestListColumnWaterfall.js
@@ -99,17 +99,17 @@ class RequestListColumnWaterfall extends
               style: { width },
             })
           );
         }
       }
     }
 
     if (typeof totalTime === "number") {
-      const title = L10N.getFormatStr("networkMenu.totalMS", totalTime);
+      const title = L10N.getFormatStr("networkMenu.totalMS2", totalTime);
       boxes.push(
         div({
           key: "total",
           className: "requests-list-timings-total",
           title,
         }, title)
       );
     }
--- a/devtools/client/netmonitor/src/components/TimingsPanel.js
+++ b/devtools/client/netmonitor/src/components/TimingsPanel.js
@@ -80,17 +80,17 @@ class TimingsPanel extends Component {
           }),
           span({
             className: `requests-list-timings-box ${type}`,
             style: {
               width: `calc(${timelineScale} * (100% - ${TIMINGS_END_PADDING}))`,
             },
           }),
           span({ className: "requests-list-timings-total" },
-            L10N.getFormatStr("networkMenu.totalMS", timings[type])
+            L10N.getFormatStr("networkMenu.totalMS2", timings[type])
           )
         ),
       );
     });
 
     return (
       div({ className: "panel-container" },
         timelines,
--- a/devtools/client/netmonitor/test/browser_net_prefs-and-l10n.js
+++ b/devtools/client/netmonitor/test/browser_net_prefs-and-l10n.js
@@ -19,17 +19,17 @@ add_task(async function() {
   testL10N();
   testPrefs();
 
   return teardown(monitor);
 
   function testL10N() {
     is(typeof L10N.getStr("netmonitor.security.enabled"), "string",
       "The getStr() method didn't return a valid string.");
-    is(typeof L10N.getFormatStr("networkMenu.totalMS", "foo"), "string",
+    is(typeof L10N.getFormatStr("networkMenu.totalMS2", "foo"), "string",
       "The getFormatStr() method didn't return a valid string.");
   }
 
   function testPrefs() {
     is(Prefs.networkDetailsWidth,
       Services.prefs.getIntPref("devtools.netmonitor.panes-network-details-width"),
       "Getting a pref should work correctly.");