Bug 1499944 - Don't show detail view when changing plugin state r=jaws
authorMark Striemer <mstriemer@mozilla.com>
Thu, 18 Oct 2018 18:43:03 +0000
changeset 490336 7b0a8e47d25608312af369290db040fa9009ddcf
parent 490335 9a404545425a2d59f36f3acadc99f1a55c366429
child 490337 c0c288dc283e315982949e5d6565520f5872ab12
child 490369 272fbc5589a88513c9e9212d94bc6792731bc434
push id247
push userfmarier@mozilla.com
push dateSat, 27 Oct 2018 01:06:44 +0000
reviewersjaws
bugs1499944
milestone64.0a1
Bug 1499944 - Don't show detail view when changing plugin state r=jaws Differential Revision: https://phabricator.services.mozilla.com/D9061
toolkit/mozapps/extensions/content/extensions.xml
--- a/toolkit/mozapps/extensions/content/extensions.xml
+++ b/toolkit/mozapps/extensions/content/extensions.xml
@@ -1486,17 +1486,17 @@
         <body><![CDATA[
             this._updateState();
         ]]></body>
       </method>
     </implementation>
 
     <handlers>
       <handler event="click" button="0"><![CDATA[
-        if (!["button", "checkbox"].includes(event.originalTarget.localName) &&
+        if (!["button", "checkbox", "menulist", "menuitem"].includes(event.originalTarget.localName) &&
             !event.originalTarget.classList.contains("text-link")) {
           this.showInDetailView();
         }
       ]]></handler>
     </handlers>
   </binding>