Bug 1388134 - Fix lazy OS.Constants.Path breakage in addons test r=aswan
authorDoug Thayer <dothayer@mozilla.com>
Wed, 17 Oct 2018 17:37:10 +0000
changeset 490111 79444293ad73024fec1b8363de9a304737f5c098
parent 490110 3f01db01f1d3e286ee75b8c349e6c2915512a96f
child 490112 b2156ede19a58ae592cb36dece61f66e691bf54f
push id247
push userfmarier@mozilla.com
push dateSat, 27 Oct 2018 01:06:44 +0000
reviewersaswan
bugs1388134
milestone64.0a1
Bug 1388134 - Fix lazy OS.Constants.Path breakage in addons test r=aswan Delaying the loading of some OS.Constants.Path members to reduce startup IO is breaking the test_system_delay_update.js test, because it leaves tmpaddon-* files in the user's temp directory. As far as I can tell this is okay (please correct me if wrong) - but the error in AddonTestUtils was being avoided because the OS.Constants.Path.tmpDir value was being read before we override TmpD for the test. So now we are leaving them to be ignored in the TmpD directory we specified, rather than leaving them to be ignored in the user's temp directory. Depends on D6080 Differential Revision: https://phabricator.services.mozilla.com/D6081
toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini
--- a/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini
+++ b/toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini
@@ -213,16 +213,17 @@ tags = blocklist
 fail-if = os == "android"
 [test_strictcompatibility.js]
 [test_switch_os.js]
 # Bug 1246231
 skip-if = os == "mac" && debug
 [test_syncGUID.js]
 [test_system_allowed.js]
 [test_system_delay_update.js]
+skip-if = true # Bug 1495021
 [test_system_repository.js]
 [test_system_reset.js]
 [test_system_update_blank.js]
 [test_system_update_checkSizeHash.js]
 [test_system_update_custom.js]
 [test_system_update_empty.js]
 skip-if = true # Failing intermittently due to a race condition in the test, see bug 1348981
 [test_system_update_enterprisepolicy.js]