Bug 1483325 - re-enable sidebar test after checking for correct messages to get them out of the queue, rs=mixedpuppy
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Thu, 30 Aug 2018 00:43:06 +0100
changeset 482342 4e8684ce7609bfb45570b0eaa2b9e89efc487fc7
parent 482341 fb2c0eb9ad707ed11f05e7159ba3a132ead10879
child 482343 ecf1c85b657f0828a6e7541253b8226be2351db2
push id232
push userfmarier@mozilla.com
push dateWed, 05 Sep 2018 20:45:54 +0000
reviewersmixedpuppy
bugs1483325
milestone63.0a1
Bug 1483325 - re-enable sidebar test after checking for correct messages to get them out of the queue, rs=mixedpuppy
browser/components/extensions/test/browser/browser-common.ini
browser/components/extensions/test/browser/browser_ext_sidebarAction.js
--- a/browser/components/extensions/test/browser/browser-common.ini
+++ b/browser/components/extensions/test/browser/browser-common.ini
@@ -154,17 +154,16 @@ skip-if = !e10s || !crashreporter # the 
 [browser_ext_sessions_getRecentlyClosed.js]
 [browser_ext_sessions_getRecentlyClosed_private.js]
 [browser_ext_sessions_getRecentlyClosed_tabs.js]
 [browser_ext_sessions_restore.js]
 [browser_ext_sessions_restoreTab.js]
 [browser_ext_sessions_window_tab_value.js]
 [browser_ext_settings_overrides_default_search.js]
 [browser_ext_sidebarAction.js]
-skip-if = debug #Bug 1483325
 [browser_ext_sidebarAction_browser_style.js]
 [browser_ext_sidebarAction_context.js]
 [browser_ext_sidebarAction_contextMenu.js]
 [browser_ext_sidebarAction_runtime.js]
 [browser_ext_sidebarAction_tabs.js]
 [browser_ext_sidebarAction_windows.js]
 [browser_ext_simple.js]
 [browser_ext_slow_script.js]
--- a/browser/components/extensions/test/browser/browser_ext_sidebarAction.js
+++ b/browser/components/extensions/test/browser/browser_ext_sidebarAction.js
@@ -65,16 +65,17 @@ async function sendMessage(ext, msg, dat
   ext.sendMessage({msg, data});
   await ext.awaitMessage("done");
 }
 
 add_task(async function sidebar_initial_install() {
   ok(document.getElementById("sidebar-box").hidden, "sidebar box is not visible");
   let extension = ExtensionTestUtils.loadExtension(getExtData());
   await extension.startup();
+  await extension.awaitMessage("sidebar");
 
   // Test sidebar is opened on install
   ok(!document.getElementById("sidebar-box").hidden, "sidebar box is visible");
 
   await extension.unload();
   // Test that the sidebar was closed on unload.
   ok(document.getElementById("sidebar-box").hidden, "sidebar box is not visible");
 });