Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Fri, 12 Oct 2018 15:07:17 +0100
changeset 489305 4c11d8d96c247b0057a30e1521ac56ce90283f5e
parent 489304 2cd2f8f1bc806c45b5d797809abcec8688b1ab65
child 489306 340e50c6e0cbb28f5e19ef359b1896d7c94ae009
push id247
push userfmarier@mozilla.com
push dateSat, 27 Oct 2018 01:06:44 +0000
reviewersbgrins, MarcoZ
bugs1498274
milestone64.0a1
Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ These are two other cases where grouping is not really necessary. For accessibility, the checkbox at the end of the download interstitial dialog does not need to be in the same group as the radio button, and the question text can more simply just label the radiogroup. The vbox is still necessary to hide the section, but is not related to accessibility or dialog structure. Differential Revision: https://phabricator.services.mozilla.com/D8421
browser/components/shell/content/setDesktopBackground.xul
browser/locales/en-US/chrome/browser/setDesktopBackground.dtd
toolkit/mozapps/downloads/content/unknownContentType.xul
--- a/browser/components/shell/content/setDesktopBackground.xul
+++ b/browser/components/shell/content/setDesktopBackground.xul
@@ -56,24 +56,22 @@
       </menulist>
       <spacer flex="1"/>
       <label value="&color.label;"/>
       <html:input id="desktopColor"
                   type="color"
                   onchange="gSetBackground.updateColor(this.value);"/> 
     </hbox>
 #endif
-    <groupbox align="center">
-      <caption label="&preview.label;"/>
-      <stack>
-        <!-- if width and height are not present, they default to 300x150 and stretch the stack -->
-        <html:canvas id="screen" width="1" height="1"/>
-        <image id="monitor"/>
-      </stack>
-    </groupbox>
+
+    <stack>
+      <!-- if width and height are not present, they default to 300x150 and stretch the stack -->
+      <html:canvas id="screen" width="1" height="1" role="presentation"/>
+      <image id="monitor"/>
+    </stack>
 
 #ifdef XP_MACOSX
     <separator/>
 
     <hbox align="right">
       <button id="setDesktopBackground"
               label="&setDesktopBackground.title;"
               oncommand="gSetBackground.setDesktopBackground();"/>
--- a/browser/locales/en-US/chrome/browser/setDesktopBackground.dtd
+++ b/browser/locales/en-US/chrome/browser/setDesktopBackground.dtd
@@ -3,13 +3,12 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <!ENTITY position.label             "Position:">
 <!ENTITY tile.label                 "Tile">
 <!ENTITY center.label               "Center">
 <!ENTITY stretch.label              "Stretch">
 <!ENTITY fill.label                 "Fill">
 <!ENTITY fit.label                  "Fit">
-<!ENTITY preview.label              "Preview">
 <!ENTITY color.label                "Color:">
 <!ENTITY setDesktopBackground.title "Set Desktop Background">
 <!ENTITY openDesktopPrefs.label     "Open Desktop Preferences">
 <!ENTITY closeWindow.key            "w">
--- a/toolkit/mozapps/downloads/content/unknownContentType.xul
+++ b/toolkit/mozapps/downloads/content/unknownContentType.xul
@@ -53,19 +53,19 @@
     </hbox>
     
     <separator class="thin"/>
 
     <hbox align="center" id="basicBox" collapsed="true">
       <label id="unknownPrompt" value="&unknownPromptText.label;" flex="1"/>
     </hbox>
 
-    <groupbox flex="1" id="normalBox">
-      <caption label="&actionQuestion.label;"/>
-      <separator class="thin"/>
+    <vbox flex="1" id="normalBox">
+      <separator/>
+      <label control="mode" class="header" value="&actionQuestion.label;"/>
       <radiogroup id="mode" class="small-indent">
         <hbox>
           <radio id="open" label="&openWith.label;" accesskey="&openWith.accesskey;"/>
           <deck id="modeDeck" flex="1">
             <hbox id="openHandlerBox" flex="1" align="center"/>
             <hbox flex="1" align="center">
               <button id="chooseButton" oncommand="dialog.chooseApp();"
 #ifdef XP_MACOSX
@@ -88,17 +88,17 @@
       
       <separator/>
 #ifdef XP_UNIX
       <description id="settingsChange" hidden="true">&settingsChangePreferences.label;</description>
 #else
       <description id="settingsChange" hidden="true">&settingsChangeOptions.label;</description>
 #endif
       <separator class="thin"/>
-    </groupbox>
+    </vbox>
   </vbox>
   
   <menulist id="openHandler" flex="1">
     <menupopup id="openHandlerPopup" oncommand="dialog.openHandlerCommand();">
       <menuitem id="defaultHandler" default="true" crop="right"/>
       <menuitem id="otherHandler" hidden="true" crop="left"/>
       <menuseparator/>
       <menuitem id="choose" label="&other.label;"/>