Bug 1495878: Disable wasm signal handlers in the aarch64 Windows build. r=luke
authorDavid Major <dmajor@mozilla.com>
Wed, 03 Oct 2018 17:06:23 -0400
changeset 487757 463344943de8904defdc9f08ec8062290c290b75
parent 487756 1d430601366efb28787e886fe197c0647a44a1c1
child 487758 df5adaaa7e64ce2ba46c6bbaa1e02f555b08a603
push id246
push userfmarier@mozilla.com
push dateSat, 13 Oct 2018 00:15:40 +0000
reviewersluke
bugs1495878
milestone64.0a1
Bug 1495878: Disable wasm signal handlers in the aarch64 Windows build. r=luke
js/src/wasm/WasmSignalHandlers.cpp
--- a/js/src/wasm/WasmSignalHandlers.cpp
+++ b/js/src/wasm/WasmSignalHandlers.cpp
@@ -820,16 +820,22 @@ ProcessHasSignalHandlers()
 #endif
 
     // Initalize ThreadLocal flag used by WasmTrapHandler
     sAlreadyHandlingTrap.infallibleInit();
 
     // Install a SIGSEGV handler to handle safely-out-of-bounds asm.js heap
     // access and/or unaligned accesses.
 #if defined(XP_WIN)
+
+# if defined(_M_ARM64)
+    // The AArch64 Windows build is not ready for this yet.
+    return false;
+# endif
+
 # if defined(MOZ_ASAN)
     // Under ASan we need to let the ASan runtime's ShadowExceptionHandler stay
     // in the first handler position. This requires some coordination with
     // MemoryProtectionExceptionHandler::isDisabled().
     const bool firstHandler = false;
 # else
     // Otherwise, WasmTrapHandler needs to go first, so that we can recover
     // from wasm faults and continue execution without triggering handlers