searching for reviewer(surkov)
e6a310eb8e42c16180e6fd1c9539e7a751f07c69: Bug 1493844 - Part 2 - Remove the "caption" and "groupbox" bindings. r=bgrins,dao,jaws,johannh,surkov
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 23 Oct 2018 10:14:06 +0100 - rev 490753
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1493844 - Part 2 - Remove the "caption" and "groupbox" bindings. r=bgrins,dao,jaws,johannh,surkov Proper native "groupbox" styling depends on the structure of the XBL binding. By restyling the Page Info dialog, the native styling is now unused except for the Print Page Setup dialog on Windows. The native apperance is thus not applied by default anymore, and the "groupbox" element can just be used semantically for accessibility. The Print Page Setup dialog applies the native styling on its own in a way that still works on Windows. The only other consumers of "groupbox" are the in-content Preferences pages and dialogs. These are updated to use simpler styles that don't depend on the binding structure. Differential Revision: https://phabricator.services.mozilla.com/D8752
295644de04d2b1abbccd102473cbf3023dfce21a: Bug 1492393 - Make our table index methods aware of cells spanning multiple columns, r=surkov
Marco Zehe <mzehe@mozilla.com> - Fri, 19 Oct 2018 08:18:04 +0000 - rev 490462
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492393 - Make our table index methods aware of cells spanning multiple columns, r=surkov Sometimes, when cells have display:block, and a different cell in the same row has a column span, our index methods did not take these into account. Also, when regular tables encounter such a cell, index calculation failed. Differential Revision: https://phabricator.services.mozilla.com/D7867
011cfa1666cbede441dcb7bc5f9e4b00c41d5878: Bug 1487312 - Fix content insertion accessibility notifications in Shadow DOM. r=Jamie,surkov
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 18 Oct 2018 10:02:51 +0200 - rev 490459
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487312 - Fix content insertion accessibility notifications in Shadow DOM. r=Jamie,surkov The issue was specific to content insertion directly under a shadow root, the rest should work (see bug 1427825 for the fix for other similar occurrences). The removal of the aContainer argument follows the same pattern as bug 1442207. Differential Revision: https://phabricator.services.mozilla.com/D6431
320f407a7677d7cef64f6e2213fc2e1449511da1: Bug 1499702 - Clean up break statements in EventQueue::CoalesceEvents(), r=surkov
Marco Zehe <mzehe@mozilla.com> - Thu, 18 Oct 2018 07:06:45 +0000 - rev 490213
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499702 - Clean up break statements in EventQueue::CoalesceEvents(), r=surkov Differential Revision: https://phabricator.services.mozilla.com/D8971
93395637457196a6e01987dde862bbcb3327b976: Bug 1416363 - Remove colorpicker binding and related code. r=bgrins,surkov
Tim Nguyen <ntim.bugs@gmail.com> - Thu, 04 Oct 2018 01:03:19 +0000 - rev 488177
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1416363 - Remove colorpicker binding and related code. r=bgrins,surkov Depends on D7575 Differential Revision: https://phabricator.services.mozilla.com/D7576
b5a47b972169a6fea58589a0513ddce7b289c7b9: Bug 1494707 - Add a null check for a retrieved row accessible in HTMLTableAccessible::CellAt, r=surkov
Marco Zehe <mzehe@mozilla.com> - Thu, 04 Oct 2018 06:30:06 +0000 - rev 487946
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494707 - Add a null check for a retrieved row accessible in HTMLTableAccessible::CellAt, r=surkov When checking for an accessible if it is a table row instead of a table cell, when retrieving the actual row at the given index, null check it to make sure we don't pass an invalid accessible to the TableAccessible::CellInRowAt method. I accidentally omitted that null check in the updated patch for bug 1486668. Differential Revision: https://phabricator.services.mozilla.com/D7162
001c36e011c4873c6f2362091ea8af16d4d6e9f7: Bug 1486668 - <td> with display: block doesn't get table cell semantics, r=surkov
Marco Zehe <mzehe@mozilla.com> - Wed, 26 Sep 2018 08:47:35 +0000 - rev 486678
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1486668 - <td> with display: block doesn't get table cell semantics, r=surkov Differential Revision: https://phabricator.services.mozilla.com/D6158
9a11678be551dc67fc5ba7910bc49d4b4162bee3: Bug 1484048 - Part III, Wait for audio source to load before starting a11y tests r=surkov
Timothy Guan-tin Chien <timdream@gmail.com> - Mon, 17 Sep 2018 20:49:16 +0000 - rev 485629
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484048 - Part III, Wait for audio source to load before starting a11y tests r=surkov Appearently with UA Widget the page loads quicker, so the tests must now explicitly wait for the audio source to load to test on the video controls UI in its stable state. Depends on D3840 Differential Revision: https://phabricator.services.mozilla.com/D3841
d9840fe72bb527706e1dc6d18349b4ce7069eafb: Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:39:16 +0100 - rev 485587
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov Differential Revision: https://phabricator.services.mozilla.com/D4550
238d92348159fa0b14c7acbd3549bc3335c47ada: Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:39:16 +0100 - rev 485538
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov Differential Revision: https://phabricator.services.mozilla.com/D4550
ed6ac1e1266ccf886999b9d45458e66b2cc5aec7: Bug 1485097: When handling aria-owns relocation and an owned child doesn't yet have an accessible, skip it if the owned child is actually an ancestor of its owner. r=surkov
James Teh <jteh@mozilla.com> - Wed, 19 Sep 2018 02:15:55 +0000 - rev 485512
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1485097: When handling aria-owns relocation and an owned child doesn't yet have an accessible, skip it if the owned child is actually an ancestor of its owner. r=surkov This can easily be reproduced if the ancestor being owned has role="presentation", but there are other cases as well. If we don't prevent this, we end up with a loop. Differential Revision: https://phabricator.services.mozilla.com/D4051
4eb33bf25d6f7d4dab6b4bfdd84c4ae2b58f7d5e: Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:39:16 +0100 - rev 485374
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov Differential Revision: https://phabricator.services.mozilla.com/D4550
6263695b3cb85d546f5fc46d357c94a057b71cf7: Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov
Jonathan Kingston <jkt@mozilla.com> - Wed, 29 Aug 2018 15:39:16 +0100 - rev 485236
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1485305 - accessible/ Ensure loadURI always passes a triggeringPrincipal() r=surkov Differential Revision: https://phabricator.services.mozilla.com/D4550
0b3bd846add245f60a32ddc787890f411241dfdc: Bug 1488109: If the focused element has aria-activedescendant and the target id is moved to another node, move accessible focus to the new target. r=surkov
James Teh <jteh@mozilla.com> - Wed, 05 Sep 2018 04:43:18 +0000 - rev 483079
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1488109: If the focused element has aria-activedescendant and the target id is moved to another node, move accessible focus to the new target. r=surkov Differential Revision: https://phabricator.services.mozilla.com/D4832
eac4056f176a6cad1bc6a68a3606b8daa3a83bc3: Bug 1322621: If aria-activedescendant is removed or changed to an invalid id while an element is focused, move accessible focus to the element itself. r=surkov
James Teh <jteh@mozilla.com> - Fri, 31 Aug 2018 07:00:59 +0000 - rev 482764
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1322621: If aria-activedescendant is removed or changed to an invalid id while an element is focused, move accessible focus to the element itself. r=surkov Differential Revision: https://phabricator.services.mozilla.com/D4732
e2531be104190923d29397506ef035eb85ef6ef9: Bug 1486887 - Use binding parent for input[type] retrieval. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Fri, 31 Aug 2018 15:11:00 +0300 - rev 482678
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1486887 - Use binding parent for input[type] retrieval. r=surkov
6ce3008e2f46c1cb37d79c42f49fdb48265fdd43: Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 29 Aug 2018 14:04:25 +0100 - rev 482363
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1457218 - Part 3 - Remove the "menu-button" binding. r=surkov,bgrins Differential Revision: https://phabricator.services.mozilla.com/D4531
20db845c4c8708965992adfadc737ff094b6e677: Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins
Paolo Amadini <paolo.mozmail@amadzone.org> - Fri, 24 Aug 2018 15:44:38 +0100 - rev 482020
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1457216 - Remove support for editable menulists. r=surkov,bgrins Differential Revision: https://phabricator.services.mozilla.com/D4306
4a875f3a9e4d722b0f086db3c1437a3cd3ce0ac2: Bug 1485862 - Set correct text-input-type for input[type=number]. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Fri, 24 Aug 2018 13:34:00 +0300 - rev 481690
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485862 - Set correct text-input-type for input[type=number]. r=surkov
2c1a7b85ecbe8d1fafe493cc25f179bf0254803f: Bug 1479678: Fix incorrect start offset when retrieving accessible text attributes if the last spelling error is not within this accessible. r=surkov
James Teh <jteh@mozilla.com> - Fri, 24 Aug 2018 03:08:28 +0000 - rev 481574
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1479678: Fix incorrect start offset when retrieving accessible text attributes if the last spelling error is not within this accessible. r=surkov When dealing with an editor which contains multiple accessibles, the previous spelling error range might be in a previous accessible, not the accessible currently being queried. In this case, DOMPointToOffset will return the length of this accessible. Previously, we weren't checking for this and were overriding the start offset of the returned range regardless, resulting in broken offsets. Now, we leave the start offset alone in this case. Differential Revision: https://phabricator.services.mozilla.com/D3960
4746df79fc33bb8d5c87cfb4738a7029004ebc57: Bug 1484778 - Null-check scroll frame in DispatchScrollingEvent. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Tue, 21 Aug 2018 10:24:00 -0400 - rev 481434
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484778 - Null-check scroll frame in DispatchScrollingEvent. r=surkov
10656d31657321c67425494d554f092d4c1da6ae: Bug 1484248 - Accessible name calculation from label content should include cells. r=surkov
Joanmarie Diggs <jdiggs@igalia.com> - Fri, 17 Aug 2018 08:14:00 +0300 - rev 480513
Push 229 by fmarier@mozilla.com at Sun, 19 Aug 2018 02:09:13 +0000
Bug 1484248 - Accessible name calculation from label content should include cells. r=surkov Change the name calculation rule of HTML 'table' element from eNoNameRule to eNameFromSubtreeIfReqRule. That way the table won't get an accessible name, but will be descended when building a name from a parent element's contents.
da7e0c710c7d7a7ff3e124db32d4eae9ffebd2a1: Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Wed, 15 Aug 2018 13:07:00 -0400 - rev 480078
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
dad95d849302c966da9a710e96c80e7882eec5c2: Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Tue, 14 Aug 2018 11:46:00 +0300 - rev 479868
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1479591 - Introduced accessibility scrolling event and interface. r=surkov
2a51d4fba8a52208d273bdb3863cd7d2c8524aa2: Bug 1479036 - Android classes role additions. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Thu, 09 Aug 2018 14:43:00 +0300 - rev 479196
Push 217 by fmarier@mozilla.com at Fri, 10 Aug 2018 22:05:44 +0000
Bug 1479036 - Android classes role additions. r=surkov
ab8293506be28247f76acb9e9da78a20e6ffad0f: Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r=surkov
James Teh <jteh@mozilla.com> - Fri, 03 Aug 2018 13:31:43 +1000 - rev 478595
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480058 part 3: Support accessible selection retrieval methods for XUL tabs with aria-multiselectable. r=surkov The XULSelectControlAccessible selection methods don't handle ARIA selection. Therefore, if aria-multiselectable is set, use the base implementation of the selection retrieval methods. We don't bother overriding the selection setting methods because implementations (e.g. browser tabs) don't support setting of aria-selected by the a11y engine and we still want to be able to set the primary selected item according to XUL. Being able to retrieve multiple selection programmatically is far more important than being able to set it. MozReview-Commit-ID: CmVp9KyieMY
0f3121479e3f0ff0016233534fd78d3262760fe1: Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r=surkov
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:27:18 +1000 - rev 478594
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480058 part 2: Add nsAccUtils::IsARIAMultiSelectable and make nsAccUtils::ISARIASelected const. r=surkov We need to be able to call these methods from const methods, so they must take a const Accessible*. MozReview-Commit-ID: CDsWZG1ik31
a0a9bd6c09dedc6a11043b8cb669b34b883f5a5f: Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r=surkov
James Teh <jteh@mozilla.com> - Thu, 02 Aug 2018 16:25:09 +1000 - rev 478593
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480058 part 1: Expose states for aria-selected/aria-multiselectable on XUL tab/tabs. r=surkov MozReview-Commit-ID: JeV5vBffQIq
d640ff079867a7feaafc1a427140ddb50cbd9acf: Bug 1480971 - add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE r=surkov
Tokio Kajitsuka <kajitsuka-tokio@g.ecc.u-tokyo.ac.jp> - Sat, 04 Aug 2018 19:47:50 +0900 - rev 478528
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480971 - add AccessibleNode::mRelationProperties to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE r=surkov change the type of AccessibleNode::mRelationProperties to nsRefPtrHashtable and add it to NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE
de9367e7a51159d2dffe0fc873cd447468516a8e: Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r=surkov
James Teh <jteh@mozilla.com> - Tue, 31 Jul 2018 11:22:59 +1000 - rev 477611
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1479642: Make Windows XULMenuitemAccessibleWrap::Name const so it overrides AccessibleWrap::Name. r=surkov This again exposes the accelerator (e.g. Ctrl+T for New Tab) for menu items via IAccessible::accName on windows. Bug 1438193 made Accessible::Name const. On Windows, XULMenuitemAccessibleWrap::Name is overridden to append the accelerator to the name. Unfortunately, this override was missed when converting Name to const (and wasn't a compile error because it didn't use the override keyword). As such, this override stopped being called; we always called the const version, since that's the one inherited into AccessibleWrap. Making this const causes this override to be called. MozReview-Commit-ID: 7Gb199mzhHa
0bde8c96f409d01b9f054b55d9c4eb2f95bb3099: Bug 1479530 - Swap newPosition with oldPosition in ProxyVirtualCursorChangeEvent. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Mon, 30 Jul 2018 11:41:00 +0300 - rev 477520
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1479530 - Swap newPosition with oldPosition in ProxyVirtualCursorChangeEvent. r=surkov
2307557b66b17dbc6952cf67995bba138b05443c: Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 11:07:07 +0100 - rev 476873
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov MozReview-Commit-ID: 2l6rvxykrWB
a809b45ff49ba5814795b30b5a460d7d2d1b6a23: Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov
Mark Banner <standard8@mozilla.com> - Wed, 25 Jul 2018 11:07:07 +0100 - rev 476790
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1478308 - Remove unnecessary ChromeUtils.imports in accessible/ r=surkov MozReview-Commit-ID: 2l6rvxykrWB
38ebcdae9bca37cfdb17c2199030cbe4f2612aa8: Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 18 Jul 2018 11:23:32 +0100 - rev 475356
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1472555 - Part 5 - Remove the listbox layout. r=bz,surkov MozReview-Commit-ID: Bx1p1nTurCz
9503f9df661aa2bac483db14a879d4b77a645bb7: Bug 1469769 - Part 1: a11y: Replace failing NS_NOTREACHED with NS_ERROR. r=surkov
Chris Peterson <cpeterson@mozilla.com> - Mon, 04 Jun 2018 01:44:18 -0700 - rev 475290
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1469769 - Part 1: a11y: Replace failing NS_NOTREACHED with NS_ERROR. r=surkov This SelectionManager assertion fails when running the testing/marionette/harness/marionette_harness/tests/unit/test_navigation.py TestBackForwardNavigation.test_non_remote_about_pages marionette test. This assertion failure is bug 1126649. This patch DOES NOT fix the cause of the assertion failure (a missing HyperTextAccessible). It just replaces this failing NS_NOTREACHED with NS_ERROR because I am removing the NS_NOTREACHED macro. MozReview-Commit-ID: EVfyZlMwN4p
99869599a2f547ab414a11b3dedf0e9df7aa3666: Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 17 Jul 2018 17:58:37 +0100 - rev 475224
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1474108 - Convert listbox accessibility tests to use the "richlistbox" element. r=surkov This prepares for the removal of the "listbox" element and binding. MozReview-Commit-ID: G1OxRGBphmw
0fb2b9a769eb581919baf5b824901bcb564c1b74: Bug 1475087 - Include boundaryType in vc change event. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Mon, 16 Jul 2018 13:56:00 +0300 - rev 475092
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1475087 - Include boundaryType in vc change event. r=surkov
d55a38a6be534e3f7c62da7ae36a65d8526ea0a4: Bug 1475078 - Go to last substring in current position when movePreviousByText. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Wed, 11 Jul 2018 13:49:28 -0700 - rev 475044
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1475078 - Go to last substring in current position when movePreviousByText. r=surkov In the case of an unbound pivot (endOffset == startOffset == -1), we should move to the last substring in the current position when movePreviousByText is called.
552130bca48389d0b57fee87f5ab7865e0ae6abe: Bug 1475068 - If accessible's parent has text interface, use it in pivot move by text. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Wed, 11 Jul 2018 13:36:02 -0700 - rev 475043
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1475068 - If accessible's parent has text interface, use it in pivot move by text. r=surkov
ed8baebfeb78bae7b4fa3a78be13173729df2e01: Bug 1475087 - Include boundaryType in vc change event. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Mon, 09 Jul 2018 13:50:58 -0700 - rev 475035
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1475087 - Include boundaryType in vc change event. r=surkov
178261758dc9ea7bd8ee0d91923003455e07a4ab: Bug 1472274 - Alter selection direction according to the last change. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Thu, 05 Jul 2018 15:19:00 +0300 - rev 473488
Push 201 by fmarier@mozilla.com at Sat, 07 Jul 2018 02:45:18 +0000
Bug 1472274 - Alter selection direction according to the last change. r=surkov nsIAccessibleText.setSelectionBounds should accept a start offset that is larger than an end offset. This is an indica tion that it is a reverse selection, and the caret should be at the start of the selection. This should also be consistent with how multiple range selections work interactively - the caret should re main at the last offset reached.
335d37068a98acdb703f6f2da58388b21f63e477: Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov
James Teh <jteh@mozilla.com> - Wed, 27 Jun 2018 15:33:08 +1000 - rev 473023
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov For example, this can happen when choosing File menu -> new Tab. Focus briefly returns to the document in the original tab, so we ask that document to restore focus. The remote document then sends a focus event to the parent. However, before the parent can process that event, focus has already moved to the address bar for the new tab. With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible. MozReview-Commit-ID: 7k58dzREqZD
f32174f44c65f500d8f69b73bee6f42d306a23e5: Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov
James Teh <jteh@mozilla.com> - Wed, 27 Jun 2018 15:33:08 +1000 - rev 472652
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1471466: Don't fire a focus event for a remote accessible if focus has moved into the chrome since the event was sent. r=surkov For example, this can happen when choosing File menu -> new Tab. Focus briefly returns to the document in the original tab, so we ask that document to restore focus. The remote document then sends a focus event to the parent. However, before the parent can process that event, focus has already moved to the address bar for the new tab. With this check, we discover that focus is now in the chrome and thus avoid firing the event for the remote accessible. MozReview-Commit-ID: 7k58dzREqZD
2fa69e8f19b92e2bc11de7cbea3300cdab6a56c4: Bug 1465823 - Add new position and offsets to pivot change notifications and vc events. r=surkov
Eitan Isaacson <eitan@monotonous.org> - Thu, 21 Jun 2018 14:47:00 +0300 - rev 471559
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1465823 - Add new position and offsets to pivot change notifications and vc events. r=surkov
ca59f5dfd548d64d7b8c480f358bfcc80433bdc6: Bug 1469379 - let is missing from accessible/tests/mochitest/aom/test_general.html. r=surkov
Tokio Kajitsuka <kajitsuka-tokio@g.ecc.u-tokyo.ac.jp> - Tue, 19 Jun 2018 04:49:16 +0900 - rev 471156
Push 197 by fmarier@mozilla.com at Sat, 23 Jun 2018 00:56:20 +0000
Bug 1469379 - let is missing from accessible/tests/mochitest/aom/test_general.html. r=surkov
9e717c6aaa70daa363832215d3a78ffa605f92bb: Bug 1467503 - Make it compile with --disable-accessibility again. r=surkov
Mats Palmgren <mats@mozilla.com> - Thu, 07 Jun 2018 18:43:06 +0200 - rev 470007
Push 193 by fmarier@mozilla.com at Fri, 08 Jun 2018 00:53:54 +0000
Bug 1467503 - Make it compile with --disable-accessibility again. r=surkov
85ce7eda501b891b25326979f52171230ff2d969: Bug 1462465 - Cache AccessibleNode in Node. r=surkov,smaug
Tokio Kajitsuka <kajitsuka-tokio@g.ecc.u-tokyo.ac.jp> - Sat, 26 May 2018 22:47:48 +0900 - rev 469979
Push 193 by fmarier@mozilla.com at Fri, 08 Jun 2018 00:53:54 +0000
Bug 1462465 - Cache AccessibleNode in Node. r=surkov,smaug Cache AccessibleNode and make it able to operate the same instance by nsINode::GetAccessibleNode
a819042f190938ddc234eadf42b13ab871b722cf: Bug 1466727 part 4. Stop using nsITreeColumn in accessibility code. r=surkov
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 05 Jun 2018 23:01:37 -0400 - rev 469708
Push 190 by fmarier@mozilla.com at Thu, 07 Jun 2018 20:18:35 +0000
Bug 1466727 part 4. Stop using nsITreeColumn in accessibility code. r=surkov
1ce9fe4210ce4e79a109823bebd0a1ba7a2c8a4b: Bug 1466673 part 3. Stop using nsITreeColumns in accessibility code. r=surkov
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 05 Jun 2018 13:30:17 -0400 - rev 469641
Push 190 by fmarier@mozilla.com at Thu, 07 Jun 2018 20:18:35 +0000
Bug 1466673 part 3. Stop using nsITreeColumns in accessibility code. r=surkov
671ec6415311aab033bda40cb9d80cd5f376b3d4: Bug 1466822 - Implement support for new blockquote, caption, and paragraph ARIA roles. r=surkov
Joanmarie Diggs <jdiggs@igalia.com> - Tue, 05 Jun 2018 06:46:00 -0400 - rev 469628
Push 190 by fmarier@mozilla.com at Thu, 07 Jun 2018 20:18:35 +0000
Bug 1466822 - Implement support for new blockquote, caption, and paragraph ARIA roles. r=surkov * Create BLOCKQUOTE internal role (also needed for correct exposure of blockquote element on ATK) * Add new ARIA roles to internal ARIA map * Add new roles to existing ARIA roles mochitest and update blockquote element test to reflect mapping to the new internal role