searching for reviewer(standard8)
88351e371a8b8c21dc69555f53707a8fae6df40a: Bug 1500959 - Clean up browser_visibleTabs_tabPreview.js. r=Standard8
Dão Gottwald <dao@mozilla.com> - Wed, 24 Oct 2018 18:00:22 +0000 - rev 491301
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500959 - Clean up browser_visibleTabs_tabPreview.js. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D9650
74998050fbc4bf8da4dab2626c033cec0b34dbfb: Bug 1499652 - Pass on return values from forwarded textbox methods. r=Standard8
Dão Gottwald <dao@mozilla.com> - Wed, 24 Oct 2018 16:51:52 +0000 - rev 491170
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499652 - Pass on return values from forwarded textbox methods. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D9639
8be2131ed18337d6d5011d51aa9d9f39aefff495: Bug 1501270 - Set the UrlbarInput value to the target URL when selecting a result. r=standard8
Dão Gottwald <dao@mozilla.com> - Wed, 24 Oct 2018 11:41:43 +0200 - rev 491051
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501270 - Set the UrlbarInput value to the target URL when selecting a result. r=standard8
bc350062ad1b45d628e05ee715ff51d1f4d8bcdc: Bug 1494334 - Implement UrlbarInput::textValue getter. r=Standard8
Dão Gottwald <dao@mozilla.com> - Tue, 23 Oct 2018 16:19:56 +0000 - rev 490954
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494334 - Implement UrlbarInput::textValue getter. r=Standard8 Depends on D9505 Differential Revision: https://phabricator.services.mozilla.com/D9508
0dc37e5676af1f7851a7a86a339d9903fa42e59c: Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Mon, 22 Oct 2018 23:42:48 +0000 - rev 490891
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm Depends on D9293. Differential Revision: https://phabricator.services.mozilla.com/D9294
eff50d9238028b1202f7a3d68a7c9da92ddbadcd: Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Tue, 23 Oct 2018 08:34:13 +0000 - rev 490890
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm Ran ESLint's automatic '--fix' option on the above files. Differential Revision: https://phabricator.services.mozilla.com/D9293
2e4bdafb70ce4febc9fb071ad1743cc0b49096de: Bug 1499096 - Update tests using ok() to is(), with minor fixes;r=Standard8
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Oct 2018 07:21:18 +0000 - rev 490877
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499096 - Update tests using ok() to is(), with minor fixes;r=Standard8 Depends on D8741 This changeset updates some calls to ok() that should actually be calls to is() and that needed tiny fixes to match the expected value. Differential Revision: https://phabricator.services.mozilla.com/D8742
dfaaf3978e3c7f1c98fd20270a0e50e4a6ddd733: Bug 1499096 - Use ok() with 2 arguments instead of 3 when possible;r=Standard8
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Oct 2018 07:13:35 +0000 - rev 490876
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499096 - Use ok() with 2 arguments instead of 3 when possible;r=Standard8 Depends on D8740. This changeset replaces calls to ok with 3 arguments to calls with 2 arguments in situations where the switch does not have a significant impact on the assert. Differential Revision: https://phabricator.services.mozilla.com/D8741
a82f6a836cf384325aef49402fd4473a744648aa: Bug 1499096 - Update wrong usage of ok() with todo_is();r=Standard8
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Oct 2018 07:13:02 +0000 - rev 490875
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499096 - Update wrong usage of ok() with todo_is();r=Standard8 Depends on D8739. This changeset updates calls to ok() that were most likely intended for is(), but are not working as is. Differential Revision: https://phabricator.services.mozilla.com/D8740
eee0effaa1f00aeb017a2c7bf107425e64222faa: Bug 1499096 - Update tests using ok() to is();r=Standard8
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Oct 2018 07:12:23 +0000 - rev 490874
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499096 - Update tests using ok() to is();r=Standard8 This changeset updates all the test that were wrongly using ok() and wanted to use is() AND for which the assert is still passing without any modification required. Differential Revision: https://phabricator.services.mozilla.com/D8739
98cfc4f7de934502dbae28e733c03aaaa935d2d4: Bug 1500936 - Run eslint --fix on devtools/client/inspector for comma-dangle;r=Standard8
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Oct 2018 07:08:24 +0000 - rev 490873
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500936 - Run eslint --fix on devtools/client/inspector for comma-dangle;r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D9409
924b484fa4dff96148d00cfaf16bea9f065ed054: Bug 1500936 - Remove comma-dangle override from devtools/client/inspector;r=Standard8
Julian Descottes <jdescottes@mozilla.com> - Tue, 23 Oct 2018 07:08:22 +0000 - rev 490872
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500936 - Remove comma-dangle override from devtools/client/inspector;r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D9408
501fffbf872d0a320069448010aa0706d3b81409: Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Mon, 22 Oct 2018 19:41:58 +0000 - rev 490815
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1423839 - Part 2: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (manual changes) r=Standard8,jdm Depends on D9293. Differential Revision: https://phabricator.services.mozilla.com/D9294
406ca9722ffaa14caf02923c541942725f835d32: Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm
James Lee <jamesl33info@gmail.com> - Mon, 22 Oct 2018 19:41:33 +0000 - rev 490814
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1423839 - Part 1: Enable ESLint for NetUtil.jsm and netwerk/cookie/test/unit/ (automatic changes) r=Standard8,jdm Ran ESLint's automatic '--fix' option on the above files. Differential Revision: https://phabricator.services.mozilla.com/D9293
36e622253bc438b14e6356138492f445c9360eab: Bug 1498584 - Unable to delete urls containing backslashes from history. r=Standard8
Marco Bonardo <mbonardo@mozilla.com> - Fri, 19 Oct 2018 13:19:24 +0000 - rev 490511
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498584 - Unable to delete urls containing backslashes from history. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D9097
6ea457f6ca9d48bf51ffd0ccec57305d2e191882: Bug 1477671 - Stop allowing creation of new live bookmarks from the backend. r=standard8
Marco Bonardo <mbonardo@mozilla.com> - Sat, 06 Oct 2018 10:32:13 +0100 - rev 488921
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1477671 - Stop allowing creation of new live bookmarks from the backend. r=standard8 Differential Revision: https://phabricator.services.mozilla.com/D7083
c452c4911dafe76de02e5a02c3d9cf33e589663c: Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson
Ursula Sarracini <ursulasarracini@gmail.com> - Wed, 10 Oct 2018 14:48:56 +0000 - rev 488889
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson Differential Revision: https://phabricator.services.mozilla.com/D7772
003208b2dd175a1ecd16a9a781011c115a3d7d06: Bug 1497814 - Clean up UrlbarInput getters and setters. r=Standard8
Dão Gottwald <dao@mozilla.com> - Wed, 10 Oct 2018 10:18:59 +0000 - rev 488834
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497814 - Clean up UrlbarInput getters and setters. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D8188
41725614e772232c3ebcc7c2ead5330414f1a465: Bug 1496703 - Make UrlbarValueFormatter not hold references to anonymous textbox nodes and the editor since they can change when the textbox moves, e.g. when wrapping it for customize mode. r=Standard8
Dão Gottwald <dao@mozilla.com> - Wed, 10 Oct 2018 09:26:30 +0000 - rev 488827
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496703 - Make UrlbarValueFormatter not hold references to anonymous textbox nodes and the editor since they can change when the textbox moves, e.g. when wrapping it for customize mode. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D8067
c35bab726b030312c53f48a654d5fcc2e1264ac2: Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
Siddhant085 <dpsrkp.sid@gmail.com> - Tue, 09 Oct 2018 18:40:08 +0000 - rev 488733
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8 nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing. The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine. Differential Revision: https://phabricator.services.mozilla.com/D7972
dd0480856174ebb56abe03c063f4833f8c4f5d43: Bug 1423843 - Enabled ESLint for dom/notification/test/unit r=Standard8,mccr8
divyansh <sharma.divyansh.501@iitg.ernet.in> - Tue, 09 Oct 2018 18:23:15 +0000 - rev 488728
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1423843 - Enabled ESLint for dom/notification/test/unit r=Standard8,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D8026
d19abac48609d70d5bb491bd39ef9ea12088af03: Bug 1497464 - UrlbarInput value setter needs to call formatValue. r=Standard8
Dão Gottwald <dao@mozilla.com> - Tue, 09 Oct 2018 11:40:25 +0000 - rev 488572
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497464 - UrlbarInput value setter needs to call formatValue. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D8069
fa8c1d18270920a5a98263c9836f4c3b240140aa: Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Siddhant085 <dpsrkp.sid@gmail.com> - Tue, 02 Oct 2018 15:30:24 +0000 - rev 488266
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8 Changed the validation function for PageInfo to use a more general validateItemProperties. This changes the error message being thrown. Changed the respective test cases to accomodate the change. Differential Revision: https://phabricator.services.mozilla.com/D5831
1638774724799ea8eb692868a2c501d088839a2c: Bug 1496476 - add tabContextChanged stub. r=standard8
Dão Gottwald <dao@mozilla.com> - Fri, 05 Oct 2018 15:43:53 +0200 - rev 488117
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496476 - add tabContextChanged stub. r=standard8
67c81aab154d1f3e2f54a4141beae04ca7995144: Bug 1491249 - Implement URL tooltip. r=Standard8
Dão Gottwald <dao@mozilla.com> - Thu, 04 Oct 2018 15:53:09 +0000 - rev 488020
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491249 - Implement URL tooltip. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D7698
b37b275c93648fc79fd82633e2db3b969cd14e46: Bug 1496152 - Implement UrlbarInput focused getter. r=Standard8
Dão Gottwald <dao@mozilla.com> - Wed, 03 Oct 2018 20:16:30 +0000 - rev 487864
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496152 - Implement UrlbarInput focused getter. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D7630
35617edceddab3f598412be21028155ada286e62: Bug 1496165 - Rename UrlbarInput event handlers to be more readable. r=Standard8
Dão Gottwald <dao@mozilla.com> - Wed, 03 Oct 2018 19:33:41 +0000 - rev 487863
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496165 - Rename UrlbarInput event handlers to be more readable. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D7635
a4d2c14d8fa5ca3531d15c83fdb1616b3e7fcfc8: Bug 1491245 - Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r=Standard8
Dão Gottwald <dao@mozilla.com> - Tue, 02 Oct 2018 19:27:42 +0000 - rev 487651
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491245 - Introduce UrlbarValueFormatter and use it in both UrlbarInput and urlbarBindings.xml. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D7492
19165a49129512561ee268e671c9e389b566b489: Bug 1491400 - Cut off inheritance for dropmarkers within other widgets where -moz-image-region might be set for the primary icon. r=Standard8
Dão Gottwald <dao@mozilla.com> - Tue, 02 Oct 2018 12:19:07 +0000 - rev 487516
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491400 - Cut off inheritance for dropmarkers within other widgets where -moz-image-region might be set for the primary icon. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D7399
89a23642630a660d5d816143f735019a4fc488e7: Bug 1494690 - Set the right maxResults in UrlbarInput. r=standard8
Dão Gottwald <dao@mozilla.com> - Fri, 28 Sep 2018 15:15:58 +0200 - rev 487013
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494690 - Set the right maxResults in UrlbarInput. r=standard8
9f1c5ece3510d1e38630bd73994466ec0eb271bd: Bug 1493951 - Fix autofill for about: urls. r=Standard8
Marco Bonardo <mbonardo@mozilla.com> - Wed, 26 Sep 2018 08:08:56 +0000 - rev 486672
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493951 - Fix autofill for about: urls. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D6772
184a229a8cc47b96110e1b81688eb193f1963721: Bug 1491255 - Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
Dão Gottwald <dao@mozilla.com> - Wed, 26 Sep 2018 17:44:04 +0200 - rev 486649
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491255 - Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
8cb351adc7d35a62d80c57e0e7868ca61fb04b20: Bug 1491255 - Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
Dão Gottwald <dao@mozilla.com> - Wed, 26 Sep 2018 16:11:19 +0200 - rev 486639
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491255 - Port URL trimming from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
d4c858c70bc9870a88d841ad933b9ea74fe547bc: Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Siddhant085 <dpsrkp.sid@gmail.com> - Tue, 25 Sep 2018 18:21:56 +0000 - rev 486586
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8 Changed the validation function for PageInfo to use a more general validateItemProperties. This changes the error message being thrown. Changed the respective test cases to accomodate the change. Differential Revision: https://phabricator.services.mozilla.com/D5831
db16547e0d608eb51fc876fcbb43c23c071d6f63: Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8
Siddhant085 <dpsrkp.sid@gmail.com> - Mon, 24 Sep 2018 16:12:46 +0000 - rev 486350
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1479445: Update the validation of PageInfo to use validateItemProperties r=mak,Standard8 Changed the validation function for PageInfo to use a more general validateItemProperties. This changes the error message being thrown. Changed the respective test cases to accomodate the change. Differential Revision: https://phabricator.services.mozilla.com/D5831
daa8803c67e40f36494ed2ab7b236e119d6b4ddb: Bug 1490848 - Constraint failed errors when trying to download urls not present in history. r=Standard8
Marco Bonardo <mbonardo@mozilla.com> - Mon, 24 Sep 2018 15:28:23 +0000 - rev 486346
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1490848 - Constraint failed errors when trying to download urls not present in history. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D6666
f138b7d87e7f728534d4cc416eb84a66fdddbd7a: Bug 1491252 - Port URL overflow handling from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
Dão Gottwald <dao@mozilla.com> - Fri, 21 Sep 2018 19:12:05 +0200 - rev 486002
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491252 - Port URL overflow handling from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
a6b130810bc42f125709fe40c2e26fe9f5f985f6: Bug 1491252 - Port URL overflow handling from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
Dão Gottwald <dao@mozilla.com> - Thu, 20 Sep 2018 13:06:34 +0200 - rev 485992
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491252 - Port URL overflow handling from urlbarBindings.xml to UrlbarInput.jsm. r=standard8
c22c89c9a6c2449c9f355815ee2b54a2c1c1d645: Bug 1481795 - Remove the maintenance task for reparenting built-in root folders r=Standard8
Kajal Kumari Sah <kajalksah07@gmail.com> - Fri, 14 Sep 2018 10:41:32 +0000 - rev 484733
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1481795 - Remove the maintenance task for reparenting built-in root folders r=Standard8 This is now managed on initialisation (xref bug 1472241) Differential Revision: https://phabricator.services.mozilla.com/D5675
c324bd6eb4bf102541d3eb1b751ee2f7a408fff4: Bug 1477985 - Implement basic UrlbarInput and UrlbarView classes and a hidden pref for using them. r=standard8
Dão Gottwald <dao@mozilla.com> - Thu, 13 Sep 2018 18:38:07 +0200 - rev 484499
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1477985 - Implement basic UrlbarInput and UrlbarView classes and a hidden pref for using them. r=standard8
f105be1abab0e32cb0344d28d364430b20e96f1c: Bug 1477985 - Implement basic UrlbarInput and UrlbarView classes and a hidden pref for using them. r=standard8
Dão Gottwald <dao@mozilla.com> - Wed, 12 Sep 2018 20:47:03 +0200 - rev 484314
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1477985 - Implement basic UrlbarInput and UrlbarView classes and a hidden pref for using them. r=standard8
a830e988efa180379b1b2dea3edcba0474f6bc0f: Bug 1489063 - Remove unused autocomplete-textbox class. r=standard8
Dão Gottwald <dao@mozilla.com> - Thu, 06 Sep 2018 11:46:21 +0200 - rev 483375
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1489063 - Remove unused autocomplete-textbox class. r=standard8
69199edacdf637e4a93ce77066da9b6e51671377: Bug 1066992 - Bookmarks backup should not exceed max backups a=standard8
Siddhant <dpsrkp.sid@gmail.com> - Thu, 30 Aug 2018 23:41:37 +0530 - rev 482973
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1066992 - Bookmarks backup should not exceed max backups a=standard8
05e07c98cc3654d75c2918eaa36882a3683ca65c: Bug 1487246: Enable the eslint no-sequences rule. r=Standard8
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 29 Aug 2018 16:15:33 -0700 - rev 482608
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1487246: Enable the eslint no-sequences rule. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D4681
2897eaa81db844652558fbe941f6a0f6e23ed29a: Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8
Dave Townsend <dtownsend@oxymoronical.com> - Wed, 29 Aug 2018 16:12:55 -0700 - rev 482607
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1487246: Remove uses of comma sequences in linted code. r=Standard8 Two cases were hiding permanently failing tests. I've commented those out and filed bug 1487431. Differential Revision: https://phabricator.services.mozilla.com/D4680
b604e88375472de2a53b836dd9d1f76d4802ad3b: Bug 1460856 - [mozlint] Display suppressed warnings count in the summary and stylish formatters r=Standard8
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 27 Aug 2018 13:37:28 +0000 - rev 482035
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1460856 - [mozlint] Display suppressed warnings count in the summary and stylish formatters r=Standard8 Depends on D3821 Differential Revision: https://phabricator.services.mozilla.com/D3992
f664646a2e7c6554a738fe724c7a021fd9c591d7: Bug 1460856 - [mozlint] Suppress warnings by default r=Standard8,sylvestre
Andrew Halberstadt <ahalberstadt@mozilla.com> - Mon, 27 Aug 2018 13:39:46 +0000 - rev 482034
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1460856 - [mozlint] Suppress warnings by default r=Standard8,sylvestre As of this patch, any lint issue at the "warning" level will *only* be displayed if --warnings is passed in. This gives us some flexibility to track issues that are "recommended to fix" but that aren't required (aka don't cause a backout). I think it would be ideal if the reviewbot ran with warnings enabled, and CI ran without warnings. This way these issues will be surfaced to developers (and hopefully get fixed prior to landing), but developers will always be able to ignore them if the situation warrants it. Since the last change converted everything to use errors, this patch should be a no-op for now. However as we move forward (and potentially decide that certain types of lint issues should result in a backout), this feature will start seeing more and more use. Depends on D3820 Differential Revision: https://phabricator.services.mozilla.com/D3821
38549f3a51879ed4efc1c0a55c85e88198ed1c05: Bug 1460856 - [mozlint] Stop using warnings in all current linters r=Standard8
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 28 Aug 2018 19:24:55 +0000 - rev 482033
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1460856 - [mozlint] Stop using warnings in all current linters r=Standard8 Soon, warnings will be suppressed by default and won't causes a failure. Therefore to prevent loss of coverage, we need to make sure that any lint warning that causes a failure today, needs to be converted to an error so it keeps failing tomorrow. Depends on D3819 Differential Revision: https://phabricator.services.mozilla.com/D3820
f84d024c27b5e8b12aecb986218eac2b5aa2f703: Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8 on a CLOSED TREE
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 24 Aug 2018 16:20:36 +0000 - rev 481679
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8 on a CLOSED TREE Differential Revision: https://phabricator.services.mozilla.com/D4095
f83d8d85c94f2d1cab19085ec1662808def93fe9: Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 24 Aug 2018 16:20:36 +0000 - rev 481674
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485577 - Pass triggeringPrincipal into openDialog for window opening code. r=jkt,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D4095