searching for reviewer(sparky)
8f1ea035b4e3486d0f7628c46b72d520bec0b0b3: Bug 1490981: Disable browser_animation_keyframes-progress-bar test on win ccov. r=sparky
Daisuke Akatsuka <dakatsuka@mozilla.com> - Wed, 19 Sep 2018 11:46:03 +0000 - rev 485570
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490981: Disable browser_animation_keyframes-progress-bar test on win ccov. r=sparky Differential Revision: https://phabricator.services.mozilla.com/D6229
dcedddab6d8947a557b3a9f1724a2a37a4f13b54: Bug 1397722 - [tryselect] Filter 'ccov' tasks out of the target task set (now they must be selected with --full), r=sparky
Andrew Halberstadt <ahalberstadt@mozilla.com> - Tue, 21 Aug 2018 20:00:32 +0000 - rev 481046
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1397722 - [tryselect] Filter 'ccov' tasks out of the target task set (now they must be selected with --full), r=sparky Usually people don't mean to schedule code coverage tasks on try. But e.g |mach try fuzzy -q "'mochitest"|, will cause them to be scheduled as a side effect. This results in wasted resources and superfluous data in ActiveData. This patch makes it so you need to explicitly pass --full to select ccov tasks (even though they're technically part of the target task graph). Differential Revision: https://phabricator.services.mozilla.com/D3917
28d777ff7f7e6de56811cd8a6fc3a80cbedd84b7: Bug 1475459 - Move beforeTestSync call after setting _globalProperties. r=sparky
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 03 Aug 2018 10:34:00 +0200 - rev 478299
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1475459 - Move beforeTestSync call after setting _globalProperties. r=sparky beforeTestSync uses an asynchronous operation that takes a while to finish. In the meantime, it's very likely that the browser will run some tasks scheduled to run when idle, which cause XPCOMUtils mock in browser-test.js to be used, which references _globalProperties.
1de7861347105883b5dbe52e9cf75f5fe8c048ca: Bug 1471575 - Reset/dump gcov counters before/after reftest tests. r=sparky
Marco Castelluccio <mcastelluccio@mozilla.com> - Tue, 17 Jul 2018 10:07:50 +0200 - rev 475280
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1471575 - Reset/dump gcov counters before/after reftest tests. r=sparky
00630f737536b4327f3d29234a4882fb29c862b9: Bug 1459311 - Remove completely uncovered files from per-test reports. r=jmaher,sparky
Marco Castelluccio <mcastelluccio@mozilla.com> - Fri, 04 May 2018 22:06:10 +0200 - rev 462151
Push 166 by fmarier@mozilla.com at Thu, 10 May 2018 00:43:18 +0000
Bug 1459311 - Remove completely uncovered files from per-test reports. r=jmaher,sparky
bf368c4e5c0a37074f5a74076ca5e4db4b1b0994: Bug 1431753 - Upload per-test coverage reports. r=sparky
Marco Castelluccio <mcastelluccio@mozilla.com> - Thu, 19 Apr 2018 12:42:38 +0200 - rev 460508
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1431753 - Upload per-test coverage reports. r=sparky
81c22c501c2a9f18a33398a97cc7c43144349223: Fix the attribute names in the comments in the sanitizer blacklists to the final adopted names. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Tue, 06 Mar 2018 15:16:54 -0800 - rev 452593
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Fix the attribute names in the comments in the sanitizer blacklists to the final adopted names. No bug, r=sparky
b11cbe9fc6020d2c6f92066f8c90f46f354d68f0: Make Nursery.cpp's CanaryMagicValue a constexpr so it doesn't break (some) builds with -Werror=unused-const-variable. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Wed, 03 May 2017 13:58:36 -0700 - rev 390545
Push 51 by fmarier@mozilla.com at Fri, 05 May 2017 18:41:45 +0000
Make Nursery.cpp's CanaryMagicValue a constexpr so it doesn't break (some) builds with -Werror=unused-const-variable. No bug, r=sparky
1a867dd80624f5c69fffa2dd878f14cfe86ba43b: Bug 1325675 - Followup bustage fix for a newly-landed test that needs an update along the same lines as the others this bug just touched. r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 29 Dec 2016 18:30:59 -0600 - rev 358405
Push 17 by fmarier@mozilla.com at Fri, 13 Jan 2017 22:14:57 +0000
Bug 1325675 - Followup bustage fix for a newly-landed test that needs an update along the same lines as the others this bug just touched. r=sparky
9329689b3f83bd2545c1c8e56807a973dcdc1062: Bug 1031362 follow-up - Fix local unified compilation bustage by including required headers. r=sparky
Jonathan Watt <jwatt@jwatt.org> - Sat, 24 Dec 2016 21:53:23 +0000 - rev 358141
Push 17 by fmarier@mozilla.com at Fri, 13 Jan 2017 22:14:57 +0000
Bug 1031362 follow-up - Fix local unified compilation bustage by including required headers. r=sparky
232a786cf87fb0f68f9bda6e9316515524d2ac8a: Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky
Jonathan Watt <jwatt@jwatt.org> - Tue, 07 Jun 2016 21:10:18 +0100 - rev 331212
Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky
8eef6c268b9dcee36b7f42b48bae61a747a60545: No bug - Mark some SVG classes as final. r=sparky
Jonathan Watt <jwatt@jwatt.org> - Fri, 06 May 2016 17:25:55 +0100 - rev 326221
No bug - Mark some SVG classes as final. r=sparky
f9ee57defd9ddad86f3545ad512b42d4ea64f640: No Bug - Remove some unnecessary SVGImageContext.h includes and add comments. r=sparky
Jonathan Watt <jwatt@jwatt.org> - Fri, 22 Apr 2016 15:07:31 +0100 - rev 322851
No Bug - Remove some unnecessary SVGImageContext.h includes and add comments. r=sparky
070e28f591b68baa2faf93c69b7f191ead4a6f02: Bug 1254128 - Make the Mozilla .lldbinit use the full path for topsrcdir. r=sparky
Jonathan Watt <jwatt@jwatt.org> - Tue, 01 Mar 2016 16:36:08 +0000 - rev 314222
Bug 1254128 - Make the Mozilla .lldbinit use the full path for topsrcdir. r=sparky MozReview-Commit-ID: wBrUd7qFy1
231cbcd20fe477f2c565bcde3f50f998c575c468: Bug 1029483 - Fix various 99ch style violations in Intl.cpp. r=sparky
Jeff Walden <jwalden@mit.edu> - Wed, 01 Jul 2015 14:00:08 -0700 - rev 271785
Bug 1029483 - Fix various 99ch style violations in Intl.cpp. r=sparky
0fa9873c2881f2e87e7d049990e88b1740584f09: Bug 990082 - Add missing null check to nsWindowGfx::CreateIcon. r=sparky, a=sylvestre]
Jonathan Watt <jwatt@jwatt.org> - Wed, 16 Apr 2014 14:40:07 +0100 - rev 187102
Bug 990082 - Add missing null check to nsWindowGfx::CreateIcon. r=sparky, a=sylvestre]
8494153485ee1a97b97ae0468f154de84b0ec9e9: Bug 990082 - Add missing null check to nsWindowGfx::CreateIcon. r=sparky
Jonathan Watt <jwatt@jwatt.org> - Sun, 06 Apr 2014 15:41:45 +0100 - rev 185080
Bug 990082 - Add missing null check to nsWindowGfx::CreateIcon. r=sparky
91d27f0ac7dd5008933dbfd7b941fc2f075a59ef: Bug 355063 - bustage followup for Android/Metro. r=sparky
Justin Dolske <dolske@mozilla.com> - Wed, 21 Aug 2013 20:09:45 -0700 - rev 146305
Bug 355063 - bustage followup for Android/Metro. r=sparky
121b620c7e4976cc4567be6bdbf272bcfb87e369: Bug 496923 - Make update-test402.sh executable. r=sparky
Jeff Walden <jwalden@mit.edu> - Fri, 31 May 2013 14:41:54 -0700 - rev 135294
Bug 496923 - Make update-test402.sh executable. r=sparky
23d6197df2dd64759dbd719c3c8182453393cbbb: Bug 649570 - |delete window.NaN| should be a TypeError. This got fixed...sometime. Add a a test so we don't regress this in the future. r=sparky
Jeff Walden <jwalden@mit.edu> - Tue, 14 May 2013 12:56:26 -0700 - rev 133915
Bug 649570 - |delete window.NaN| should be a TypeError. This got fixed...sometime. Add a a test so we don't regress this in the future. r=sparky
5d07eabd9a876afd2a98183958849dc7cf3e919f: Minor style fixes to ObjectImpl.h. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 18 Apr 2013 16:21:48 -0700 - rev 131467
Minor style fixes to ObjectImpl.h. No bug, r=sparky
489ab986ea69e1ba7746e383a267483db9d861ea: #include jsscriptinlines.h in SPSProfiler.cpp so that it builds in no-jit configurations. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 04 Apr 2013 14:43:43 -0700 - rev 129334
#include jsscriptinlines.h in SPSProfiler.cpp so that it builds in no-jit configurations. No bug, r=sparky
e800ddbeba1ac246664cbee2d35e9df1890a0c1c: Bug 854419 - Fix ecma_5/JSON/parse-array-gc.js to work in non-debug builds. r=sparky as trivial
Jeff Walden <jwalden@mit.edu> - Mon, 25 Mar 2013 14:16:31 -0700 - rev 128076
Bug 854419 - Fix ecma_5/JSON/parse-array-gc.js to work in non-debug builds. r=sparky as trivial
9e397b0d223c9805be61bbd13dcd712613a4b586: Fix a C-style cast to a const_cast<>. Followup to bug 837957, r=sparky
Jeff Walden <jwalden@mit.edu> - Tue, 19 Mar 2013 16:34:37 -0700 - rev 127499
Fix a C-style cast to a const_cast<>. Followup to bug 837957, r=sparky
13c970f6a2e4c62ea79c6b78efb41b72d43a8760: Add a JSObject::addDataProperty overload that takes Handle<PropertyName*>, to preserve the name/element distinction further when possible, anticipating future property-splitting work. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 27 Dec 2012 11:20:22 -0600 - rev 120595
Add a JSObject::addDataProperty overload that takes Handle<PropertyName*>, to preserve the name/element distinction further when possible, anticipating future property-splitting work. No bug, r=sparky
6104f18f25276d9026b7140d312738ef988a1761: No bug - Fix four warnings in js/src; r=sparky
Ms2ger <ms2ger@gmail.com> - Sun, 06 Jan 2013 13:45:56 +0100 - rev 119308
No bug - Fix four warnings in js/src; r=sparky
c72d0bbb5571b2b8225808e53c4aa96be5f95758: Whitespace tab-killing patrol. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Fri, 04 Jan 2013 17:00:43 -0600 - rev 119187
Whitespace tab-killing patrol. No bug, r=sparky
62c52b199c9a566593444a029022f2783e88462f: Bug 792108 - Add more truthiness tests to ensure strict equality isn't affected by JSCLASS_EMULATES_UNDEFINED, and that falsy objects don't compare equal unless they're actually the same object. Just tests, they pass locally for me with the --tbpl driver option to do what Tinderbox does, r=sparky
Jeff Walden <jwalden@mit.edu> - Tue, 18 Dec 2012 17:01:46 -0500 - rev 117909
Bug 792108 - Add more truthiness tests to ensure strict equality isn't affected by JSCLASS_EMULATES_UNDEFINED, and that falsy objects don't compare equal unless they're actually the same object. Just tests, they pass locally for me with the --tbpl driver option to do what Tinderbox does, r=sparky
1c065e36b49d3c7150e13ca6d8df9c9b42daceaf: no bug; fix configure.in message on Android to not be lies and give useful info; r=sparky
Vladimir Vukicevic <vladimir@pobox.com> - Tue, 13 Nov 2012 14:20:54 -0500 - rev 114453
no bug; fix configure.in message on Android to not be lies and give useful info; r=sparky
cd5b9d2728d0d68364cc6452369ea353d1e58fba: Warning patrol: change the type of a variable to that of the value assigned to it, remove a set-but-never-used variable. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 12 Nov 2012 13:40:29 -0800 - rev 114346
Warning patrol: change the type of a variable to that of the value assigned to it, remove a set-but-never-used variable. No bug, r=sparky
d5e23f4018c67d62d9c393544fae0c6f8e7c5f8b: Give LinkedListElement a thisDuringConstruction() method, and use it in member initialization to silence an MSVC compiler warning. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 18 Oct 2012 18:39:54 -0700 - rev 111984
Give LinkedListElement a thisDuringConstruction() method, and use it in member initialization to silence an MSVC compiler warning. No bug, r=sparky
176600f40ddfc4d73e2367285eca456eda33ed62: Minor style nits in WeakPtr code forgotten by me when reviewing. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 08 Oct 2012 16:03:52 -0700 - rev 110955
Minor style nits in WeakPtr code forgotten by me when reviewing. No bug, r=sparky
978e9865042f4be110e719742d17a7d5480ec2b3: Eliminate a few nullptr-to-bool conversions to avoid a clang warning (which we upgrade to error) in some clang revs. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Tue, 09 Oct 2012 16:14:42 -0700 - rev 110880
Eliminate a few nullptr-to-bool conversions to avoid a clang warning (which we upgrade to error) in some clang revs. No bug, r=sparky
e2fb3f7e790df9250af28f0154e59991362ee443: Split up an assertion of x && y && z into separate asserts for x, y, and z, for easier at-a-glance understandings of failures should the assertion ever be hit. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 01 Oct 2012 11:23:40 -0700 - rev 109714
Split up an assertion of x && y && z into separate asserts for x, y, and z, for easier at-a-glance understandings of failures should the assertion ever be hit. No bug, r=sparky
69ace0535ffa16c42aa01335f724542439c4838f: Tweak an assertion in HashTable.h to use initialized() rather than !null, for clarity. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 10 Sep 2012 13:17:55 -0700 - rev 107992
Tweak an assertion in HashTable.h to use initialized() rather than !null, for clarity. No bug, r=sparky
9f3534c54fa38db04f783b218c8f9d310a779900: Fix another obvious typo to make MutableHandle<Value> a friend of ValueOperations<MutableHandle<Value>> and MutableValueOperations<MutableHandle<Value>>. Followup to bug 773049, r=sparky
Jeff Walden <jwalden@mit.edu> - Fri, 13 Jul 2012 12:04:33 -0700 - rev 99742
Fix another obvious typo to make MutableHandle<Value> a friend of ValueOperations<MutableHandle<Value>> and MutableValueOperations<MutableHandle<Value>>. Followup to bug 773049, r=sparky
14b79d264b0b07db0511469b81988940aaead90a: Bug 760995 - Move Scoped.h into the mozilla namespace. r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 11 Jun 2012 16:16:47 -0700 - rev 97704
Bug 760995 - Move Scoped.h into the mozilla namespace. r=sparky
b3067d05a76a2bc8c3f5f4fb1bb30464a2c6a0fa: Bug 760995 - Move Scoped.h into the mozilla namespace. r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 11 Jun 2012 16:16:47 -0700 - rev 97643
Bug 760995 - Move Scoped.h into the mozilla namespace. r=sparky
1c2b09648bd54bdbd80d480991e8d0ddf3d13cfc: Fix an obvious bool-to-pointer conversion warning, no bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 18 Jun 2012 13:48:58 -0700 - rev 97499
Fix an obvious bool-to-pointer conversion warning, no bug, r=sparky
a112cf3d055d8930f8bdb7f40b8537cc26bab787: Fix a couple style nits missed during review. Followup to bug 616262, r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 14 Jun 2012 17:55:11 -0700 - rev 97353
Fix a couple style nits missed during review. Followup to bug 616262, r=sparky
ebbc966ba9b8cc1b3198fa8cff4bf0af8109ba4b: Quell -Werror=return-type by adding some more MOZ_NOT_REACHED. Continuing along with bug 751377, r=sparky
Jeff Walden <jwalden@mit.edu> - Tue, 29 May 2012 12:01:32 -0700 - rev 96509
Quell -Werror=return-type by adding some more MOZ_NOT_REACHED. Continuing along with bug 751377, r=sparky
a807b20be0bf0452eba439aa0d83215a14d61913: Bug 737056 - Add some documentation on the mozilla::Version API; r=sparky
Ehsan Akhgari <ehsan@mozilla.com> - Thu, 07 Jun 2012 17:55:46 -0400 - rev 96501
Bug 737056 - Add some documentation on the mozilla::Version API; r=sparky DONTBUILD
1a0f4431003105008d31616e75b8db2d3291d54f: Style patrol to make everything conform to mfbt/STYLE. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Sun, 03 Jun 2012 20:36:43 -0700 - rev 96218
Style patrol to make everything conform to mfbt/STYLE. No bug, r=sparky
c766acdbe3116fe7c02d0578648019fa65fb8f1d: Remove TypeIsUint8Clamped as it's now unused. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Mon, 30 Apr 2012 14:55:19 -0700 - rev 93438
Remove TypeIsUint8Clamped as it's now unused. No bug, r=sparky
448b65b7b799ce0ddf7f9514c09b0ddf1fd11d4e: Remove an unnecessary jsdate.h #include from jsobjinlines.h, and add a new one to vm/GlobalObject.cpp, significantly reducing the number of files compiled when jsdate.h changes. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 26 Apr 2012 18:58:30 -0700 - rev 93056
Remove an unnecessary jsdate.h #include from jsobjinlines.h, and add a new one to vm/GlobalObject.cpp, significantly reducing the number of files compiled when jsdate.h changes. No bug, r=sparky
afa931630210ef87b92c4e8ee9769052394a5094: Line-wrap the mfbt style docs at 80 characters. The docs are more easily edited the other way, but MXR doesn't auto-wrap long lines, and readability trumps writability here. No bug, r=sparky, DONTBUILD
Jeff Walden <jwalden@mit.edu> - Fri, 09 Mar 2012 15:02:51 -0800 - rev 88951
Line-wrap the mfbt style docs at 80 characters. The docs are more easily edited the other way, but MXR doesn't auto-wrap long lines, and readability trumps writability here. No bug, r=sparky, DONTBUILD
09db7c74f24d3d0859dacb7b07b277ff18e05bb6: Bug 712378 followup - Fix incorrect license headers; r=sparky
Ms2ger <ms2ger@gmail.com> - Fri, 10 Feb 2012 11:04:44 +0100 - rev 86808
Bug 712378 followup - Fix incorrect license headers; r=sparky
e433daca145f6fba40167416016ff7d62a2ffaa5: Bug 707049 - Followup: fix accidentally introduced 'uint8's from js/src; r=sparky
Ms2ger <ms2ger@gmail.com> - Mon, 02 Jan 2012 19:06:35 +0100 - rev 83844
Bug 707049 - Followup: fix accidentally introduced 'uint8's from js/src; r=sparky
656af9b2d4817739d1eed19c6ef3e6f1d022f95c: Bug 713944 - Move some declarations down to uses in fill(). r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 29 Dec 2011 05:44:08 -0600 - rev 83776
Bug 713944 - Move some declarations down to uses in fill(). r=sparky
fdc3f397377a565c03bc31b89011655828014cb3: s/class (JSObject|JSContext)/struct \1/g in nsDOMEvent.h, silencing a ton of warnings on Windows, and I think with Clang too. No bug, r=sparky
Jeff Walden <jwalden@mit.edu> - Thu, 15 Dec 2011 03:48:09 -0500 - rev 82858
s/class (JSObject|JSContext)/struct \1/g in nsDOMEvent.h, silencing a ton of warnings on Windows, and I think with Clang too. No bug, r=sparky