searching for reviewer(snorp)
45e3efb5e07666bd7e6e7bb0c0db34aa2cd75b4a: Bug 1499895 - [1.3] Add triggering URI to onLoadRequest. r=snorp,jchen
Eugen Sawin <esawin@mozilla.com> - Wed, 17 Oct 2018 10:06:42 +0200 - rev 490358
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499895 - [1.3] Add triggering URI to onLoadRequest. r=snorp,jchen
d72b8e9bac3f8eead0f679b5ad07f9b1b6a7e7d8: Bug 1499137 - unbind media manager service only when both codecs and DRM bridges are gone. r=jya,snorp
John Lin <jolin@mozilla.com> - Wed, 17 Oct 2018 15:26:49 +0000 - rev 490088
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499137 - unbind media manager service only when both codecs and DRM bridges are gone. r=jya,snorp Differential Revision: https://phabricator.services.mozilla.com/D8794
3939abb2b2c283dfdd09ea45b29d2d6fcb042dfa: Bug 1495786 - Update tests to use AllowOrDeny in lieu of Boolean. r=snorp
Dylan Roeh <droeh@mozilla.com> - Tue, 16 Oct 2018 12:24:05 -0500 - rev 489809
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1495786 - Update tests to use AllowOrDeny in lieu of Boolean. r=snorp
af27cdf736f592782bb9f6d0a0bff62222a55e3e: Bug 1495786 - Replace ambiguous Booleans with AllowOrDeny, an enum with clearly named values. r=snorp,jchen
Dylan Roeh <droeh@mozilla.com> - Tue, 16 Oct 2018 12:23:42 -0500 - rev 489808
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1495786 - Replace ambiguous Booleans with AllowOrDeny, an enum with clearly named values. r=snorp,jchen
ac0fc3f030290176619301bc08e25694a3741464: Bug 1454444: Add GeckoSession.getUserAgent. r=snorp,esawin
Agi Sferro <agi@mozilla.com> - Thu, 11 Oct 2018 15:31:15 +0000 - rev 489118
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1454444: Add GeckoSession.getUserAgent. r=snorp,esawin This patch adds a new API to GeckoSession to get the currently used UserAgent. Differential Revision: https://phabricator.services.mozilla.com/D8022
8dcf2e242b3aee77099c6370a0c25e009c5838ef: Bug 1495030 - [1.0] Add third-party tracker cookies blocking setting. r=snorp,baku
Eugen Sawin <esawin@mozilla.com> - Thu, 04 Oct 2018 20:49:31 +0200 - rev 488116
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495030 - [1.0] Add third-party tracker cookies blocking setting. r=snorp,baku
9ebf0b05b44abcdfeebf98ffcc6db352261d9f5e: Bug 1495907 - Ensure MediaService self terminates when parent process dies r=snorp
Randall Barker <rbarker@mozilla.com> - Wed, 03 Oct 2018 14:43:43 +0000 - rev 487776
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495907 - Ensure MediaService self terminates when parent process dies r=snorp Differential Revision: https://phabricator.services.mozilla.com/D7548
005e374d721ecb778d3a8293e6a1c033c4916e0a: Bug 1492308 - 5. Make various objects use the new disposal mechanism; r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 02 Oct 2018 19:59:40 +0000 - rev 487646
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492308 - 5. Make various objects use the new disposal mechanism; r=snorp Make LayerViewSupport, NPZCSupport, GeckoEditableSupport, and SessionAccessibility use the new disposal mechanism to ensure the disposal is performed safely. Differential Revision: https://phabricator.services.mozilla.com/D7110
17a45b4d6fd5c7f36c6ba8004e615d4d348c3cbd: Bug 1492308 - 4. Add new mechanism for safely disposing native objects; r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 02 Oct 2018 19:59:37 +0000 - rev 487645
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492308 - 4. Add new mechanism for safely disposing native objects; r=snorp Add a new mechanism in NativePtr::Detach to safely dispose objects. A new disposer Runnable is passed to OnDetach functions. The OnDetach functions invoke the disposer after changing the object state. The disposer then makes sure the object hasn't been attached to another native object in the meantime. Disposal is only performed when the current native object matches the original one. Differential Revision: https://phabricator.services.mozilla.com/D7109
7893e8aae29590b426a71fb7fe151dc75b385143: Bug 1492308 - 3. Add test for tapping after content crash; r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 02 Oct 2018 19:59:34 +0000 - rev 487644
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492308 - 3. Add test for tapping after content crash; r=snorp Add a test for the crash scenario where PZC is used after content crashes and restarts. Differential Revision: https://phabricator.services.mozilla.com/D7108
8ab31240dbec5dbe913462a7d68dfa3f5526cdce: Bug 1492308 - 2. Create new native handle before clearing old one; r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 02 Oct 2018 19:59:32 +0000 - rev 487643
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492308 - 2. Create new native handle before clearing old one; r=snorp Create a new native handle first before deleting any old ones, so we can be sure the new handle would not have the same value as the old handle, which can confuse our code. Differential Revision: https://phabricator.services.mozilla.com/D7107
0f4cf0de3dfa19eea89f6d5c55ac7f4e980e0c90: Bug 1492308 - 1. Generate natives binding for all JNIObject classes; r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 02 Oct 2018 19:59:28 +0000 - rev 487642
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492308 - 1. Generate natives binding for all JNIObject classes; r=snorp Right now we skip generating natives binding for a class if the class doesn't have native methods. However, we should still generate the natives binding for JNIObject classes because these classes can still be attached to C++ objects even without native methods. Differential Revision: https://phabricator.services.mozilla.com/D7106
66fcf985374fbc49cbf5a27f850193ce4c18989a: Bug 1489933 - Make GeckoDisplay and PanZoomController constructors protected r=snorp
Paul Roget <paul@mozilla.com> - Tue, 02 Oct 2018 10:22:26 -0500 - rev 487495
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1489933 - Make GeckoDisplay and PanZoomController constructors protected r=snorp
59dc22658d45275e7ae8495fbde9286ff88e4038: Bug 1494486 - Add testing for PromptDelegate.onPopupRequest. r=snorp
Dylan Roeh <droeh@mozilla.com> - Mon, 01 Oct 2018 12:53:28 -0500 - rev 487481
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494486 - Add testing for PromptDelegate.onPopupRequest. r=snorp
b3439a7f9f2771424d2dab0e5f5c260e3a3872f4: Bug 1486061 - [1.1] Add GeckoView safe browsing tests. r=snorp
Eugen Sawin <esawin@mozilla.com> - Fri, 24 Aug 2018 19:19:35 +0200 - rev 486925
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1486061 - [1.1] Add GeckoView safe browsing tests. r=snorp
50c67bb42d237c19acad051802389180e1700a19: Bug 1481296 - Add a popup blocking API to PromptDelegate. r=jchen,snorp
Dylan Roeh <droeh@mozilla.com> - Fri, 07 Sep 2018 13:39:57 -0500 - rev 486663
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1481296 - Add a popup blocking API to PromptDelegate. r=jchen,snorp
a7f1d2b04291a97a44fc08160b33cf3b0488127c: Bug 1492771 - Make GeckoSession non-final r=snorp
Paul Rouget <paul@mozilla.com> - Thu, 20 Sep 2018 14:12:15 +0200 - rev 486628
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492771 - Make GeckoSession non-final r=snorp
9d576eb300e650b9e50fc197c3d2027291d10c29: Bug 1491787 - Use document rather than event target to check fullscreen state in Android's browser.js. r=snorp
Xidorn Quan <me@upsuper.org> - Thu, 20 Sep 2018 13:50:09 +0000 - rev 485832
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491787 - Use document rather than event target to check fullscreen state in Android's browser.js. r=snorp The content of e.target has been changed in bug 1375319 from document to the fullscreen element, so the current code makes it never dispatch DOMFullScreen:Start, so the Java side would not be aware of such state. This code was initially added in bug 859683 for supporting scrolling when the fullscreen element is the document element. Since then, it seems that the related code had been refactored, and the only usage of rootElement was removed in bug 1416330. Because of that, it is no longer necessary to use event target, and we can just use document directly, which would fix this issue. Differential Revision: https://phabricator.services.mozilla.com/D6221
22a6f4ef044a5d23e4232d94433184b0b3ec91c9: Bug 1442176 - 2. Add pinned-to-screen flag in GeckoSession; r=snorp r=droeh
Jim Chen <nchen@mozilla.com> - Mon, 17 Sep 2018 17:47:21 -0400 - rev 485397
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1442176 - 2. Add pinned-to-screen flag in GeckoSession; r=snorp r=droeh Add a flag for whether the session should be pinned to the screen. The app would check the flag and prevent scrolling of the session when it's pinned. Differential Revision: https://phabricator.services.mozilla.com/D5190
10f0ecb6ed63df89c6295f3c9fbcf896471186eb: Bug 1442176 - 1. Remove current pin-on-caret-drag code; r=snorp
Jim Chen <nchen@mozilla.com> - Mon, 17 Sep 2018 17:47:21 -0400 - rev 485396
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1442176 - 1. Remove current pin-on-caret-drag code; r=snorp Remove the current code that pins the toolbar on caret drag, which only works for Fennec. Differential Revision: https://phabricator.services.mozilla.com/D5189
28888ba362a12cb91bdbe193fa601f4b8c70f2d8: Bug 1449567 - Don't reattach compositor for the same compositor object; r=snorp
Jim Chen <nchen@mozilla.com> - Mon, 17 Sep 2018 17:29:30 +0000 - rev 485183
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1449567 - Don't reattach compositor for the same compositor object; r=snorp If we're trying to detach and reattach the same compositor object for whatever reason, we should skip it so we don't inadvertently end up not attaching the object at all. Differential Revision: https://phabricator.services.mozilla.com/D5608
a02ef614a87bc32bcf2742f2e1ca849c66f7a47e: Bug 1280184 - Turn off downloads integration on Android M and later. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 17 Sep 2018 15:01:03 +0000 - rev 485181
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1280184 - Turn off downloads integration on Android M and later. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D5948
52573727971b04056f78c20e6873215c2345bbba: Bug 1449567 - Don't reattach compositor for the same compositor object; r=snorp
Jim Chen <nchen@mozilla.com> - Thu, 13 Sep 2018 16:25:26 +0000 - rev 484948
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1449567 - Don't reattach compositor for the same compositor object; r=snorp If we're trying to detach and reattach the same compositor object for whatever reason, we should skip it so we don't inadvertently end up not attaching the object at all. Differential Revision: https://phabricator.services.mozilla.com/D5608
6021f554fe5bbd71ed4b34b8340ae5c993e14e46: Bug 1486552 - geckoview: Add GeckoRuntimeSettings.setLocale method. r=snorp
Matt Brubeck <mbrubeck@mozilla.com> - Fri, 31 Aug 2018 11:33:29 -0700 - rev 484573
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1486552 - geckoview: Add GeckoRuntimeSettings.setLocale method. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D4794
5cfda4227c6a2301c05900ee40d710b2324fb4a9: Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=Gijs,snorp,jcj,mcmanus,sfraser,keeler,baku,ato
Dipen Patel <bugzilla@pansara.org> - Tue, 11 Sep 2018 00:07:30 +0000 - rev 483964
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=Gijs,snorp,jcj,mcmanus,sfraser,keeler,baku,ato Move all fields of nsISSLStatus to nsITransportSecurityProvider Remove nsISSLStatus interface and definition Update all code and test references to nsISSLStatus Maintain ability to read in older version of serialized nsISSLStatus. This is verified with psm_DeserializeCert gtest. Differential Revision: https://phabricator.services.mozilla.com/D3704
bd8baf88f3739a6b2211faaafea974c84a87d0b2: Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=snorp,ato,sfraser,keeler,baku,mcmanus,Gijs
Dipen Patel <bugzilla@pansara.org> - Fri, 07 Sep 2018 22:50:17 +0000 - rev 483622
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=snorp,ato,sfraser,keeler,baku,mcmanus,Gijs Move all fields of nsISSLStatus to nsITransportSecurityProvider Remove nsISSLStatus interface and definition Update all code and test references to nsISSLStatus Maintain ability to read in older version of serialized nsISSLStatus. This is verified with psm_DeserializeCert gtest. Differential Revision: https://phabricator.services.mozilla.com/D3704
0a43224df4691815d432718813a0e84bf5b7aa21: Bug 1474847 - Fix GeckoSurfaceTexture not correctly removed from container when released: r=snorp,rbarker
Imanol Fernandez <imanol@mozilla.com> - Thu, 06 Sep 2018 15:35:31 +0000 - rev 483431
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1474847 - Fix GeckoSurfaceTexture not correctly removed from container when released: r=snorp,rbarker When entering and exiting immersive mode multiple time (~30) the WebGL context can be lost. This is caused because GeckoSurfaceTexture things there are more than 200 textures created. Differential Revision: https://phabricator.services.mozilla.com/D4235
34d7cf7fa7eb1c51c6e7f2b4cbf3e5da20ba36d8: Bug 1484001 - Avoid ending up with a null mRuntime after restoring state in GeckoView. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 30 Aug 2018 20:09:02 +0000 - rev 482653
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484001 - Avoid ending up with a null mRuntime after restoring state in GeckoView. r=snorp If we don't have a saved session, we do nothing. If somebody called setSession beforehand, we continue using that session, otherwise we create a fallback session in onAttachedToWindow(). If we have a saved session and nobody called setSession, we use the saved session. If the saved session was closed and doesn't have a runtime, we use the default runtime as a fallback. If we have both a saved session and somebody already called setSession, we transfer what can be transferred from the saved session, unless the saved session is closed and the session from setSession is open. If the saved session was open, we use its runtime as well going forward (since transferring the state from an open session transfers the window and the runtime as well), otherwise we keep the old mRuntime. Differential Revision: https://phabricator.services.mozilla.com/D4711
a6e752d996557df8cd1782c52751edde538bb9ab: Bug 1485178 - Only migrate sharedprefs when in Fennec. r=snorp
Dylan Roeh <droeh@mozilla.com> - Tue, 28 Aug 2018 11:35:46 -0500 - rev 482191
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485178 - Only migrate sharedprefs when in Fennec. r=snorp
33c06c93406863777cedffacc04e78caab6d1e8d: Bug 1483397 - Add media control API so apps can control when media is paused r=snorp,rbarker,jchen
Imanol Fernandez <imanol@mozilla.com> - Tue, 28 Aug 2018 21:55:03 +0000 - rev 482047
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483397 - Add media control API so apps can control when media is paused r=snorp,rbarker,jchen Add a GeckoSession property too specify if media should be suspended when the session is inactive. Differential Revision: https://phabricator.services.mozilla.com/D4472
ca0f02aa22ea8a12765eeed8a7f337c3b5b1be2e: Bug 1474847 - Fix GeckoSurfaceTexture not correctly removed from container when released: r=snorp,rbarker
Imanol Fernandez <imanol@mozilla.com> - Mon, 27 Aug 2018 15:15:21 +0000 - rev 481908
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1474847 - Fix GeckoSurfaceTexture not correctly removed from container when released: r=snorp,rbarker When entering and exiting immersive mode multiple time (~30) the WebGL context can be lost. This is caused because GeckoSurfaceTexture things there are more than 200 textures created. Differential Revision: https://phabricator.services.mozilla.com/D4236
9e979fcf44ddcba566b49df5eb0cb8f80f4861c1: Bug 1484220 - Enable marionette in all fennec builds; r=snorp
Geoff Brown <gbrown@mozilla.com> - Mon, 27 Aug 2018 07:19:02 -0600 - rev 481774
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484220 - Enable marionette in all fennec builds; r=snorp
ebb3dfbeaee88ce71a5287de5c97cbc6a5fbede2: Bug 1484246 - Part 2 - Add more explanation to certificate errors caused by Symantec distrust to Fennec. r=snorp
Johann Hofmann <jhofmann@mozilla.com> - Sun, 26 Aug 2018 14:32:01 +0200 - rev 481739
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484246 - Part 2 - Add more explanation to certificate errors caused by Symantec distrust to Fennec. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D4297
75b11f12bf4be13dbcabaf81c322d12ad6106b86: Bug 1479270 - part2 : remove HLS video player. r=snorp
alwu <alwu@mozilla.com> - Fri, 24 Aug 2018 22:36:18 +0000 - rev 481712
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1479270 - part2 : remove HLS video player. r=snorp Since we have native HLS support in 59 [1], we can remove those codes which is used to play HLS. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1345752 Differential Revision: https://phabricator.services.mozilla.com/D4166
1676f895a7102a9fab1a84c2a5e43449edd7f870: Bug 1479270 - part2 : remove HLS video player. r=snorp
alwu <alwu@mozilla.com> - Fri, 24 Aug 2018 14:52:00 +0000 - rev 481670
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1479270 - part2 : remove HLS video player. r=snorp Since we have native HLS support in 59 [1], we can remove those codes which is used to play HLS. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1345752 Differential Revision: https://phabricator.services.mozilla.com/D4166
3f1617759de56e327eb0b4edf1c4689a95ad8023: Bug 1484496: Part 5c - Convert mobile/ nsISimpleEnumerator users to use JS iteration. r=snorp
Kris Maglione <maglione.k@gmail.com> - Sat, 18 Aug 2018 19:28:06 -0700 - rev 481504
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484496: Part 5c - Convert mobile/ nsISimpleEnumerator users to use JS iteration. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D3731
3758580bd8895d0a0df7762fbc38b2b746ecef5d: Bug 1330257 - 8. Add tests for Oreo auto-fill frontend; r=snorp
Jim Chen <nchen@mozilla.com> - Thu, 23 Aug 2018 17:03:35 -0400 - rev 481442
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1330257 - 8. Add tests for Oreo auto-fill frontend; r=snorp Add some tests for the Oreo auto-fill frontend, similar to the tests for the a11y auto-fill frontend. However, because these tests depend on the ViewStructure class, they require SDK 23+ to run. Differential Revision: https://phabricator.services.mozilla.com/D3810
e635f336c727db6e34b09184b42feb2879f3622b: Bug 1484823 - Fix Android build errors with NDK r18-beta1. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 22 Aug 2018 16:01:33 +0000 - rev 481238
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484823 - Fix Android build errors with NDK r18-beta1. r=snorp Getting a working local build with the system clang might be tricky, while building with NDK r17 clang is broken (bug 1484723). NDK r18-beta1 fixes this, but also made all jvalue* method parameters in jni.h const,so in order to support building with it we need to adjust our relevant function types, too. Differential Revision: https://phabricator.services.mozilla.com/D3832
94cfd6113ca7c7efef708d2b0af8bcd5703d7fe2: Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp
Dylan Roeh <droeh@mozilla.com> - Tue, 21 Aug 2018 12:52:39 -0500 - rev 481144
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1478171 - [1.0] Forward channel redirect to nsILoadURIDelegate to allow external handling. r=smaug,snorp
d0e40284db4b4f5851e23bb0e4a406e6f8e2ac5f: Bug 1330257 - 7. Add Oreo auto-fill frontend; r=esawin r=snorp
Jim Chen <nchen@mozilla.com> - Tue, 21 Aug 2018 15:23:29 -0400 - rev 480957
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1330257 - 7. Add Oreo auto-fill frontend; r=esawin r=snorp Add a frontend for the Oreo auto-fill API in SessionTextInput, which processes events from Gecko and provides consumer APIs that match the Oreo auto-fill APIs. GeckoView then forwards the necessary calls to SessionTextInput. Differential Revision: https://phabricator.services.mozilla.com/D3538
53ef69afca6959ca87e5c4cfb97955371d729fab: Bug 1330257 - 7. Add Oreo auto-fill frontend; r=esawin r=snorp
Jim Chen <nchen@mozilla.com> - Mon, 20 Aug 2018 22:28:21 -0400 - rev 480824
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1330257 - 7. Add Oreo auto-fill frontend; r=esawin r=snorp Add a frontend for the Oreo auto-fill API in SessionTextInput, which processes events from Gecko and provides consumer APIs that match the Oreo auto-fill APIs. GeckoView then forwards the necessary calls to SessionTextInput. Differential Revision: https://phabricator.services.mozilla.com/D3538
369762aaed07c4e20d5837219ff55f6f17c28aa8: Bug 1484374 - Update GeckoView to handle the autoplay-media permission request. r=snorp
Randall Barker <rbarker@mozilla.com> - Sat, 18 Aug 2018 17:19:32 +0000 - rev 480595
Push 229 by fmarier@mozilla.com at Sun, 19 Aug 2018 02:09:13 +0000
Bug 1484374 - Update GeckoView to handle the autoplay-media permission request. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D3680
c75f6fed5d90fc3345f4ba5aa6779d40dc1248b3: Bug 1483665 - Only call SetSelectionDragState in parent process; r=snorp
Jim Chen <nchen@mozilla.com> - Fri, 17 Aug 2018 23:05:08 +0000 - rev 480572
Push 229 by fmarier@mozilla.com at Sun, 19 Aug 2018 02:09:13 +0000
Bug 1483665 - Only call SetSelectionDragState in parent process; r=snorp We can't call nsWindow::SetSelectionDragState in the child process so check for the parent process first. Differential Revision: https://phabricator.services.mozilla.com/D3561
247060b7dc37f5ff17a7edd9a9ca8294e31c86fa: Bug 1483893 - Avoid crashing if we somehow don't have a GeckoRuntime. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 16 Aug 2018 16:49:48 -0500 - rev 480335
Push 227 by fmarier@mozilla.com at Sat, 18 Aug 2018 09:02:59 +0000
Bug 1483893 - Avoid crashing if we somehow don't have a GeckoRuntime. r=snorp MozReview-Commit-ID: AGJMrZP0fWu
47e290808d8e401d70ef5fc4a8f523388de6dd96: Bug 1483342 - [1.1] Add GeckoRuntime Safe Browsing API. r=snorp,jchen,francois
Eugen Sawin <esawin@mozilla.com> - Tue, 14 Aug 2018 21:40:50 +0200 - rev 480215
Push 227 by fmarier@mozilla.com at Sat, 18 Aug 2018 09:02:59 +0000
Bug 1483342 - [1.1] Add GeckoRuntime Safe Browsing API. r=snorp,jchen,francois
73efbce701a9880e35a5139dc67757fa68ad892a: Bug 1476106 - Part 5 - Subscribe PromptService to OrientationChangeListener, too. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 02 Aug 2018 21:17:07 +0200 - rev 479940
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1476106 - Part 5 - Subscribe PromptService to OrientationChangeListener, too. r=snorp Now that GeckoScreenOrientation generally offers notifications of screen orientation changes, the PromptService no longer needs to do its own orientation tracking and require to be fed orientation changes from each activity using it. MozReview-Commit-ID: K7KbDsQip7b
67b327d75ce6ff41b854ce731739e0a6851674ca: Bug 1476106 - Part 4 - Refresh ScreenManager data when detecting orientation changes. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 02 Aug 2018 22:03:59 +0200 - rev 479939
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1476106 - Part 4 - Refresh ScreenManager data when detecting orientation changes. r=snorp As of bug 1475875, cached screen data is now held by Gecko, so - we no longer need to cache the screen size (retrieval of which can be expensive when called en masse, as required e.g. by font inflation) within GeckoAppShell, and - we need to trigger a refresh of that data instead when the activity orientation changes. MozReview-Commit-ID: JsY6sBCcOih
e936ef6b4b50fc09d0ffb988cb563f4a79d7b34c: Bug 1476106 - Part 3 - Move GeckoScreenOrientation updates into GeckoView. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 12 Aug 2018 13:31:59 +0200 - rev 479938
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1476106 - Part 3 - Move GeckoScreenOrientation updates into GeckoView. r=snorp By moving the calls to GeckoScreenOrientation.update() into GeckoView, any app using a GeckoView will automatically update the screen orientation in Gecko, too, without any further action being required by the embedding app. The synchronisation around GeckoScreenOrientation.update()/(un)lock() is required for the following scenario: If (un)locking of the screen orientation as requested by Gecko caused the actual screen orientation of the app to change, there are two ways in which this will cause our internal screen orientation to be updated: 1. Either the call to delegate.setRequestedOrientationForCurrentActivity (happening on the Gecko thread if the original request to (un)lock came from Gecko) returns first and update() is subsequently first called from the Gecko thread, too, meaning the onOrientationChange notification to Gecko can occur synchronously as well. In that case, as soon as (un)lock returns to Gecko, querying our internal screen orientation will return the correct value. 2. Or else the GeckoView.onConfigurationChanged() call resulting from the screen rotation manages to call GeckoScreenOrientation.update() first and does so from the Android UI thread. This means that the onOrientationChange notification will be redispatched asynchronously to the Gecko thread, while the Gecko thread's call to GeckoScreenOrientation.update() will return early without doing any work, as the screen orientation had already been previously updated by the UI thread. As a result,there will be a period of time between the Gecko thread returning from GeckoScreenOrientation.(un)lock() and the onOrientationChange notification finally executing where querying the internal screen orientation will not yet return the new orientation. This can cause problems for Gecko (test) code that expects to (un)lock the orientation and then be able to immediately query the new, changed orientation after the call to (un)lock returns. Without additional measures in place, there are no guarantees at what point the GeckoView will receive the onConfigurationChanged() call in relation to the request to change the activity's orientation making its way back to (un)lock(). Therefore, we add synchronisation such that no other thread will be able to up- date the screen orientation in GeckoScreenOrientation while another thread is still busy (un)locking the screen orientation. MozReview-Commit-ID: 5s5NEJcuS0p
70bfe613b3253974eb3a2d2562739a6fd6d4ed22: Bug 1476106 - Part 2 - Fix setting of mRuntime when restoring GeckoView from savedInstanceState. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 04 Aug 2018 15:21:40 +0200 - rev 479937
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1476106 - Part 2 - Fix setting of mRuntime when restoring GeckoView from savedInstanceState. r=snorp The call to mSession.transferFrom(ss.session) in the line above also transfers the window from ss.session into mSession, which means we subsequently won't be able to retrieve a runtime from ss.session any more, thereby defeating the goal of calling mRuntime = ss.session.getRuntime(). This case is encountered e.g. when the containing activity is destroyed and sub- sequently recreated after a configuration change that isn't handled by the app, e.g. screen rotation in the GeckoView example app. MozReview-Commit-ID: 5YGskdLZWqw
1484cdde97b801100ce3b06eb19d510b4f7408ff: Bug 1476106 - Part 1 - Make it possible to notify Java listeners from GeckoScreenOrientation, too. r=snorp
Jan Henning <jh+bugzilla@buttercookie.de> - Thu, 02 Aug 2018 21:10:33 +0200 - rev 479936
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1476106 - Part 1 - Make it possible to notify Java listeners from GeckoScreenOrientation, too. r=snorp Once responsibility for notifying GeckoScreenOrientation of potentially changed screen orientations moves from GeckoApp into GeckoView, the former will no longer be able to benefit from the return value of calling GeckoScreen- Orientation.update(), indicating whether the orientation actually changed or in fact remained the same. GeckoApp however requires that information in order to reset/refresh parts of the UI when the orientation changes, and since GeckoScreenOrientation is already doing all the work of tracking screen orientation changes, we don't want to have to partially duplicate those efforts again in GeckoApp. Instead, we introduce a mechanism for GeckoScreenOrientation to notify interested parties on the Android app side as well. The GeckoScreenOrientation.update() call in GeckoApp.onResume() is removed completely (as opposed to merely removing the refreshChrome() bit) at this stage already because it is unnecessary. If any screen rotation happened while the activity was in background, it will receive an onConfigurationChanged() call anyway before being resumed again. MozReview-Commit-ID: Ila1evcj8Ud