searching for reviewer(smaug)
91f9ce903f7a4a244c5371918d9ade49cd3051cb: Bug 1501833 - Allow the retargetdocumentfocus attribute to be used in any chrome document. r=smaug
Brendan Dahl <bdahl@mozilla.com> - Wed, 24 Oct 2018 21:10:37 +0000 - rev 491223
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501833 - Allow the retargetdocumentfocus attribute to be used in any chrome document. r=smaug Fixes test browser/base/content/test/general/browser_documentnavigation.js for browser.xhtml. Differential Revision: https://phabricator.services.mozilla.com/D9711
4f1fd54c853fd655e91975b364dd5640559f5f6e: Bug 1488973: Wrap privileged promises in a promise for the document we`re returning to. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Wed, 24 Oct 2018 17:41:46 +0000 - rev 491177
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488973: Wrap privileged promises in a promise for the document we`re returning to. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D7961
819df51e30836ba46efe72d91654a3c6b9365f02: Bug 1488973: Wrap privileged promises in a promise for the document we`re returning to. r=smaug
Zibi Braniecki <zbraniecki@mozilla.com> - Tue, 23 Oct 2018 18:59:06 +0000 - rev 491072
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488973: Wrap privileged promises in a promise for the document we`re returning to. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D7961
51b0078af6385a478f640ca30c87c74586e70d32: Bug 1499821 - Some general code style fixes for nsTransferable. r=smaug
Tom Schuster <evilpies@gmail.com> - Tue, 23 Oct 2018 12:17:02 +0000 - rev 490937
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499821 - Some general code style fixes for nsTransferable. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D9496
ed140051bbd084272751b203b475e1a712f1c2d1: Bug 1499821 - Remove unused nsITransferable.isLargeDataSet. r=smaug
Tom Schuster <evilpies@gmail.com> - Mon, 22 Oct 2018 21:46:38 +0000 - rev 490884
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499821 - Remove unused nsITransferable.isLargeDataSet. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D9440
d9c2a804cbc8188d5b15e3c8038ea27300ab79a6: Bug 1499996 - Wait to run tests until new window gets focus r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 23 Oct 2018 07:34:55 +0000 - rev 490878
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499996 - Wait to run tests until new window gets focus r=smaug test_expanding_selection_per_page.html creates another window and requires focus event on each case which creates editing host because EditorEventListener::Focus() sets ancestor limit of Selection as the editing host. Therefore, if the window itself does not have focus, focus event won't be fired on editing hosts. So, the reason why the orange occurs almost all with opt build is, debug build is enough slow to wait focus of new window before running test. Differential Revision: https://phabricator.services.mozilla.com/D9473
a3fad30f081a0bcd4aeae913942fc360dbdbf30e: Bug 1500011 - Use CheckedInt more in CalculateBufferSizeForImage, r=smaug
Nika Layzell <nika@thelayzells.com> - Thu, 18 Oct 2018 16:20:03 -0400 - rev 490733
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500011 - Use CheckedInt more in CalculateBufferSizeForImage, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D9145
bbb8bac97270807cf396a7d0c33a777e6a57d4d0: Bug 1500956 part 3. Fix our DOM pre-insertion checks to actually match the spec. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 23 Oct 2018 00:32:01 +0200 - rev 490726
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500956 part 3. Fix our DOM pre-insertion checks to actually match the spec. r=smaug
5c6566236a81d93dd1f41aec87b2dc56fbf5c8c9: Bug 1500956 part 2. Change our EnsurePreInsertionValidity implementation to follow the spec more closely. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 23 Oct 2018 00:32:00 +0200 - rev 490725
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500956 part 2. Change our EnsurePreInsertionValidity implementation to follow the spec more closely. r=smaug This is basically putting in https://dom.spec.whatwg.org/#concept-node-ensure-pre-insertion-validity step 3 and moving step 4 to the right place in the order of steps. This matters, because step 3 throws a different exception from all the other steps.
b5d831c8d69c567921c24afd111e22bd42223e29: Bug 1500956 part 1. Change IsAllowedAsChild to take an ErrorResult instead of returning a boolean. r=smaug
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 23 Oct 2018 00:32:00 +0200 - rev 490724
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500956 part 1. Change IsAllowedAsChild to take an ErrorResult instead of returning a boolean. r=smaug The spec algorithms have a step that throws NotFoundError in between steps that throw HierarchyRequestError. We can't really implement that with our current setup. This changeset does not change observable behavior.
140a56e90594382a0c24298b08a5a853e95c0b32: Bug 1499792: Remove unneeded 'ThrottledEventQueue' forward declarations. r=smaug
Jim Blandy <jimb@mozilla.com> - Thu, 18 Oct 2018 12:20:14 +0000 - rev 490541
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499792: Remove unneeded 'ThrottledEventQueue' forward declarations. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D9008
394a1e5544f65e59ea1e12e19f788f50078ddf20: Bug 1486888 - Support XUL broadcasters in non-XUL documents. r=smaug
Brendan Dahl <bdahl@mozilla.com> - Fri, 19 Oct 2018 01:22:46 +0000 - rev 490409
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486888 - Support XUL broadcasters in non-XUL documents. r=smaug The majority of the XUL broadcaster logic is moved out of XULDocument and into a separate class (XULBroadcastManager). The hookup points for when listeners need to be created and listeners need to be notified is now handled by the XULElement itself and nsDocument. To avoid any overhead, the XULBroadcastManager is only ever created when a document uses a listener. The new approach does have the disadvantage that broadcasting can now only work with XULElements, but going forward we'd like to discontinue this feature and rely on MutationObservers to implement similar things. One test had to be modified to use XUL elements instead of HTML elements because of the reason noted above. Differential Revision: https://phabricator.services.mozilla.com/D8888
02a07fe8780872236c65ddc30470209bef95b71b: Bug 1482425 - PresShell::PageMove() should use different rules to look for a container element for aExtend value r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 18 Oct 2018 04:42:53 +0000 - rev 490205
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1482425 - PresShell::PageMove() should use different rules to look for a container element for aExtend value r=smaug PresShell::PageMove() climbs up to parent document when there is no scrollable parent in current document. However, if aExtend is true, it should expand Selection in the document itself. Therefore, it needs different rules to look for container of expanding Selection from scrollable element to scroll. Additionally, old rules (i.e., before the fix of bug 1369072 which caused this regression) were also buggy. It used parent scrollable element or root scrollable element simply. Therefore, if found scrollable element is ancestor of selection limiter, it didn't work as expected. This patch creates nsFrameSelection::GetFrameToPageSelect() to retrieve per-page selection container element with the following rules: - look for a scrollable element in selection limiter. - if there is no scrollable element, use selection limiter. - if there is no selection limiter, use the root frame. So, nsFrameSelection::CommonPageMove() should take nsIFrame rather than nsIScrollableFrame since container of per-page selection may be used in non-scrollable contenteditable element. If it's called with non-scrollable frame, it needs to compute the expanding range with the frame size. Differential Revision: https://phabricator.services.mozilla.com/D8954
1249680014b0b4faf9eed339f9716755322bb33d: Bug 1499473: Simplify TabGroup a bit, now that ThrottledEventQueue::Create is infallible. r=smaug
Jim Blandy <jimb@mozilla.com> - Wed, 17 Oct 2018 20:41:59 +0000 - rev 490171
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499473: Simplify TabGroup a bit, now that ThrottledEventQueue::Create is infallible. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8915
7b427b1667424b7d673dafc10629590a840ea688: Bug 1498860 - Add window.screenLeft / window.screenTop as aliases of screenX / screenY. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Oct 2018 02:20:15 +0000 - rev 489956
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498860 - Add window.screenLeft / window.screenTop as aliases of screenX / screenY. r=smaug Tests are at https://github.com/web-platform-tests/wpt/pull/13543. Spec is waiting on those, but this matches all other browsers. Differential Revision: https://phabricator.services.mozilla.com/D8917
f2e35ed6a6928b35e085462dc4268fd86f00fdb9: Bug 1497601 - Use a xul:description instead of a xul:label for tooltips;r=smaug
Brian Grinstead <bgrinstead@mozilla.com> - Tue, 16 Oct 2018 13:54:07 +0000 - rev 489803
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497601 - Use a xul:description instead of a xul:label for tooltips;r=smaug We'd like to be able to implement label features with a Custom Element, and we don't want to run CE reactions inside of NAC. Differential Revision: https://phabricator.services.mozilla.com/D8241
9508a03be7c2ed82678cf62b0ba5356826738e9b: Bug 1258143 - Remove LocalMediaStream. r=jib,smaug
Andreas Pehrson <apehrson@mozilla.com> - Mon, 15 Oct 2018 08:17:07 +0000 - rev 489649
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1258143 - Remove LocalMediaStream. r=jib,smaug Differential Revision: https://phabricator.services.mozilla.com/D8064
b32ff85f22247b5f7512e672e2d77d41d38a397a: Bug 1435789: implement relayProtocol for localcandidate stats r=smaug,ng
Philipp Hancke <fippo@appear.in> - Sun, 07 Oct 2018 07:42:48 +0000 - rev 489499
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1435789: implement relayProtocol for localcandidate stats r=smaug,ng relayProtocol is the standardized variant of mozLocalTransport. Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-relayprotocol IDL: https://w3c.github.io/webrtc-stats/#icecandidate-dict* Differential Revision: https://phabricator.services.mozilla.com/D3428
905c871bcf0366ad037e4409ce21afe2a2fba440: Bug 1258143 - Remove LocalMediaStream. r=jib,smaug
Andreas Pehrson <apehrson@mozilla.com> - Thu, 11 Oct 2018 12:43:34 +0000 - rev 489317
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1258143 - Remove LocalMediaStream. r=jib,smaug Differential Revision: https://phabricator.services.mozilla.com/D8064
bb32faa290f0b8871c7c72798dc1876b01e48a31: Bug 1377146 - Remove AudioStreamTrack and VideoStreamTrack from js. r=jib,smaug
Andreas Pehrson <apehrson@mozilla.com> - Thu, 11 Oct 2018 15:36:11 +0000 - rev 489201
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1377146 - Remove AudioStreamTrack and VideoStreamTrack from js. r=jib,smaug Differential Revision: https://phabricator.services.mozilla.com/D8063
ccdfe4ca1f881fea6751d8addbd6466d106ed3dd: Bug 1498445 - Stop creating a style attribute for invalid property values. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Oct 2018 09:07:00 +0000 - rev 489196
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1498445 - Stop creating a style attribute for invalid property values. r=smaug This matches all other browsers, and the spec. Added an explicit test for this, and a test that tests what cssstyledeclaration-mutationrecord-002.html wanted to test, which is that changing an existing declaration doesn't generate a mutation record. Differential Revision: https://phabricator.services.mozilla.com/D8500
8aef0f43b2d891668022474f0af701980de6e39d: Bug 934425 - Add SinkId in webidl for HTMLMediaElement. r=smaug
Alex Chronopoulos <achronop@gmail.com> - Fri, 12 Oct 2018 08:44:55 +0000 - rev 489186
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 934425 - Add SinkId in webidl for HTMLMediaElement. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D5873
858b41d7b9edd2c999ffc616ad76a0e96a9b97ca: Bug 1484849 - history.go(0) should reload the current page and not involve the entire session history r=smaug
Perry Jiang <perry@mozilla.com> - Thu, 11 Oct 2018 15:43:25 +0000 - rev 489122
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1484849 - history.go(0) should reload the current page and not involve the entire session history r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8322
cecf523a14b1c3d211e04d6b6d1a67633d2d1512: Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug
Yaron Tausky <ytausky@mozilla.com> - Thu, 11 Oct 2018 12:37:37 +0000 - rev 489057
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug Differential Revision: https://phabricator.services.mozilla.com/D4237
55588bdd2ee8f5bcd66c6af0b340d5b02bf0411e: Bug 1497831 - Use nsTArray instead of nsIArray for nsIFormatConverter. r=smaug
Tom Schuster <evilpies@gmail.com> - Wed, 10 Oct 2018 20:26:06 +0000 - rev 488977
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497831 - Use nsTArray instead of nsIArray for nsIFormatConverter. r=smaug Depends on D8194 Differential Revision: https://phabricator.services.mozilla.com/D8195
2852663b840e9a4348130dcbf8efdd494f738a76: Bug 1497831 - Use nsTArray instead of nsIArray for nsITransferable. r=smaug
Tom Schuster <evilpies@gmail.com> - Wed, 10 Oct 2018 20:25:54 +0000 - rev 488976
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497831 - Use nsTArray instead of nsIArray for nsITransferable. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8194
2c01f22661fabd177c81e658e93319bc4faba8df: Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug
Yaron Tausky <ytausky@mozilla.com> - Wed, 10 Oct 2018 13:55:23 +0000 - rev 488888
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1263734: Implement ServiceWorkerContainer.startMessages() r=asuth,smaug Differential Revision: https://phabricator.services.mozilla.com/D4237
d56cf859abf7a9c638c7b436a6872a724574905f: Bug 1363508 - Part 3: Spoofing navigator.maxTouchPoints into 0 if fingerprinting resistance is enabled r=arthuredelstein,masayuki,smaug
Tim Huang <tihuang@mozilla.com> - Tue, 09 Oct 2018 11:50:03 +0000 - rev 488882
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1363508 - Part 3: Spoofing navigator.maxTouchPoints into 0 if fingerprinting resistance is enabled r=arthuredelstein,masayuki,smaug The maxTouchPoints is going to review the detail of users' hardware. So, we will spoof it into 0 if fingerprinting resistance is on. Depends on D6004 Differential Revision: https://phabricator.services.mozilla.com/D6005
3e9933f36e458a44212e316b554fbaaaacbfd72b: Bug 1363508 - Part 1: Spoofing pen/touch pointer events into mouse pointer events when fingerprinting resistance is on r=arthuredelstein,masayuki,smaug
Tim Huang <tihuang@mozilla.com> - Tue, 09 Oct 2018 11:55:43 +0000 - rev 488880
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1363508 - Part 1: Spoofing pen/touch pointer events into mouse pointer events when fingerprinting resistance is on r=arthuredelstein,masayuki,smaug The pointerType field in the pointer event will reveal the details of users' hardware; this is a fingerprinting vector. So, we would spoof all types of pointer events into mouse type pointer events for protecting users from browser fingerprinting when fingerprinting resistance is on. In this patch, we would spoof the pointerType as well as other fields that mouse pointer events don't support, like pressure, tiltX/Y and so on when fingerprinting resistance is on. Differential Revision: https://phabricator.services.mozilla.com/D6003
9e84f8d5b086020dba510678222a6c3ec568edf2: Bug 1461708 - part 8: Make EventStateManager handle middle click paste as a default action of mouseup event r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:06:17 +0000 - rev 488852
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 8: Make EventStateManager handle middle click paste as a default action of mouseup event r=smaug This patch makes EventStateManager handle middle click paste as a default action. Unfortunately, we cannot remove the call of HandleMiddleClickPaste() in EditorEventListener because it's important to consume middle click event before any elements in the editor. For example, if clicked HTMLEditor has non-editable <a href> element, middle click event needs to be handled by the editor rather than contentAreaUtils which handles click events of <a href> elements. The cause of this kind of issues is, any click event handlers which handle non-primary button events still listen to "click" events. Therefore, this patch makes HandleMiddleClickPaste() do nothing if the mouseup event is fired on an editor. Differential Revision: https://phabricator.services.mozilla.com/D7855
0f2549de4e47ed8570b1e0a3f368bc82c17895b9: Bug 1461708 - part 7: Make EventStateManager::HandleMiddleClickPaste() dispatch ePaste event by itself r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:05:39 +0000 - rev 488851
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 7: Make EventStateManager::HandleMiddleClickPaste() dispatch ePaste event by itself r=smaug This is preparation of the last patch. Even if no editor is clicked with middle button, we need to do: - collapse Selection at the clicked point. - dispatch "paste" event. Therefore, HandleMiddleClickPaste() should dispatch ePaste event by itself and each editor methods should have a bool argument which the caller wants ePaste event automatically. Note that Chromium dispatches "paste" event and pastes clipboard content into clicked editor even if preceding "auxclick" event is consumed. However, our traditional behavior is not dispatching "paste" event nor pasting clipboard content. Unless Chromium developer keeps their odd behavior, we should keep our traditional behavior since our behavior is conforming to DOM event model. Differential Revision: https://phabricator.services.mozilla.com/D7854
95d15775e123f881124b1b0b239b2dd8f837bd0e: Bug 1461708 - part 5: Move EditorEventListener::HandleMiddleClickPaste() to EventStateManager r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:04:17 +0000 - rev 488849
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 5: Move EditorEventListener::HandleMiddleClickPaste() to EventStateManager r=smaug EventStateManager needs to handle middle click paste without editor. Therefore, the handler should be in EventStateManager. Differential Revision: https://phabricator.services.mozilla.com/D7852
219527f4c312eb25ee1103ac3bdfa38f87539e02: Bug 1461708 - part 4: Move implementation of UIEvent::GetRangeParent() and UIEvent::RangeOffset() to nsLayoutUtils r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:03:34 +0000 - rev 488848
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 4: Move implementation of UIEvent::GetRangeParent() and UIEvent::RangeOffset() to nsLayoutUtils r=smaug We need to move EditorEventListener::HandleMiddleClickPaste() into EventStateManager to handle middle click paste after all click events are dispatched. This is preparation of the change. HandleMiddleClickPaste() uses UIEvent::GetRangeParent() and UIEvent::RangeOffset() to collapse Selection at clicked point. However, EventStateManager cannot access them since EventStateManager can handle it with WidgetMouseEvent. Fortunately, only WidgetMouseEvent is necessary for implementing them. Therefore, we can move the implementation into nsLayoutUtils and merge them. Differential Revision: https://phabricator.services.mozilla.com/D7851
d61721276fcc478dd8f672dcd63749e775283d32: Bug 1461708 - part 3: EventStateManager::InitAndDispatchClickEvent() shouldn't overwrite nsEventStatus with nsEventStatus_eIgnore r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:02:50 +0000 - rev 488847
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 3: EventStateManager::InitAndDispatchClickEvent() shouldn't overwrite nsEventStatus with nsEventStatus_eIgnore r=smaug EventStateManager::InitAndDispatchClickEvent() sends given nsEventStatus to nsIPresShell::HandleEventWithTarget(). Then, it sends the status to EventStateManager::PreHandleEvent() before dispatching the event. At this time, EventStateManager::PreHandleEvent() resets the state to nsEventStatus_eIgnore. Therefore, for example, if eMouseClick event is consumed but eMouseAuxClick is ignored, the event status result is nsEventStatus_eIgnore. So, neither DispatchClickEvents() nor PostMouseUpEventHandler() cannot check whether at least one click event is consumed. This patch makes EventStateManager::InitAndDispatchClickEvent() sends local variable of nsEventStatus to nsIPresShell::HandleEventWithTarget(). Then, merge the result with current status. If we'd change nsEventStatus to enum class, we could make this change as custom "operator|=" or something. Differential Revision: https://phabricator.services.mozilla.com/D7850
588859b2d5ccac8b371eed74dc751b2ec0b834cc: Bug 1461708 - part 2: Split EventStateManager::CheckForAndDispatchClick() r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:01:57 +0000 - rev 488846
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 2: Split EventStateManager::CheckForAndDispatchClick() r=smaug This patch splits EventStateManager::CheckForAndDispatchClick(). One is for handling default action of eMouseUp, the other is for dispatching click events. This makes it easier to add other default actions after dispatching click events. Differential Revision: https://phabricator.services.mozilla.com/D7849
973ea169460670805ba5dbe8bc0051313a1a2979: Bug 1461708 - part 1: Clean up EventStateManager::CheckForAndDispatchClick() with early-return style r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:01:18 +0000 - rev 488845
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 1: Clean up EventStateManager::CheckForAndDispatchClick() with early-return style r=smaug Differential Revision: https://phabricator.services.mozilla.com/D7848
18d88d24495acae45a381f8bf95c3ab86fe800ec: Bug 1491403 - Part 3: Propagate the user input event handling state to the promise resolve handlers in case the promise creator requests it r=smaug,arai,baku
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 09 Oct 2018 21:42:22 +0000 - rev 488749
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491403 - Part 3: Propagate the user input event handling state to the promise resolve handlers in case the promise creator requests it r=smaug,arai,baku Depends on D7004 Differential Revision: https://phabricator.services.mozilla.com/D7005
ecce651fad51ab1a5718b6e6f208093ec075612d: Bug 1473108 - Part 2: Make PresShell not point to unbound NAC in event content stack; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 09 Oct 2018 12:16:15 +0000 - rev 488598
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1473108 - Part 2: Make PresShell not point to unbound NAC in event content stack; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8042
b38223cb4fd1a8084343a76cd5c4cf02c6c35086: Bug 1473108 - Part 1: Devirtualize nsIPresShell::GetCurrentEventFrame/GetEventTargetContent; r=smaug
Edgar Chen <echen@mozilla.com> - Tue, 09 Oct 2018 09:47:58 +0000 - rev 488597
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1473108 - Part 1: Devirtualize nsIPresShell::GetCurrentEventFrame/GetEventTargetContent; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D8041
550aa5330baf471ec1b9c6a05f4a598bec88ebf6: Bug 1497546 - Disable new behavior of keyCode and charCode of keypress event r=smaug a=Aryx
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 09 Oct 2018 21:04:37 +0300 - rev 488579
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497546 - Disable new behavior of keyCode and charCode of keypress event r=smaug a=Aryx Summary: The fix of bug 1479964 breaks some web apps using Google Closure including Google's apps. So, for Nightly testers, we should disable the new behavior until Google Closure fixes it or we can disable the new behavior per web apps. Reviewers: smaug Reviewed By: smaug Bug #: 1497546 Differential Revision: https://phabricator.services.mozilla.com/D8090
a9db3033d9cbf95c87e8c26c361ffe558ef6e3a9: Bug 1479964 - Set KeyboardEvent.keyCode and KeyboardEvent.charCode to same value if the event is "keypress" event r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 09 Oct 2018 04:43:37 +0000 - rev 488466
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1479964 - Set KeyboardEvent.keyCode and KeyboardEvent.charCode to same value if the event is "keypress" event r=smaug Chrome sets both KeyboardEvent.keyCode and KeyboardEvent.charCode of "keypress" event to same value. On the other hand, our traditional behavior is, sets one of them to 0. Therefore, we need to set keyCode value to charCode value if the keypress event is caused by a non-function key, i.e., it may be a printable key with specific modifier state and/or different keyboard layout for compatibility with Chrome. Similarly, we need to set charCode value to keyCode value if the keypress event is caused by a function key which is not mapped to producing a character. Note that this hack is for compatibility with Chrome. So, for now, it's enough to change the behavior only for "keypress" event handlers in web content. If we completely change the behavior, we need to fix a lot of default handlers and mochitests too. However, it's really difficult because default handlers check whether keypress events are printable or not with following code: > if (event.charCode && > !event.altKey && !event.ctrlKey && !event.metaKey) { or > if (!event.keyCode && > !event.altKey && !event.ctrlKey && !event.metaKey) { So, until we stop dispatching "keypress" events for non-printable keys, we need complicated check in each of them. And also note that this patch changes the behavior of KeyboardEvent::KeyCode() when spoofing is enabled and the instance is initialized by initKeyEvent() or initKeyboardEvent(). That was changed by bug 1222285 unexpectedly and keeping the behavior makes patched code really ugly. Therefore, this takes back the old behavior even if spoofing is enabled. Differential Revision: https://phabricator.services.mozilla.com/D7974
70f63648a0f6cf738d5555eb347986d7323ef16e: Bug 1497126 - Fix WPTs for 1 level of recursion when loading nested iframes with same URL, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 08 Oct 2018 16:04:57 +0200 - rev 488282
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497126 - Fix WPTs for 1 level of recursion when loading nested iframes with same URL, r=smaug
dc46a5f43a47d173b7c29226aab8bc590701bc99: Bug 1497126 - Allow 1 level of recursion when loading nested iframes with same URL, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 08 Oct 2018 16:04:56 +0200 - rev 488281
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497126 - Allow 1 level of recursion when loading nested iframes with same URL, r=smaug
15fe5851f113defcc86285e94ed79687031a5d56: Bug 1310193 - Remove wrapping of nsISupports as nsISupportsInterfacePointer in transferables. r=smaug
Neil Deakin <enndeakin@gmail.com> - Sun, 07 Oct 2018 16:33:07 +0200 - rev 488274
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1310193 - Remove wrapping of nsISupports as nsISupportsInterfacePointer in transferables. r=smaug
fd12d054f76cfe041be35fb2f50322d5378edc8a: Bug 1495364 - FeaturePolicy: geolocation, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 06 Oct 2018 13:10:30 +0200 - rev 488232
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495364 - FeaturePolicy: geolocation, r=smaug
e6cfd555f0d1d013d3c9c5f519f96889c2994609: Bug 1290420 Part 4: Make the PresShell create a MobileViewportManager on demand. r=botond,smaug
Brad Werth <bwerth@mozilla.com> - Thu, 04 Oct 2018 03:28:40 +0000 - rev 488025
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1290420 Part 4: Make the PresShell create a MobileViewportManager on demand. r=botond,smaug Depends on D3376 Differential Revision: https://phabricator.services.mozilla.com/D3377
ec06f75313deec2dd3acf1d29b9cb3661a9bcc16: Bug 1290420 Part 1: Add a docshell flag for overriding meta viewport handling. r=smaug
Botond Ballo <botond@mozilla.com>, Brad Werth <bwerth@mozilla.com> - Thu, 04 Oct 2018 00:19:40 +0000 - rev 488022
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1290420 Part 1: Add a docshell flag for overriding meta viewport handling. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D3373
de02c78c82b754299fefda4d10c9f137cabeca95: Bug 1495272 Part 2 - Use DeferredFinalize in SweepTearOffs when recording/replaying, r=smaug.
Brian Hackett <bhackett1024@gmail.com> - Wed, 03 Oct 2018 15:03:37 -1000 - rev 487997
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495272 Part 2 - Use DeferredFinalize in SweepTearOffs when recording/replaying, r=smaug.
1873f93e51a63549336cce3df1c850e743352a19: Bug 1496284 - Drop Etherpad instances from "dom.keyboardevent.keypress.hack.dispatch_non_printable_keys" r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 04 Oct 2018 09:19:49 +0000 - rev 487984
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496284 - Drop Etherpad instances from "dom.keyboardevent.keypress.hack.dispatch_non_printable_keys" r=smaug Etherpad fixed the bug with new Gecko behavior and has already released it in this August. So, even if some instances still use older versions, we can request them to update the version. This patch removes all Etherpad instances we know from the blacklist of strict keypress dispatching. So, Nightly testers can find old instances easier. Differential Revision: https://phabricator.services.mozilla.com/D7694
cafd172dc48a1d45bedad15185c720f0103bfec3: Bug 1495362 - FeaturePolicy: fullscreen, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 04 Oct 2018 14:34:37 +0200 - rev 487911
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495362 - FeaturePolicy: fullscreen, r=smaug