searching for reviewer(peterv)
2a0dfe99894b5e2173bd37ea01a1c7292b11e886: Bug 1498222 - Add BrowsingContext.docShell webidl. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 18 Oct 2018 06:52:30 +0000 - rev 490673
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498222 - Add BrowsingContext.docShell webidl. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D8381
26d29ab41cdf753774f2d7ccdc0a7b460a5528cc: Bug 1497110 - remove currencySystem from PaymentRequest. r=edenchuang, peterv
Marcos Cáceres <mcaceres@mozilla.com> - Sun, 07 Oct 2018 21:00:00 +0300 - rev 489774
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497110 - remove currencySystem from PaymentRequest. r=edenchuang, peterv
9d7540135cac5a0adc6c9ab34f7f2851ca3b9b1c: Bug 1492823 - Ensure user input suppression works correctly even after document.open. r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 09 Oct 2018 08:56:01 -0400 - rev 488548
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492823 - Ensure user input suppression works correctly even after document.open. r=peterv
892a0ef879980cd26764f7a6c96501356c35ea14: Bug 1491122 - Fix GetCCParticipant comment r=peterv
Andrew McCreight <continuation@gmail.com> - Fri, 28 Sep 2018 09:28:02 +0000 - rev 487131
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491122 - Fix GetCCParticipant comment r=peterv Differential Revision: https://phabricator.services.mozilla.com/D5889
1de6dfd1e6ed1e54e440f1d9bf18ffc579b76a3b: Bug 1480113 - Split parent process specific parts out of BrowsingContext r=peterv
Andreas Farre <farre@mozilla.com> - Fri, 14 Sep 2018 14:57:18 +0000 - rev 485063
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1480113 - Split parent process specific parts out of BrowsingContext r=peterv Create ChromeBrowsingContext and move parent process specific parts from BrowsingContext there. After that make sure that all BrowsingContexts created in the parent process is actually ChromeBrowsingContexts and all BrowsingContexts in the child processes are BrowsingContexts. Differential Revision: https://phabricator.services.mozilla.com/D5419
fa0aa4da4ea69bd615406e1ff2cdf03bf01bffa6: Bug 1490503 - Mark more XPConnect classes builtinclass r=peterv
Andrew McCreight <continuation@gmail.com> - Fri, 14 Sep 2018 17:52:36 +0000 - rev 484784
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490503 - Mark more XPConnect classes builtinclass r=peterv Also, make nsIXPCWrappedJSObjectGetter not scriptable to save a tiny amount of binary size. Differential Revision: https://phabricator.services.mozilla.com/D5613
ea41800d0ae0aa96db5810ec6ba52acfb0f12802: Bug 1489098 - Remove useless use of PromiseFlatString. r=peterv
Henri Sivonen <hsivonen@hsivonen.fi> - Tue, 11 Sep 2018 17:17:05 +0000 - rev 484134
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489098 - Remove useless use of PromiseFlatString. r=peterv MozReview-Commit-ID: 10JE4PRp8i0 Differential Revision: https://phabricator.services.mozilla.com/D5237
b5c403ab80f96de0834214cab00996b617df18b1: Bug 1481238 - Create WebIDL interface for BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Wed, 29 Aug 2018 05:00:00 +0300 - rev 482184
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1481238 - Create WebIDL interface for BrowsingContext. r=peterv Expose Chrome only WebIDL to interface with BrowsingContext from script. The API consists of parent, firstChild and nextSibling attributes for BrowsingContext, and the browsingContext attribute for Window.
612ca23ddb81bfa32c2e53484f16e0076fe85841: Bug 1481238 - Add tests for BrowsingContext. r=peterv
Andreas Farre <farre@mozilla.com> - Tue, 28 Aug 2018 02:41:00 +0300 - rev 482183
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1481238 - Add tests for BrowsingContext. r=peterv
ed3c662bb21dd708601519540c99e939abb12cff: Bug 1469019 - Object.fromEntries. r=evilpie, r=peterv
Jason Orendorff <jorendorff@mozilla.com> - Tue, 14 Aug 2018 13:25:30 -0500 - rev 480753
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1469019 - Object.fromEntries. r=evilpie, r=peterv
76659fa6e0e0c22bf3f0fda416dd3fec601e9ae8: Bug 1483487 - Add asertions around creating and retrieving DOM proxy expando objects r=peterv
Jon Coppeard <jcoppeard@mozilla.com> - Mon, 20 Aug 2018 10:12:35 +0100 - rev 480629
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1483487 - Add asertions around creating and retrieving DOM proxy expando objects r=peterv
425a0334587be1a6ecccaa04789eea86d1f8d605: Bug 1393306 - Add deprecation warning in 57 for removal of stat.isRemote in 58. r=ng,peterv
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 01 Sep 2017 22:35:56 -0400 - rev 478457
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1393306 - Add deprecation warning in 57 for removal of stat.isRemote in 58. r=ng,peterv MozReview-Commit-ID: 7wKBg3KQxjo
10b4f3fa453f53e8ed30a573caa7e1c28d7e224e: Bug 1445659 - Make BrowsingContext interact with bfcache. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 28 Jun 2018 05:40:00 +0300 - rev 477050
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1445659 - Make BrowsingContext interact with bfcache. r=peterv Have BrowsingContext keep its own cache to enable caching of BrowsingContexts, especially in the parent process. This isn't really optimal, since it effectively duplicates the cache in the child process. BFcache keeps a list of strong pointers to the list of cached nsDocShells, where each nsDocShell in turn keeps a reciprocated strong pointer to its BrowsingContext, which in turn is held in the BrowsingContexts list of cached contexts. Ideally these caches should be merged.
c70a61e3f34ace5748837cbf6d174587093c0fd9: Bug 1445659 - Create basic Browsing Context in Content Parent and Child. r=peterv
Andreas Farre <farre@mozilla.com> - Thu, 26 Jul 2018 10:31:00 +0300 - rev 477049
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1445659 - Create basic Browsing Context in Content Parent and Child. r=peterv Add BrowsingContext to allow the tree structure of docshells to exist in several processes simultaneously. This is a first step towards allowing a tree structure preserving separation of docshells across processes.
3f78090c350cef688152174293308a31879040c8: Bug 1382035. Treat Promise return values like undefined for javascript: urls. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 23 Jul 2018 16:18:33 -0400 - rev 476076
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1382035. Treat Promise return values like undefined for javascript: urls. r=peterv
13efb4f58614a7bb20ca3149b0ca50cf92c7a13d: Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Sat, 16 Jun 2018 17:21:46 +0300 - rev 474585
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv
2379329b14139a9f4484c9eab1c94f649bf1869b: Bug 1475003, don't notify DOM of SMIL changes, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 12 Jul 2018 13:04:26 +0300 - rev 474567
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1475003, don't notify DOM of SMIL changes, r=peterv
16581950a2b9fcbce35cf9118e7198745fade2eb: Bug 1472618 - Make navigator.platform return "Win32", even on Win64 OS. r=peterv
Chris Peterson <cpeterson@mozilla.com> - Mon, 02 Jul 2018 11:02:23 -0700 - rev 474406
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1472618 - Make navigator.platform return "Win32", even on Win64 OS. r=peterv navigator.platform returns "Win64" in 64-bit Firefox and IE, but "Win32" in 64-bit Chrome and Edge. "Win32" appears to be the de facto platform value for Windows. This change doesn't hide the OS architecture from web content because navigator.userAgent still mentions "Win64; x64" in 64-bit Firefox, Chrome, Edge, and IE. MozReview-Commit-ID: CplYnGDQgTe
e8c0ffefb34fdd3e24161152af148553aa58e624: Bug 1428246 - The attributeChangedCallback is fired twice for the *first* style attribute change, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 26 Jun 2018 12:54:00 +0300 - rev 471931
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1428246 - The attributeChangedCallback is fired twice for the *first* style attribute change, r=peterv The idea with this patch is that style code will first call InlineStyleDeclarationWillChange before style declaration has changed, and SetInlineStyleDeclaration once it has changed. In order to be able to report old attribute value, InlineStyleDeclarationWillChange reads the value and also calls AttributeWillChange (so that DOMMutationObserser can grab the old value). Later SetInlineStyleDeclaration passes the old value to SetAttrAndNotify so that mutation events and attributeChanged callbacks are handled correctly. Because of performance, declaration can't be cloned for reading the old value. And that is why the recently-added callback is used to detect when declaration is about to change (bug 1466963 and followup bug 1468665). To keep the expected existing behavior, even if declaration isn't changed, but just a new declaration was created (since there wasn't any), we need to still run all these willchange/set calls. That is when the code has 'if (created)' checks. Since there are several declaration implementation and only nsDOMCSSAttributeDeclaration needs the about-to-change callback, GetPropertyChangeClosure is the one to initialize the callback closure, and the struct which is then passes as data to the closure. Apparently we lost mutation event testing on style attribute when the pref was added, so test_style_attr_listener.html is modified to test both pref values.
f18328bef6bb069e0b651c913281537b219b1dbd: Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 14:25:49 +0300 - rev 471490
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
32d9328cab02821a252de5a23f2f6de090d9e083: Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 14:25:49 +0300 - rev 471487
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1453795 - XPConnect - Initialize member fields in classes/ structures. r=peterv
668a0db86e1e596a946f7eb7bf90fa1341465efb: Bug 1453795 - DOM/XSLT - Initialize member fields in classes/ structures. r=peterv
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 15 Jun 2018 13:59:04 +0300 - rev 471486
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1453795 - DOM/XSLT - Initialize member fields in classes/ structures. r=peterv
292092eabd6fffbec0e7c82bac6d4c03e30edf23: Bug 1466221. Implement ToJSValue variants for non-refcounted (so owned) DOM objects. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Sat, 09 Jun 2018 01:03:15 -0400 - rev 470263
Push 196 by fmarier@mozilla.com at Mon, 18 Jun 2018 22:44:32 +0000
Bug 1466221. Implement ToJSValue variants for non-refcounted (so owned) DOM objects. r=peterv
4d39fdf74ae76b02509a190b7081eecf49e25efe: bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv
Karl Tomlinson <karlt+@karlt.net> - Thu, 10 May 2018 17:04:12 +1200 - rev 469820
Push 190 by fmarier@mozilla.com at Thu, 07 Jun 2018 20:18:35 +0000
bug 1442776 make CycleCollectedJSContext accessible from JSContext private r=peterv Inheriting PerThreadAtomCache on CycleCollectedJSContext permits use of static_cast, avoiding one level of indirection compared to adding a CycleCollectedJSContext* to PerThreadAtomCache. PerThreadAtomCache is over 18kB, and so WorkerJSContext and WorkletJSContext are moved from the stack to the heap. MozReview-Commit-ID: 6jdJeZcviK4
c116c385bb02387c9b2b8e2ff1780ee1754b6be7: Bug 1461321 - input.list should work in shadow DOM, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 24 May 2018 22:46:11 +0300 - rev 467904
Push 182 by fmarier@mozilla.com at Wed, 30 May 2018 01:07:46 +0000
Bug 1461321 - input.list should work in shadow DOM, r=peterv
29b727bc2caae70606356c6627cfd0bc5dde033f: Bug 1459309 - currentScript should be null when evaluating scripts from shadow DOM, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 11 May 2018 20:24:50 +0300 - rev 467626
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1459309 - currentScript should be null when evaluating scripts from shadow DOM, r=peterv
69256fdf60d6e4a24c5f82bb60639f1c7f37af33: Bug 1404864 - ensure HTMLInputElement.form works per spec in Shadow DOM, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 18 May 2018 20:02:14 +0300 - rev 467061
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1404864 - ensure HTMLInputElement.form works per spec in Shadow DOM, r=peterv
dbb42b18303aaad9d8985568247b85f1bbb4b7cb: Bug 1455802. Get rid of web-visible XMLStyleSheetProcessingInstruction. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 14 May 2018 18:54:16 -0400 - rev 466398
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1455802. Get rid of web-visible XMLStyleSheetProcessingInstruction. r=peterv MozReview-Commit-ID: GBumpNuvzZf
cc0781a786348335c8eba7e2e979239ffb9ac577: Bug 1460435 - Move ID observing from Document to DocumentOrShadowRoot, r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Mon, 14 May 2018 21:39:53 +0300 - rev 466323
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1460435 - Move ID observing from Document to DocumentOrShadowRoot, r=peterv
10fdb852c81a789846a213224e9751ceb578d44a: Bug 1460334 - Fix crash caused when attempting to migrate <deck> from a XBL binding to a Custom Element. r=peterv
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 10 May 2018 14:08:00 -0400 - rev 466318
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1460334 - Fix crash caused when attempting to migrate <deck> from a XBL binding to a Custom Element. r=peterv
784fa857364def613c4b3cd6b3ab62113c256c72: Bug 1455796 - Make browser_messagemanager_loadprocessscript.js aware of OOP WebExtensions. r=peterv, a=test-only
Dennis Schubert <dschubert@mozilla.com> - Tue, 08 May 2018 15:18:08 +0200 - rev 465717
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1455796 - Make browser_messagemanager_loadprocessscript.js aware of OOP WebExtensions. r=peterv, a=test-only MozReview-Commit-ID: KENm9TmElUU
1a9006749da6f47a55d7f0eef667f9bdd2e5acd7: Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
Eric Rahm <erahm@mozilla.com> - Tue, 17 Apr 2018 11:22:04 -0700 - rev 465514
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
0edb8dca7087c69848aa6a6a05b315eb3a4c2d60: Bug 1453339 - Make it harder to mess up Promise::All. r=peterv, a=RyanVM
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 12 Apr 2018 23:26:44 -0400 - rev 465264
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1453339 - Make it harder to mess up Promise::All. r=peterv, a=RyanVM MozReview-Commit-ID: UO4wssYHj7
eb825e4db72f892b87e53fec8619d7643a17a990: Bug 1453339 - Make it harder to mess up Promise::All. r=peterv, a=abillings
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 13 Apr 2018 19:31:42 -0400 - rev 465259
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1453339 - Make it harder to mess up Promise::All. r=peterv, a=abillings MozReview-Commit-ID: UO4wssYHj7
88bd9da5a3964e897a9933cf70e827f0ab52f83d: Bug 1414452 - Clear dirAutoSetBy properties iteratively. r=peterv, a=abillings
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 28 Nov 2017 16:17:17 +0200 - rev 462960
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1414452 - Clear dirAutoSetBy properties iteratively. r=peterv, a=abillings
ec8faf9d7f3e89c6b390019c0a5433c51b7c116c: Bug 1412741 - Back out the fix for bug 1381408, because that change doesn't look like it's web-compatible. r=peterv, a=ritu
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 02 Nov 2017 13:02:55 -0400 - rev 462614
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1412741 - Back out the fix for bug 1381408, because that change doesn't look like it's web-compatible. r=peterv, a=ritu MozReview-Commit-ID: LSYYAt0bAkT
e4cfb8924eea1c40da0a8b3a8974edacd773616a: Bug 1455796 - Make browser_messagemanager_loadprocessscript.js aware of OOP WebExtensions r=peterv
Dennis Schubert <dschubert@mozilla.com> - Tue, 08 May 2018 15:18:08 +0200 - rev 462437
Push 166 by fmarier@mozilla.com at Thu, 10 May 2018 00:43:18 +0000
Bug 1455796 - Make browser_messagemanager_loadprocessscript.js aware of OOP WebExtensions r=peterv MozReview-Commit-ID: KENm9TmElUU
f3ad04730dd303ef877104fd534b144f1d23a49f: Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
Eric Rahm <erahm@mozilla.com> - Tue, 17 Apr 2018 11:22:04 -0700 - rev 460410
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv a=abillings
e47d7dbc1cd289086eb63c24cce1600c2b5329c7: Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv
Eric Rahm <erahm@mozilla.com> - Tue, 17 Apr 2018 11:22:04 -0700 - rev 460311
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1451908 - Check for infinite value in txFormatNumberFunctionCall. r=peterv
438494d2d17bec92e4f4e38661a85b60680ab087: Bug 1453339. Make it harder to mess up Promise::All. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Fri, 13 Apr 2018 19:31:42 -0400 - rev 458793
Push 159 by fmarier@mozilla.com at Thu, 19 Apr 2018 00:14:50 +0000
Bug 1453339. Make it harder to mess up Promise::All. r=peterv MozReview-Commit-ID: UO4wssYHj7
91406356569ce2b32ed48486cc516f490eec1ab8: Bug 1453339 - Make it harder to mess up Promise::All. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 12 Apr 2018 17:03:49 -0400 - rev 458317
Push 159 by fmarier@mozilla.com at Thu, 19 Apr 2018 00:14:50 +0000
Bug 1453339 - Make it harder to mess up Promise::All. r=peterv MozReview-Commit-ID: UO4wssYHj7
7c5124a18c41675786081ae51bfd65c64eede342: Bug 1445912 - Remove PopupBoxObject::enableKeyboardNavigator/enableRollup/setConsumeRollupEvent in favor of DOM attributes. r=enn,peterv
Dão Gottwald <dao@mozilla.com> - Thu, 12 Apr 2018 16:55:50 +0200 - rev 458109
Push 159 by fmarier@mozilla.com at Thu, 19 Apr 2018 00:14:50 +0000
Bug 1445912 - Remove PopupBoxObject::enableKeyboardNavigator/enableRollup/setConsumeRollupEvent in favor of DOM attributes. r=enn,peterv
7c26bbdac00f8ef5866b673bfc59fb452f8fb549: Bug 1445710. Reduce codesize a bit by removing DOM DefineInterfaceObject methods. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 15:32:19 -0400 - rev 456683
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1445710. Reduce codesize a bit by removing DOM DefineInterfaceObject methods. r=peterv MozReview-Commit-ID: 6JRYz4FV9vP
5cc5f9c978a3f1a8c6e0083e8024c216a11805bd: Bug 1447454. Stop allowing implicit downcasts in StrongOrRawPtr. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 15:32:19 -0400 - rev 456680
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1447454. Stop allowing implicit downcasts in StrongOrRawPtr. r=peterv MozReview-Commit-ID: BSXp3ThY1dC
7271d56c190dc07d422e1184ab33833fbdfdf206: Bug 1085062 followup. Actually address the review comments. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 14:43:41 -0400 - rev 456672
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1085062 followup. Actually address the review comments. r=peterv
6d94022fef7a99bc7d246ee561ed6443836b1244: Bug 1085062. Remove hasXPConnectImpls support from bindings codegen. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 14:39:52 -0400 - rev 456670
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1085062. Remove hasXPConnectImpls support from bindings codegen. r=peterv
a9a254ed2869dad2802a6658f73a941438ff9cc2: Bug 1085061. Remove the hasXPConnectImpls flag from EventTarget. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Wed, 04 Apr 2018 14:39:48 -0400 - rev 456669
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1085061. Remove the hasXPConnectImpls flag from EventTarget. r=peterv This is the behavior change. The cleanup will be in bug 1085062.
d6ed830430a75fceb4303ad4db9ed93d9b12a2d9: Bug 1448588 - Assume contiguous XPCOM strings in txDouble. r=peterv.
Henri Sivonen <hsivonen@hsivonen.fi> - Sat, 24 Mar 2018 21:24:25 +0200 - rev 455328
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1448588 - Assume contiguous XPCOM strings in txDouble. r=peterv. MozReview-Commit-ID: 9gDx13PNFWr
9ed0718ede32ea01c67a47b8f143152e860a8be2: Bug 1446246 part 2. Combine HTMLConstructor and CreateXULOrHTMLElement into a single function. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 15:49:02 -0400 - rev 455180
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1446246 part 2. Combine HTMLConstructor and CreateXULOrHTMLElement into a single function. r=peterv This fixes an observable bug we had due to doing the steps in a different order from the spec: the 'prototype' get can have side-effects so needs to happen after some of the other sanity checks. MozReview-Commit-ID: 83zNhqfqFRu
b470762b46768b7867824cda8e0190037913b3fe: Bug 1446246 part 1. Use a single handwritten HTMLConstructor implementation, instead of code-generating lots of very similar implementations. r=peterv
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 27 Mar 2018 15:49:02 -0400 - rev 455179
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1446246 part 1. Use a single handwritten HTMLConstructor implementation, instead of code-generating lots of very similar implementations. r=peterv The codegen changes are mostly a backout of the changes made in bug 1274159. The HTMLConstructor implementation is mostly copied from one of the code-generated ones, with a few modifications: * Derive the interface name from the proto id instead of hardcoding it. * Use the proto/constructor ids to get constructor and prototype objects. * Use ErrorResult instead of FastErrorResult; we don't want the precedent of using FastErrorResult in non-generated code. There will be further changes to combine HTMLConstructor and CreateXULOrHTMLElement, in a separate changeset. MozReview-Commit-ID: 44D0qw23ioP