searching for reviewer(pehrsons)
db19bf2d6479d2e7e399b5ff03eaee0019b3d05b: Bug 1498679 - Stop moving variable to fix Linux64 debug coverage build. r=pehrsons
Alex Chronopoulos <achronop@gmail.com> - Fri, 19 Oct 2018 12:47:06 +0000 - rev 490492
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498679 - Stop moving variable to fix Linux64 debug coverage build. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D9244
cf707f5b0477c1537f411d1f776ad10303f2ccd2: Bug 1499615 - Silence unused returned value warning and initialize the counter. r=pehrsons
Alex Chronopoulos <achronop@gmail.com> - Thu, 18 Oct 2018 11:24:36 +0000 - rev 490299
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499615 - Silence unused returned value warning and initialize the counter. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D8964
0162bb225b88cfda9b702d88464d48fbf1f372ee: Bug 1499850 - make MediaTimer slightly more efficient; r=pehrsons
Nathan Froyd <froydnj@mozilla.com> - Thu, 18 Oct 2018 07:00:11 -0400 - rev 490222
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499850 - make MediaTimer slightly more efficient; r=pehrsons Instead of creating a timer and then setting the timer's target, we can determine the timer's target and pass it in directly when the timer is created. This reordering of steps is slightly more efficient, since SetTarget() is both a virtual call and requires locking, both of which can be skipped if we know the target at timer creation time.
b4d7770b8661338c878166beca941eeb830f6041: Bug 1497254 - clang-format MediaEngineWebRTCAudio.{cpp,h} and MediaEnginePrefs.h. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 17 Oct 2018 13:05:59 +0000 - rev 490056
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497254 - clang-format MediaEngineWebRTCAudio.{cpp,h} and MediaEnginePrefs.h. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D8959
233b7314da9d100272e895a8ce74b4490e557ac7: Bug 1497254 - Remove the concept of an Allocation from MediaEngineWebRTCAudio. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 17 Oct 2018 13:05:51 +0000 - rev 490055
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497254 - Remove the concept of an Allocation from MediaEngineWebRTCAudio. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D8732
0190c5793ffeeb0eec281cf377435c7a592415f3: Bug 1487057 - Part 11 - Work around the fact that EndTrack uses mCommands. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 12 Oct 2018 15:57:49 +0200 - rev 489230
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 11 - Work around the fact that EndTrack uses mCommands. r=pehrsons This is temporaray until Andreas fixes all this.
9cf36402deed806fb359c25f633d6dc9f31dc7ea: Bug 1487057 - Part 10 - Remove MediaEngineWebRTCAudio::mEnabled. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 03 Oct 2018 14:58:28 +0200 - rev 489229
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 10 - Remove MediaEngineWebRTCAudio::mEnabled. r=pehrsons It was redundant with mState. Differential Revision: https://phabricator.services.mozilla.com/D7602
e1a790218e20b97d32957965379423a67196f54b: Bug 1487057 - Part 9 - Make SourceMediaStream::SetEnded go through the message queue so it's in the right order w.r.t. Stop. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 01 Oct 2018 17:12:14 +0200 - rev 489228
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 9 - Make SourceMediaStream::SetEnded go through the message queue so it's in the right order w.r.t. Stop. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7601
45d2c462dc92c43eed9582c1b309f8df0c66b37f: Bug 1487057 - Part 8 - Split MediaEngineWebRTCMicrophoneSource in two classes, one for control one for processing. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 07 Sep 2018 16:53:23 +0200 - rev 489227
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 8 - Split MediaEngineWebRTCMicrophoneSource in two classes, one for control one for processing. r=pehrsons Big but not complex: - Remove the mutex - Move all MSG thread to a new class (AudioInputProcessing) - Remove the WebRTCAudioDataListener class, AudioInputProcessing is the listener - Use message passing for all modifications to the AudioInputProcessing. Differential Revision: https://phabricator.services.mozilla.com/D5442
273c92182c3cccd9ad6ef2abaf30d11fd42b6aea: Bug 1487057 - Part 7 - Flatten mAllocation and fix some locking. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 05 Sep 2018 16:00:33 +0200 - rev 489226
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 7 - Flatten mAllocation and fix some locking. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5441
582e630a2fcb9b5cea5a320bd155bd2123af0982: Bug 1487057 - Part 6 - Reorganize attributes and document thread access better. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 03 Sep 2018 14:52:54 +0200 - rev 489225
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 6 - Reorganize attributes and document thread access better. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5440
746f70de2691bb500afd00daa6cc4d6bf20b07dd: Bug 1487057 - Part 5 - Remove MediaEngineWebRTCMicrophoneSource::mStarted. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 03 Sep 2018 11:10:32 +0200 - rev 489224
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 5 - Remove MediaEngineWebRTCMicrophoneSource::mStarted. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5439
304b4f68b942eb98cddfda6c58376332772b3e72: Bug 1487057 - Part 4 - Remove AsyncLatencyLogger and associated code. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 30 Aug 2018 17:11:57 +0200 - rev 489223
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 4 - Remove AsyncLatencyLogger and associated code. r=pehrsons It's not maintained and probably does not work anymore. Differential Revision: https://phabricator.services.mozilla.com/D5438
2ff222ff2a723fc90210e9bd84968333c0fa5f86: Bug 1487057 - Part 3 - Turn the mAllocations array into an mAllocation UniquePtr, that can be nullptr. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 29 Aug 2018 19:00:28 +0200 - rev 489222
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 3 - Turn the mAllocations array into an mAllocation UniquePtr, that can be nullptr. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5437
7e6e230af6980d38db68c814c840a090bb5a354a: Bug 1487057 - Part 2 - Remove RegisterForAudioMixing/NeedsMixing, they are unused. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 29 Aug 2018 15:29:08 +0200 - rev 489221
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 2 - Remove RegisterForAudioMixing/NeedsMixing, they are unused. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5436
efd0c87b160b7b2549890fe3d0b30a63fc2c6bc8: Bug 1487057 - Part 1 - Move audio related classes in MediaEngineWebRTC.h to their own header files, clean up includes slightly. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 29 Aug 2018 14:38:43 +0200 - rev 489220
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487057 - Part 1 - Move audio related classes in MediaEngineWebRTC.h to their own header files, clean up includes slightly. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5435
55c832b1f2fecec90fb4afef27669ab971fc2fab: Bug 934425 - Implement setSinkId in HTMLMediaElement. r=pehrsons
Alex Chronopoulos <achronop@gmail.com> - Fri, 12 Oct 2018 09:39:30 +0000 - rev 489187
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 934425 - Implement setSinkId in HTMLMediaElement. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5874
87921c31f0b70062ce1fa0bb3464107dd4a8370d: Bug 934425 - Implement asynchronous method to switch sink in MediaDecoder. r=pehrsons
Alex Chronopoulos <achronop@gmail.com> - Fri, 12 Oct 2018 08:44:47 +0000 - rev 489185
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 934425 - Implement asynchronous method to switch sink in MediaDecoder. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5872
336da65f35ea1237d94c4a8e6d67b8f2bd794496: Bug 1497351 - Remove dictionary null defaults from MediaTrackConstraintSet; handle absence in NormalizedConstraintSet. r=bzbarsky,pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 11 Oct 2018 02:03:17 +0000 - rev 489000
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497351 - Remove dictionary null defaults from MediaTrackConstraintSet; handle absence in NormalizedConstraintSet. r=bzbarsky,pehrsons Differential Revision: https://phabricator.services.mozilla.com/D8054
690cfe65a8c961ec5b2e56f8249498693e26edd0: Bug 1493885 - Rewrite MediaStream-MediaElement-srcObject.https.html to use async/await. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 03 Oct 2018 21:44:42 +0000 - rev 488173
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493885 - Rewrite MediaStream-MediaElement-srcObject.https.html to use async/await. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7568
690011b571305eb937172d9d68e5dd4260f6e33e: Bug 1493885 - Update MediaStream-MediaElement-srcObject.https.html to spec, and bring back test that currentTime changes must be ignored. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 03 Oct 2018 21:37:54 +0000 - rev 488172
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493885 - Update MediaStream-MediaElement-srcObject.https.html to spec, and bring back test that currentTime changes must be ignored. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7567
8ba29ee081caa2de560c4b68f548fb04d6cbb567: Bug 1495904 - Have HTMLMediaElement::Seek() return synchronous errors synchronously instead of causing uncatchable promise rejections in web console. Enforce existing fastSeek() and mediaElement.currentPosition = value behavior (which is to ignore... r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 05 Oct 2018 15:43:32 +0000 - rev 488170
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495904 - Have HTMLMediaElement::Seek() return synchronous errors synchronously instead of causing uncatchable promise rejections in web console. Enforce existing fastSeek() and mediaElement.currentPosition = value behavior (which is to ignore... r=pehrsons ...errors) if srcObject is a MediaStream. r?pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7566
fb7f5d71b31ad06c7207f0945cd8fdbee003e237: Bug 1495478 - Move LogConstraints() to class MediaConstraintsHelper and add logging of missing constraints (rollup includes backed-out bug 1494498) r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Tue, 02 Oct 2018 16:13:20 +0000 - rev 487565
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495478 - Move LogConstraints() to class MediaConstraintsHelper and add logging of missing constraints (rollup includes backed-out bug 1494498) r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7378
d0a586d4d64a5bc6ae2679943621c05473d92ae3: Bug 1494498 - Some constraints were missing in MediaManager logs. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Mon, 01 Oct 2018 14:34:33 +0000 - rev 487349
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494498 - Some constraints were missing in MediaManager logs. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7153
7b19326c79fbc26da2d53bfd294d26935b593fb2: Bug 1494806 - Fixed exact string constraints w/arrays, e.g. {deviceId: {exact:['id']}}, were treated as ideal. r=pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 28 Sep 2018 11:29:12 +0000 - rev 487164
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494806 - Fixed exact string constraints w/arrays, e.g. {deviceId: {exact:['id']}}, were treated as ideal. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D7144
ae4bb7377de29271d14f5ff56f08adec53f8fe0b: Bug 1481152 - Restrict to a single input stream per process on Linux, when using PulseAudio and audio remoting is enabled. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 25 Sep 2018 10:04:44 +0000 - rev 486490
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1481152 - Restrict to a single input stream per process on Linux, when using PulseAudio and audio remoting is enabled. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D5543
0700ed6720e530ce30f4c734330ad9cca5f6306c: Bug 1487419 - Save current desktop configuration in ScreenCapturerMac::Init; r=pehrsons
Dan Minor <dminor@mozilla.com> - Wed, 05 Sep 2018 13:55:27 -0400 - rev 484089
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1487419 - Save current desktop configuration in ScreenCapturerMac::Init; r=pehrsons Summary: The fix for Bug 1409018 accidentally removed saving the current desktop configuration during Init() which causes it to not be set when a different screen is selected, meaning that regardless of the choice made, only the first screen is captured. Reviewers: pehrsons Tags: #secure-revision Bug #: 1487419 Differential Revision: https://phabricator.services.mozilla.com/D5062
61396b1eaa14477e196564ea0c4c0ba79439a64d: Bug 1483926 - Take into account mInputDeviceID is always nullptr on Android for now. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 21 Aug 2018 16:32:24 +0000 - rev 481179
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483926 - Take into account mInputDeviceID is always nullptr on Android for now. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D3899
f2dc5d8ac9ac55899c14d7a031951ccef0bc720d: Bug 1480036 - Allow scaling all MSG volume with a pref. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 01 Aug 2018 12:10:32 +0200 - rev 480884
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1480036 - Allow scaling all MSG volume with a pref. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D2594
352e47aeafac716617392486f88c20107dce2a00: Bug 1480036 - Stop relying on having the default device set globally. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 01 Aug 2018 15:18:32 +0200 - rev 480883
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1480036 - Stop relying on having the default device set globally. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D3508
3f99a091261fb67d798c7f16808d5a19efc7364b: Bug 1480036 - Allow forcing a specific audio output device from a test. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 01 Aug 2018 14:16:30 +0200 - rev 480882
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1480036 - Allow forcing a specific audio output device from a test. r=pehrsons Differential Revision: https://phabricator.services.mozilla.com/D3507
655d8b94c8f1f78185f51a11ff0d30f929ac5016: Bug 1483926 - Fix Android device enumeration. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 17 Aug 2018 15:34:16 +0000 - rev 480726
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1483926 - Fix Android device enumeration. r=pehrsons Not having a return here means that we end up clearing our device list. Differential Revision: https://phabricator.services.mozilla.com/D3613
67c4ed3c73d7bb770edcbdffebfb5688a3822a5b: Bug 1404977 - Tests P2: Add test to ensure multiple, concurrent gUM calls in a single window succeed. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Fri, 03 Aug 2018 10:35:59 -0400 - rev 478327
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Tests P2: Add test to ensure multiple, concurrent gUM calls in a single window succeed. r=pehrsons MozReview-Commit-ID: HGwcu6Z2mDn
c2d350fb074fb0c59eb922973ee33fc8ceeec0a5: Bug 1404977 - Tests P1: Add test to ensure multiple, concurrent gUM calls in separate iframes succeed. r=pehrsons
Bryce Van Dyk <bvandyk@mozilla.com> - Tue, 10 Jul 2018 15:09:50 +0200 - rev 478326
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Tests P1: Add test to ensure multiple, concurrent gUM calls in separate iframes succeed. r=pehrsons MozReview-Commit-ID: Iyr2A0R1rMd
d3fc55ebb24ab7117d5bbe740653af807dfe05b0: Bug 1404977 - Part 17 - Re-implement the workaround for the lack of input device enumeration on Android. r=pehrsons
Paul Adenot <paul@paul.cx> - Wed, 04 Jul 2018 18:00:57 +0200 - rev 478324
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 17 - Re-implement the workaround for the lack of input device enumeration on Android. r=pehrsons MozReview-Commit-ID: 5EiQ6a3OaIR
edc7a43bb7592c5407564151feeeb38c3684281f: Bug 1404977 - Part 16 - Unit test CubebDeviceEnumerator. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 22 Jun 2018 11:55:31 +0200 - rev 478323
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 16 - Unit test CubebDeviceEnumerator. r=pehrsons This is done by implementing a fake cubeb backend that implements the subset of operations we need, while offering an API to be able to control what this backend is doing. Because we're reimplementing the private cubeb API, it is necessary to copy part of a cubeb internal header, and mimick exactly how the vtable mechanism to do the dynamic dispatch to the diffferent backends in cubeb works. This is not ideal but works. When the cubeb API functions are called (from deep in the Gecko process), we re-bind the call to the mock cubeb backend object and behave exactly like a normal backend (calling various callbacks and returning fake objects). Finally, we inject this mock cubeb backend to the running Gecko process (in lieu of the real one that would have been picked) by setting the global sCubebBackend variable via a private API exposed only in the test in CubebUtils.h. MozReview-Commit-ID: 8ZbJhl7pZ2t
ecbae0557eaae616491c2c87fe42591bb64d7b48: Bug 1404977 - Part 15 - Invalidate the device cache before re-enumerating devices when the cubeb backend does not support dynamic device collection invalidation. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 22 Jun 2018 11:47:06 +0200 - rev 478322
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 15 - Invalidate the device cache before re-enumerating devices when the cubeb backend does not support dynamic device collection invalidation. r=pehrsons Also, clear the array that's been passed in before appending the new devices. MozReview-Commit-ID: BTnwzyKBrb5
3259ebfa7dea7816ce60dbd0814908e2d66031d4: Bug 1404977 - Part 14 - Add a way to set the global cubeb* singleton at runtime, from a test. r=pehrsons
Paul Adenot <paul@paul.cx> - Fri, 22 Jun 2018 11:45:31 +0200 - rev 478321
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 14 - Add a way to set the global cubeb* singleton at runtime, from a test. r=pehrsons This is for testing purposes only. Defining ENABLE_SET_CUBEB_BACKEND before including CubebUtils.h will expose the function. This is not to be set outside of test files. MozReview-Commit-ID: D0V8oLj9xo6
dc0f442f208cec6baa8d2675faff00a5adedb143: Bug 1404977 - Part 13 - Remove useless mutex, and assert why they were useless, in WebRTCAudioDataListeners. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 31 May 2018 16:44:00 +0200 - rev 478320
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 13 - Remove useless mutex, and assert why they were useless, in WebRTCAudioDataListeners. r=pehrsons MozReview-Commit-ID: 2Mb5WZXbYgS
eba12c9748f882d9a1d84038cf9b3ae15ebe0987: Bug 1404977 - Part 12 - Make DeviceChanged() notification thread safe by using the MSG message queue. r=pehrsons
Paul Adenot <paul@paul.cx> - Thu, 31 May 2018 16:42:24 +0200 - rev 478319
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 12 - Make DeviceChanged() notification thread safe by using the MSG message queue. r=pehrsons This is slightly slower, especially if the main thread is busy, but it's cleaner and actually safe. MozReview-Commit-ID: 4C2FalxmE3L
d28f054ca88e4a441d0df0febc32227f005f97a3: Bug 1404977 - Part 11 - Make sure the default device is the first element in the list. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 29 May 2018 15:20:47 +0200 - rev 478318
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 11 - Make sure the default device is the first element in the list. r=pehrsons MozReview-Commit-ID: LTJErFTm1wN
d09741d7dab28b401e4a1b753078f93be6a2eea3: Bug 1404977 - Part 10 - Make logging uniform, and consistently use GraphImpl() to access the graph impl. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 17 Apr 2018 17:11:13 +0200 - rev 478317
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 10 - Make logging uniform, and consistently use GraphImpl() to access the graph impl. r=pehrsons MozReview-Commit-ID: DZ7zhQsBtvy
20a567fbf561dd88c059439f2b34e1024c58ca2c: Bug 1404977 - Part 9 - Propagate the changes to the GraphDrivers, simplifying them, and brokering all access through the MSG. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 30 Apr 2018 16:01:56 +0200 - rev 478316
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 9 - Propagate the changes to the GraphDrivers, simplifying them, and brokering all access through the MSG. r=pehrsons For an AudioCallbackDriver, the number of input channels is immutable, and passed at construction, so that it's less necessary to rely on global state. MozReview-Commit-ID: F9TL1H92z3W
507d5c269d25aee79fe081b1b02a4970ddcc1fb0: Bug 1404977 - Part 8 - Tell the MSG the MediaEngineAudioSource are now independent and that we can have multiple of them, cleanup the MSG-side API for managing them. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 30 Apr 2018 16:01:38 +0200 - rev 478315
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 8 - Tell the MSG the MediaEngineAudioSource are now independent and that we can have multiple of them, cleanup the MSG-side API for managing them. r=pehrsons The MSG now can feed microphone data to all its input listeners. This paves the way for multiple input device, if we feel it's needed at some point, but does not implement it. The method for adding/removing inputs are also cleaned up. MozReview-Commit-ID: 9OX4Da6Gjq2
c63f8579e0dbc3b3401897db3095b51ef4af3c0e: Bug 1404977 - Part 7 - Make each MediaEngineWebRTCMicrophoneSource independent. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 30 Apr 2018 15:37:18 +0200 - rev 478314
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 7 - Make each MediaEngineWebRTCMicrophoneSource independent. r=pehrsons MozReview-Commit-ID: 1RSsT6AV3iI
700fadf31c3a79c98679f0986900c06d494e0f37: Bug 1404977 - Part 6 - Remove unused include for lock-free FIFO. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 30 Apr 2018 15:33:28 +0200 - rev 478313
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 6 - Remove unused include for lock-free FIFO. r=pehrsons MozReview-Commit-ID: 8gVKlD7lMIX
16671b7c328ac8fe27fef7906aac7afef9dc7a3d: Bug 1404977 - Part 5 - Allow querying the number of input channels from a WebRTCAudioDataListener. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 30 Apr 2018 15:30:58 +0200 - rev 478312
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 5 - Allow querying the number of input channels from a WebRTCAudioDataListener. r=pehrsons MozReview-Commit-ID: JkpEZOJpOTl
72fd73a9d4e3180fe0c16479b2da5f891addb312: Bug 1404977 - Part 3 - Remove global statics, introduce an audio device enumerator r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 30 Apr 2018 15:18:22 +0200 - rev 478311
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 3 - Remove global statics, introduce an audio device enumerator r=pehrsons MozReview-Commit-ID: 55VlpGIAOxp
3e1bbbc9047f732251966666c1d5a80265c3593f: Bug 1404977 - Part 2 - Augment AudioDeviceInfo with a cubeb device id. r=pehrsons
Paul Adenot <paul@paul.cx> - Mon, 30 Apr 2018 15:24:52 +0200 - rev 478310
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 2 - Augment AudioDeviceInfo with a cubeb device id. r=pehrsons MozReview-Commit-ID: GrOnxHuN2Oj
127bff24bfc8fa5d0e619ea727ab4a0c522c4497: Bug 1404977 - Part 1 - Add missing lock to the PREF_CUBEB_BACKEND branch of the pref callback in CubebUtils.cpp. r=pehrsons
Paul Adenot <paul@paul.cx> - Tue, 17 Apr 2018 16:45:33 +0200 - rev 478309
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1404977 - Part 1 - Add missing lock to the PREF_CUBEB_BACKEND branch of the pref callback in CubebUtils.cpp. r=pehrsons MozReview-Commit-ID: CBAmQKDq36z