searching for reviewer(njn)
3428510869a9b347639d3f79506d7225be92c191: Bug 1476757 - Grow and shrink the profiler buffer dynamically so as to not waste memory when a large buffer size limit is picked. r=njn
Markus Stange <mstange@themasta.com> - Mon, 22 Oct 2018 15:52:17 +0000 - rev 490764
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1476757 - Grow and shrink the profiler buffer dynamically so as to not waste memory when a large buffer size limit is picked. r=njn Depends on D6264 Differential Revision: https://phabricator.services.mozilla.com/D6265
ef82ba4b7f22f673870bc71ad4564bf0ef228b06: Bug 1476757 - Add methods to change the capacity of the ProfileBuffer. r=njn
Markus Stange <mstange@themasta.com> - Fri, 12 Oct 2018 13:39:47 +0000 - rev 490763
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1476757 - Add methods to change the capacity of the ProfileBuffer. r=njn Depends on D8218 Differential Revision: https://phabricator.services.mozilla.com/D6264
1924a400dfa461fc3ec3e47fd290838d78ed38a1: Bug 1476757 - Change {a,m}EntrySize to {a,m}Capacity in ProfileBuffer r=njn
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 12 Oct 2018 13:39:45 +0000 - rev 490762
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1476757 - Change {a,m}EntrySize to {a,m}Capacity in ProfileBuffer r=njn Differential Revision: https://phabricator.services.mozilla.com/D8218
470dd43efaa6a9b5c0d9e72e65276f7c07be4f25: Bug 1496623 - Rename and comment GeckoProfilerThread::installed() r=njn
Paul Bone <pbone@mozilla.com> - Fri, 05 Oct 2018 10:52:43 +1000 - rev 488436
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496623 - Rename and comment GeckoProfilerThread::installed() r=njn
46462bfc0e9b3de81847600e6d15f2c688766cde: Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn
Eric Rahm <erahm@mozilla.com> - Mon, 01 Oct 2018 16:38:17 -0700 - rev 488401
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn On some builds we only get 'SmokeDMD' references during testing rather than a full file path. This adds 'SmokeDMD' to the acceptable frame description list.
fcdc1d5eaf1a932992287074d0c91504dd7180d8: Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn
Eric Rahm <erahm@mozilla.com> - Mon, 01 Oct 2018 16:38:17 -0700 - rev 487625
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn On some builds we only get 'SmokeDMD' references during testing rather than a full file path. This adds 'SmokeDMD' to the acceptable frame description list.
d39c2dfcc7004a4736436c564de239ba68b20c03: Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn
Eric Rahm <erahm@mozilla.com> - Mon, 01 Oct 2018 16:38:17 -0700 - rev 487537
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn On some builds we only get 'SmokeDMD' references during testing rather than a full file path. This adds 'SmokeDMD' to the acceptable frame description list.
7566a6bac33d41042243ac2cef94f32b7d0c08df: Bug 1457481 - Add nsIProfiler.GetSymbolTable and a profiler/rust-helper crate which implements it for ELF binaries. r=njn,jrmuizel
Markus Stange <mstange@themasta.com> - Tue, 02 Oct 2018 01:50:02 +0000 - rev 487497
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1457481 - Add nsIProfiler.GetSymbolTable and a profiler/rust-helper crate which implements it for ELF binaries. r=njn,jrmuizel r?njn for the profiler parts r?jrmuizel for the ELF parsing parts Depends on D7020 Differential Revision: https://phabricator.services.mozilla.com/D7021
1192c15fc9347ccd6169dcb5bea81d7f2399e3fd: Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn
Eric Rahm <erahm@mozilla.com> - Mon, 01 Oct 2018 16:38:17 -0700 - rev 487488
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1409739 - Part 1: Accept SmokeDMD when filtering test DMD stacks. r=njn On some builds we only get 'SmokeDMD' references during testing rather than a full file path. This adds 'SmokeDMD' to the acceptable frame description list.
4478820fbcaadbbcca55e5a487b55efd2f0ed4cf: Bug 1457481 - Add nsIProfiler.GetSymbolTable and a profiler/rust-helper crate which implements it for ELF binaries. r=njn,jrmuizel
Markus Stange <mstange@themasta.com> - Mon, 01 Oct 2018 20:16:07 +0000 - rev 487428
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1457481 - Add nsIProfiler.GetSymbolTable and a profiler/rust-helper crate which implements it for ELF binaries. r=njn,jrmuizel r?njn for the profiler parts r?jrmuizel for the ELF parsing parts Depends on D7020 Differential Revision: https://phabricator.services.mozilla.com/D7021
326be6e41703289e5183ddc9aeb3dbaa3183380c: Bug 1493955 - Store floating-point preferences in a locale-independent way r=njn
Gabriele Svelto <gsvelto@mozilla.com> - Fri, 28 Sep 2018 20:54:09 +0000 - rev 487165
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493955 - Store floating-point preferences in a locale-independent way r=njn Differential Revision: https://phabricator.services.mozilla.com/D6796
ba1fef7b14eb4fd87ae72231196ddf29cd5fc5a6: Bug 1493955 - Store floating-point preferences in a locale-independent way r=njn
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 27 Sep 2018 20:41:39 +0000 - rev 486955
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493955 - Store floating-point preferences in a locale-independent way r=njn Differential Revision: https://phabricator.services.mozilla.com/D6796
ac2c1fea89ea57dee4a5b85dd046ca7ef71a9baf: Bug 1486728 - Report memory usage of Shadow DOM style data. r=njn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 29 Aug 2018 22:24:29 +0000 - rev 482331
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1486728 - Report memory usage of Shadow DOM style data. r=njn This is on top of bug 1486623. While at it removed the 'stale computed styles' report, since it was unused since I removed the undisplayed maps. Differential Revision: https://phabricator.services.mozilla.com/D4453
481d502afc69d7d120b2d80a2b881bcea25c2661: Bug 1486528 - Remove some unnecessary nsIMemory imports. r=njn
Marco Castelluccio <mcastelluccio@mozilla.com> - Mon, 27 Aug 2018 16:38:18 +0200 - rev 481835
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1486528 - Remove some unnecessary nsIMemory imports. r=njn
5ba2bfc9b269b9dae5818005b3b453e3e54c07d6: Bug 1481670 - Add a non-mangled version of the valgrind suppression for SaveWordToEnv. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 22 Aug 2018 09:02:13 +0900 - rev 481590
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1481670 - Add a non-mangled version of the valgrind suppression for SaveWordToEnv. r=njn This is similar to what was done with SaveToEnv in bug 1457999.
b7f4a1596d18d093e8f25bc8947a005d75ee2e7f: Bug 1485210 - Add --sym-offsets=yes to valgrind command line. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 22 Aug 2018 08:58:08 +0900 - rev 481056
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485210 - Add --sym-offsets=yes to valgrind command line. r=njn When valgrind prints out backtraces, it prints raw addresses and symbol names, but that doesn't help find the exact code that caused the errors, because we don't know where the libraries are loaded. With --sym-offsets=yes, it adds the offset from the symbol, which allows to find the relevant code in the binary.
baaf4be9a9dc245044589f8fba0992ef7896f915: Bug 1484809 - Put class nsRelativeFilePref into its own include file. r=njn
Jorg K <jorgk@jorgk.com> - Tue, 21 Aug 2018 00:28:00 +0300 - rev 480846
Push 231 by fmarier@mozilla.com at Wed, 22 Aug 2018 00:04:13 +0000
Bug 1484809 - Put class nsRelativeFilePref into its own include file. r=njn
060aa1c7072322d21ec4190fdb07dc1dd89abe0c: Bug 1481139 - fix GMP process IPC channel error on Android. r=jld,njn
John Lin <jolin@mozilla.com> - Fri, 17 Aug 2018 00:06:20 +0000 - rev 480472
Push 227 by fmarier@mozilla.com at Sat, 18 Aug 2018 09:02:59 +0000
Bug 1481139 - fix GMP process IPC channel error on Android. r=jld,njn Bug 1481139 - p1: handle invalid file descriptors. Bug 1481139 - p2: add dummy fds for GMP process. Two file descriptors were added in bug 1438678 and 1471025 for content/child process but not GMP process, and it breaks the IPC channel on Android. Add dummy values to make it work for now before bug 1440207 clean up the mess. Differential Revision: https://phabricator.services.mozilla.com/D3541
0b2b4da68f04f3431bfff08859d73a210573bec1: Bug 1484109 - Part 3: Make nsRelativeFilePref final; r=njn
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 17 Aug 2018 10:27:24 -0400 - rev 480407
Push 227 by fmarier@mozilla.com at Sat, 18 Aug 2018 09:02:59 +0000
Bug 1484109 - Part 3: Make nsRelativeFilePref final; r=njn
489fccb13b3e963b8bf8b235a7b4c82805061ca9: Bug 1484109 - Part 2: Make nsIRelativeFilePref non-scriptable, since there are no script consumers; r=njn
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 17 Aug 2018 10:26:50 -0400 - rev 480406
Push 227 by fmarier@mozilla.com at Sat, 18 Aug 2018 09:02:59 +0000
Bug 1484109 - Part 2: Make nsIRelativeFilePref non-scriptable, since there are no script consumers; r=njn
0da5607c48f6861e5f2880bb0b596267e03e242e: Bug 1484109 - Part 1: Remove the XPCOM component registration for nsRelativeFilePref; r=njn
Ehsan Akhgari <ehsan@mozilla.com> - Fri, 17 Aug 2018 10:26:25 -0400 - rev 480405
Push 227 by fmarier@mozilla.com at Sat, 18 Aug 2018 09:02:59 +0000
Bug 1484109 - Part 1: Remove the XPCOM component registration for nsRelativeFilePref; r=njn
5928090fcb23935e819e22f392367309428cb648: Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Aug 2018 11:40:02 +1000 - rev 480140
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
a91ccbe2b3fd8b9303b034d7a6035de572495fd0: Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
Cameron McCormack <cam@mcc.id.au> - Thu, 16 Aug 2018 11:40:02 +1000 - rev 480117
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn
0d27c68cfaf85c07e1059184f17354b358228dfe: Bug 1482797 - Don't use MADV_FREE on Linux until we support it properly. r=njn
Mike Hommey <mh+mozilla@glandium.org> - Wed, 15 Aug 2018 17:21:25 +0900 - rev 479961
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482797 - Don't use MADV_FREE on Linux until we support it properly. r=njn
e6a44943b17774c94e3c22e85e5260b0a62121ac: Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:52:42 +1000 - rev 479952
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio Summary: Depends On D3286 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1483121 Differential Revision: https://phabricator.services.mozilla.com/D3295
8d6f6eef3c76805d95cde66f354f150b75fbe9e4: Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 479951
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn Summary: Depends On D3285 Reviewers: njn! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3286
c4b64bd53e9266f0116a27d9a41488149455005d: Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 479950
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio Summary: Depends On D3284 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3285
73c353f1d88fd07830c9034ad67800f333149cee: Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:39 +1000 - rev 479949
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio Summary: Depends On D3283 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3284
6605ef249363dcf770e4d07d9753b2252690d1f2: Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479948
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio Summary: Depends On D3282 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3283
57507aba8ffd33917ad48c52b29a0fe2dad3f7a1: Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479947
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn Summary: Depends On D3281 Reviewers: njn! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3282
7ef73ff1649501f237c2df7d588ad8f9f544bed8: Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479946
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn Summary: Depends On D3280 Reviewers: njn! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3281
6c488a5eb81d3e2e41ba0913b2610facf6df465b: Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479945
Push 224 by fmarier@mozilla.com at Fri, 17 Aug 2018 00:53:15 +0000
Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen Reviewers: njn!, hsivonen! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3280
0a8334bbcf4594d5bc1195d31f15d550ac8e9a4a: Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:52:42 +1000 - rev 479890
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio Summary: Depends On D3286 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1483121 Differential Revision: https://phabricator.services.mozilla.com/D3295
cb2dcb8590711584e1689583a75f66d7195bb550: Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 479889
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1482782 - Part 7: Expand out nsStaticAtom.h macros now that we only static atom table. r=njn Summary: Depends On D3285 Reviewers: njn! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3286
c834d4ca2eef0a7ace7aa7e480bba0ad76bbb8fb: Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:42 +1000 - rev 479888
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1482782 - Part 6: Remove support for multiple static atom sources. r=njn,emilio Summary: Depends On D3284 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3285
887de0efbb67f436a241a60fea0fc4a001656cdd: Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:39 +1000 - rev 479887
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1482782 - Part 5: Move CSS anonymous box atoms to nsGkAtoms. r=njn,emilio Summary: Depends On D3283 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3284
018fdb50a6bec77b3022b2431334bae21339c4cb: Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479886
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1482782 - Part 4: Move CSS pseudo-element atoms to nsGkAtoms. r=njn,emilio Summary: Depends On D3282 Reviewers: njn!, emilio! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3283
33a8aa8096c94e9be06d4aec7a8ad274f5dcf9de: Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479885
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1482782 - Part 3: Define atom type in nsGkAtomList.h. r=njn Summary: Depends On D3281 Reviewers: njn! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3282
e3632354f16ec80028cf3004fcc1322f7c0ff405: Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479884
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1482782 - Part 2: Move directory service atoms into nsGkAtoms. r=njn Summary: Depends On D3280 Reviewers: njn! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3281
46f8319bee824fe669df21ee6023c9ea55349ac3: Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen
Cameron McCormack <cam@mcc.id.au> - Wed, 15 Aug 2018 15:46:00 +1000 - rev 479883
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen Reviewers: njn!, hsivonen! Tags: #secure-revision Bug #: 1482782 Differential Revision: https://phabricator.services.mozilla.com/D3280
42e2eeaca65d313926e962b6583d52d4bcab6d15: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 479194
Push 217 by fmarier@mozilla.com at Fri, 10 Aug 2018 22:05:44 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant C++ functions are updated to take a typed enum. JavaScript calls are unaffected but they will throw if the string argument does not correspond to one of the known entries in the C++ enum. The existing whitelists and blacklists of annotations are also generated from the YAML file and all duplicate code related to them has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included in the list (and some obsolete ones have been removed) and all call sites have been updated including tests where appropriate.
d323d133324be6cae829825d6d0a894ea219a5b3: Bug 1474701: Fix shutdown profile-save (fix imbalance) and add JSONWriter assertions r=mstange,njn
Randell Jesup <rjesup@jesup.org> - Mon, 06 Aug 2018 10:44:26 -0400 - rev 478515
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1474701: Fix shutdown profile-save (fix imbalance) and add JSONWriter assertions r=mstange,njn
1e9ecba54e7b1e6ee614e323ece9c98c373311a9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 478339
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.
86471a18672fb8b1c7edf27076f5e2964e2389f9: Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 05 Jul 2018 15:42:11 +0200 - rev 478333
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1348273 - Convert crash annotations into a machine-readable list of constants; r=ted.mielczarek,njn,dholbert,mak,cpearce,mcmanus,froydnj,Dexter,jrmuizel,jchen,jimm,bz,surkov This introduces the machinery needed to generate crash annotations from a YAML file. The relevant functions are updated to take a typed enum (in C++) and an integer constant (in JavaScript). A JavaScript wrapper around the crash reporter service is provided to hold the constants. The existing whitelists and blacklists of annotations are also generated from the YAML file and the existing duplicate code has been consolidated. Once written out to the .extra file the annotations are converted in string form and are no different than the existing ones. All existing annotations have been included (and some obsolete ones removed) and all call sites have been updated including tests.
ada1690b63e92f902b1543f38cfb6327d1652a52: Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r=njn,sfink
Markus Stange <mstange@themasta.com> - Thu, 02 Aug 2018 13:49:48 -0400 - rev 478184
Push 212 by fmarier@mozilla.com at Fri, 03 Aug 2018 00:39:34 +0000
Bug 1476793 - Teach HelperThread how to push/pop profiler label frames, and use this capability to push an IDLE frame when the thread is idle. r=njn,sfink MozReview-Commit-ID: 6HIWrA27X87
38b22cd7188cbbb6c65b385489501b18f9ef5d8e: Bug 1477009 - use a dependent CString on Android for finding breakpad ids; r=njn
Nathan Froyd <froydnj@mozilla.com> - Thu, 26 Jul 2018 09:47:05 -0400 - rev 476804
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1477009 - use a dependent CString on Android for finding breakpad ids; r=njn This is slightly more efficient, since we don't have to copy the string.
d6c5e93d33a1f86946480004fc19c2d4ef3984e1: Bug 1477904: Correctly handle static var caches with changed default values. r=njn
Kris Maglione <maglione.k@gmail.com> - Mon, 23 Jul 2018 22:50:03 -0700 - rev 476611
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1477904: Correctly handle static var caches with changed default values. r=njn MozReview-Commit-ID: H2ImQrmrtAV
37435502b7c0301bbcf9d161a0700a92b9e0d929: Bug 1475836: Clear cached callback pref when deleting branch. r=njn
Kris Maglione <maglione.k@gmail.com> - Fri, 20 Jul 2018 11:57:37 -0700 - rev 476166
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1475836: Clear cached callback pref when deleting branch. r=njn MozReview-Commit-ID: C60kGkoFBL8
d68c6c56856cdd0306fc7c3491438d301526db51: Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn
Kris Maglione <maglione.k@gmail.com> - Mon, 23 Jul 2018 17:32:54 -0700 - rev 476165
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn In order to avoid the overhead of doing a full pref lookup for every static var cache at content process startup, we currently assume that the default value of any static varcache pref will always match the default value of its database entry (as long as the pref isn't locked). This lets us only perform lookups for preferences which have a user value, or are locked. If the default values of those preferences are changed in a bundled preference file, though, the varcache value will be correct in the parent process, but not in child processes. Since this is an easy mistake to make, we should assert that it doesn't happen. Note: This change only affects applications which use e10s. Applications like Thunderbird can still override default values of any static pref with impunity. Repacks and distributors can only do so by changing user values or locking the preference after the change (which is the standard practice for enterprise deployments). MozReview-Commit-ID: JMHQBrp9HN
1b389b00030ed38cdb3543aa5d1a67795be47565: Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn
Kris Maglione <maglione.k@gmail.com> - Mon, 23 Jul 2018 17:32:54 -0700 - rev 476156
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1477254: Assert that varcache prefs match pref values at content process startup. r=njn In order to avoid the overhead of doing a full pref lookup for every static var cache at content process startup, we currently assume that the default value of any static varcache pref will always match the default value of its database entry (as long as the pref isn't locked). This lets us only perform lookups for preferences which have a user value, or are locked. If the default values of those preferences are changed in a bundled preference file, though, the varcache value will be correct in the parent process, but not in child processes. Since this is an easy mistake to make, we should assert that it doesn't happen. Note: This change only affects applications which use e10s. Applications like Thunderbird can still override default values of any static pref with impunity. Repacks and distributors can only do so by changing user values or locking the preference after the change (which is the standard practice for enterprise deployments). MozReview-Commit-ID: JMHQBrp9HN