searching for reviewer(michal)
106c2a54ae6a95718cbb8bfb7a9453e1fefa5027: Bug 1499917 - Read entire length of expected string from the stream r=michal
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 19 Oct 2018 18:00:50 +0000 - rev 490543
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499917 - Read entire length of expected string from the stream r=michal The test ocasionally fails out in e10s mode, because stream.available() might not return the entire string length (it's async). So the child process needs to wait for all of the bytes to be read. Differential Revision: https://phabricator.services.mozilla.com/D9274
42319047f3d9ad10a2849c1e7b1b9cf6d2bb6de0: Bug 1487100 - Allow opening the input stream for original content when alt-data is available r=michal,luke
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 17 Oct 2018 12:27:37 +0000 - rev 490207
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487100 - Allow opening the input stream for original content when alt-data is available r=michal,luke In trying to use fetch with alt-data, we sometimes want the benefit of using alt-data but the JS consumer actually needs to use the original HTTP response from the server. To get around this problem, we introduce a new API - nsICacheInfoChannel.getOriginalInputStream(nsIInputStreamReceiver) that asyncly receives the input stream containing the HTTP response in the cache entry. Depends on D8071 Differential Revision: https://phabricator.services.mozilla.com/D8072
e37adb23fd48ca1576ba954fe203b3fd6d6155f3: Bug 1487100 - Allow calling nsICacheInfoChannel.preferAlternativeDataType(altDataType, contentType) multiple times r=michal,luke
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 17 Oct 2018 13:58:30 +0000 - rev 490206
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487100 - Allow calling nsICacheInfoChannel.preferAlternativeDataType(altDataType, contentType) multiple times r=michal,luke This patch changes the way we set and handle the preferred alternate data type. It is no longer just one choice, but a set of preferences, each conditional on the contentType of the resource. For example: var cc = chan.QueryInterface(Ci.nsICacheInfoChannel); cc.preferAlternativeDataType("js-bytecode", "text/javascript"); cc.preferAlternativeDataType("ammended-text", "text/plain"); cc.preferAlternativeDataType("something-else", ""); When loaded from the cache, the available alt-data type will be checked against "js-bytecode" if the contentType is "text/javascript", "ammended-text" if the contentType is "text/plain" or "something-else" for all contentTypes. Note that the alt-data type could be "something-else" even if the contentType is "text/javascript". The preferences are saved as an nsTArray<mozilla::Tuple<nsCString, nsCString>>. Differential Revision: https://phabricator.services.mozilla.com/D8071
7f9d03c29a6ffd82c1b5e17c14e27a2ae9d64434: Bug 1487100 - Allow opening the input stream for original content when alt-data is available r=michal,luke
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 17 Oct 2018 12:27:37 +0000 - rev 490169
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487100 - Allow opening the input stream for original content when alt-data is available r=michal,luke In trying to use fetch with alt-data, we sometimes want the benefit of using alt-data but the JS consumer actually needs to use the original HTTP response from the server. To get around this problem, we introduce a new API - nsICacheInfoChannel.getOriginalInputStream(nsIInputStreamReceiver) that asyncly receives the input stream containing the HTTP response in the cache entry. Depends on D8071 Differential Revision: https://phabricator.services.mozilla.com/D8072
dd1c31ea78c2b15d14750d137037a54d50719997: Bug 1487100 - Allow calling nsICacheInfoChannel.preferAlternativeDataType(altDataType, contentType) multiple times r=michal,luke
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 17 Oct 2018 13:58:30 +0000 - rev 490168
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1487100 - Allow calling nsICacheInfoChannel.preferAlternativeDataType(altDataType, contentType) multiple times r=michal,luke This patch changes the way we set and handle the preferred alternate data type. It is no longer just one choice, but a set of preferences, each conditional on the contentType of the resource. For example: var cc = chan.QueryInterface(Ci.nsICacheInfoChannel); cc.preferAlternativeDataType("js-bytecode", "text/javascript"); cc.preferAlternativeDataType("ammended-text", "text/plain"); cc.preferAlternativeDataType("something-else", ""); When loaded from the cache, the available alt-data type will be checked against "js-bytecode" if the contentType is "text/javascript", "ammended-text" if the contentType is "text/plain" or "something-else" for all contentTypes. Note that the alt-data type could be "something-else" even if the contentType is "text/javascript". The preferences are saved as an nsTArray<mozilla::Tuple<nsCString, nsCString>>. Differential Revision: https://phabricator.services.mozilla.com/D8071
51abf3731a71737a336d196b2f004f18b49edff9: Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. r=michal
Robert Bartlensky <rbartlensky@mozilla.com> - Tue, 17 Jul 2018 12:32:42 +0100 - rev 476435
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. r=michal MozReview-Commit-ID: F1p3ji1ezp3
38e729d91ed2873b708bd4800b01b8433ffceabd: Bug 1468501 - Implement a way to delete network cache by nsIPrincipal, r=mayhemer, r=michal
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 20 Jul 2018 13:57:18 +0200 - rev 475724
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1468501 - Implement a way to delete network cache by nsIPrincipal, r=mayhemer, r=michal
d5e2a4d678f05bd9409d7f943687c2a27a8a6218: Bug 1470355 - BufferWriter should stop reading data when the wanted amount has been reached, r=michal
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 02 Jul 2018 02:00:00 +0300 - rev 472887
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1470355 - BufferWriter should stop reading data when the wanted amount has been reached, r=michal
50b0bfa64b2c631dfd146657207c04cb2ca31f65: Bug 1470355 - BufferWriter should stop reading data when the wanted amount has been reached, r=michal
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 02 Jul 2018 02:00:00 +0300 - rev 472884
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1470355 - BufferWriter should stop reading data when the wanted amount has been reached, r=michal
0349f4afb8d37c13d1643967d8ba0f9edaaf8324: Bug 1453204 - Fix 425 return code for websocket. r=michal
Dragana Damjanovic <dd.mozilla@gmail.com> - Fri, 29 Jun 2018 09:10:00 +0300 - rev 472703
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1453204 - Fix 425 return code for websocket. r=michal
287bdf729c7985a5995900b8cee7a7a7db4f98d9: Bug 1453795 - Necko - Initialize member fields in classes/ structures. r=michal
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 14 Jun 2018 11:19:07 +0300 - rev 470734
Push 196 by fmarier@mozilla.com at Mon, 18 Jun 2018 22:44:32 +0000
Bug 1453795 - Necko - Initialize member fields in classes/ structures. r=michal
1ea106440d1bdc80cae928cafad4cff08c9619ef: Bug 1460561 - nsMultiplexInputStream should behave correctly when NS_InputStreamIsBuffered() is used, r=michal, r=froydnj
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 24 May 2018 07:51:53 +0200 - rev 468933
Push 185 by fmarier@mozilla.com at Mon, 04 Jun 2018 18:38:09 +0000
Bug 1460561 - nsMultiplexInputStream should behave correctly when NS_InputStreamIsBuffered() is used, r=michal, r=froydnj
eea17fb776842aa503b019496b874efa6a00b55d: Bug 1460561 - nsMultiplexInputStream should behave correctly when NS_InputStreamIsBuffered() is used, r=michal
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 24 May 2018 07:51:53 +0200 - rev 467775
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1460561 - nsMultiplexInputStream should behave correctly when NS_InputStreamIsBuffered() is used, r=michal
11c7370ae92e99b06b6b1869edbd25418773acb8: Bug 1426353 - Do not allow the parent process to consume alt-data generated in the content process. r=michal, a=RyanVM
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 06 Mar 2018 02:44:51 +0100 - rev 464685
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1426353 - Do not allow the parent process to consume alt-data generated in the content process. r=michal, a=RyanVM MozReview-Commit-ID: htQ28muaBI
698ab4eff5bf1efb1af8ea74e0a8f4f2f906e5ae: Bug 1450302 - nsInputStreamPump should interrupt the reading of the inputStream when suspended, r=michal
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 05 May 2018 22:58:43 +0200 - rev 462041
Push 166 by fmarier@mozilla.com at Thu, 10 May 2018 00:43:18 +0000
Bug 1450302 - nsInputStreamPump should interrupt the reading of the inputStream when suspended, r=michal
a9185d7a30d832b0f93919f8522bd465e96a9b45: Bug 1427726 - remove support for remote JAR files, r=michal
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 07 Feb 2018 13:54:39 +0000 - rev 457768
Push 155 by fmarier@mozilla.com at Thu, 12 Apr 2018 17:56:07 +0000
Bug 1427726 - remove support for remote JAR files, r=michal MozReview-Commit-ID: H7aaTmj3FI1
f41cf7811770bb9de1ac59a906c2e246fdce8bcf: Bug 1427726 - remove support for remote JAR files, r=michal
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 07 Feb 2018 13:54:39 +0000 - rev 457750
Push 155 by fmarier@mozilla.com at Thu, 12 Apr 2018 17:56:07 +0000
Bug 1427726 - remove support for remote JAR files, r=michal MozReview-Commit-ID: H7aaTmj3FI1
798d83c02cc1da9a2577da5d27a6e4338a5936a7: Bug 1451295 - Add a null check for mChannel r=michal
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 05 Apr 2018 17:47:14 +0300 - rev 456964
Push 153 by fmarier@mozilla.com at Tue, 10 Apr 2018 02:28:40 +0000
Bug 1451295 - Add a null check for mChannel r=michal MozReview-Commit-ID: 7YYhFQuKsPk
1f7081335eb901bcc885c18467599441007b70f1: Bug 1451063 - nsICache does not inherit from nsISupports r=michal
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 05 Apr 2018 16:58:44 +0300 - rev 456949
Push 153 by fmarier@mozilla.com at Tue, 10 Apr 2018 02:28:40 +0000
Bug 1451063 - nsICache does not inherit from nsISupports r=michal MozReview-Commit-ID: 9azOJAEy5DH
d18246f06ea5e0dce155c786c08bd03aa7f67427: Bug 1441726 - Include CacheStorageService::mPurgeTimeStamps hashtable in the memory reporter. r=michal
Honza Bambas <honzab.moz@firemni.cz> - Tue, 27 Mar 2018 10:21:00 +0300 - rev 456231
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1441726 - Include CacheStorageService::mPurgeTimeStamps hashtable in the memory reporter. r=michal
6815e9ee09adf18721c2305f53b3947ee6b81615: Bug 1433088 - Make the HTTP cache entry age based validation calculation work with the internal one-second only round-down resolution to make max-age=0 force immediate expiration. r=michal
Honza Bambas <honzab.moz@firemni.cz> - Wed, 28 Mar 2018 08:35:00 -0400 - rev 455363
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1433088 - Make the HTTP cache entry age based validation calculation work with the internal one-second only round-down resolution to make max-age=0 force immediate expiration. r=michal
457b9e70da837921fb5e6b12682b5c0c7604dc6e: Bug 1442784 - Carry isMainDocumentChannel HTTP channel flag to redirected HTTP channels, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Mon, 26 Mar 2018 10:49:00 +0300 - rev 455163
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1442784 - Carry isMainDocumentChannel HTTP channel flag to redirected HTTP channels, r=michal
80a1cfc4f0698c4703c58df7aa868fea523a3604: Bug 1395114 - Remove nsIUnicharStreamLoader. r=emilio,michal
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 26 Mar 2018 12:45:31 +0300 - rev 455058
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1395114 - Remove nsIUnicharStreamLoader. r=emilio,michal MozReview-Commit-ID: ECKNnJt80oK
964191c031db7c9b50b6a4f5dad9da1eb63acb49: Bug 1426353 - Do not allow the parent process to consume alt-data generated in the content process. r=michal
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 06 Mar 2018 02:44:51 +0100 - rev 453917
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1426353 - Do not allow the parent process to consume alt-data generated in the content process. r=michal MozReview-Commit-ID: htQ28muaBI
5e50ce0cce022ae075e03e49d301bbdec3dfcf7c: Bug 1395760 - In offline mode, fail HTTP load when a cache entry is partial, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Fri, 02 Mar 2018 13:42:00 +0200 - rev 453526
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1395760 - In offline mode, fail HTTP load when a cache entry is partial, r=michal
0f64845d179b9bf45a6ae38b9b597e3993422fb7: Bug 1443900 - don't allocate nsCStrings when doing integer parsing; r=michal
Nathan Froyd <froydnj@mozilla.com> - Thu, 08 Mar 2018 09:43:00 -0500 - rev 452087
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1443900 - don't allocate nsCStrings when doing integer parsing; r=michal There's no need to allocate a completely new nsCString when all we want to do is parse a character string into an integer. We can allocate a dependent string instead, which will avoid some memory churn.
65e4fa2d1e1fd9e100210a1ab86e041eb08a4d0a: Bug 1379072 - Intermittent failure of browser/components/sessionstore/test/browser_354894_perwindowpb.js, r=michal
Liang-Heng Chen <xeonchen@gmail.com> - Tue, 27 Feb 2018 09:21:00 +0200 - rev 450167
Push 146 by fmarier@mozilla.com at Fri, 02 Mar 2018 02:16:17 +0000
Bug 1379072 - Intermittent failure of browser/components/sessionstore/test/browser_354894_perwindowpb.js, r=michal Wait for the tabs to finish when loading test tabs.
fa721c35fc3fd89c0acf8b55a625425bda70d7c7: Bug 1438332 - Change RCWN test to expect the to account for very fast code execution r=michal
Valentin Gosu <valentin.gosu@gmail.com> - Sat, 17 Feb 2018 00:25:51 +0100 - rev 449046
Push 144 by fmarier@mozilla.com at Fri, 23 Feb 2018 02:24:57 +0000
Bug 1438332 - Change RCWN test to expect the to account for very fast code execution r=michal The test would set a timer for 200ms then expect to be called back more than 200ms later (as in 201ms or more) This change makes sure that we don't fail if the callback comes back exactly 200ms later. MozReview-Commit-ID: 1OCyO3juAdZ
e221a4e7b13c98091df7efdfd2c359b248e3039a: Bug 1437058 - Add LOG for CacheEntryHandle::~CacheEntryHandle to track its lifetime correctly, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Fri, 09 Feb 2018 07:19:00 +0200 - rev 447921
Push 137 by fmarier@mozilla.com at Thu, 15 Feb 2018 20:52:22 +0000
Bug 1437058 - Add LOG for CacheEntryHandle::~CacheEntryHandle to track its lifetime correctly, r=michal
77c14093bc69d945cc6646c3e5a4d09ecd760eee: Bug 1152332 - Let connection proxy filters return the result asynchronously - core changes, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Thu, 08 Feb 2018 07:18:00 +0200 - rev 447640
Push 135 by fmarier@mozilla.com at Sat, 10 Feb 2018 02:56:15 +0000
Bug 1152332 - Let connection proxy filters return the result asynchronously - core changes, r=michal
ce34d962b0df2487653636d166e8fac11b438fd5: Bug 1152332 - Let connection proxy filters return the result asynchronously - update/introduce tests, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Thu, 08 Feb 2018 05:49:00 +0200 - rev 447639
Push 135 by fmarier@mozilla.com at Sat, 10 Feb 2018 02:56:15 +0000
Bug 1152332 - Let connection proxy filters return the result asynchronously - update/introduce tests, r=michal
06dc5a5ea2238a6611c965bba2c46d1533524aa6: Bug 1430197 - Remove the HTTP cache half-live experiment, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Fri, 12 Jan 2018 11:51:00 +0200 - rev 443978
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1430197 - Remove the HTTP cache half-live experiment, r=michal
5a503850a497e892b8e4036bb7155194e6db3254: Bug 1423550 - Lookup regula HTTP cache on appcache NETWORK namespace match, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Mon, 08 Jan 2018 07:26:00 +0200 - rev 442759
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1423550 - Lookup regula HTTP cache on appcache NETWORK namespace match, r=michal
b6df8ef5dec1491bdea535579016578ae9483ced: Bug 1422467. r=michal
Honza Bambas <honzab.moz@firemni.cz> - Thu, 21 Dec 2017 14:39:42 -0500 - rev 441698
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1422467. r=michal
d9fb1d761acffc84bb32a5829a4f1ee71fddc16c: Bug 1416682 - Don't allow writing alt-data to HTTP cache entry when the loading channel has failed to release the entry, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Fri, 01 Dec 2017 11:01:00 +0200 - rev 439536
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1416682 - Don't allow writing alt-data to HTTP cache entry when the loading channel has failed to release the entry, r=michal
79dda82f07c432bdbe3445c7cf6dc4875499059a: Bug 1416682 - Add nsICacheEntry.drop() to explicitly release HTTP cache entries from channels to avoid logical deadlocks, r=michal
Honza Bambas <honzab.moz@firemni.cz> - Thu, 30 Nov 2017 12:03:00 +0200 - rev 439533
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1416682 - Add nsICacheEntry.drop() to explicitly release HTTP cache entries from channels to avoid logical deadlocks, r=michal
16643f939e8f3a126dd7732cc379f73d102cb0b7: Bug 1340197 - Don't wait for concurrent HTTP cache entry when the depending load is a top-level navigation. r=michal
Honza Bambas <honzab.moz@firemni.cz> - Mon, 27 Nov 2017 07:26:00 -0500 - rev 439516
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1340197 - Don't wait for concurrent HTTP cache entry when the depending load is a top-level navigation. r=michal
1f6112300d6e28ffe64940c94a6baae035a8ee9a: Bug 1420334 - protect timestamp setting in a critical section, r=michal
Junior Hsu <juhsu@mozilla.com> - Thu, 30 Nov 2017 19:45:00 +0200 - rev 439104
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1420334 - protect timestamp setting in a critical section, r=michal
42fc2739a3332a50a169ce78127fe95dec8b6787: Bug 1340197 - Don't wait for concurrent HTTP cache entry when the depending load is a top-level navigation. r=michal
Honza Bambas <honzab.moz@firemni.cz> - Mon, 27 Nov 2017 07:26:00 -0500 - rev 438496
Push 120 by fmarier@mozilla.com at Wed, 29 Nov 2017 22:27:43 +0000
Bug 1340197 - Don't wait for concurrent HTTP cache entry when the depending load is a top-level navigation. r=michal
16a31f23b98a98e4cb843658cd4a3189d0c134f4: Bug 1396307 - Make sure we only set mRaceCacheWithNetwork to true when the feature is enabled. r=michal, a=lizzard
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 06 Sep 2017 10:24:01 +0200 - rev 432862
Push 109 by fmarier@mozilla.com at Wed, 15 Nov 2017 09:57:56 +0000
Bug 1396307 - Make sure we only set mRaceCacheWithNetwork to true when the feature is enabled. r=michal, a=lizzard MozReview-Commit-ID: FrLjfuExmYV
3f387c200939b3dc99a477cd2d5c448adc877131: Bug 1410620 - Change CacheInfo interfaces in network to use ACString. r=michal,froydnj
Tom Schuster <evilpies@gmail.com> - Sun, 29 Oct 2017 12:19:48 +0100 - rev 431537
Push 108 by fmarier@mozilla.com at Fri, 03 Nov 2017 18:37:44 +0000
Bug 1410620 - Change CacheInfo interfaces in network to use ACString. r=michal,froydnj
692541a9f99bcbf3c3be823df728c03cde3752eb: Bug 1411697 - Make sure to SendDocumentChannelCleanup even when mPreferredCachedAltDataType is set r=michal
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 26 Oct 2017 15:54:37 +0200 - rev 431180
Push 108 by fmarier@mozilla.com at Fri, 03 Nov 2017 18:37:44 +0000
Bug 1411697 - Make sure to SendDocumentChannelCleanup even when mPreferredCachedAltDataType is set r=michal MozReview-Commit-ID: ApXNqS9tcfh
d69682dd908a6d633b82d4dc8e721252794bb72b: Bug 1399467 - Remove assertion FTPChannelParent that is triggered by bad ftp URL r=michal
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 12 Oct 2017 21:51:58 +0200 - rev 428918
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1399467 - Remove assertion FTPChannelParent that is triggered by bad ftp URL r=michal MozReview-Commit-ID: 3vBKRReapHa
f013760760f227e45493de3f251949dbb23750c2: Bug 1402151, part 9 - Implement gtest for FTP directory listing parsing. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:19:33 -0700 - rev 428803
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1402151, part 9 - Implement gtest for FTP directory listing parsing. r=michal This test turns the existing stand alone test for the FTP directory listing parser into a gtest. MozReview-Commit-ID: 7n60TfcTXTJ
cef4777d22b61fcd833ef380859f9060a0af7183: Bug 1402151, part 8 - Add an argument to ParseFTPList to return the current time. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 13:27:09 -0700 - rev 428802
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1402151, part 8 - Add an argument to ParseFTPList to return the current time. r=michal If the year is omitted from a listing, then the parsing code assumes that the date occurred within the last year. To compute what the year should be, the code thus needs to know what the current year, month and day are. This patch parameterizes ParseFTPList over a function that returns a PRTime. This will allow the gtest to pass in a fixed time. Firefox itself will continue to use PR_Now to get the current time. MozReview-Commit-ID: 8IbVWbUBHYs
90904b0eae64bd077c48abd9cd468a17acb49897: Bug 1402151, part 7 - Add a time zone argument to ParseFTPList. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:45:27 -0700 - rev 428801
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1402151, part 7 - Add a time zone argument to ParseFTPList. r=michal In a few places, the FTP parser needs to know the time zone and daylight savings time correction, encapsulated in PRTimeParamFn. Before this patch, it would use the time zone of the current machine, which would obviously make automated testing difficult. This patch allows a caller to pass in a PRTimeParamFn, which will allow the gtest to use GMT instead of whatever the local time is. MozReview-Commit-ID: 81R3Zbndr43
8c4e5c96e95f8488534eaa3f1a0768ba6b67a409: Bug 1402151, part 6 - Manual fixups for times in E-EPLF.out. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 12:53:01 -0700 - rev 428800
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1402151, part 6 - Manual fixups for times in E-EPLF.out. r=michal After the automatic fixes in the previous patch, a few of the times in late March and early April are still off by an hour. Maybe this was affected by the changes in when daylight savings time or some bug in my conversion script. I have no idea. This patch just fixes the test to match the actual output. MozReview-Commit-ID: IghWfkWfxvi
f60db82364456137ec937b604f78eafaf77e5e86: Bug 1402151, part 5 - Adjust E-EPLF.out from Paris time to GMT. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 12:50:35 -0700 - rev 428799
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1402151, part 5 - Adjust E-EPLF.out from Paris time to GMT. r=michal The dates in the input for this file are specified as seconds since Jan 1, 1970 or whenever. The conversion to a normal date depends on the current time zone. The original output seems to have been generated using GMT+1, with adjustments for daylight savings time at the appropriate parts of the year. To make this easier to test, this patch changes all of the times to GMT, without any daylight savings time adjustment. This change was automatically created by the Python script attached to the bug. MozReview-Commit-ID: 3uSAGtJYsMW
427f0784d60c108795c46de9163ba317f6edf6e9: Bug 1402151, part 4 - Fix some FTP parser tests. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 11:26:18 -0700 - rev 428798
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1402151, part 4 - Fix some FTP parser tests. r=michal D-WinNT: The parser treats <JUNCTION> without an arrow as junk for some reason. Chrome's FTP directory listing parser doesn't seem to support <JUNCTION> at all, so it can't be too important. I just deleted that from the expected output to match Firefox's current behavior. I also added basic tests for three bugs that were fixed without any tests landed. E-EPLF.out: Add a license to the top. U-WinNT.out: We're not testing junk or comment output, and we don't use the list: prefix, so remove all of those. Also, we now output the proper year (2000 instead of 00, for instance), so fix that in the test output. Finally, the time in the output for this test is formatted differently, for whatever reason, so change it to match the actual output. V-VMS-mix.out: Fix file sizes. File sizes on VMS can only be approximated. When the FTP tests initially landed in 2002, this was handled by not trying. Bug 22299 landed in 2003 and changed our behavior to approximate the size, but the tests were not updated. MozReview-Commit-ID: 1DVfBfHh82y
b866226c10a468bf35d7aebd43971bfd66c2b00b: Bug 1402151, part 3 - Move parse-ftp unit tests into the gtest directory. r=michal
Andrew McCreight <continuation@gmail.com> - Mon, 25 Sep 2017 10:58:11 -0700 - rev 428797
Push 99 by fmarier@mozilla.com at Tue, 24 Oct 2017 22:56:23 +0000
Bug 1402151, part 3 - Move parse-ftp unit tests into the gtest directory. r=michal This will make them easier to access from a gtest. MozReview-Commit-ID: 3lV4DwTosXT