searching for reviewer(mgaudet)
d12102a7cea7849009ff99668c23a3d7626e47f7: Bug 1501328 - CacheIR stub for out-of-bounds indexed GetElement on Arrays. r=mgaudet
Kannan Vijayan <kvijayan@mozilla.com> - Wed, 24 Oct 2018 23:51:54 -0400 - rev 491210
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501328 - CacheIR stub for out-of-bounds indexed GetElement on Arrays. r=mgaudet
7884434cdddeaa4c763168db3524cd785486b10d: Bug 1499536 - Implement CodeGeneratorARM64::visitShiftI and visitUrshD. r=mgaudet
Sean Stangl <sstangl@mozilla.com> - Mon, 22 Oct 2018 14:00:00 -0400 - rev 490821
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499536 - Implement CodeGeneratorARM64::visitShiftI and visitUrshD. r=mgaudet Fixes ion/bug1000960.js.
c8d29a3d6554c10d9250196700f7a1acd5ea6a73: Bug 1498386 - Implement LIRGeneratorARM64 register helpers. Passes auto-regress/bug1268034.js. r=mgaudet
Sean Stangl <sstangl@mozilla.com> - Thu, 11 Oct 2018 14:22:00 +0300 - rev 489811
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498386 - Implement LIRGeneratorARM64 register helpers. Passes auto-regress/bug1268034.js. r=mgaudet
cfc3293b75f8fb471a83248eab8cd654fe9da47a: Bug 1485789 - Cleanup defineUntypedPhi(). r=mgaudet
Sean Stangl <sstangl@mozilla.com> - Tue, 09 Oct 2018 18:07:34 -0400 - rev 488756
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1485789 - Cleanup defineUntypedPhi(). r=mgaudet For https://bugzilla.mozilla.org/show_bug.cgi?id=1485789, from the linked discussion. Normally Kannan should review this, since he asked for it, but I'm using this as an excuse to try out Phabricator, and it looks like he hasn't linked his Bugzilla account yet. Test Plan: Covered by existing jit-tests. Differential Revision: https://phabricator.services.mozilla.com/D4170
63b06faf2f9e34510dd5661bb9ac20211d56ceac: Bug 1486857 - Don't box result of IonCompareIC; r=mgaudet
Johannes Schulte <j_schulte@outlook.com> - Wed, 19 Sep 2018 18:55:25 +0200 - rev 487535
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1486857 - Don't box result of IonCompareIC; r=mgaudet
dce559a7ac350c38dc03c3fbe3b2b5eb91b45a06: Bug 1491353 - Make the allocator fallible to work-around false positive uncatchable OOMs. r=mgaudet
Nicolas B. Pierron <nicolas.b.pierron@nbp.name> - Wed, 19 Sep 2018 18:34:24 +0200 - rev 487523
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491353 - Make the allocator fallible to work-around false positive uncatchable OOMs. r=mgaudet
7bbf9560f451422023e71284069254309eb9ca78: Bug 1490993 part 1 - Always use braces for if/for/while statements in js/src/jit/x64. r=mgaudet
Jan de Mooij <jdemooij@mozilla.com> - Thu, 13 Sep 2018 13:51:46 +0000 - rev 484965
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490993 part 1 - Always use braces for if/for/while statements in js/src/jit/x64. r=mgaudet Differential Revision: https://phabricator.services.mozilla.com/D5762
6a52f517bdb44b42b677c7c50a67d9306b3ed935: Bug 1488698 - Always use braces for if/for/while statements in js/src/jit, part 2. r=mgaudet
Jan de Mooij <jdemooij@mozilla.com> - Thu, 06 Sep 2018 11:51:36 +0200 - rev 484049
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1488698 - Always use braces for if/for/while statements in js/src/jit, part 2. r=mgaudet
9f1df06ee3066e30ca84e270e37087f632969ca6: Bug 1488698 - Always use braces for if/for/while statements in js/src/vm, part 2. r=mgaudet
Jan de Mooij <jdemooij@mozilla.com> - Thu, 06 Sep 2018 11:11:36 +0200 - rev 484032
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1488698 - Always use braces for if/for/while statements in js/src/vm, part 2. r=mgaudet
9d438550d85682669333a5f522c3491dfa1ee2e3: Bug 1485738: Add column number information to the JitSpew r=mgaudet
Denis Palmeiro <dpalmeiro@mozilla.com> - Fri, 31 Aug 2018 22:59:42 +0300 - rev 482687
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485738: Add column number information to the JitSpew r=mgaudet Summary: It is currently quite difficult to debug minified scripts. The JitSpew and profiler used to display only line numbers, so all of the output would be emitted as "script:1". Column number information is now collected by the gecko profiler as of bug 785922. The JitSpew should also emit column numbers so that it's easy to line up with the profiler output. Reviewers: mgaudet Reviewed By: mgaudet Subscribers: jandem Bug #: 1485738 Differential Revision: https://phabricator.services.mozilla.com/D4677
3f831b709e370b14ccf9f06508760633cd6b312a: Bug 1485738: Add column number information to the JitSpew r=mgaudet
Denis Palmeiro <dpalmeiro@mozilla.com> - Fri, 31 Aug 2018 22:59:42 +0300 - rev 482644
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485738: Add column number information to the JitSpew r=mgaudet Summary: It is currently quite difficult to debug minified scripts. The JitSpew and profiler used to display only line numbers, so all of the output would be emitted as "script:1". Column number information is now collected by the gecko profiler as of bug 785922. The JitSpew should also emit column numbers so that it's easy to line up with the profiler output. Reviewers: mgaudet Reviewed By: mgaudet Subscribers: jandem Bug #: 1485738 Differential Revision: https://phabricator.services.mozilla.com/D4677
7d527975aa0e9ee49b01c3120f4738e254a4424f: Bug 1487023: Replace the self-hosted SameValue function with Object.is. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Wed, 29 Aug 2018 02:41:28 -0700 - rev 482309
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1487023: Replace the self-hosted SameValue function with Object.is. r=mgaudet
e8a440cca97f287d762b84f8c7b1fea7a770a108: Bug 1461374 - Deduplicate GuardXrayExpandoShapeAndDefaultProto using emitLoadStubField r=mgaudet
bobslept <bobslept@protonmail.com> - Mon, 13 Aug 2018 19:09:07 -0400 - rev 482262
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1461374 - Deduplicate GuardXrayExpandoShapeAndDefaultProto using emitLoadStubField r=mgaudet
74a166849e43a03dbe9a4dc342f4c22c5d6557a9: Bug 1484627 : [MIPS] Fix simulator build failure after Bug 1481998; r=mgaudet
Dragan Mladjenovic <dragan.mladjenovic> - Mon, 20 Aug 2018 09:11:32 +0200 - rev 480938
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484627 : [MIPS] Fix simulator build failure after Bug 1481998; r=mgaudet
b52558db35441e9eeec4a138170922c6a085e48e: Bug 1483593 - [MIPS] Fix build failure after Bug 1481998. r=mgaudet
Dragan Mladjenovic <dragan.mladjenovic@rt-rk.com> - Wed, 15 Aug 2018 09:32:00 +0300 - rev 480197
Push 227 by fmarier@mozilla.com at Sat, 18 Aug 2018 09:02:59 +0000
Bug 1483593 - [MIPS] Fix build failure after Bug 1481998. r=mgaudet
b9a687b9bbe2414a0c452f4e631afc129ebe3244: Bug 1480819 - Part 7: Add comments, constants, and better variable names to RegExp stubs. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 10 Aug 2018 05:43:46 -0700 - rev 479552
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1480819 - Part 7: Add comments, constants, and better variable names to RegExp stubs. r=mgaudet
411fa809129a533f492136cb8ac58a4ef7e1119e: Bug 1480819 - Part 6: Add helper methods to MacroAssembler to work with CharEncoding and reduce code duplication. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 10 Aug 2018 08:50:28 -0700 - rev 479551
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1480819 - Part 6: Add helper methods to MacroAssembler to work with CharEncoding and reduce code duplication. r=mgaudet
68db5a68d65abca77d8f857e6b89b42973833ef6: Bug 1480819 - Part 5: Add registers and encoding type as members to CreateDependentString. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 03 Aug 2018 09:12:53 -0700 - rev 479550
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1480819 - Part 5: Add registers and encoding type as members to CreateDependentString. r=mgaudet
215a50752a4966c2d8ef8dc2b51f73a25351c6b0: Bug 1480819 - Part 4: Don't save non-volatile registers. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 03 Aug 2018 09:12:04 -0700 - rev 479549
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1480819 - Part 4: Don't save non-volatile registers. r=mgaudet
34165b194cf9df25e92febd28948d93554280bf6: Bug 1480819 - Part 3: Reorder temporary register names in generateRegExpMatcherStub. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 03 Aug 2018 09:10:46 -0700 - rev 479548
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1480819 - Part 3: Reorder temporary register names in generateRegExpMatcherStub. r=mgaudet
7ad24c33a9b5747245545b3ea8aca85a0e57429d: Bug 1480819 - Part 2: Switch the temporary variables used for CopyStringChars in CreateDependentString::generate. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 03 Aug 2018 09:09:40 -0700 - rev 479547
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1480819 - Part 2: Switch the temporary variables used for CopyStringChars in CreateDependentString::generate. r=mgaudet
09d8a8e246481cde29ee88928dc14a98b36d8634: Bug 1480819 - Part 1: Remove dead and unnecessary code to restore registers from generateRegExpMatcherStub. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Fri, 03 Aug 2018 09:08:50 -0700 - rev 479546
Push 222 by fmarier@mozilla.com at Thu, 16 Aug 2018 00:03:56 +0000
Bug 1480819 - Part 1: Remove dead and unnecessary code to restore registers from generateRegExpMatcherStub. r=mgaudet
27adb1a1c96195ec919cdaea57349d4d21483de0: Bug 1480575: Implement cmp32 with Address operands for ARM MacroAssembler and use it in LIsPackedArray. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Thu, 02 Aug 2018 13:24:02 -0700 - rev 478901
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480575: Implement cmp32 with Address operands for ARM MacroAssembler and use it in LIsPackedArray. r=mgaudet
ef2291b03c194651468a824af685caae99cfdc9e: Bug 1480018: Change some Base(Value)Index users to BaseObject(Element|Slot)Index. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Thu, 02 Aug 2018 08:02:17 -0700 - rev 478199
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480018: Change some Base(Value)Index users to BaseObject(Element|Slot)Index. r=mgaudet
f2f0f683f69aef13c9b33028ff4a10548b1a85b4: Bug 1480116: Improve codegen for LIsConstructor, LConvertElementsToDoubles, and the surrogate check in PrepareAndExecuteRegExp. r=mgaudet
André Bargull <andre.bargull@gmail.com> - Thu, 02 Aug 2018 13:12:50 -0700 - rev 478198
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480116: Improve codegen for LIsConstructor, LConvertElementsToDoubles, and the surrogate check in PrepareAndExecuteRegExp. r=mgaudet
8775ded167016ebfbbdc96ba99a216a36fbc4643: Bug 1461386: Deduplicate emitGuardFunctionPrototype r=mgaudet
Wander Lairson Costa <wcosta@mozilla.com> - Thu, 26 Jul 2018 10:13:34 -0300 - rev 478038
Push 212 by fmarier@mozilla.com at Fri, 03 Aug 2018 00:39:34 +0000
Bug 1461386: Deduplicate emitGuardFunctionPrototype r=mgaudet Move emitGuardFunctionPrototype to CacheIRCompiler and remove it from both Baseline and Ion. MozReview-Commit-ID: 1N7VszyiRCS
aaf899a792690f535f1f130e7dd08264b1f8f1ac: Bug 1468750 - add 'trackAttached' method to 'GetIteratorIRGenerator' class. r=mgaudet
Petru Gurita <petru.gurita1@gmail.com> - Thu, 28 Jun 2018 23:56:17 +0300 - rev 473214
Push 200 by fmarier@mozilla.com at Thu, 05 Jul 2018 23:51:35 +0000
Bug 1468750 - add 'trackAttached' method to 'GetIteratorIRGenerator' class. r=mgaudet Added method 'trackAttached' to the class 'GetIteratorIRGenerator' and implemented it accordingly. MozReview-Commit-ID: CRLXFaOfgZD
5eec827640825e1cfd283060f1a207ee15698d1f: Bug 1461375 - Deduplicate emitMegamorphicStoreSlotResult between Ion and Baseline. r=mgaudet
Simon Brand <simonrbrand@gmail.com> - Fri, 08 Jun 2018 20:39:29 +0100 - rev 470251
Push 196 by fmarier@mozilla.com at Mon, 18 Jun 2018 22:44:32 +0000
Bug 1461375 - Deduplicate emitMegamorphicStoreSlotResult between Ion and Baseline. r=mgaudet
abf2c521a0b1cb5e97d8ed5abc54f482f8d5283b: Bug 1459754 - Fix missing property IC for uncacheable proto case. r=mgaudet
Ted Campbell <tcampbell@mozilla.com> - Tue, 08 May 2018 12:52:20 -0400 - rev 469885
Push 190 by fmarier@mozilla.com at Thu, 07 Jun 2018 20:18:35 +0000
Bug 1459754 - Fix missing property IC for uncacheable proto case. r=mgaudet
d7aa8e8f9b0e99fa15c2c021dbe135ea7510283d: Bug 1461376 - Deduplicate LoadObject using emitLoadStubField. r=mgaudet
bobslept <bobslept@protonmail.com> - Fri, 18 May 2018 19:57:02 +0200 - rev 467136
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1461376 - Deduplicate LoadObject using emitLoadStubField. r=mgaudet
f17388afa985e6bd47662690fea7be374319c526: Bug 1461372 - Deduplicate GuardGroupHasUnanalyzedNewScript using emitLoadStubField. r=mgaudet
bobslept <bobslept@protonmail.com> - Thu, 17 May 2018 21:38:26 +0200 - rev 466877
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1461372 - Deduplicate GuardGroupHasUnanalyzedNewScript using emitLoadStubField. r=mgaudet
a1ea9ba622e615e1cb262894d1f8b9ee581ae43e: Bug 1456470: Mark a few fields as protected in ARM classes to avoid unused private fields warnings; r=mgaudet
Benjamin Bouvier <benj@benj.me> - Tue, 24 Apr 2018 15:35:57 +0200 - rev 460413
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1456470: Mark a few fields as protected in ARM classes to avoid unused private fields warnings; r=mgaudet
e65bb33f2ae069c91f7e379d1b19e814934f5fb7: Bug 1424760 (Part 2) - Number each of the GC telemetry properties r=mgaudet
Paul Bone <pbone@mozilla.com> - Sat, 16 Dec 2017 03:04:02 +1100 - rev 443851
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1424760 (Part 2) - Number each of the GC telemetry properties r=mgaudet By numbering each of the properties we can easily check that we do not exceed the limit in GCTelemetry.jsm. Note that this is not relevent for the nursery since it does not send telemetry.