searching for reviewer(m_kato)
f01896424c3a2fa77c20f9b9b40da89a2a09c1ba: Bug 1501260 - Make HTMLEditRules::DocumentModifiedWorker() create bogus node via editor instance r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 25 Oct 2018 05:55:04 +0000 - rev 491341
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501260 - Make HTMLEditRules::DocumentModifiedWorker() create bogus node via editor instance r=m_kato HTMLEditRules::DocumentModifiedWorker() may be called asynchronously via AddScriptRunnder. Therefore, this may not be in the stack while editor handles an edit action. Then, HTMLEditRules cannot access edit action data which will be put on the stack after fixing bug 1465702. So, it should do it after once calling a method of editor instance (and editor instance should call back proper HTMLEditRules method). Differential Revision: https://phabricator.services.mozilla.com/D9536
ca2018e79dc07aef83d62d70905e64895bc607a2: Bug 1501180 - Make TextEditRules::Notify() hide input characters via editor instance r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 25 Oct 2018 03:35:26 +0000 - rev 491271
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501180 - Make TextEditRules::Notify() hide input characters via editor instance r=m_kato TextEditRules::Notify() is callback of the timer. Therefore, this won't be in the stack while editor handles an edit action. Then, TextEditRules cannot access edit action data which will be put on the stack after fixing bug 1465702. So, it should do it after once calling a method of editor instance (and editor instance should call back proper TextEditRules method). Differential Revision: https://phabricator.services.mozilla.com/D9502
6437c4d882fd5375b5ba58646f0bf4b219b0f75e: Bug 1501177 - Create HTMLEditor::InsertAsCitedQuotationInternal() for internal use of nsIEditorMailSupport::InsertAsCitedQuotation() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 25 Oct 2018 04:49:13 +0000 - rev 491269
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501177 - Create HTMLEditor::InsertAsCitedQuotationInternal() for internal use of nsIEditorMailSupport::InsertAsCitedQuotation() r=m_kato HTMLEditor::InsertAsCitedQuotation() is an XPCOM method, so, it shouldn't be used for internal use. Instead, there should be non-virtual method and InsertAsCitedQuotation() should use it. Differential Revision: https://phabricator.services.mozilla.com/D9501
b7fdf387fa7b2ecd8f046524f72ed1abc76a02fc: Bug 1500862 - part 3: Change all stack base helper classes which access protected members of EditorBase to nested classes of EditorBase r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 24 Oct 2018 09:42:06 +0000 - rev 491091
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500862 - part 3: Change all stack base helper classes which access protected members of EditorBase to nested classes of EditorBase r=m_kato AutoTransactionBatch, AutoPlaceholderBatch, AutoSelectionRestorer, AutoTopLevelEditSubActionNotifier, AutoTransactionsConserveSelection and AutoUpdateViewBatch access protected members of EditorBase. The access scope management assume that they are used only by EditorBase or its subclasses or TextEditRules or its inherited class (i.e., HTMLEditRules). For guaranteeing this at build-time, we should change them to nested classes of EditorBase. Then, EditorBase and its subclasses and friends can use them. Differential Revision: https://phabricator.services.mozilla.com/D9479
d2112ced49ef79ddf69c041a8b01589869c39343: Bug 1500862 - part 2: Create AutoTransactionBatchExternal class which calls XPCOM methods instead of non-virtual internal methods r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 24 Oct 2018 05:18:40 +0000 - rev 491090
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500862 - part 2: Create AutoTransactionBatchExternal class which calls XPCOM methods instead of non-virtual internal methods r=m_kato Unfortunately, TextServicesDocument::InsertText() is too complicated to do it with both editor class and TextServicesDocument separately. Therefore, this patch adds AutoTransactionBatchExternal class which is almost same as AutoTransactionBatch but uses XPCOM methods to begin/end transaction. This change helps editor to manage whether it starts to handle new edit action or not when BeginTransaction() is called explicitly. Differential Revision: https://phabricator.services.mozilla.com/D9478
7bda40ae7f004f43c3afbfb66f7a3b5a2ea2eaa9: Bug 1500862 - part 1: Make HTMLEditor::SetInlineProperty() remove exclusive style automatically r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 24 Oct 2018 04:17:42 +0000 - rev 491089
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500862 - part 1: Make HTMLEditor::SetInlineProperty() remove exclusive style automatically r=m_kato StyleUpdatingCommand::ToggleState() removes exclusive style when it sets superscript style or subscript style. However, it accesses protected members of EditorBase via AutoTransactionBatch even though it's outside of editor classes. This patch moves the removing exclusive style code from the method to HTMLEditor::SetInlineProperty() and rename it "AsAction". Differential Revision: https://phabricator.services.mozilla.com/D9477
92c8efea77140bc65e183d4c560550bc91d58eb4: Bug 1484126 - part 21: Rewrite some loops in HTMLTableEditor.cpp with CellData::NextColumnIndex() or CellData::NextRowIndex() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 16 Oct 2018 01:10:44 +0000 - rev 489744
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 21: Rewrite some loops in HTMLTableEditor.cpp with CellData::NextColumnIndex() or CellData::NextRowIndex() r=m_kato A lot of loops in HTMLTableEditor.cpp scans cells along column-axis or row-axis. In those cases, they need to skip columns/rows which are spanned from prior column/row. So, we can rewrite them with CellData::NextColumnIndex() or CellData::NextRowColumn(). Differential Revision: https://phabricator.services.mozilla.com/D8358
19605351b3612103810730b1ce7fdee53d2e3b33: Bug 1484126 - part 20: Replace |CellData::mFirst.mColumn + CellData::mEffectiveColSpan| with CellData::NextColumnIndex() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:37:38 +0000 - rev 489743
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 20: Replace |CellData::mFirst.mColumn + CellData::mEffectiveColSpan| with CellData::NextColumnIndex() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8357
35c3aff251f06de9cd80cb5193abc5cb80d33166: Bug 1484126 - part 19: Replace |CellData::mCurrent.mColumn + CellData::NumberOfFollowingColumns()| with CellData::LastColumnIndex() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:35:33 +0000 - rev 489742
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 19: Replace |CellData::mCurrent.mColumn + CellData::NumberOfFollowingColumns()| with CellData::LastColumnIndex() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8356
8a2722c90ac91c4d4969100f4e6d4481bf2ab4d2: Bug 1484126 - part 18: Make HTMLEditor::InsertTableCellsWithTransaction() use CellData::NextColumnIndex() instead of |CellData::mCurrent::mColumn + CellData::mColSpan| r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:35:10 +0000 - rev 489741
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 18: Make HTMLEditor::InsertTableCellsWithTransaction() use CellData::NextColumnIndex() instead of |CellData::mCurrent::mColumn + CellData::mColSpan| r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8355
cbb895793f89b70afd138fb2df2ed2fbaf491e4e: Bug 1484126 - part 17: Make all CellData users refer CellData::mIsSelected directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:34:40 +0000 - rev 489740
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 17: Make all CellData users refer CellData::mIsSelected directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8354
4c70964d90fda77a9c06094accf3815fdfac1f2c: Bug 1484126 - part 16: Replace |CellData::mEffectiveColSpan - 1| with CellData::NumberOfFollowingColumns() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:34:06 +0000 - rev 489739
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 16: Replace |CellData::mEffectiveColSpan - 1| with CellData::NumberOfFollowingColumns() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8353
e5c8e5cbaf3dbbc60d6d2dce5db844820c6009b9: Bug 1484126 - part 15: Make all CellData users refer CellData::mEffectiveColspan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:33:33 +0000 - rev 489738
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 15: Make all CellData users refer CellData::mEffectiveColspan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8352
ed17432df28cf6e49cd8909835ae1b684d66f14c: Bug 1484126 - part 14: Replace |CellData::mEffectiveRowSpan - 1| with CellData::NumberOfFollowingRows() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 11:15:15 +0000 - rev 489737
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 14: Replace |CellData::mEffectiveRowSpan - 1| with CellData::NumberOfFollowingRows() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8351
3e1b1e01e6a43921ba453465c7d18ce5623b787d: Bug 1484126 - part 13: Make all CellData users refer CellData::mEffectiveRowSpan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 10:44:08 +0000 - rev 489736
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 13: Make all CellData users refer CellData::mEffectiveRowSpan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8350
e0cea47221b84d9ad48ad0f54bffaa5b280d76cd: Bug 1484126 - part 12: Make all CellData users refer CellData::mColSpan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 08:22:29 +0000 - rev 489735
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 12: Make all CellData users refer CellData::mColSpan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8349
6ab5dd75fbf4c7d8b02ee5d538ab69bc26fc087d: Bug 1484126 - part 11: Make all CellData users refer CellData.mRowSpan directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 08:14:18 +0000 - rev 489734
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 11: Make all CellData users refer CellData.mRowSpan directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8348
3e9c08f4f705ff9c789de57b68207d87b6045416: Bug 1484126 - part 10: Replace all comparisons of CellData::mFirst.mColumn and CellData::mCurrent.mColumn with CellData::IsSpannedFromOtherColumn() or CellData::IsSpannedFromOtherRowOrColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 08:06:14 +0000 - rev 489733
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 10: Replace all comparisons of CellData::mFirst.mColumn and CellData::mCurrent.mColumn with CellData::IsSpannedFromOtherColumn() or CellData::IsSpannedFromOtherRowOrColumn() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8347
8f7afde0a6f624e98469f07ed14f7f350e503861: Bug 1484126 - part 9: Make all CellData users refer CellData::mFirst.mColumn directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 07:37:57 +0000 - rev 489732
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 9: Make all CellData users refer CellData::mFirst.mColumn directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8346
b23363aa593d1dffea31f626f53f430953be556b: Bug 1484126 - part 8: Replace |CellData::mCurrent.mRow - CellData::mFirst.mRow| with CellData::NumberOfPrecedingRows() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 05:06:13 +0000 - rev 489731
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 8: Replace |CellData::mCurrent.mRow - CellData::mFirst.mRow| with CellData::NumberOfPrecedingRows() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8345
448d887560d4e6be3e91e831ebe161fc858bb68f: Bug 1484126 - part 7: Replace all comparisons of CellData::mFirst.mRow and CellData::mCurrent.mRow with CellData::IsSpannedFromOtherRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 04:21:34 +0000 - rev 489730
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 7: Replace all comparisons of CellData::mFirst.mRow and CellData::mCurrent.mRow with CellData::IsSpannedFromOtherRow() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8344
0f9a168cb7c818b7ed782228cce640699022e64e: Bug 1484126 - part 6: Make all CellData users refer CellData::mFirst.mRow directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 04:10:32 +0000 - rev 489729
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 6: Make all CellData users refer CellData::mFirst.mRow directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8343
181c07ae07c598314b76cb5b9b0c700d72c07488: Bug 1484126 - part 5: Make all CellData users refer CellData::mElement directly r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 04:06:32 +0000 - rev 489728
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 5: Make all CellData users refer CellData::mElement directly r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8342
539a4c3e194663e4631be32d1ca304a9e0bd0c1e: Bug 1484126 - part 4: Make all CellData users use CellData::mCurrent.mColumn r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 02:01:09 +0000 - rev 489727
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 4: Make all CellData users use CellData::mCurrent.mColumn r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8341
24e31e2070fa5386008cbf4e75589e10086d3e83: Bug 1484126 - part 3: Make all CellData users use CellData::mCurrent.mRow r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 01:43:54 +0000 - rev 489726
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 3: Make all CellData users use CellData::mCurrent.mRow r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8340
d3609fcd3c88b1b424ccd09cff8c8279853cba2b: Bug 1484126 - part 2: Make all nsITableEditor::GetCellDataAt() use CellData r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 15 Oct 2018 01:43:11 +0000 - rev 489725
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 2: Make all nsITableEditor::GetCellDataAt() use CellData r=m_kato This patch makes all nsITableEditor::GetCellDataAt() use CellData, and if each caller checks the result of GetCellDataAt() with NS_FAILED(), this replaces it with CellData::FailedOrNotFound() since GetCellDataAt() returns error even when it does not find a cell element. Finally, copies each CellData member to the variable which received corresponding value from GetCellDataAt() for making this change safe. Note that for easier to review, the copying blocks have odd indent. Those variables will be removed or corrected the indent by the following patches. Differential Revision: https://phabricator.services.mozilla.com/D8339
bf74fc63e8163598d8978e014ee28bdab9bb4455: Bug 1484126 - part 1: Create CellData struct which implements nsITableEditor::GetCellDataAt() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 12 Oct 2018 13:40:25 +0000 - rev 489724
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 1: Create CellData struct which implements nsITableEditor::GetCellDataAt() r=m_kato nsITableEditor::GetCellDataAt() is an XPCOM method but used internally a lot. Additionally, it scatters a lot of variables (including unused) since it takes a lot of out arguments to return. Therefore, this should be implemented as struct and users should refer each member as result. This does not replaces the callers yet since it's too risky if the caller is not tested by automated test. Following patches will replace the method call and each variable step by step. Differential Revision: https://phabricator.services.mozilla.com/D8338
d7f0492bf2620cd6c18b7ab57726677cb5827f10: Bug 1484126 - part 0: Add automated tests for nsITableEditor.getCellDataAt() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 12 Oct 2018 04:09:19 +0000 - rev 489723
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1484126 - part 0: Add automated tests for nsITableEditor.getCellDataAt() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D8337
57d97b765e4913a0abecea6444eb4e9bd43025cd: Bug 1497815 - Rename EditorEventListener::EnsureCommitCompoisition() to EditorEventListener::EnsureCommitComposition() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 11 Oct 2018 09:12:15 +0000 - rev 489047
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497815 - Rename EditorEventListener::EnsureCommitCompoisition() to EditorEventListener::EnsureCommitComposition() r=m_kato Just fixing typo of the method name. Differential Revision: https://phabricator.services.mozilla.com/D8336
a22e64bb83ed9873094e753df4f91e0f29853c13: Bug 1461708 - part 6: Make EditorEventListener::MouseClick() use WidgetMouseEvent instead of dom::MouseEvent r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 10 Oct 2018 12:05:21 +0000 - rev 488850
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1461708 - part 6: Make EditorEventListener::MouseClick() use WidgetMouseEvent instead of dom::MouseEvent r=m_kato The event argument of only EditorEventListener::MouseClick() can be replaced with WidgetMouseEvent simply. So, for avoiding unnecessary RefPtr in EditorEventListener::HandleEvent(), we should fix this now. Differential Revision: https://phabricator.services.mozilla.com/D7853
80f3e8b1d66fb5a9dbaba457ae2535a679ec49c5: Bug 1495978 - Make PuppetWidget::StartPluginIME() restore cross process dispatching state of given keyboard event instance after sending it to the main process synchronously r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 09 Oct 2018 01:29:42 +0000 - rev 488464
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495978 - Make PuppetWidget::StartPluginIME() restore cross process dispatching state of given keyboard event instance after sending it to the main process synchronously r=m_kato PuppetWidget::StartPluginIME() calls TabChild::SendStartPluginIME() with given WidgetKeyboardEvent instance. Then, the keyboard event will be marked as "posted to remote process" by ParamTraits<mozilla::WidgetEvent>::Write(). However, the method sends back the keyboard event to the main process synchronously. So, we don't want the event is treated as "posted" since the flag is used to check whether current process handles posted event *before* the remote process or not. So, PuppetWidget::StartPluginIME() should restore the cross process dispatching state with calling WidgetEvent::ResetCrossProcessDispatchingState(). Unfortunately, this also clears propagation state of the event too if the event has already been posted to a remote process and is waiting reply from the remote process. This shouldn't occur in content process, however, we should check it with MOZ_ASSERT() for detecting regressions. Differential Revision: https://phabricator.services.mozilla.com/D7579
323691f11567176e1e70a6d49a628e2ed653de6e: Bug 1495964 - Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 04 Oct 2018 02:51:16 +0000 - rev 487894
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495964 - Remove unnecessary NS_ASSERTION in nsChildView::DispatchEvent() r=m_kato The assertion was reasonable check before fixing bug 1446401. However, this is currently valid situation in UI Events spec. Differential Revision: https://phabricator.services.mozilla.com/D7578
3b77ee1b098608adfdd6bd62bed3eab27dfd8f69: Bug 1494651 - Update encoding_rs to 0.8.7. r=m_kato
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 01 Oct 2018 01:11:59 +0000 - rev 487292
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494651 - Update encoding_rs to 0.8.7. r=m_kato MozReview-Commit-ID: EB0wO4BxFAb Differential Revision: https://phabricator.services.mozilla.com/D7087
7fb27b858fda61306e1de21604438f39e98c5fd0: Bug 1484111 - part 1: Create HTMLEditor::InsertTableCellsWithTransaction() for internal use of nsITableEditor::InsertTableCell() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 11:44:35 +0000 - rev 485822
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484111 - part 1: Create HTMLEditor::InsertTableCellsWithTransaction() for internal use of nsITableEditor::InsertTableCell() r=m_kato nsITableEditor::InsertTableCell() is an XPCOM method but used internally. So, HTMLEditor should implement it with a non-virtual method and all internal users should use it instead. Differential Revision: https://phabricator.services.mozilla.com/D6259
d10273c0ead345543e631bd83fa00ffcbb6d5f15: Bug 1484111 - part 0: Add automated tests for nsITableEditor.insertTableCell.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 11:44:33 +0000 - rev 485821
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484111 - part 0: Add automated tests for nsITableEditor.insertTableCell.html r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6258
c44ff40b9ade65a7d185be509a3c19a042f6cb91: Bug 1484116 - part 1: Create HTMLEditor::InsertTableColumnsWithTransaction() for internal use of nsITableEditor::InsertTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 09:15:08 +0000 - rev 485789
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484116 - part 1: Create HTMLEditor::InsertTableColumnsWithTransaction() for internal use of nsITableEditor::InsertTableColumn() r=m_kato nsITableEditor::InsertTableColumn() is an XPCOM method but it's used internally. So, HTMLEditor should implement it with a non-virtual method and internal users should use it instead. Differential Revision: https://phabricator.services.mozilla.com/D6257
c7af8a8d767a0f3ec95e43099b1bfc82555a85be: Bug 1484116 - part 0: Add automated tests for nsITableEditor.insertTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 09:15:06 +0000 - rev 485788
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484116 - part 0: Add automated tests for nsITableEditor.insertTableColumn() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6256
d5e804da423c24b63bd30d6af6fdcdf7d44c6829: Bug 1484117 - part 0: Add automated tests for nsITableEditor.insertTableRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 04:45:18 +0000 - rev 485786
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484117 - part 0: Add automated tests for nsITableEditor.insertTableRow() r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6178
ede1caad730617f3396a476ac3209a7b98b8add3: Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 20 Sep 2018 06:55:17 +0000 - rev 485785
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow() r=m_kato nsITableEditor::InsertTableRow() is an XPCOM method but there are some internal users. So, HTMLEditor should implement it with a non-virtual method and it should be used by all internal users. Differential Revision: https://phabricator.services.mozilla.com/D6179
cf2ee1753201dcec1c9b882bd530d209ea5fb731: Bug 1484119 - part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 09:00:06 +0000 - rev 485566
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484119 - part 2: Make HTMLEditor::DeleteTableCellWithTransaction() remove <table> element if it becomes empty r=m_kato HTMLEditor::DeleteTableCellWithTransaction() does not remove <table> element even if it becomes empty only when 2 or more cell elements are selected. Therefore, we should check table size before removing a row and if it's the last row, the method should remove <table>. Differential Revision: https://phabricator.services.mozilla.com/D6177
c5c4ddcd12a9480c8e16832d850eb8888064dbf6: Bug 1484119 - part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 08:50:11 +0000 - rev 485565
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484119 - part 1: Create HTMLEditor::DeleteTableCellWithTransaction() for internal use of nsITableEditor::DeleteTableCell() r=m_kato nsITableEditor::DeleteTableCell() is an XPCOM method but used internally. So, HTMLEditor should implement it with non-virtual method and use it internally. Differential Revision: https://phabricator.services.mozilla.com/D6176
5e85c1d0661618835d0a7de1e8d8d5978ee8f13d: Bug 1484119 - part 0: Add automated tests for nsITableEditor.deleteTableCell.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 02:03:29 +0000 - rev 485564
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484119 - part 0: Add automated tests for nsITableEditor.deleteTableCell.html r=m_kato Although this has a lot of todo_is() since this API is really broken. Differential Revision: https://phabricator.services.mozilla.com/D6175
ca674e42cbca78bdc927be1ad2db12ebe211fdd6: Bug 1484120 - part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 01:58:48 +0000 - rev 485556
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484120 - part 1: Create HTMLEditor::DeleteTableCellContentsWithTransaction() for internal use of nsITableEditor::DeleteTableCellContents() r=m_kato nsITableEditor::DeleteTableCellContents() is an XPCOM method but it's used internally. So, HTMLEditor should implement it with a non-virtual method and all internal users should use the non-virtual method instead. This patch adds HTMLEditor::DeleteTableCellContentsWithTransaction() for that. Additionally, this patch renames its helper method DeleteCellContents() to DeleteAllChidlrenWithTransaction() and moves it to HTMLEditor.cpp since it can handle any element nodes. Differential Revision: https://phabricator.services.mozilla.com/D6174
1e13d82e0536c892e2417346b34fcd20a3e3c8a0: Bug 1484120 - part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 01:58:51 +0000 - rev 485555
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484120 - part 0: Add automated tests for nsITableEditor.deleteTableCellContents.html r=m_kato Differential Revision: https://phabricator.services.mozilla.com/D6173
aeedb53775769e6ccc5bd361491529a71009b129: Bug 1490641 - Disable all Gecko specific UIs by default in release build r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 06:40:03 +0000 - rev 485554
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490641 - Disable all Gecko specific UIs by default in release build r=m_kato Currently, we have some Gecko specific editing UI: - Resizers to resize <img>s, <table>s, absolutely positioned elements. - Inline-table-editing UI to add/remove rows/columns. - Grabber to move absolutely positioned element. They are now disabled by default in Nightly and early-Beta. Starting from 64, this patch makes them disabled by default even on release channel. Note that the other browsers do not have those UIs and web apps can enable them with document.execCommand() on Gecko anyway. Those UI usage is enough low according to the telemetry, but a few users use them aggressively (see bug 1452538 comment 19). This is a request from W3C Editing API WG: https://github.com/w3c/editing/issues/171 Differential Revision: https://phabricator.services.mozilla.com/D6112
a0f7c46838a0766a2bbb4d318c4ea02c59b82be7: Bug 1484121 - part 2: Clean up HTMLEditor::DeleteColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 06:39:31 +0000 - rev 485525
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484121 - part 2: Clean up HTMLEditor::DeleteColumn() r=m_kato This patch renames HTMLEditor::DeleteColumn() to HTMLEditor::DeleteTableColumnWithTransaction() and cleans up its implementation. Differential Revision: https://phabricator.services.mozilla.com/D5934
d2025ca568f79b5b7c77458a8f3a546381cd0d05: Bug 1484121 - part 1: Create HTMLEditor::DeleteSelectedTableColumnsWithTransaction() for internal use of nsITableEditor::DeleteTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 06:34:33 +0000 - rev 485524
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484121 - part 1: Create HTMLEditor::DeleteSelectedTableColumnsWithTransaction() for internal use of nsITableEditor::DeleteTableColumn() r=m_kato nsITableEditor::DeleteTableColumn() is an XPCOM method but used internally. So, it should be implemented with non-virtual method and internal users should use it. Note that this changes only one thing. This moves |AutoTopLevelEditSubActionNotifier maybeTopLevelEditSubAction(...| from below DeleteTableElementAndChildrenWithTransaction() to above it. I.e., DeleteTableElementAndChildrenWithTransaction() works under EditSubAction::eDeleteNode as the top level sub-action now. This is same as DeleteSelectedTableRowsWithTransaction(). Therefore, the difference with it when it removes <table> is now fixed. Differential Revision: https://phabricator.services.mozilla.com/D5933
d3f152e4c6cfbf5f2cf2d0c96a7bd3ed3ddb0448: Bug 1484121 - part 0: Add automated tests for nsITableEditor.deleteTableColumn() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 19 Sep 2018 04:32:10 +0000 - rev 485523
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484121 - part 0: Add automated tests for nsITableEditor.deleteTableColumn() r=m_kato This add automated tests for nsITableEditor.deleteTableColumn(). However, this contains some fixes of existing code since with those bugs, the test isn't passed even in the simplest case. Differential Revision: https://phabricator.services.mozilla.com/D5932
b240ef0f369466ad48c7129aba86ddae1dda8397: Bug 1484122 - part 2: Clean up HTMLEditor::DeleteRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 18 Sep 2018 08:31:00 +0000 - rev 485347
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484122 - part 2: Clean up HTMLEditor::DeleteRow() r=m_kato This patch renames HTMLEditor::DeleteRow() to HTMLEditor::DeleteTableRowWithTransaction() and cleans up its implementation. Differential Revision: https://phabricator.services.mozilla.com/D5931
7e2fe3f19c3c7dad58c34c436fd46b5e362892a2: Bug 1484122 - part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow() r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 18 Sep 2018 07:56:45 +0000 - rev 485346
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484122 - part 1: Create HTMLEditor::DeleteSelectedTableRowsWithTransaction() for internal use of nsITableEditor::DeleteTableRow() r=m_kato nsITableEditor::DeleteTableRow() is an XPCOM method but there are some internal users. So, it should be implemented as non-virtual protected method and internal users should use it instead. This also renames (and reimplement) HTMLEditor::DeleteTable2() since it's really bad name and the code dispatches unnecessary "selectionchange" events. Differential Revision: https://phabricator.services.mozilla.com/D5930