searching for reviewer(froydnj)
113b4856d0f94b3e71bc24998971d67a00c75fcc: Bug 1499821 - Introduce the FindDataFlavor helper function to nsTransferable. r=froydnj
Tom Schuster <evilpies@gmail.com> - Thu, 25 Oct 2018 10:04:43 +0000 - rev 491304
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499821 - Introduce the FindDataFlavor helper function to nsTransferable. r=froydnj This combines some of your ideas from D8074, in which I think is quite a big improvement to the overall code. The code for nsTransferable::GetTransferData, especially nsIFlavorDataProvider is a bit wonky, because I tried to preserve the current behavior. Differential Revision: https://phabricator.services.mozilla.com/D9599
444ecc63baf3485f5d8448dda33592c6319e368a: Bug 1480006 - Enable LTO on Android CI builds. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 10 Aug 2018 14:55:30 +0900 - rev 491253
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1480006 - Enable LTO on Android CI builds. r=froydnj
fbe393405a4ac2fccae94a26d173fc9fbe30e276: Bug 1499915 - Use elfhack from the build for Android xpcshell tests r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Oct 2018 13:45:50 +0000 - rev 491232
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499915 - Use elfhack from the build for Android xpcshell tests r=froydnj Android xpcshell tests run `elfhack -r`, and do so by using an elfhack binary from an archive downloaded via tooltool (which contains other things). Instead, we just put the elfhack binary in the target.common.tests.tar.gz archive, and make the xpcshell harness use it from there instead, allowing to pick in-tree changes to elfhack. Depends on D9623 Differential Revision: https://phabricator.services.mozilla.com/D9624
550a527e90ee52ce0ec3095b2fd977446ee2f5f2: Bug 1499915 - Support undoing elfhack when the elfhacked sections are in separate segments r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Oct 2018 13:42:38 +0000 - rev 491231
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499915 - Support undoing elfhack when the elfhacked sections are in separate segments r=froydnj This is some sort of followup to bug 1423813, providing a minimalistic way to undo elfhack when the elfhack sections are in separate segments, which has been the case since bug 1385783 but didn't cause problems on Android builds until bug 1423822. Depends on D9622 Differential Revision: https://phabricator.services.mozilla.com/D9623
0988f87f6bd2504463cea12fe0f2ba9ef5317b38: Bug 1499915 - Remove support for the elfhack filler segment r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Oct 2018 13:42:31 +0000 - rev 491230
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499915 - Remove support for the elfhack filler segment r=froydnj This effectively backs out bug 822584, which worked around a similar problem to what we are facing with Android xpcshell, being that the crash reporter doesn't handle the address space "fragmentation" induced by elfhack. The work around worked, at the expense of some added complexity. It was used for B2G only, and has effectively been unused since B2G was retired. Differential Revision: https://phabricator.services.mozilla.com/D9622
7b87be447ed82263ea5e1e8cb6f5412dd427dc71: Bug 1499821 - Introduce the FindDataFlavor helper function to nsTransferable. r=froydnj
Tom Schuster <evilpies@gmail.com> - Wed, 24 Oct 2018 21:34:32 +0000 - rev 491222
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499821 - Introduce the FindDataFlavor helper function to nsTransferable. r=froydnj This combines some of your ideas from D8074, in which I think is quite a big improvement to the overall code. The code for nsTransferable::GetTransferData, especially nsIFlavorDataProvider is a bit wonky, because I tried to preserve the current behavior. Differential Revision: https://phabricator.services.mozilla.com/D9599
434f70360933449c52ece7a00a6268391f805f08: Bug 1492663 - Upgrade most CI builds to clang 7 r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 27 Sep 2018 15:33:42 +0000 - rev 491198
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492663 - Upgrade most CI builds to clang 7 r=froydnj The cctools-port linker links against libraries from clang (for LTO), which have different SONAMEs depending on the clang version. Which means the linker needs to be used along the same version of clang it was built against. Thus we also make it depend on linux64-clang-7. But changing the dependency is not enough, cf. bug 1471905, so also touch its build script, which it turns out, we need to do anyways because llvm-dsymutil was renamed to dsymutil. Relatedly, all toolchains that are built using cctools-port need to use linux64-clang-7 too. Building compiler-rt 7 with the OSX 10.11 SDK fails because of some newer APIs being used in compiler-rt for xray, but this is not a feature we use, so disable that. Differential Revision: https://phabricator.services.mozilla.com/D6766
70984251b17425dc35f140dbca8097064184afc5: Bug 1492584, part 1 - Eagerly initialize nsLayoutModule in the component manager. r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 24 Oct 2018 16:10:29 +0000 - rev 491183
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492584, part 1 - Eagerly initialize nsLayoutModule in the component manager. r=froydnj nsLayoutModule must be initialized in order to call into JS, but I don't want to have to rely on calling a service in that module. Instead, always initialize the module very early in component manager initialization. This also makes initialization more consistent, so things like errors in manifests won't affect when it happens, which can result in different behavior in different builds. I also made nsLayoutModule initialization infallible, because I can't imagine that we can do much that is useful without it. Another change I made is that gInitialized is set to true even in a GPU process. This simplifies checking whether initialization has happened already when we start up the layout module. Differential Revision: https://phabricator.services.mozilla.com/D9583
cc08f0f9cd01231b0b55f77cfc26b2b18c9d23bb: Bug 1501531 - Update ccache stats parser for ccache 3.5 release. r=froydnj
Ting-Yu Lin <tlin@mozilla.com> - Wed, 24 Oct 2018 17:33:39 +0000 - rev 491176
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501531 - Update ccache stats parser for ccache 3.5 release. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D9613
b283e9a224e0450ff9880af7b7366f9e73661ac5: Bug 1402282 - Move CSPRNG logic to common area r=froydnj
Cosmin Sabou <csabou@mozilla.com> - Wed, 24 Oct 2018 02:49:33 +0300 - rev 491033
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1402282 - Move CSPRNG logic to common area r=froydnj
52d8c77e0718743635379b1354ed44e1fb055394: Bug 1500102 - Build the mingw static libc++ with debug information r=froydnj
Tom Ritter <tom@mozilla.com> - Thu, 18 Oct 2018 09:17:07 -0500 - rev 490988
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500102 - Build the mingw static libc++ with debug information r=froydnj
b0efa0731412c1fef077a02c3683a90a36352218: Bug 1500102 - Build the mingw static libc++ with debug information r=froydnj
Tom Ritter <tom@mozilla.com> - Thu, 18 Oct 2018 09:17:07 -0500 - rev 490977
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500102 - Build the mingw static libc++ with debug information r=froydnj
918d2aeb31eb7d18603be0c5f6ae9b27c12b6fc2: Bug 1500803 - Convert fxc2 to the mingw-clang toolchain r=froydnj
Tom Ritter <tom@mozilla.com> - Sun, 21 Oct 2018 09:10:50 -0500 - rev 490918
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500803 - Convert fxc2 to the mingw-clang toolchain r=froydnj This required bumping wine since the ucrt bits we needed are not in the old version of wine we were using.
dfa1eb1d036fc0b11a449627c0a69702b3f6309f: Bug 1499534: Add Pause, Resume, and IsPaused methods to ThrottledEventQueue. r=froydnj
Jim Blandy <jimb@mozilla.com> - Tue, 23 Oct 2018 06:21:10 +0000 - rev 490849
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499534: Add Pause, Resume, and IsPaused methods to ThrottledEventQueue. r=froydnj Depends on D8913 Differential Revision: https://phabricator.services.mozilla.com/D8914
ded047a09c690d95cbe1a2c8babdfa8d917cf29b: Bug 1497707, part 5 - Inline mozilla::ModuleLoader into mozJSComponentLoader. r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 23 Oct 2018 00:46:49 +0000 - rev 490836
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 5 - Inline mozilla::ModuleLoader into mozJSComponentLoader. r=froydnj Now that the XPCOM component loader infrastructure has stopped pretending to support other file extensions, this intermediate interface is no longer needed. Depends on D8171 Differential Revision: https://phabricator.services.mozilla.com/D8172
e44f3f8cde9c63cc407b959f816d2999a0200eec: Bug 1497707, part 4 - Only support loading JS files in the component manager. r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 23 Oct 2018 00:47:38 +0000 - rev 490835
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 4 - Only support loading JS files in the component manager. r=froydnj JS is the only file extension actually supported, and there are a few layers of cruft that can be eliminated if we specialize it. This eliminates one XPCOM registration of the JS component loader. Depends on D8170 Differential Revision: https://phabricator.services.mozilla.com/D8171
3db6926e3e4441e726a4163f2a60da58584f76b6: Bug 1497707, part 3 - Remove various unused things from nsComponentManager. r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 23 Oct 2018 00:47:31 +0000 - rev 490834
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 3 - Remove various unused things from nsComponentManager. r=froydnj Depends on D8169 Differential Revision: https://phabricator.services.mozilla.com/D8170
bd13c578aceb65c8af0e760a2279db486b91e578: Bug 1497707, part 2 - The second argument to nsComponentManagerImpl::RegisterModule is always null. r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 23 Oct 2018 00:47:24 +0000 - rev 490833
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 2 - The second argument to nsComponentManagerImpl::RegisterModule is always null. r=froydnj This allows some code to be deleted, including a KnownModule ctor. Depends on D8168 Differential Revision: https://phabricator.services.mozilla.com/D8169
09a38fc0ac95612377bc130dd1241c8faa7edf91: Bug 1500259 - update rkv to 0.5 and uuid to 0.6 r=froydnj
Myk Melez <myk@mykzilla.org> - Mon, 22 Oct 2018 16:31:40 +0000 - rev 490786
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500259 - update rkv to 0.5 and uuid to 0.6 r=froydnj Updating rkv to 0.5 enables us to un-vendor new-ordered-float, as rkv 0.4 is the last crate in the tree that depends on it. It also enables us to un-vendor version 0.5 of uuid. We previously needed that version because multiple third-party crates depended on it, and we have limited control over third-party sub-dependencies. But rkv 0.4 was the last third-party crate that still depended on version 0.5 of uuid; rkv 0.5 depends on version 0.6 of uuid. There would still be two internal crates that depend on version 0.5 of uuid: geckodriver and webrender_bindings. But we have more control over internal sub-dependencies, and we can update those two internal crates to depend on version 0.6 of uuid. This patch does so. To summarize, this patch makes the following changes: * rkv: 0.4 -> 0.5 * new-ordered-float: un-vendored * geckodriver: uuid dependency 0.5 -> 0.6 * webrender_bindings: uuid dependency 0.5 -> 0.6 * uuid 0.5: un-vendored * uuid 0.6: remains in tree Differential Revision: https://phabricator.services.mozilla.com/D9160
4a1ac74c37a8c1bbb99c000c43638279cbb08ec6: Bug 1499534: Add GTests for ThrottledEventQueue. r=froydnj
Jim Blandy <jimb@mozilla.com> - Mon, 22 Oct 2018 14:47:44 +0000 - rev 490783
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499534: Add GTests for ThrottledEventQueue. r=froydnj This was already reviewed and approved in bug 1426467. Differential Revision: https://phabricator.services.mozilla.com/D8913
178100c1204ca777a4d263f6d92dfca94333570a: Bug 1431441 - Part 7 - Relax WebReplay fcntl rules to avoid sqlite crash r=froydnj
Haik Aftandilian <haftandilian@mozilla.com> - Thu, 18 Oct 2018 20:53:48 +0000 - rev 490780
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1431441 - Part 7 - Relax WebReplay fcntl rules to avoid sqlite crash r=froydnj Patch provided by Brian Hackett <bhackett@mozilla.com>. Only allow a limited set of commands to be used when events are not passed through and we are recording/replaying the outputs. Depends on D8474 Differential Revision: https://phabricator.services.mozilla.com/D8475
507a9e5aaeea48bcf83b11022568a07718ca321a: Bug 1497476 - Clang-format nsTransferable.cpp. r=froydnj
Tom Schuster <evilpies@gmail.com> - Wed, 17 Oct 2018 16:48:43 +0000 - rev 490588
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497476 - Clang-format nsTransferable.cpp. r=froydnj Running clang-format makes this code at least a bit more pleasant to look at. Differential Revision: https://phabricator.services.mozilla.com/D8074
09a979b6e583eab5833722f358c3a26e0b89a3a2: Bug 1488808 Part 16 - Avoid deadlocking in a few places after diverging from the recording, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:15:41 -0600 - rev 490283
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488808 Part 16 - Avoid deadlocking in a few places after diverging from the recording, r=froydnj.
baaaaa544bb0da29752973de7ce72a7d8d5ee84a: Bug 1488808 Part 10 - Notify the record/replay system when a message pump thread blocks after diverging from the recording, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:05:02 -0600 - rev 490277
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488808 Part 10 - Notify the record/replay system when a message pump thread blocks after diverging from the recording, r=froydnj.
0ce807f9d1f679c848341e4858df243a5c127bdf: Bug 1488808 Part 9 - Specify regions of code where recording is not interrupted and threads can diverge, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:04:29 -0600 - rev 490276
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488808 Part 9 - Specify regions of code where recording is not interrupted and threads can diverge, r=froydnj.
0130de663e9f9006da9381d89967758af9974224: Bug 1488808 Part 8 - Redirection changes for supporting layout and painting after diverging from the recording, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:04:01 -0600 - rev 490275
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488808 Part 8 - Redirection changes for supporting layout and painting after diverging from the recording, r=froydnj.
b6ca168b7e52bff9f36a6ca07c1dab6750c87882: Bug 1488808 Part 7 - Keep track of the PID of the recording process, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:02:02 -0600 - rev 490274
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488808 Part 7 - Keep track of the PID of the recording process, r=froydnj.
4478e865d77054f42534630aca3d85d41e810f44: Bug 1488808 Part 5 - Add infrastructure for performing system calls in the middleman process, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 10:00:58 -0600 - rev 490272
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488808 Part 5 - Add infrastructure for performing system calls in the middleman process, r=froydnj.
42143e96a1ea13f9b5adaf0ae4e9b8f3c9cdb200: Bug 1488808 Part 1 - Fix return value sets in Preamble_Veto, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Wed, 17 Oct 2018 09:58:50 -0600 - rev 490268
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488808 Part 1 - Fix return value sets in Preamble_Veto, r=froydnj.
2da6504c901e9474566aa1663d907bd58bed9edb: Bug 1496581 - Split nsISeekableStream in 2 classes: nsISeekableStream and nsITellableStream, f=mayhemer, r=froydnj
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 18 Oct 2018 13:35:35 +0200 - rev 490223
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496581 - Split nsISeekableStream in 2 classes: nsISeekableStream and nsITellableStream, f=mayhemer, r=froydnj In the current code there are 3 main issues: 1. nsFileStream is not really thread-safe. There is nothing to protect the internal members and we see crashes. 2. nsPipeInputStream doesn't implement ::Seek() method and that caused issues in devtools when a nsHttpChannel sends POST data using a pipe. In order to fix this, bug 1494176 added a check in nsHttpChannel: if the stream doesn't implement ::Seek(), let's clone it. This was an hack around nsPipeInputStream, and it's bad. 3. When nsHttpChannel sends POST data using a file stream, nsFileStream does I/O on main-thread because of the issue 2. Plus, ::Seek() is called on the main-thread causing issue 1. Note that nsPipeInputStream implements only ::Tell(), of the nsISeekableStream methods. It doesn't implement ::Seek() and it doesn't implement ::SetEOF(). With this patch I want to fix point 2 and point 3 (and consequentially issue 1 - but we need a separate fix for it - follow up). The patch does: 1. it splits nsISeekableStream in 2 interfaces: nsITellableStream and nsISeekableStream. 2. nsPipeInputStream implements only nsITellableStream. Doing this, we don't need the ::Seek() check for point 2 in nsHttpChannel: a simple QI check is enough. 3. Because we don't call ::Seek() in nsHttpChannel, nsFileStream doesn't do I/O on the main-thread, and we don't crash doing so.
ca4774548edb6ce092a600e246865e6111cee3d5: Bug 1499534: Add GTests for ThrottledEventQueue. r=froydnj
Jim Blandy <jimb@mozilla.com> - Wed, 17 Oct 2018 21:34:57 +0000 - rev 490192
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499534: Add GTests for ThrottledEventQueue. r=froydnj This was already reviewed and approved in bug 1426467. Differential Revision: https://phabricator.services.mozilla.com/D8913
bb1b80139e377d9f5202e9fa1b94d39985381caf: Bug 1497707, part 5 - Inline mozilla::ModuleLoader into mozJSComponentLoader r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:43 +0000 - rev 490177
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 5 - Inline mozilla::ModuleLoader into mozJSComponentLoader r=froydnj Now that the XPCOM component loader infrastructure has stopped pretending to support other file extensions, this intermediate interface is no longer needed. Depends on D8171 Differential Revision: https://phabricator.services.mozilla.com/D8172
11c813f192e21cec64b252515c6b89d37b255300: Bug 1497707, part 4 - Only support loading JS files in the component manager r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:43 +0000 - rev 490176
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 4 - Only support loading JS files in the component manager r=froydnj JS is the only file extension actually supported, and there are a few layers of cruft that can be eliminated if we specialize it. This eliminates one XPCOM registration of the JS component loader. Depends on D8170 Differential Revision: https://phabricator.services.mozilla.com/D8171
32595f9e73d376499b5d1d26b1954a37a9c7e600: Bug 1497707, part 3 - Remove various unused things from nsComponentManager r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:42 +0000 - rev 490175
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 3 - Remove various unused things from nsComponentManager r=froydnj Depends on D8169 Differential Revision: https://phabricator.services.mozilla.com/D8170
f37f2d39ec9cddf0d6fed933422c854bfebca488: Bug 1497707, part 2 - The second argument to nsComponentManagerImpl::RegisterModule is always null r=froydnj
Andrew McCreight <continuation@gmail.com> - Wed, 17 Oct 2018 20:45:42 +0000 - rev 490174
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497707, part 2 - The second argument to nsComponentManagerImpl::RegisterModule is always null r=froydnj This allows some code to be deleted, including a KnownModule ctor. Depends on D8168 Differential Revision: https://phabricator.services.mozilla.com/D8169
63248a593eae0a14ffc33ab0057cf41d3ecb8018: Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj
Nick Alexander <nalexander@mozilla.com> - Wed, 17 Oct 2018 19:46:03 +0000 - rev 490156
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj The desired outcome of this change is that we'll set -Wl,--version-script based on linker kind and not on the output of $LINKER -v. This is a cheap way to address a simple problem that has a complicated ideal solution. The underlying issue is that in some situations, when targeting Android, a macOS system ld is interrogated to determine if a cross-compiling linker "is GNU ld" and a particular linker feature is set in that situation. The macOS system ld doesn't pass the "is GNU ld" test, and the linker feature isn't set; that causes link failures, even though the actual linker has nothing to do with the system ld. The ideal solution is to test for linker capabilities dynamically. We do a lot of that in old-configure.in, and we don't do any of that in toolchain.configure. Rather than start testing in toolchain.configure, we hard-code: a cheap solution to the immediate problem. MinGW suffers somewhat from the opposite problem: the linker "is GNU ld" (compatible), but the linker checks don't happen at all. We hard-code for MinGW based on the C compiler instead. Differential Revision: https://phabricator.services.mozilla.com/D8471
3eb04f5363eb661fa2ae544a934a7ace85b65282: Bug 1496179 - Make mozglue.dll a private SxS assembly. r=aklotz,froydnj
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 10 Oct 2018 22:57:53 +0900 - rev 490138
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496179 - Make mozglue.dll a private SxS assembly. r=aklotz,froydnj SxS assemblies do not obey the usual DLL search order. It will make it possible to load mozglue.dll from appdir even if the PreferSystem32Images mitigation is enabled and System32 has a random mozglue.dll.
06e5a5bfd05ef276dce035af837f2ba76e9a55a4: Bug 1498938 - Support [implicit_jscontext] XPIDL calls on Linux/PPC64.; r=froydnj
A. Wilcox <AWilcox@Wilcox-Tech.com> - Wed, 17 Oct 2018 23:12:51 +0000 - rev 490123
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498938 - Support [implicit_jscontext] XPIDL calls on Linux/PPC64.; r=froydnj
a64b17b18dae852bae1de933d840b823f8f1b643: Bug 1495574 - Support copying ip-relative xchg instructions, r=froydnj.
Brian Hackett <bhackett1024@gmail.com> - Sun, 14 Oct 2018 09:48:34 -0600 - rev 489966
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1495574 - Support copying ip-relative xchg instructions, r=froydnj.
e85db490e17a596a40eb8bc2a3d2787a77c41d50: Bug 1499462: Remove dead failure handling and comments from ThrottledEventQueue::Create. r=froydnj
Jim Blandy <jimb@mozilla.com> - Tue, 16 Oct 2018 21:24:48 +0000 - rev 489940
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499462: Remove dead failure handling and comments from ThrottledEventQueue::Create. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D8890
3361fcc40ea294df9eed70a218c0eafe11bf60a7: Bug 1497446 - Follow-up to repair incorrect vendoring of lalrpop-snap. r=froydnj
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 16 Oct 2018 15:25:03 +0000 - rev 489863
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497446 - Follow-up to repair incorrect vendoring of lalrpop-snap. r=froydnj This (large) file exists in the lalrpop-snap crate and should be part of the vendoring of that crate. However it seems to have been accidentally removed in bug 1497446. This patch adds it back by running ./mach vendor rust --build-peers-said-large-imports-were-ok on a clean m-c tree. Differential Revision: https://phabricator.services.mozilla.com/D8863
a3521c2b925b7ab1847031a027730962179eea9e: Bug 1498404 - Fix some errors in manifests r=froydnj
Andrew McCreight <continuation@gmail.com> - Tue, 16 Oct 2018 13:26:23 +0000 - rev 489858
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498404 - Fix some errors in manifests r=froydnj In FxAccountsComponents.manifest, the previous line registers the component CID, but only for the main process. This means we hit an error while parsing the manifest in the child process, because the CID is not recognized. The fix is simply to not try to use the CID to register the contract in the child process. As for the rest of the changes, since bug 1438688, XPT information is compiled into the Firefox binary, so the interfaces manifest entry is no longer needed. This patch removes instances of this line from manifest files. This makes some manifest files empty, so the patch also removes the now-empty files. Differential Revision: https://phabricator.services.mozilla.com/D8751
5687061cc8320ab2f339766cb1cf0c0877deee72: Bug 1498637 - Use __gcov_flush to implement dumping and resetting instead of __gcov_dump and __gcov_reset. r=froydnj
Marco Castelluccio <mcastelluccio@mozilla.com> - Mon, 15 Oct 2018 10:36:45 +0200 - rev 489816
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498637 - Use __gcov_flush to implement dumping and resetting instead of __gcov_dump and __gcov_reset. r=froydnj
1f5478a63db8a1f606ad2fd6ead34b5d91712357: Bug 1495669: Share bindgen flags globally; r=emilio, r=froydnj
Benjamin Bouvier <benj@benj.me> - Tue, 09 Oct 2018 15:01:52 +0200 - rev 489570
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1495669: Share bindgen flags globally; r=emilio, r=froydnj
b8d90d5901bec950a7fe1a1763b17c3d401e59b8: Bug 1498767 - Add missing MFBT tests to testing/cppunittest.py. r=froydnj
Botond Ballo <botond@mozilla.com> - Sat, 13 Oct 2018 21:54:27 +0000 - rev 489501
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498767 - Add missing MFBT tests to testing/cppunittest.py. r=froydnj Also add a comment to mfbt/tests/moz.build to remind people that tests need to be added to testing/cppunittest.py. Differential Revision: https://phabricator.services.mozilla.com/D8664
91300d29898b1a1102e1b62164aeee1f56b2ee86: Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj
Nick Alexander <nalexander@mozilla.com> - Fri, 12 Oct 2018 22:38:44 +0000 - rev 489421
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489443 - Set GCC_USE_GNU_LD based on linker kind. r=froydnj The desired outcome of this change is that we'll set `-Wl,--version-script` based on linker kind and not on the output of `$LINKER -v`. This is a cheap way to address a simple problem that has a complicated ideal solution. The underlying issue is that in some situations, when targeting Android, a macOS system `ld` is interrogated to determine if a cross-compiling linker "is GNU ld" and a particular linker feature is set in that situation. The macOS system `ld` doesn't pass the "is GNU ld" test, and the linker feature isn't set; that causes link failures, even though the actual linker has nothing to do with the system `ld`. The ideal solution is to test for linker capabilities dynamically. We do a lot of that in old-configure.in, and we don't do any of that in toolchain.configure. Rather than start testing in toolchain.configure, we hard-code: a cheap solution to the immediate problem. Differential Revision: https://phabricator.services.mozilla.com/D8471
a232864e100291f7fe7e7b60745aae2094786b43: Bug 1498450 - Avoid the footgun from @depends-function comparison r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Fri, 12 Oct 2018 13:44:08 +0000 - rev 489415
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498450 - Avoid the footgun from @depends-function comparison r=froydnj While we do have some uses of @depends-function comparison in some templaces, related to host/target, we ought to be using `is` comparisons rather than `==` anyways, so we switch those, and prevent other kinds of comparisons being used at all. This unveils the one noted in https://phabricator.services.mozilla.com/D7713?id=21357#inline-30414 (and surprisingly only that one), that we remove entirely since it was doing nothing in practice. Bug 1492305 will have to add it back in a proper form. Differential Revision: https://phabricator.services.mozilla.com/D8501
5855ac73f9d73828dc7e556dbd02fc30e7f5021f: Bug 1427808 - Remove the now-unused win64-clang-cl-st-an toolchain. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 12 Oct 2018 07:15:00 -0400 - rev 489409
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1427808 - Remove the now-unused win64-clang-cl-st-an toolchain. r=froydnj
28f93e22d7967f516870629a62e0daba5b529154: Bug 1427808 - Static analysis builds no longer need to force the use of link.exe. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 12 Oct 2018 07:14:00 -0400 - rev 489408
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1427808 - Static analysis builds no longer need to force the use of link.exe. r=froydnj
5f551081abcba592d7b404b7975d46e42e5e7984: Bug 1427808 - Make static analysis builds use the main win64-clang-cl toolchain. r=froydnj
David Major <dmajor@mozilla.com> - Fri, 12 Oct 2018 07:14:00 -0400 - rev 489407
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1427808 - Make static analysis builds use the main win64-clang-cl toolchain. r=froydnj