searching for reviewer(dholbert)
1c2698dc96cb707f7979e5eadef311fc0f4c8c35: Bug 1498273 Part 4: Add tests of FlexItem clampState. r=dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 25 Oct 2018 00:14:40 +0000 - rev 491247
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498273 Part 4: Add tests of FlexItem clampState. r=dholbert Depends on D9447 Differential Revision: https://phabricator.services.mozilla.com/D8776
a40344d98665905cd05f742e38cbe93f3bc7b5d4: Bug 1498273 Part 3: Define and set ComputedFlexItemInfo::mClampState. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 24 Oct 2018 23:47:23 +0000 - rev 491246
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498273 Part 3: Define and set ComputedFlexItemInfo::mClampState. r=dholbert Depends on D9727 Differential Revision: https://phabricator.services.mozilla.com/D9728
28d81e5c33d8e04494ad4455a8d7cf5a0813083f: Bug 1498273 Part 2: Change mHasMinViolation and mHasMaxViolation to also track clamp state after item freeze. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 24 Oct 2018 23:46:39 +0000 - rev 491245
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498273 Part 2: Change mHasMinViolation and mHasMaxViolation to also track clamp state after item freeze. r=dholbert Depends on D8769 Differential Revision: https://phabricator.services.mozilla.com/D9727
24b46ea119a07030f321c71007d158277d919e1a: Bug 1498273 Part 1: Updated Flex.webidl to add a per-item clamp state attribute. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 24 Oct 2018 23:46:16 +0000 - rev 491244
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498273 Part 1: Updated Flex.webidl to add a per-item clamp state attribute. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D8769
915d77bbcf8b9eafb9a51af01e06c146175f1dfc: Bug 1501057 - Trivial clipPaths should respect visibility=hidden r=dholbert
longsonr <longsonr@gmail.com> - Wed, 24 Oct 2018 06:01:57 +0100 - rev 491049
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501057 - Trivial clipPaths should respect visibility=hidden r=dholbert
ec3c914d6136944e6803e1596d383d9cd64fba64: Bug 1501109 Part 2: Update test expectations for flex line growth state. r=dholbert
Brad Werth <bwerth@mozilla.com> - Tue, 23 Oct 2018 16:24:00 +0000 - rev 490950
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501109 Part 2: Update test expectations for flex line growth state. r=dholbert Depends on D9454 Differential Revision: https://phabricator.services.mozilla.com/D9455
19472cba78cc8439d0b1007ce1d4a8b3f2fcd592: Bug 1501109 Part 1: Change Flex API growth state to match layout algorithm, and use enums from webidl. r=dholbert
Brad Werth <bwerth@mozilla.com> - Tue, 23 Oct 2018 16:23:37 +0000 - rev 490949
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501109 Part 1: Change Flex API growth state to match layout algorithm, and use enums from webidl. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D9454
88c9e1c85918410a8d6bd10c25b4e1b17b5b58fc: Bug 1448317 - Don't include absolutely-positioned and float children in element outline. r=dholbert
Xidorn Quan <me@upsuper.org> - Tue, 23 Oct 2018 06:37:16 +0000 - rev 490871
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448317 - Don't include absolutely-positioned and float children in element outline. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D9349
e1fde2f49f84ca071bc41175b3335969b974c88b: Bug 1500609 part 1 - Add a nsFlexContainerFrame method to remove cached data that depend on flex items' intrinsic isize (idempotent patch). r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 22 Oct 2018 00:54:57 +0200 - rev 490614
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500609 part 1 - Add a nsFlexContainerFrame method to remove cached data that depend on flex items' intrinsic isize (idempotent patch). r=dholbert
49e1cc5fdf49b102fa27980622087fc550ed93bb: Bug 1497589 Part 5: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 17 Oct 2018 20:23:27 +0000 - rev 490307
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497589 Part 5: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert Depends on D8617 Differential Revision: https://phabricator.services.mozilla.com/D8618
d8e73cf6952fd03c118b8cdd3cc97a8f59045f95: Bug 1497589 Part 4: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 17 Oct 2018 20:23:09 +0000 - rev 490306
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497589 Part 4: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert Depends on D8616 Differential Revision: https://phabricator.services.mozilla.com/D8617
082aaca611f9f0e13cd82d6cc708b687cfd35b7c: Bug 1497589 Part 3: Stub in physical direction enums for Flex API main and cross axes. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 17 Oct 2018 20:22:46 +0000 - rev 490305
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497589 Part 3: Stub in physical direction enums for Flex API main and cross axes. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D8616
d0b82fc9252d1c017cfd7e3381873c9e2ee9ee8f: Bug 1497589 Part 2: Rename Flex API classes to avoid namespace collision with nsFlexContainerFrame classes. r=dholbert
Brad Werth <bwerth@mozilla.com> - Wed, 17 Oct 2018 20:22:26 +0000 - rev 490304
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497589 Part 2: Rename Flex API classes to avoid namespace collision with nsFlexContainerFrame classes. r=dholbert Depends on D9022 Differential Revision: https://phabricator.services.mozilla.com/D9023
c597d36a2d7ac1b32de3d57054a87176737ae814: Bug 1497589 Part 1: Move Flex.webidl to the chrome-webidl directory. r=bzbarsky,dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 18 Oct 2018 00:08:02 +0000 - rev 490303
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497589 Part 1: Move Flex.webidl to the chrome-webidl directory. r=bzbarsky,dholbert Differential Revision: https://phabricator.services.mozilla.com/D9022
af0263577e4d16da5c44df23ef5a44685c07a4d0: Bug 1495892 - Aggregates in c++2a can't have deleted ctors. r=dholbert
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 16 Oct 2018 19:39:37 +0000 - rev 489883
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1495892 - Aggregates in c++2a can't have deleted ctors. r=dholbert GLContextSymbols previously had a deleted default ctor to prevent accidentally leaving its members uninitialized, instead of zeroing with aggregate initialization. Differential Revision: https://phabricator.services.mozilla.com/D8796
83fca840ea7f02901d0ad92a09a28120b1bc82a6: Bug 1490747 part 2 - Center the <legend> border-box (not its margin-box) within the <fieldset> border area. (tests) r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 12 Oct 2018 21:36:04 +0200 - rev 489311
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1490747 part 2 - Center the <legend> border-box (not its margin-box) within the <fieldset> border area. (tests) r=dholbert
8f7a45eb3e5116e2ff06d867a14a2464f0bab306: Bug 1490747 part 1 - Center the <legend> border-box (not its margin-box) within the <fieldset> border area. r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 12 Oct 2018 21:36:03 +0200 - rev 489310
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1490747 part 1 - Center the <legend> border-box (not its margin-box) within the <fieldset> border area. r=dholbert
f3480613106993d658f9b5a46f41e59ca9934a5e: Bug 1496833 - Add a reftest that depends on ancestor intrinsics being cleared on bsize changes. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 09 Oct 2018 17:52:55 +0000 - rev 488652
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496833 - Add a reftest that depends on ancestor intrinsics being cleared on bsize changes. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D7921
4e07d3243403123217539ce6d328641daa0513da: Bug 1491235: [css-contain] Make 'contain:layout' (not 'contain:size') suppress baseline measurements r=dholbert
Manuel Rego Casasnovas <rego@igalia.com> - Tue, 09 Oct 2018 14:13:13 -0700 - rev 488594
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491235: [css-contain] Make 'contain:layout' (not 'contain:size') suppress baseline measurements r=dholbert The CSSWG has recently resolved that layout containment suppress baseline alignment, while size containment does not: https://github.com/w3c/csswg-drafts/issues/2995 Spec text (https://drafts.csswg.org/css-contain/#containment-layout): "7. For the purpose of the vertical-align property, or any other property whose effects need to relate the position of the containing element's baseline to something other than its descendants, the containing element is treated as having no baseline." And a note in (https://drafts.csswg.org/css-contain/#containment-size): "Note: size containment does not suppress baseline alignment. See layout containment for that." This patch does this change just switching IsContainSize() by IsLayoutSize() in several places related to baseline alignment in the source code. With the patch several WPT tests start to pass. Apart from that, some of the tests under vendor-imports are updated to follow the new behavior.
6daf79d1bace1f7169901b91203655988ee5e11f: Bug 1495169 - Remove cached measuring reflows if we aren't measuring the right thing because we got interrupted. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 04 Oct 2018 20:24:04 +0000 - rev 488070
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495169 - Remove cached measuring reflows if we aren't measuring the right thing because we got interrupted. r=dholbert If we're waiting on an interrupt, then our child items haven't been totally reflowed and our measures would be bogus. This will probably regress performance in the cases bug 1209697 fixed, so we should probably add an interrupt check somewhere in nsFlexContainerFrame to avoid keeping reflowing flex containers indefinitely. We could probably just bail out from our reflow if any kid reflow was interrupted. Filed bug 1495532 to consider that. Differential Revision: https://phabricator.services.mozilla.com/D7288
e887b26390ec2f660536f6cac5d63e40163c182b: Bug 1290420 Part 2: Respect the metaViewportOverride flag on the docshell. r=dholbert
Botond Ballo <botond@mozilla.com>, Brad Werth <bwerth@mozilla.com> - Thu, 04 Oct 2018 00:19:40 +0000 - rev 488023
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1290420 Part 2: Respect the metaViewportOverride flag on the docshell. r=dholbert Depends on D3373 Differential Revision: https://phabricator.services.mozilla.com/D3375
72d5f7a7f6eccc258f0779915c25d464784215d7: Bug 1494694: Improve a comment in the ComputedFlexItemInfo structure header. r=dholbert
Brad Werth <bwerth@mozilla.com> - Mon, 01 Oct 2018 16:08:00 +0000 - rev 487352
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494694: Improve a comment in the ComputedFlexItemInfo structure header. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D7115
e0409191447598c31c52a4d4296a897413693dbb: Bug 1338158: use 'unset' value more in UA stylesheets, in cases where we're already just resetting the property. r=dholbert
Yatri <yatripatel.169@gmail.com> - Sat, 22 Sep 2018 11:46:06 -0700 - rev 486150
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1338158: use 'unset' value more in UA stylesheets, in cases where we're already just resetting the property. r=dholbert
dc6c04a63309d3461c0ca9dc23ae186a91deb8c6: Bug 1396642 - support smaller viewBox coordinates at the expense of larger ones r=dholbert
Robert Longson <longsonr@gmail.com> - Tue, 18 Sep 2018 19:43:53 +0100 - rev 485409
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1396642 - support smaller viewBox coordinates at the expense of larger ones r=dholbert
0273829e46ea49c8f4c2213c2c7282be99b170c5: Bug 1491731 - [css-text-3] Resolve 'text-indent' using a zero percentage basis in intrinsic sizing. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 17 Sep 2018 20:14:24 +0200 - rev 485126
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491731 - [css-text-3] Resolve 'text-indent' using a zero percentage basis in intrinsic sizing. r=dholbert Per CSSWG resolution: https://github.com/w3c/csswg-drafts/issues/1597#issuecomment-406001183
f3bf35137fe85853783b22de09ad05f29e18d395: Bug 1489149 - Check all child lists for children, not just the principal list. r=dholbert
Mats Palmgren <mats@mozilla.com> - Sun, 16 Sep 2018 20:36:48 +0200 - rev 484954
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489149 - Check all child lists for children, not just the principal list. r=dholbert
df4e19315cd308ce146ffb6dd81385b4e690833a: Bug 1490730 part 1 - [css-grid] Static position should use content-box, not padding-box. r=dholbert
Mats Palmgren <mats@mozilla.com> - Sat, 15 Sep 2018 01:30:18 +0200 - rev 484800
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490730 part 1 - [css-grid] Static position should use content-box, not padding-box. r=dholbert
a6eb531e1216a2c78fc2ee36d9d52eec8bd5d636: Bug 1290420 Part 2: Respect the metaViewportOverride flag on the docshell. r=dholbert
Botond Ballo <botond@mozilla.com>, Brad Werth <bwerth@mozilla.com> - Tue, 11 Sep 2018 15:17:24 +0000 - rev 484424
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1290420 Part 2: Respect the metaViewportOverride flag on the docshell. r=dholbert Depends on D3373 Differential Revision: https://phabricator.services.mozilla.com/D3375
2ca4150b4f77a3d300d9153e99e6f3bf99109972: Bug 1490525 Part 3 - Remove unused #includes in nsColumnSetFrame.cpp r=dholbert
Ting-Yu Lin <aethanyc@gmail.com> - Wed, 12 Sep 2018 20:37:20 +0000 - rev 484411
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490525 Part 3 - Remove unused #includes in nsColumnSetFrame.cpp r=dholbert Verified locally by s/UNIFIED_SOURCES/SOURCES/ in layout/generic/moz.build. Differential Revision: https://phabricator.services.mozilla.com/D5636
69658275272a9439305358857a9c609f23ffc229: Bug 1490525 Part 2 - Convert nsColumnSetFrame's reflow logs by using MOZ_LOG r=dholbert
Ting-Yu Lin <aethanyc@gmail.com> - Wed, 12 Sep 2018 20:37:48 +0000 - rev 484410
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490525 Part 2 - Convert nsColumnSetFrame's reflow logs by using MOZ_LOG r=dholbert Since bug 775624, nsReflowStatus has become a class, not an integer. We need to expose operator<<() for nsReflowStatus to non-debug build to dump nsReflowStatus's content in MOZ_LOG. Differential Revision: https://phabricator.services.mozilla.com/D5635
643ffcb9063dfb9395c76d81665ed4cd03c0dff3: Bug 1490685 - Adjust an assertion. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 12 Sep 2018 17:25:15 +0200 - rev 484315
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490685 - Adjust an assertion. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D5676
ac14e03c37f0f20173b3f868963af26235e928e1: Bug 1490311 - Remove some other unused constructors / setters. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Sep 2018 17:57:15 +0200 - rev 484143
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490311 - Remove some other unused constructors / setters. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D5545
62172d3ec291d76748f73a53061bd2ef00737472: Bug 1490311 - Remove unused NS_ROUND_OFFSET_TO_PIXELS and SetColumnRuleWidth. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Sep 2018 17:05:09 +0200 - rev 484142
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490311 - Remove unused NS_ROUND_OFFSET_TO_PIXELS and SetColumnRuleWidth. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D5541
e40729af94e6197f871e7144596799b1bd4ba8c7: Bug 1490311 - Remove useless nsStyleFont constructor. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Sep 2018 16:44:38 +0200 - rev 484141
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490311 - Remove useless nsStyleFont constructor. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D5533
efa759ae5eb0ab65056a0d841974461b336f1106: Bug 1490311 - Remove unused nsStyleFont::{EnableZoom, UnZoomText}. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Sep 2018 16:19:55 +0200 - rev 484140
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490311 - Remove unused nsStyleFont::{EnableZoom, UnZoomText}. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D5530
a763a7590d5bc93fbfceded88ee0710c1ea49d87: Bug 1489863 - Add a crashtest. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Sep 2018 15:10:12 +0200 - rev 484133
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489863 - Add a crashtest. r=dholbert This crashtest is simpler than the one from bug 1489287, so I think we should land it. Differential Revision: https://phabricator.services.mozilla.com/D5523
21fc8a773b280d0abc62661591b0440e260e078a: Bug 1489770 - Don't convert InlineBreak::Before reflow status to Incomplete unless we know the child frame is splittable. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 11 Sep 2018 20:07:28 +0200 - rev 484080
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489770 - Don't convert InlineBreak::Before reflow status to Incomplete unless we know the child frame is splittable. r=dholbert
1719e0b4140df4657af0c05d18665f0af0f3e6dd: Bug 1489153 - Push any child next-in-flows in our principal list to OverflowList before starting our reflow. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 11 Sep 2018 20:07:28 +0200 - rev 484079
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489153 - Push any child next-in-flows in our principal list to OverflowList before starting our reflow. r=dholbert
584b58e90de79ea9b18fc9c94c12d5884861c725: Bug 1470462 - contain:size for nsGridContainerFrame - r=dholbert
Gerald Squelart <gsquelart@mozilla.com> - Tue, 11 Sep 2018 00:00:05 +0000 - rev 483979
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1470462 - contain:size for nsGridContainerFrame - r=dholbert When contain:size is set for a grid container, ignore sizes from children when computing own size during layout. Differential Revision: https://phabricator.services.mozilla.com/D4429
9a89fcb3c96c7641571e2283b81ebdb0ffc0da2e: Bug 1478485 - Use the stored CB on abs.pos. grid items when calculating used offset values. r=dholbert
Mats Palmgren <mats@mozilla.com> - Tue, 11 Sep 2018 00:57:53 +0200 - rev 483891
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1478485 - Use the stored CB on abs.pos. grid items when calculating used offset values. r=dholbert
68592cefee573b075b68880e65828e820e2e16ed: Bug 1488300 - Kick off external SVG resource loading from DidSetComputedStyle. r=dholbert
Xidorn Quan <me@upsuper.org> - Fri, 07 Sep 2018 21:08:44 +0000 - rev 483605
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1488300 - Kick off external SVG resource loading from DidSetComputedStyle. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D4901
ab7a4b7fca6579fdba4a1ff692a1e8ec020b0d14: Bug 1488657 - Have anonymous element in text input inherit scrollbar-width from the element. r=dholbert
Xidorn Quan <me@upsuper.org> - Thu, 06 Sep 2018 23:12:44 +0000 - rev 483486
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1488657 - Have anonymous element in text input inherit scrollbar-width from the element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D5101
d4191ae7bccdb97bac3463070adb4084e25706dc: Bug 1488657 - Have anonymous element in text input inherit scrollbar-width from the element. r=dholbert
Xidorn Quan <me@upsuper.org> - Thu, 06 Sep 2018 07:36:20 +0000 - rev 483406
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1488657 - Have anonymous element in text input inherit scrollbar-width from the element. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D5101
91a9eae5ae1ea30e45b016d58a15c44b327a5eef: Bug 1488219 - Mark nsDateTimeControlFrame as a leaf frame. r=dholbert
Ting-Yu Lin <aethanyc@gmail.com> - Wed, 05 Sep 2018 00:27:43 +0000 - rev 483072
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1488219 - Mark nsDateTimeControlFrame as a leaf frame. r=dholbert nsDateTimeControlFrame should be a leaf like all the other <input> frames like nsTextControlFrame, nsCheckboxRadioFrame, etc. Differential Revision: https://phabricator.services.mozilla.com/D4985
8f1ffafbdb88d9ea8c1a7cfd7dfb7bc219322d80: Bug 1486115 - use mozilla::IsAsciiDigit and mozilla::AsciiAlphanumericToNumber r=dholbert
Robert Longson <longsonr@gmail.com> - Fri, 31 Aug 2018 16:55:04 +0100 - rev 482610
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1486115 - use mozilla::IsAsciiDigit and mozilla::AsciiAlphanumericToNumber r=dholbert
e36b98a79cd85470eef43718b9c32c8bde54e3fd: Bug 1486488 - Don't assume that SVGAnimationElement has a parent on bind. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 Aug 2018 09:06:08 +0000 - rev 481951
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1486488 - Don't assume that SVGAnimationElement has a parent on bind. r=dholbert This is a regression from bug 1450250, which removed a if (!GetCx()) early return in this function. That early return was wrong, both because it prevented elements that were in shadow trees from targeting other elements, but also because that check was not present in AfterSetAttr, which means that dynamic updates to the attribute would work. Pass the SVGAnimationElement itself to resolve references. That's what we do for attribute mutations, and also it's the same behavior we have, since the ID lookup IDTracker does only depends on containing shadow root and containing document, and that's invariant between a kid and it's DOM parent. Some other code has been updated to take references instead of pointers so the null-safety of those methods is explicit. Differential Revision: https://phabricator.services.mozilla.com/D4349
c673b6f64457db9dba65a2cc235b6a38f29aef14: Bug 1485495 - Use AutoRestore to restore aState.mAdditionalStateBits. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 27 Aug 2018 18:38:58 +0000 - rev 481932
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485495 - Use AutoRestore to restore aState.mAdditionalStateBits. r=dholbert Depends On D4020 Differential Revision: https://phabricator.services.mozilla.com/D4021
cb7af446b84177a4ee6cb18d31cbf52d026a6ac6: Bug 1485495 - Move column-span preference to StaticPrefList.h. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 27 Aug 2018 18:38:58 +0000 - rev 481930
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485495 - Move column-span preference to StaticPrefList.h. r=dholbert We can access the bool pref in C++ by writing if (StaticPrefs::layout_css_column_span_enabled()) { // do something } Differential Revision: https://phabricator.services.mozilla.com/D4020
fcae76a34c32ad73442d7440a203230c053a7649: Bug 1464723 - Implement custom scrollbar support for GTK widget. r=karlt,dholbert
Xidorn Quan <me@upsuper.org> - Fri, 24 Aug 2018 07:40:07 +0000 - rev 481709
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1464723 - Implement custom scrollbar support for GTK widget. r=karlt,dholbert When any scrollbar color is specified, or scrollbar-width is thin, we switch to use the fallback rendering. The change to xulscrollbars.css is for ensuring that the scrollbar is displayed for scrollbar-width: thin when there is no scrollbar color specified. It wouldn't affect cases where -moz-appearance takes effect. This also changes the fallback width of the scrollbars. Since the two widths was picked rather randomly, I think it should be fine to change it if a value looks better than the old one, especially on Linux which is the main usecase for this fallback rendering. Differential Revision: https://phabricator.services.mozilla.com/D3952
833c2ea661a64ed1bcbd8bbeef96e5fc29b1d42e: Bug 1483946 - Fix CSS containment issue with scrollable elements - r=dholbert
Gerald Squelart <gsquelart@mozilla.com> - Thu, 23 Aug 2018 15:55:54 +0000 - rev 481553
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483946 - Fix CSS containment issue with scrollable elements - r=dholbert Scrollable elements already trap all of their contents, nothing should spill out, so there is no need for special handling of the `contain` CSS property. Differential Revision: https://phabricator.services.mozilla.com/D3854