searching for reviewer(daisuke)
6dddfbd0f3fb9ff61ed5b061c5687ff07f0978f4: Bug 1494552 - Allow user to refresh USB devices. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Thu, 25 Oct 2018 11:29:11 +0000 - rev 491314
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494552 - Allow user to refresh USB devices. r=jdescottes,daisuke Adds a "Refresh devices button". I was unsure on whether this button should use state for this or just plug directly into the adb module. In the end I opted for doing it via actions/state because it would also allow us to show somewhere else an indication of whether the scanner is running or not (in case we need it). But if you think this is overkill, I'll gladly change it. To try it, with the device connected, open and close firefox. If you press Refresh you should see the list update. Differential Revision: https://phabricator.services.mozilla.com/D9500
ed6fb38d05c86fe07bf21d24c49e25ad90c29826: Bug 1488660 - Fix devtools tab reordering in RTL locales;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 19 Oct 2018 08:00:27 +0000 - rev 491211
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488660 - Fix devtools tab reordering in RTL locales;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6910
3a7ba1fe0277d580a678b86ab92d4496d4fe6681: Bug 1500062 - Add error logging middleware to new aboutdebugging;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 24 Oct 2018 17:24:56 +0000 - rev 491175
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500062 - Add error logging middleware to new aboutdebugging;r=ladybenko,daisuke Differential Revision: https://phabricator.services.mozilla.com/D9089
fc43dc9c58ef134764b0f21fea149438d14895ea: Bug 1497944 - Show wifi category but with disabled message;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 24 Oct 2018 12:02:17 +0000 - rev 491119
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497944 - Show wifi category but with disabled message;r=daisuke Depends on D9223 Differential Revision: https://phabricator.services.mozilla.com/D9224
6b8d7dcfe0e76208d6ddd3c79b94648d60ca95eb: Bug 1497944 - Hide wifi section in ConnectPage behind pref;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 24 Oct 2018 09:35:06 +0000 - rev 491118
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497944 - Hide wifi section in ConnectPage behind pref;r=daisuke Depends on D9222 . Differential Revision: https://phabricator.services.mozilla.com/D9223
399c3dbac7e2cb48a317268cf3593236fa826e64: Bug 1497944 - Drop the (Recommended) from WiFi section in Connect page;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 24 Oct 2018 09:33:55 +0000 - rev 491117
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497944 - Drop the (Recommended) from WiFi section in Connect page;r=daisuke WiFi is not even working at the moment, so it probably should not be tagged as recommended. Differential Revision: https://phabricator.services.mozilla.com/D9222
7e0caa46aba1915115b4a5dffe08633f9d213e79: Bug 1498150 - Show network location category but with disabled message;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 24 Oct 2018 09:30:53 +0000 - rev 491087
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498150 - Show network location category but with disabled message;r=ladybenko,daisuke Depends on D9122 This is a follow up to the first patch that restores the category, but shows a "disabled" message instead of the content Differential Revision: https://phabricator.services.mozilla.com/D9123
a9c39ecb125c5b6d3586f45cdca93547f863dfc2: Bug 1498150 - Hide networklocations form in ConnectPage behind pref;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 24 Oct 2018 09:27:55 +0000 - rev 491086
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498150 - Hide networklocations form in ConnectPage behind pref;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D9122
ad022c9aec53ad84e86d0164e1c3f100ae5449b1: Bug 1496400 - Remove common.css r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Mon, 22 Oct 2018 13:53:31 +0000 - rev 490680
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496400 - Remove common.css r=jdescottes,daisuke - Removed common.css - Re-ordered the loading of stylesheets, so components sheets are loaded _after_ the more generic rules - Refactored some of our components into more generic ones. Note that a few styles do not match exactly `common.css` (for instance, buttons' `min-height` and `min-width`), in favor of Photon. This might change later depending on the UX guidance we'll get eventually. Differential Revision: https://phabricator.services.mozilla.com/D8970
5ba65c3ad1ffc76c31dcfda165b87afc1269b415: Bug 1496400 - Remove common.css r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Fri, 19 Oct 2018 09:23:22 +0000 - rev 490472
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496400 - Remove common.css r=jdescottes,daisuke - Removed common.css - Re-ordered the loading of stylesheets, so components sheets are loaded _after_ the more generic rules - Refactored some of our components into more generic ones. Note that a few styles do not match exactly `common.css` (for instance, buttons' `min-height` and `min-width`), in favor of Photon. This might change later depending on the UX guidance we'll get eventually. Differential Revision: https://phabricator.services.mozilla.com/D8970
cac4aff89a39a7df33305397268510e8c7d2d840: Bug 1488506 - Add mochitest for enable/disable USB debugging in Connect page;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Thu, 18 Oct 2018 14:34:15 +0000 - rev 490302
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488506 - Add mochitest for enable/disable USB debugging in Connect page;r=ladybenko,daisuke Depends on D8556 Differential Revision: https://phabricator.services.mozilla.com/D8557
97207813052bd7a33c671422198b5d1e43adab49: Bug 1488506 - Add button to enable/disable USB debugging in Connect page;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 17 Oct 2018 08:47:30 +0000 - rev 490301
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488506 - Add button to enable/disable USB debugging in Connect page;r=ladybenko,daisuke Differential Revision: https://phabricator.services.mozilla.com/D8556
a0e2d7e922d83b15720c193f672312e639634a33: Bug 1488379 - guard for errors; r=daisuke
yulia <ystartsev@mozilla.com> - Thu, 18 Oct 2018 08:54:56 +0000 - rev 490240
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488379 - guard for errors; r=daisuke Depends on D7986 Differential Revision: https://phabricator.services.mozilla.com/D8736
51bea90a7500096e998b81000a9f766487753e62: Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 17 Oct 2018 11:11:53 +0000 - rev 490048
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke Depends on D8335 Differential Revision: https://phabricator.services.mozilla.com/D8513
5729da1055e8a464e9d062a71084e3983033721a: Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 17 Oct 2018 07:21:11 +0000 - rev 490017
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke Depends on D8335 Differential Revision: https://phabricator.services.mozilla.com/D8513
180b08bce5810da4b876e966f291bf1b90b53227: Bug 1494543 - Part 2: Add model + short runtime name to the sidebar item. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Tue, 16 Oct 2018 11:57:45 +0000 - rev 489797
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494543 - Part 2: Add model + short runtime name to the sidebar item. r=jdescottes,daisuke Added new getters to the ADB scanner so our runtime objects have now the information we need. Note that the UX of the devices in this patch doesn't still match what we had in the mockups (icons don't match, and we also need a circle with a tick), but since we have another bug to handle the CSS in the Sidebar, we can always adapt it there. The information needed to display what is shown in the mockups should be passed in this patch –if I miss anything, give me a shout! Differential Revision: https://phabricator.services.mozilla.com/D7705
bca2310f556c6848737084fe009f7976f2cf6f3c: Bug 1494543 - Part 1: Refactor sidebar items into different components. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Tue, 16 Oct 2018 09:35:25 +0000 - rev 489796
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494543 - Part 1: Refactor sidebar items into different components. r=jdescottes,daisuke This is a refactor of the components used in the sidebar. TL;DR: sidebar items now use the composition approach outlined here https://reactjs.org/docs/composition-vs-inheritance.html Before we had a container `Sidebar` component, which in turn had `SidebarItem` components inside. The issue was that depending on what item is inside, the information and UX displayed is different. Before this patch, we had an optional commponent, `DeviceSidebarItemAction` –which was featuring a "Connect" button, and was only rendered in the runtime sidebar items. However, we now need to display even more info, so continue to pass optional components to `SidebarItem` was tricky. What this patch does is to preserve `SidebarItem` and treat is a generic container of more specific content. This is passed via the `children` prop, which React automatically maps to the DOM content that we pass to that component (this is the same concept as slots in Web Components / Vue). `SidebarItem` now only contains the logic to select items in the sidebar and render them in `<li>` elements. Two new components, `SidebarFixedItem` (for our "static" pages) and `SidebarDeviceItem` are now the ones instancing `SidebarItem` with their specific contents. Differential Revision: https://phabricator.services.mozilla.com/D7704
e9abf60db23b75c1807bc6afa5b3fa9d8d483af6: Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Mon, 15 Oct 2018 07:30:44 +0000 - rev 489782
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494549 - Wait until ADB started in USB status sidebar test;r=daisuke Depends on D8335 Differential Revision: https://phabricator.services.mozilla.com/D8513
744747bb295cbb4a02dbf9960e5f7676822834c6: Bug 1494543 - Part 2: Add model + short runtime name to the sidebar item. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Thu, 11 Oct 2018 12:01:59 +0000 - rev 489593
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494543 - Part 2: Add model + short runtime name to the sidebar item. r=jdescottes,daisuke Added new getters to the ADB scanner so our runtime objects have now the information we need. Note that the UX of the devices in this patch doesn't still match what we had in the mockups (icons don't match, and we also need a circle with a tick), but since we have another bug to handle the CSS in the Sidebar, we can always adapt it there. The information needed to display what is shown in the mockups should be passed in this patch –if I miss anything, give me a shout! Differential Revision: https://phabricator.services.mozilla.com/D7705
5a54f333b855138687b5b71e33c1c6144fc7fbe5: Bug 1494543 - Part 1: Refactor sidebar items into different components. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Thu, 11 Oct 2018 11:59:26 +0000 - rev 489591
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494543 - Part 1: Refactor sidebar items into different components. r=jdescottes,daisuke This is a refactor of the components used in the sidebar. TL;DR: sidebar items now use the composition approach outlined here https://reactjs.org/docs/composition-vs-inheritance.html Before we had a container `Sidebar` component, which in turn had `SidebarItem` components inside. The issue was that depending on what item is inside, the information and UX displayed is different. Before this patch, we had an optional commponent, `DeviceSidebarItemAction` –which was featuring a "Connect" button, and was only rendered in the runtime sidebar items. However, we now need to display even more info, so continue to pass optional components to `SidebarItem` was tricky. What this patch does is to preserve `SidebarItem` and treat is a generic container of more specific content. This is passed via the `children` prop, which React automatically maps to the DOM content that we pass to that component (this is the same concept as slots in Web Components / Vue). `SidebarItem` now only contains the logic to select items in the sidebar and render them in `<li>` elements. Two new components, `SidebarFixedItem` (for our "static" pages) and `SidebarDeviceItem` are now the ones instancing `SidebarItem` with their specific contents. Differential Revision: https://phabricator.services.mozilla.com/D7704
a6cbba097c8a8300e51d3675b8e098756bc37a63: Bug 1493104 - Add unit test for AddonAwareADBScanner;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 10 Oct 2018 11:32:11 +0000 - rev 488843
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Add unit test for AddonAwareADBScanner;r=ladybenko,daisuke Depends on D7876 Differential Revision: https://phabricator.services.mozilla.com/D7877
8df2a288391c37d980e5ec0ddbf98c449ec12e6c: Bug 1493104 - Add ADBScanner decorator to listen to addon status udpates;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 10 Oct 2018 11:31:25 +0000 - rev 488842
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Add ADBScanner decorator to listen to addon status udpates;r=ladybenko,daisuke Depends on D7875 I would like to make the adb addon dependency transparent to the scanner consumers Differential Revision: https://phabricator.services.mozilla.com/D7876
cb9f55dd42570c4568d45c54ceb5176c3543df1c: Bug 1493104 - Add adbScanner to WebIDE scanners if status is already installed;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 10 Oct 2018 11:29:58 +0000 - rev 488841
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Add adbScanner to WebIDE scanners if status is already installed;r=ladybenko,daisuke Depends on D7873. This fixes the following scenario: - install ADB - connect a Device - start about:debugging => device shows up in sidebar - start WebIDE => device should show up in WebIDE Differential Revision: https://phabricator.services.mozilla.com/D7875
f7ecf841eb8fc2cdc516a9720f0a555c7f1e9b16: Bug 1493104 - Listen to ADB extension updates in about:debugging usb-runtime helper;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 10 Oct 2018 11:30:36 +0000 - rev 488840
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Listen to ADB extension updates in about:debugging usb-runtime helper;r=ladybenko,daisuke Depends on D7872. This fixes the bug where about:debugging thinks the addon is uninstalled the first time it starts. Differential Revision: https://phabricator.services.mozilla.com/D7873
fa20c2c68c4286c28c3ea4a8371d5d55396355cf: Bug 1493104 - Convert ADBScanner from a singleton to a class;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 10 Oct 2018 11:08:28 +0000 - rev 488839
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Convert ADBScanner from a singleton to a class;r=ladybenko,daisuke This allows to cleanly disable the scanner when you have several users. Without this if you start both WebIDE and about:debugging, the first listeners set in enable() can never be removed. Differential Revision: https://phabricator.services.mozilla.com/D7872
fa920249ca477da0c0ad64ed121d0887363a54f8: Bug 1493104 - Add unit test for AddonAwareADBScanner;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 05 Oct 2018 15:16:39 +0200 - rev 488816
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Add unit test for AddonAwareADBScanner;r=ladybenko,daisuke
ba67a0aadb68e1df04cf999a9a99e48d40b7d9f8: Bug 1493104 - Add ADBScanner decorator to listen to addon status udpates;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 05 Oct 2018 13:51:18 +0200 - rev 488815
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Add ADBScanner decorator to listen to addon status udpates;r=ladybenko,daisuke
5ed3ff9c48f5fb019808b03a4fad45f9dfd74435: Bug 1493104 - Add adbScanner to WebIDE scanners if status is already installed;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 05 Oct 2018 11:21:04 +0200 - rev 488814
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Add adbScanner to WebIDE scanners if status is already installed;r=ladybenko,daisuke This fixes the following scenario: - install ADB - connect a Device - start about:debugging => device shows up in sidebar - start WebIDE => device should show up in WebIDE
a56d01a749647c9bb733ee790bc2111e61a7591d: Bug 1493104 - Listen to ADB extension updates in about:debugging usb-runtime helper;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 05 Oct 2018 11:45:32 +0200 - rev 488813
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Listen to ADB extension updates in about:debugging usb-runtime helper;r=ladybenko,daisuke
6d25a11674ba1e78587b08c570995e7980c83648: Bug 1493104 - Convert ADBScanner from a singleton to a class;r=ladybenko,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 05 Oct 2018 11:17:22 +0200 - rev 488812
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493104 - Convert ADBScanner from a singleton to a class;r=ladybenko,daisuke
93467731a34be3601ec78af984b3d7f4d0af45cd: Bug 1490954 - Review Connect page CSS. r=jdescottes,daisuke
Belén Albeza <balbeza@mozilla.com> - Wed, 03 Oct 2018 13:53:46 +0000 - rev 487762
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1490954 - Review Connect page CSS. r=jdescottes,daisuke - Fixed some values so they match what it's being used in about:preferences (font sizes, margins, etc.) - Fixed page width in Connect page - Refactored some rules to be more generic and not tied up to this specific component - Now a default message appears instead of an empty <ul> when there are no network locations in the list - Adjusted icon & alignment in the Connect sections' headings Differential Revision: https://phabricator.services.mozilla.com/D7103
0b8b09f59546922daee91f342fbe38abbfdff56c: Bug 1493968 - Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Thu, 27 Sep 2018 05:48:45 +0000 - rev 486755
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493968 - Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6975
650083b7ab814e858766d1c61728aaa7c1d3e39c: Bug 1489220 - Add mochitest for empty message in debug target pane;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Wed, 26 Sep 2018 08:58:15 +0000 - rev 486691
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1489220 - Add mochitest for empty message in debug target pane;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6495
8c4325e4170b37823cf46e57d1ffd1b3e5ead693: Bug 1492863 - Fix react warnings in aboutdebugging-new;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Tue, 25 Sep 2018 11:04:58 +0000 - rev 486512
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492863 - Fix react warnings in aboutdebugging-new;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6400
6e2aaef654b01aa7eca017a24819899ca2468521: Bug 1489222 - Add mochitest to check navigation from ThisFirefox to Connect;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Tue, 25 Sep 2018 09:49:24 +0200 - rev 486430
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1489222 - Add mochitest to check navigation from ThisFirefox to Connect;r=daisuke Reviewers: daisuke Subscribers: MarcoM Bug #: 1489222 Differential Revision: https://phabricator.services.mozilla.com/D6485
573a32cebe76bbfc55ffc307abb907fb8a39d6bd: Bug 1489224 - Add mochitest to check runtimes section of aboudebugging sidebar;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 21 Sep 2018 14:38:16 +0000 - rev 486429
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1489224 - Add mochitest to check runtimes section of aboudebugging sidebar;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6402
a581d5bc795d34939e62686011df09385d24e627: Bug 1489224 - Fix order of tests in aboutdebugging-new;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 21 Sep 2018 12:31:16 +0000 - rev 486428
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1489224 - Fix order of tests in aboutdebugging-new;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6403
26719c685fd34be70dc98012b393525036e83335: Bug 1489224 - Enable adb scanner only if addon status is installed;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Mon, 24 Sep 2018 19:23:24 +0200 - rev 486427
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1489224 - Enable adb scanner only if addon status is installed;r=daisuke Using await check() to see if ADB is running is causing aboutdebugging to leak on debug windows test-verify. Ultimately we should be able to call ADB scanner without worrying if the addon is installed or not but for now we should keep things simple and only start the scanner if the extension is available.
37c3d52f7a9ea2a751da8f5fb39561c71a9628e7: Bug 1490301 - Always use relative paths in new about:debugging;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 21 Sep 2018 11:31:07 +0000 - rev 486034
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490301 - Always use relative paths in new about:debugging;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6398
d414a44d81195403aabdfb91994c5df9c9acbbc9: Bug 1489224 - Add mochitest to check runtimes section of aboudebugging sidebar;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 21 Sep 2018 14:38:16 +0000 - rev 486033
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489224 - Add mochitest to check runtimes section of aboudebugging sidebar;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6402
6300cdbc0e0434993b9474b6a9367ca50d51355d: Bug 1489224 - Fix order of tests in aboutdebugging-new;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 21 Sep 2018 12:31:16 +0000 - rev 486032
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489224 - Fix order of tests in aboutdebugging-new;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D6403
6207f0ff5943cdfd013116d4e0ac23828bc934b6: Bug 1489223 - Add mochitest for adding/removing network locations in new aboutdebugging;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Tue, 18 Sep 2018 08:42:54 +0000 - rev 485349
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489223 - Add mochitest for adding/removing network locations in new aboutdebugging;r=daisuke depends on D5798 Differential Revision: https://phabricator.services.mozilla.com/D6019
9a21b4a806b23e259cbd6b44a0739fdfb1939041: Bug 1489223 - Always wait until client is ready when opening aboutdebugging in mochitests;r=daisuke
Julian Descottes <jdescottes@mozilla.com> - Mon, 17 Sep 2018 11:55:14 +0000 - rev 485348
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1489223 - Always wait until client is ready when opening aboutdebugging in mochitests;r=daisuke Differential Revision: https://phabricator.services.mozilla.com/D5798
f10934a2b1d76e3b8accfb233425a3b8c02af571: Bug 1483497 - Allow to inspect debug targets for network locations;r=daisuke,ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Sep 2018 12:25:57 +0200 - rev 485007
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1483497 - Allow to inspect debug targets for network locations;r=daisuke,ladybenko
f90c1e080761485436620b02e3f8d99b2b20aebd: Bug 1483497 - Display debug targets for network locations;r=daisuke,ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Sep 2018 12:18:51 +0200 - rev 485006
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1483497 - Display debug targets for network locations;r=daisuke,ladybenko
0d62d337ff34f1ef8d21c85722d4272ac302ad2f: Bug 1483497 - Allow to connect to network locations runtimes;r=daisuke,ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Sep 2018 11:47:00 +0200 - rev 485005
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1483497 - Allow to connect to network locations runtimes;r=daisuke,ladybenko
4b2013edb3c836aca2395e8d2e44e80cdbc66d86: Bug 1483497 - Rename connect/disconnect actions to watch/unwatch;r=daisuke,ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Sep 2018 11:06:52 +0200 - rev 485004
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1483497 - Rename connect/disconnect actions to watch/unwatch;r=daisuke,ladybenko
4538d62973ac999a225034849c311913d042fa9b: Bug 1483497 - Split runtime actions in runtimes and debug-target;r=daisuke,ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Sep 2018 10:49:46 +0200 - rev 485003
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1483497 - Split runtime actions in runtimes and debug-target;r=daisuke,ladybenko
bd97be9a057daf93bfefcc15126ec735b98d5c11: Bug 1483497 - Rename runtime-state to debug-targets-state;r=daisuke,ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Sep 2018 10:41:44 +0200 - rev 485002
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1483497 - Rename runtime-state to debug-targets-state;r=daisuke,ladybenko
e68df673cbfb59cb8ff60f61cd82aa148908abc2: Bug 1483497 - Move selected runtime to runtimes-state;r=daisuke,ladybenko
Julian Descottes <jdescottes@mozilla.com> - Thu, 06 Sep 2018 10:29:14 +0200 - rev 485001
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1483497 - Move selected runtime to runtimes-state;r=daisuke,ladybenko