searching for reviewer(bzbarsky)
01da72655339b6e9182e0cfb06e45ed7f0cb47ae: Bug 1501124 - Switch BackstagePass to use WebIDLGlobalNameHash, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Wed, 24 Oct 2018 19:14:35 -0400 - rev 491294
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501124 - Switch BackstagePass to use WebIDLGlobalNameHash, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D9736
c8ca4a20631561e4a7a6cf68be07ec2eef2e7bd0: Bug 1501910 - Pass enumerableOnly into nsIXPCScriptable::NewEnumerate, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Wed, 24 Oct 2018 23:40:37 -0400 - rev 491293
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501910 - Pass enumerableOnly into nsIXPCScriptable::NewEnumerate, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D9749
8b0b407e053f4bbde1b14abc8b3d28d6251c908b: Bug 1500926 - Part 3: Remove unused WebIDL Codegen items, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Mon, 22 Oct 2018 22:03:17 -0400 - rev 491208
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500926 - Part 3: Remove unused WebIDL Codegen items, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D9465
3d9631fca868cb87b172f0b615aea84042084356: Bug 1500926 - Part 2: Support a test-only edgecase in Codegen.py, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Mon, 22 Oct 2018 00:57:24 -0400 - rev 491207
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500926 - Part 2: Support a test-only edgecase in Codegen.py, r=bzbarsky When running tests, we can build a WebIDL environment with no interfaces exposed on the primary global. Unfortunately, due to the perfecthash.py logic not handling empty tables, this causes an assertion to be raised. We can work around this by generating some dummy code for that situation, as we will never try to build it. Differential Revision: https://phabricator.services.mozilla.com/D9407
80b71708f7ca5d177b3ffb46b518d69d45540310: Bug 1500926 - Part 1: Use a statically generated perfect hash in WebIDLGlobalNameHash, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sun, 21 Oct 2018 21:44:17 -0400 - rev 491206
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500926 - Part 1: Use a statically generated perfect hash in WebIDLGlobalNameHash, r=bzbarsky This strategy allows us to dodge dynamic allocations in WebIDLGlobalNameHash. This removes the Init() and Shutdown() methods, as well as Register. The RegisterBindings.cpp file now only contains static data and one method declaration for the WebIDLGlobalNameHash class. This should also be faster by making the hashtable lookup infallible. Differential Revision: https://phabricator.services.mozilla.com/D9406
fbb568aa121e33fedf00c3be48a04c1593af9591: Bug 1500927 - Add copy-free jsstring support to perfecthash.py, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sun, 21 Oct 2018 21:39:35 -0400 - rev 491205
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500927 - Add copy-free jsstring support to perfecthash.py, r=bzbarsky This is needed for bug 1500926. It takes the approach of taking a JSFlatString and using AutoAssertCannotGC to read the memory directly from the JS heap. This lets us avoid re-encoding strings when performing lookups, which can be advantageous. Only ASCII strings are supported by this handler, and wide strings are hashed as though they contain only values under 0x7f. This is OK as invalid keys to perfecthash may return any hashtable entry. Differential Revision: https://phabricator.services.mozilla.com/D9405
59160a8260a02fda2bc625b02c3132d9330e2dd7: Bug 1489301 - Part 6: Remove references to 'System' from WebIDL.py, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 20:48:14 -0400 - rev 490916
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 6: Remove references to 'System' from WebIDL.py, r=bzbarsky 'Exposed=System' is no longer used in any webidl files, so we can kill it. Differential Revision: https://phabricator.services.mozilla.com/D9401
d8ac98041af79f4e14559d0118a29f3f48e7f250: Bug 1489301 - Part 5: Expose all System-only objects on Window, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 20:05:38 -0400 - rev 490915
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 5: Expose all System-only objects on Window, r=bzbarsky There is a limited number of these, and this allows me to completely remove mention of the 'System' global. In the future System-only exposure could be achieved using a [Func] enabler. Differential Revision: https://phabricator.services.mozilla.com/D9400
fbfcfc27ab30434eaac667cbbf9d33ded0abb571: Bug 1489301 - Part 4: Remove unnecessary [Exposed=System] annotations, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 20:02:53 -0400 - rev 490914
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 4: Remove unnecessary [Exposed=System] annotations, r=bzbarsky We don't need to expose on both Window and System anymore, as Window now implies System. I don't remove unnecessary [Exposed=Window] annotations, as WebIDL upstream has removed PrimaryGlobal. Differential Revision: https://phabricator.services.mozilla.com/D9399
a43d864f8502a84d46edab409c0dcc17f732f0eb: Bug 1489301 - Part 3: Fix test expecting interfaces not exposed on System, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Mon, 22 Oct 2018 10:03:52 -0400 - rev 490913
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 3: Fix test expecting interfaces not exposed on System, r=bzbarsky The `Window` interface is now exposed on system globals, so the check is now invalid. Differential Revision: https://phabricator.services.mozilla.com/D9403
dc5a91eadc49803467155a771e5de5a4f96dbbde: Bug 1489301 - Part 2: Fix broken [Func] condition assuming Window object, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sun, 21 Oct 2018 20:38:41 -0400 - rev 490912
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 2: Fix broken [Func] condition assuming Window object, r=bzbarsky This condition unwraps the global to a window, and doesn't check before dereferencing. This is no longer valid now that the corresponding interfaces are exposed on BackstagePass. Differential Revision: https://phabricator.services.mozilla.com/D9402
22888a1208aba852098e9d9036c83602222023d0: Bug 1489301 - Part 1: Expose Window interfaces on System by default, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 18:10:07 -0400 - rev 490911
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 1: Expose Window interfaces on System by default, r=bzbarsky This is done by adding BackstagePass the exposure set of Window. Differential Revision: https://phabricator.services.mozilla.com/D9398
1c0823540b44ff83a6319a363aab6e017faddaf4: Bug 1489301 - Part 6: Remove references to 'System' from WebIDL.py, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 20:48:14 -0400 - rev 490732
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 6: Remove references to 'System' from WebIDL.py, r=bzbarsky 'Exposed=System' is no longer used in any webidl files, so we can kill it. Differential Revision: https://phabricator.services.mozilla.com/D9401
529524df76a62485a06367438281b9a1155b9b42: Bug 1489301 - Part 5: Expose all System-only objects on Window, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 20:05:38 -0400 - rev 490731
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 5: Expose all System-only objects on Window, r=bzbarsky There is a limited number of these, and this allows me to completely remove mention of the 'System' global. In the future System-only exposure could be achieved using a [Func] enabler. Differential Revision: https://phabricator.services.mozilla.com/D9400
f34bc8a40bec4df77ca477793a8932f6683baa8c: Bug 1489301 - Part 4: Remove unnecessary [Exposed=System] annotations, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 20:02:53 -0400 - rev 490730
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 4: Remove unnecessary [Exposed=System] annotations, r=bzbarsky We don't need to expose on both Window and System anymore, as Window now implies System. I don't remove unnecessary [Exposed=Window] annotations, as WebIDL upstream has removed PrimaryGlobal. Differential Revision: https://phabricator.services.mozilla.com/D9399
168cf9cea716ac599dc594db4dd410bdaefd70ff: Bug 1489301 - Part 3: Fix test expecting interfaces not exposed on System, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Mon, 22 Oct 2018 10:03:52 -0400 - rev 490729
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 3: Fix test expecting interfaces not exposed on System, r=bzbarsky The `Window` interface is now exposed on system globals, so the check is now invalid. Differential Revision: https://phabricator.services.mozilla.com/D9403
19ca10fa37725e9b1a52d05bf2ed479e2a8d4a73: Bug 1489301 - Part 2: Fix broken [Func] condition assuming Window object, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sun, 21 Oct 2018 20:38:41 -0400 - rev 490728
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 2: Fix broken [Func] condition assuming Window object, r=bzbarsky This condition unwraps the global to a window, and doesn't check before dereferencing. This is no longer valid now that the corresponding interfaces are exposed on BackstagePass. Differential Revision: https://phabricator.services.mozilla.com/D9402
ff8fb091198ee6f4c86ffd4625089dd9751630a0: Bug 1489301 - Part 1: Expose Window interfaces on System by default, r=bzbarsky
Nika Layzell <nika@thelayzells.com> - Sat, 20 Oct 2018 18:10:07 -0400 - rev 490727
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1489301 - Part 1: Expose Window interfaces on System by default, r=bzbarsky This is done by adding BackstagePass the exposure set of Window. Differential Revision: https://phabricator.services.mozilla.com/D9398
8dd09fad1f352d3814244908f0ea04f29fa2a307: Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika
Kyle Machulis <kyle@nonpolynomial.com> - Thu, 18 Oct 2018 22:14:54 +0000 - rev 490383
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika Creates the nsDocShellLoadState object, which is basically nsDocShellLoadInfo plus a few extra fields to make it usable as a single argument to nsDocShell::LoadURI (and eventually nsDocShell::InternalLoad). Subframe history handling is a huge logic block in nsDocShell::LoadURI, which is only used on history loads. This patch also extracts the logic out into its own function to make the body of LoadURI clearer. Differential Revision: https://phabricator.services.mozilla.com/D6944
357559d3ec0de83e5a8075e7aad65d6493691f6e: Bug 1341390. Remove unused tests dom/tests/html and dom/tests/js. r=bzbarsky
Diego Pino Garcia <dpino@igalia.com> - Thu, 18 Oct 2018 19:46:34 -0400 - rev 490353
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1341390. Remove unused tests dom/tests/html and dom/tests/js. r=bzbarsky All the properties tested by those tests is covered by web-platform-tests.
c597d36a2d7ac1b32de3d57054a87176737ae814: Bug 1497589 Part 1: Move Flex.webidl to the chrome-webidl directory. r=bzbarsky,dholbert
Brad Werth <bwerth@mozilla.com> - Thu, 18 Oct 2018 00:08:02 +0000 - rev 490303
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497589 Part 1: Move Flex.webidl to the chrome-webidl directory. r=bzbarsky,dholbert Differential Revision: https://phabricator.services.mozilla.com/D9022
f6404da759c5d8834f367bde898dd1fcd54fc904: Bug 1498873 - Simplify a check. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Oct 2018 20:40:08 +0000 - rev 490172
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498873 - Simplify a check. r=bzbarsky And make will-change: position properly create an abspos cb while at it, since the check was missing the `mWillChangeBitfield & ABSPOS_CB` bit. Differential Revision: https://phabricator.services.mozilla.com/D8743
b77bde54527692f87c31a60112d3cb57ec13298e: Bug 1498873 - Pass the right frame to PushAbsoluteContainingBlock to determine whether we're a fixed-pos containing block. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Oct 2018 20:22:38 +0000 - rev 490170
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498873 - Pass the right frame to PushAbsoluteContainingBlock to determine whether we're a fixed-pos containing block. r=bzbarsky When we're creating a scrollframe with let's say, display: flex or grid, the containing block is the grid container itself, but the transformed frame is the scroll frame. This is the only caller that (incorrectly) passes the same frame to PushAbsoluteContainingBlock. Our painting code deals with it, mostly, because it starts from the placeholder to paint fixed items, and it hits the scrollframe, but it gets confused sometimes causing the issue described here. I'll find a way to add a crashtest for this, and maybe a reftest, though this works in non-WR. We should probably add a few more assertions to the frame constructor... Differential Revision: https://phabricator.services.mozilla.com/D8724
d7a0a0e0173e23074808c47db4c9178e8f50708a: Bug 1499571 - HTMLOptionsCollection::Remove shouldn't remove the first element of the collection if out of bounds. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Oct 2018 01:35:21 +0000 - rev 489950
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499571 - HTMLOptionsCollection::Remove shouldn't remove the first element of the collection if out of bounds. r=bzbarsky Make it just forward to HTMLSelectElement::Remove like other browsers. Differential Revision: https://phabricator.services.mozilla.com/D8934
ce783284cca7bb33684bf6fbf197387afcd2c3b4: Bug 1499567 - Do not append an empty text node when creating options from HTMLOptionCollection::SetLength. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 17 Oct 2018 00:10:46 +0000 - rev 489948
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499567 - Do not append an empty text node when creating options from HTMLOptionCollection::SetLength. r=bzbarsky Only we do that. Align with other browsers instead. I removed the max-asserts as well because I cannot make my browser assert when running this test on a debug build. Differential Revision: https://phabricator.services.mozilla.com/D8929
f2d7836b93f9ad88ef27388df27be1e6510bcdb8: Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop a=reland
Jan-Ivar Bruaroey <jib@mozilla.com> - Fri, 12 Oct 2018 20:25:07 +0300 - rev 489204
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop a=reland Differential Revision: https://phabricator.services.mozilla.com/D8053
a19bd92250b6d4c7ca6639c632bca4950d2b911d: Bug 1493237 - Use a test-only non-nsISupports wrapper cached WebIDL class in a weak map test r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Thu, 11 Oct 2018 23:02:10 +0000 - rev 489146
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493237 - Use a test-only non-nsISupports wrapper cached WebIDL class in a weak map test r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D8134
336da65f35ea1237d94c4a8e6d67b8f2bd794496: Bug 1497351 - Remove dictionary null defaults from MediaTrackConstraintSet; handle absence in NormalizedConstraintSet. r=bzbarsky,pehrsons
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 11 Oct 2018 02:03:17 +0000 - rev 489000
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497351 - Remove dictionary null defaults from MediaTrackConstraintSet; handle absence in NormalizedConstraintSet. r=bzbarsky,pehrsons Differential Revision: https://phabricator.services.mozilla.com/D8054
419218259bc1a6f5f1cd527225f1f200fbf55126: Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Thu, 11 Oct 2018 02:02:32 +0000 - rev 488999
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop Differential Revision: https://phabricator.services.mozilla.com/D8053
7672ed76df74f1a3dbedd6da63c1ccdb1c5ef36e: Bug 1497342, part 3 - Turn some WeakMap chrome mochitests into plain mochitests r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 10 Oct 2018 17:35:56 +0000 - rev 488944
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497342, part 3 - Turn some WeakMap chrome mochitests into plain mochitests r=bzbarsky This only requires changing the surrounding test boilerplate and using SpecialPowers to access chrome-privileged functions. Depends on D8132 Differential Revision: https://phabricator.services.mozilla.com/D8133
07a4bffa3dd65ee6137403289dd3422ee9167557: Bug 1497342, part 2 - Move some weak map tests r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 10 Oct 2018 17:35:54 +0000 - rev 488943
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497342, part 2 - Move some weak map tests r=bzbarsky This patch moves some Chrome mochitests into the plain mochitest directory, in order to try to preserve the history. It also removes them from the list of tests. The next patch will fix the tests and start running them again. Depends on D8131 Differential Revision: https://phabricator.services.mozilla.com/D8132
493e812d03421d640f1111e57373d6c4d777f789: Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop
Jan-Ivar Bruaroey <jib@mozilla.com> - Wed, 10 Oct 2018 07:51:09 +0000 - rev 488890
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497390 - Remove support for legacy mozAutoGainControl and mozNoiseSuppression constraints. r=bzbarsky,achronop Differential Revision: https://phabricator.services.mozilla.com/D8053
61ad878d2f66d0b129b326a526e6dff46d839e94: Bug 1493634 - make docshell responsible for outer window IDs, r=bzbarsky
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 10 Oct 2018 10:20:36 +0000 - rev 488833
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493634 - make docshell responsible for outer window IDs, r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D7702
8f0aa41876197fc701ddadb73eee8edaa753af19: Bug 1458538 - Add pause and resume events for MediaRecorder. r=bzbarsky
Bumsik Kim <k.bumsik@gmail.com> - Wed, 10 Oct 2018 02:16:32 +0300 - rev 488686
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1458538 - Add pause and resume events for MediaRecorder. r=bzbarsky Summary: This resolves the two problems of MediaRecorder: 1. MediaRecorder does not fire pause/resume events when the corresponding methods are called, as mentioned in D7910. 2. The WebIDL for MediaRecorder does not specify onpause/onresume event handler attributes neither. DispatchSimpleEvent() is used because there are no event attributes needed. Test Plan: The MediaRecorderTest.html attached in the bug report will be enough to test if the events work well as intended. Reviewers: jya, bzbarsky Reviewed By: jya, bzbarsky Bug #: 1458538 Differential Revision: https://phabricator.services.mozilla.com/D7971
9c6662e31204379c3e6f8dc4b0909f95b573664f: Bug 1495820 - Inline do_QueryWrappedNative() r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Wed, 03 Oct 2018 21:40:26 +0000 - rev 487867
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495820 - Inline do_QueryWrappedNative() r=bzbarsky This method does very little, and is called in only a few places, so just inline it. The error variant is not called at all. Simplifying this makes it easier for me to change do_QueryInterface. Differential Revision: https://phabricator.services.mozilla.com/D7527
9bdbc378f0371982a76400c02c19d68f90d828ee: Bug 1491728 - Fix ContentPrincipal::GetSiteOrigin to handle IPv6 addresses correctly. r=bzbarsky
Jan de Mooij <jdemooij@mozilla.com> - Mon, 01 Oct 2018 12:16:39 +0000 - rev 487703
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1491728 - Fix ContentPrincipal::GetSiteOrigin to handle IPv6 addresses correctly. r=bzbarsky The problem is that we used ThirdPartyUtil.getBaseDomain and for IP addresses that returns the host, and for IPv6 addresses GetHost strips the '[' and ']' brackets. Then when we passed that IP address to SetHost, we failed because SetHost wants the brackets to be present. This patch changes GetSiteOrigin to call getBaseDomain on the TLD service instead, so we can handle this case ourselves by not calling SetHost when we have an IP address. GetBaseDomain still uses ThirdPartyUtil. I tried to add a test for this (with an iframe + postMessage) but the mochitest http server doesn't support IPv6. Differential Revision: https://phabricator.services.mozilla.com/D6523
a902caa5f3209f558a58b11ce44cc4cce77a5b6a: Bug 1336712 - dom: Remove performance.now() test checks for Windows XP. r=bzbarsky
Chris Peterson <cpeterson@mozilla.com> - Thu, 13 Sep 2018 23:39:41 -0700 - rev 487231
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1336712 - dom: Remove performance.now() test checks for Windows XP. r=bzbarsky Firefox no longer supports Windows XP, so these test checks that allow for timeouts with 25 ms resolution can be removed. Also, rewrite some test logic and comments to make the test's intention clearer. The 'getOSCPU' message handler can be removed from test_worker_performance_now.html because test_worker_performance_now.js no longer needs to check for Windows XP. Stop setting the pref "privacy.reduceTimerPrecision" = false in test_performance_now.html. That pref removes performance.now()'s 1 ms resolution limit so the performance timer will run at full speed. By leaving the pref's default value, the test can assert that performance.now() is actually honoring the 1 ms limit. I didn't remove "privacy.reduceTimerPrecision" = false for the worker test. The worker tests run an accelerated setTimeout() clock, so setTimeout(1) can time out in less than 1 ms. Leaving the pref "privacy.reduceTimerPrecision" = true causes hundreds of worker tests to run more slowly (in real time), which would increase test automation time. Differential Revision: https://phabricator.services.mozilla.com/D6581
3039bfc0e2707fa57523756d29de73703baccd59: Bug 1484980 - Add selective canvas tainting for content scripts r=bzbarsky
Tomislav Jovanovic <tomica@gmail.com> - Wed, 26 Sep 2018 20:29:36 +0200 - rev 487222
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1484980 - Add selective canvas tainting for content scripts r=bzbarsky Reviewers: bzbarsky Bug #: 1484980 Differential Revision: https://phabricator.services.mozilla.com/D6999
3266c319db3ba2d2ab831eed88adcef94cf48b87: Bug 1489503 - In docShell, don't set the same title a second time. r=bzbarsky
Mark Banner <standard8@mozilla.com> - Sat, 29 Sep 2018 07:55:16 +0000 - rev 487205
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1489503 - In docShell, don't set the same title a second time. r=bzbarsky This avoids setting the title a second time when the title and uri remain the same across setTitle calls. This means we can avoid unnecessary history updates which currently result in extra disk i/o. Differential Revision: https://phabricator.services.mozilla.com/D5431
b700e538fe1f46bdf5c33a2c1b46ca4ab8e3480a: Bug 1493222 - Expose InspectorUtils to fuzzers. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Sep 2018 19:00:33 +0000 - rev 486951
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493222 - Expose InspectorUtils to fuzzers. r=bzbarsky I can be more granular if we want, by adding more ChromeOnly annotations for the functions that we don't want to expose. Differential Revision: https://phabricator.services.mozilla.com/D6530
31d61c73ab751904374d1bdc81c594add80b4cde: Bug 1494332 - Avoid setting the has-first-letter child bit on a first-line. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Sep 2018 13:16:00 +0000 - rev 486901
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494332 - Avoid setting the has-first-letter child bit on a first-line. r=bzbarsky We rely on the bit being on the block to restyle them in the right order. Differential Revision: https://phabricator.services.mozilla.com/D7086
0e75ce9f6b318dc1713e229bd05cb1f11a40a0f0: Bug 1494047 - Remove questionable and unnecessary cast in PresentationPresentingInfo::ResolvedCallback() r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Tue, 25 Sep 2018 22:17:57 +0000 - rev 486605
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494047 - Remove questionable and unnecessary cast in PresentationPresentingInfo::ResolvedCallback() r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D6851
0b509721c2f56bbf57e3a6901d3ecfe642cf956e: Bug 1493811 remove obsolete reference to TakeOwnershipOfErrorReporting() r=bzbarsky
Karl Tomlinson <karlt+@karlt.net> - Tue, 25 Sep 2018 01:49:18 +0000 - rev 486389
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493811 remove obsolete reference to TakeOwnershipOfErrorReporting() r=bzbarsky Obsolete since https://hg.mozilla.org/mozilla-central/rev/a45a6cde6558 Differential Revision: https://phabricator.services.mozilla.com/D6707
b7aa0f3bdf687053b0000a3ab9a0f98eca97185d: Bug 1493210 - Remove XUL forward references. r=bzbarsky
Brendan Dahl <bdahl@mozilla.com> - Mon, 24 Sep 2018 16:43:42 +0000 - rev 486311
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493210 - Remove XUL forward references. r=bzbarsky These are no longer needed after the removal of overlays. Differential Revision: https://phabricator.services.mozilla.com/D6511
ef927b08625419b8033f8b20d939d8ac84c88ebb: Bug 1351501, part 2 - Preserve wrappers for non-nsISupports cycle collected weak map keys r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Fri, 21 Sep 2018 18:20:35 +0000 - rev 486075
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1351501, part 2 - Preserve wrappers for non-nsISupports cycle collected weak map keys r=bzbarsky A C++ object that is exposed to JS can have its reflector used as a key in a weak map. Because a weak map does not keep its keys alive, this means that the reflector can be discarded if it has no other references aside from the C++ object, which will in turn remove its weak map entry. If the C++ object can be accessed again later from JS, it will get a new reflector which will have no weak map entry. This is bad because it means some internal implementation detail has resulted in data loss that is visible to JS. (Side note: this is also an issue for cross compartment wrappers, which is handled by another mechanism.) To fix this, we can preserve the wrapper of any DOM reflector used as a weak map key. This ensures that the reflector and its C++ object have the same lifetime. If a WebIDL object is not wrapper cached, that means that it cannot be accessed via C++, so we don't need to preserve the wrapper. This is currently implemented for nsISupports classes, but not other classes. For non-nsISupports classes, it would throw an error rather than silently fail. My patch adds support for non-nsISupports cycle collected objects. It turns out that the existing addProperty hook just does wrapper preservation, so we just call it for cycle collected classes. This does mean that if addProperty changes in the future to do something else, this code will need to be changed. I verified that this test fails if TryPreserveWrapper is changed to do nothing besides return true in the non-nsISuports case. Depends on D6197 Differential Revision: https://phabricator.services.mozilla.com/D6198
ab2856e070b9de566ec676655ac42431cdb8c17f: Bug 1351501, part 1 - Handlify TryPreserveWrapper r=bzbarsky
Andrew McCreight <continuation@gmail.com> - Fri, 21 Sep 2018 18:20:33 +0000 - rev 486074
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1351501, part 1 - Handlify TryPreserveWrapper r=bzbarsky The patch in the next part will need a handle to the object in TryPreserveWrapper. Differential Revision: https://phabricator.services.mozilla.com/D6197
ff7afc7ea4b7ba783defb75266d0629f7a4331fc: Bug 1484048 - Part IV, Don't reset mDocumentLoadGroup if the same LoadGroup is passed r=bzbarsky
Timothy Guan-tin Chien <timdream@gmail.com> - Mon, 17 Sep 2018 20:49:17 +0000 - rev 485630
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1484048 - Part IV, Don't reset mDocumentLoadGroup if the same LoadGroup is passed r=bzbarsky nsIDocument::ResetToURI() resets and set the mDocumentLoadGroup property even if it is given the same instance. This has caused BlockOnload() to break on media documents, which calls into there while removing UA Widget. This patch checks the weak ref before resets it. Depends on D3841 Differential Revision: https://phabricator.services.mozilla.com/D4484
9bc9a1e07a53e2b2f3fd4f03a462c5524bc6a929: Bug 1491561 - Remove the XPCOM registrations for LoadContext; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 15 Sep 2018 11:38:45 -0400 - rev 485193
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491561 - Remove the XPCOM registrations for LoadContext; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D5945
5219960d0d316fb30fe920f820baa02299ef50fe: Bug 1491735 - Remove the XPCOM registration for nsWebBrowserFind; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Mon, 17 Sep 2018 00:33:59 -0400 - rev 485191
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491735 - Remove the XPCOM registration for nsWebBrowserFind; r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D5993
84bade5ed574ebd9f012e5dcad253adae6dd6b8a: Bug 1488817 - Remove the has-first-letter-child bit from the block when the first-letter is removed from a first-line. r=bzbarsky
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 17 Sep 2018 17:36:06 +0000 - rev 485184
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1488817 - Remove the has-first-letter-child bit from the block when the first-letter is removed from a first-line. r=bzbarsky Always new reasons to remove the first-line frame and this reparenting stuff... I hope I can get to it. Differential Revision: https://phabricator.services.mozilla.com/D5075