searching for reviewer(bobowen)
9b976167b45aa1ea14c163e0dd4480ec1439289b: Bug 1426733: Use restricting SIDs in Windows NPAPI process sandbox (r=bobowen)
David Parks <dparks@mozilla.com> - Thu, 18 Oct 2018 16:27:56 +0000 - rev 490372
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1426733: Use restricting SIDs in Windows NPAPI process sandbox (r=bobowen) Allow NPAPI sandbox to use restricting SIDs. This hardens the plugin sandbox. Differential Revision: https://phabricator.services.mozilla.com/D8746
d37fe76d61f968dc7e65327690020c6069841adb: Bug 1498695 Revert casting to void* (1462100) because mingwclang doesn't need to do that. r=bobowen
Tom Ritter <tom@mozilla.com> - Tue, 16 Oct 2018 11:33:32 +0300 - rev 489722
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498695 Revert casting to void* (1462100) because mingwclang doesn't need to do that. r=bobowen
414fe669452a2203910fb8da59fcdf211a249ca9: Bug 1498694 Revert the patch that relaxes the MSVC requirement (1431807) since mingw-clang passes it now r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 12 Oct 2018 13:45:49 -0500 - rev 489662
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498694 Revert the patch that relaxes the MSVC requirement (1431807) since mingw-clang passes it now r=bobowen
4a46dbac24340804b026adcc919c61081673e5be: Bug 1498693 - Revert the other part of 1431803, since mingw-clang can handle it now r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 12 Oct 2018 13:44:37 -0500 - rev 489563
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498693 - Revert the other part of 1431803, since mingw-clang can handle it now r=bobowen
b705d158c204ff95d5266579de576eaa190988a0: Bug 1498676 - Revert the __try/__except mapping (part of Bug 1431803) for MinGW from the sandbox code r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 12 Oct 2018 13:15:33 -0500 - rev 489562
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498676 - Revert the __try/__except mapping (part of Bug 1431803) for MinGW from the sandbox code r=bobowen This is no longer necessary, and in fact breaks the sandbox compilation, because code inside the transformed-else blocks is only valid inside an __except block
c0b3c3c948fde682b37efa237235248aeb1f7ec2: Bug 1498672 Include string.h explicitly instead of relying on algorithm to bring it in r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 12 Oct 2018 12:55:16 -0500 - rev 489561
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498672 Include string.h explicitly instead of relying on algorithm to bring it in r=bobowen The mingw-clang build was broken because the dependency wasn't specified explicitly.
e63e2e4c0484d98b97a39215387553fca3d52b8d: Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 22:36:56 +0000 - rev 489422
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies) Flash analyzes the parents of the path to its appdata folder on Windows using GetFileAttributesW. If it runs into an error, it makes some internal decisions that cause it to break DRM video. Our new sandbox hardening causes GetFileAttributesW to return an error for some components of the path. This patch alters the behavior of GetFileAttributesW so that it always reports FILE_ATTRIBUTE_DIRECTORY for any path that both 1) would otherwise return an error and 2) is an ancestor of the appdata folder. This may not always be 100% accurate (for instance, if the folder is a reparse point) but restores video functionality. Depends on D7532 Differential Revision: https://phabricator.services.mozilla.com/D7533
a5d9e6a7242dcb49be48adc839f071dd9a9a0316: Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 22:36:22 +0000 - rev 489420
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm) The sandbox blocks GetTempFileName's prior response, causing the system to end up searching a number of (inaccessible) folders to use as a replacement for the temp folder. This patch provides a path to a new folder on the command line for the plugin process. This new temp folder, specific to this plugin process instance, is then communicated to the system via the TEMP/TMP environment variables. This is similar to what is done for the content process but avoids nsDirectoryService, which doesn't exist in plugin processes. Differential Revision: https://phabricator.services.mozilla.com/D7532
74b2087ee696eb7369b65727b81fc67121789f7d: Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 17:41:29 +0000 - rev 489373
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488439: Part 2 - Patch GetFileAttributesW for appdata parent folders in sandboxed plugin process (r=bobowen,jmathies) Flash analyzes the parents of the path to its appdata folder on Windows using GetFileAttributesW. If it runs into an error, it makes some internal decisions that cause it to break DRM video. Our new sandbox hardening causes GetFileAttributesW to return an error for some components of the path. This patch alters the behavior of GetFileAttributesW so that it always reports FILE_ATTRIBUTE_DIRECTORY for any path that both 1) would otherwise return an error and 2) is an ancestor of the appdata folder. This may not always be 100% accurate (for instance, if the folder is a reparse point) but restores video functionality. Depends on D7532 Differential Revision: https://phabricator.services.mozilla.com/D7533
85575fc37555213a204b8565bbadef7270edd19e: Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm)
David Parks <dparks@mozilla.com> - Fri, 12 Oct 2018 17:40:10 +0000 - rev 489369
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm) The sandbox blocks GetTempFileName's prior response, causing the system to end up searching a number of (inaccessible) folders to use as a replacement for the temp folder. This patch provides a path to a new folder on the command line for the plugin process. This new temp folder, specific to this plugin process instance, is then communicated to the system via the TEMP/TMP environment variables. This is similar to what is done for the content process but avoids nsDirectoryService, which doesn't exist in plugin processes. Differential Revision: https://phabricator.services.mozilla.com/D7532
6af35f6a050fb97ce23ecde1a937e0c81e8e4c02: Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm)
David Parks <dparks@mozilla.com> - Wed, 10 Oct 2018 20:16:22 +0000 - rev 488969
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1488439: Part 1 - Replace Windows temp folder in sandboxed plugin process (r=bobowen,erahm) The sandbox blocks GetTempFileName's prior response, causing the system to end up searching a number of (inaccessible) folders to use as a replacement for the temp folder. This patch provides a path to a new folder on the command line for the plugin process. This new temp folder, specific to this plugin process instance, is then communicated to the system via the TEMP/TMP environment variables. This is similar to what is done for the content process but avoids nsDirectoryService, which doesn't exist in plugin processes. Differential Revision: https://phabricator.services.mozilla.com/D7532
7db77bd81f0fa5789d264cfaff8d99d882f44923: Bug 1356347 - Handle race in browser_opened_file_tab_navigated_to_web.js due to process flip. r=bobowen
Mike Conley <mconley@mozilla.com> - Mon, 27 Aug 2018 14:32:46 -0400 - rev 482390
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1356347 - Handle race in browser_opened_file_tab_navigated_to_web.js due to process flip. r=bobowen
097d82eb192888b55fc00cc6ccba78098afda4cf: Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:29 -0600 - rev 473195
Push 200 by fmarier@mozilla.com at Thu, 05 Jul 2018 23:51:35 +0000
Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
be7032cddad2709068fb4606e10167697ba1944d: Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:29 -0600 - rev 473177
Push 200 by fmarier@mozilla.com at Thu, 05 Jul 2018 23:51:35 +0000
Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
221137d1c2de7988bfcb63deb258737fe8fb29ce: Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
Aaron Klotz <aklotz@mozilla.com> - Wed, 27 Jun 2018 11:51:29 -0600 - rev 473163
Push 200 by fmarier@mozilla.com at Thu, 05 Jul 2018 23:51:35 +0000
Bug 1460022: Part 9 - Update sandboxing code to work with revised DLL interceptor interface; r=bobowen
028265406fe7486dc66f142e234927f7b3736f20: Bug 1461421 Add OffsetOf patch to chromium patch directory r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 08 Jun 2018 12:28:26 -0500 - rev 472588
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1461421 Add OffsetOf patch to chromium patch directory r=bobowen MozReview-Commit-ID: 3td0bc2PHzu
cf350ebb3004dc8eb8c7ea4b22b4ae79ea958ca1: Bug 1461421 Use OffsetOf to calculate the location of parameters_ rather than making assumptions about the parent class r=bobowen
Tom Ritter <tom@mozilla.com> - Thu, 07 Jun 2018 13:08:27 -0500 - rev 472587
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1461421 Use OffsetOf to calculate the location of parameters_ rather than making assumptions about the parent class r=bobowen MozReview-Commit-ID: D7REZiAIMpN
a910482f4598931944910a357431b22f823578fb: Bug 1366256 - Part 4: Add plugin DLL to plugin sandbox exceptions list. r=bobowen
David Parks <dparks@mozilla.com> - Thu, 03 May 2018 16:40:19 -0700 - rev 467358
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1366256 - Part 4: Add plugin DLL to plugin sandbox exceptions list. r=bobowen This permits opening the DLL from the plugin sandbox under the USER_LIMITED sandbox setting (plugin sandbox level 3).
55e0a25f9535cecaae020bfc94d5962266823663: Bug 1366256 - Part 1: Promote Windows plugin process sandbox to level 3. r=bobowen
David Parks <dparks@mozilla.com> - Wed, 21 Feb 2018 03:48:45 -0800 - rev 467355
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1366256 - Part 1: Promote Windows plugin process sandbox to level 3. r=bobowen Level 3 changes the plugin process access token from USER_INTERACTIVE to USER_LIMITED.
72edf78c24efbdccb1a46bc0c9e4377a7d4be493: Bug 1462100 Add the 'cast to void*' MinGW sandbox patch to the chromium patchlist r=bobowen
Tom Ritter <tom@mozilla.com> - Thu, 17 May 2018 10:10:50 -0500 - rev 466946
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1462100 Add the 'cast to void*' MinGW sandbox patch to the chromium patchlist r=bobowen MozReview-Commit-ID: 457xxFsnjTL
8d4ac4eb034cc3aa81849abe218451dbee78786b: Bug 1462100 Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc r=bobowen
Tom Ritter <tom@mozilla.com> - Wed, 16 May 2018 14:18:20 -0500 - rev 466945
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1462100 Cast to void* to avoid conversion errors on MinGW, which does not do the automatic conversion like msvc r=bobowen MozReview-Commit-ID: 8fO9Nu9gaxh
4d7c95672b79599a1192419115e2b25245f7fad1: Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 11 May 2018 08:16:13 -0500 - rev 466683
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build r=bobowen MozReview-Commit-ID: 2muTxIYUx6F
ea4f3168c604994f051644b467aad92723448d12: Bug 1450708 - Ref-count the plugin FunctionBroker mutex. r=bobowen a=jcristau FIREFOX_60_0_BUILD2 FIREFOX_60_0_RELEASE
David Parks <dparks@mozilla.com> - Mon, 23 Apr 2018 13:48:06 -0700 - rev 465655
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1450708 - Ref-count the plugin FunctionBroker mutex. r=bobowen a=jcristau Instead of contending with the idiosyncracies of the platform implementations of condition variables, which have been leading to strange crashes, we hold this mutex as a ref-counted object and avoid complex object lifetime reasoning.
968f78c16b2261b8a5bf11dee8099a3b94887046: Bug 1450773 - Remove restricting SIDs from NPAPI sandbox outside of nightly builds. r=bobowen, a=jcristau
David Parks <dparks@mozilla.com> - Mon, 02 Apr 2018 15:27:07 -0700 - rev 464998
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1450773 - Remove restricting SIDs from NPAPI sandbox outside of nightly builds. r=bobowen, a=jcristau Restricting SIDs, which harden the sandbox, have caused some problems that we are investigating in nightly and that we don't want in beta/release.
9d8a25ef4fd74e465fcc75a7fc12c6671024a88f: Bug 1435286 - Stop recording draw events for reference DrawTargets returned from PrintTarget. r=bobowen a=RyanVM
Jonathan Watt <jwatt@jwatt.org> - Thu, 18 Jan 2018 12:45:18 +0000 - rev 463991
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1435286 - Stop recording draw events for reference DrawTargets returned from PrintTarget. r=bobowen a=RyanVM MozReview-Commit-ID: 1cE71hBCGx5
75912c7725910ed540e53348c4620add73f36000: Bug 1261175. r=bobowen a=gchang
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 14 Nov 2017 10:31:36 +1300 - rev 463642
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1261175. r=bobowen a=gchang MozReview-Commit-ID: B9yAN0F01rj
59c2cb4225938b754a44b1c79877a988722e4a0c: Bug 1417939 - do not crash in release builds when a PRFileDescStream is closed twice; r=bobowen a=gchang
Alex Gaynor <agaynor@mozilla.com> - Thu, 16 Nov 2017 13:38:33 -0500 - rev 462740
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1417939 - do not crash in release builds when a PRFileDescStream is closed twice; r=bobowen a=gchang This makes it API compatible with std::ostream, which it replaced. This silences a rare crash. MozReview-Commit-ID: JoNo1qRCb0n
1e02fd7fa20cca193353c033b8e4cfb2027c5e0e: Bug 1450708 - Ref-count the plugin FunctionBroker mutex. r=bobowen
David Parks <dparks@mozilla.com> - Mon, 23 Apr 2018 13:48:06 -0700 - rev 460388
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1450708 - Ref-count the plugin FunctionBroker mutex. r=bobowen Instead of contending with the idiosyncracies of the platform implementations of condition variables, which have been leading to strange crashes, we hold this mutex as a ref-counted object and avoid complex object lifetime reasoning.
b7090423b82be3dbf32830d0290b45621407ccfa: Bug 1455328 - handle repeated calls to ContentParent::AllocPPrintingParent more gracefully; r=bobowen
Alex Gaynor <agaynor@mozilla.com> - Thu, 19 Apr 2018 10:28:20 -0400 - rev 459559
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1455328 - handle repeated calls to ContentParent::AllocPPrintingParent more gracefully; r=bobowen MozReview-Commit-ID: FPl7zr7imPC
5365c443117be2ef5d68f484be2f9ada663c2f8a: Bug 1450773 - Remove restricting SIDs from NPAPI sandbox outside of nightly builds. r=bobowen
David Parks <dparks@mozilla.com> - Mon, 02 Apr 2018 15:27:07 -0700 - rev 456563
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1450773 - Remove restricting SIDs from NPAPI sandbox outside of nightly builds. r=bobowen Restricting SIDs, which harden the sandbox, have caused some problems that we are investigating in nightly and that we don't want in beta/release.
c08e6bfa67d07357d94a4acc92b0c5ede674d816: Bug 1366256: Part 1 - Promote Windows plugin process sandbox to level 3 r=bobowen
David Parks <dparks@mozilla.com> - Wed, 21 Feb 2018 03:48:45 -0800 - rev 453907
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1366256: Part 1 - Promote Windows plugin process sandbox to level 3 r=bobowen Level 3 changes the plugin process access token from USER_INTERACTIVE to USER_LIMITED.
32d6774930e55be5c03e8d631fc067a995623c1e: Bug 1438678 - Pass early prefs via shared memory instead of the command line. r=bobowen,jld,glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 16 Feb 2018 17:54:16 +1100 - rev 452719
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1438678 - Pass early prefs via shared memory instead of the command line. r=bobowen,jld,glandium. This patch replaces the large -intPrefs/-boolPrefs/-stringPrefs flags with a short-lived, anonymous, shared memory segment that is used to pass the early prefs. Removing the bloat from the command line is nice, but more important is the fact that this will let us pass more prefs at content process start-up, which will allow us to remove the early/late prefs split (bug 1436911). Although this mechanism is only used for prefs, it's conceivable that it could be used for other data that must be received very early by children, and for which the command line isn't ideal. Notable details: - Much of the patch deals with the various platform-specific ways of passing handles/fds to children. - Linux and Mac: we use a fixed fd (8) in combination with the new GeckoChildProcessHost::AddFdToRemap() function (which ensures the child won't close the fd). - Android: like Linux and Mac, but the handles get passed via "parcels" and we use the new SetPrefsFd() function instead of the fixed fd. - Windows: there is no need to duplicate the handle because Windows handles are system-wide. But we do use the new GeckoChildProcessHost::AddHandleToShare() function to add it to the list of inheritable handles. We also ensure that list is processed on all paths (MOZ_SANDBOX with sandbox, MOZ_SANDBOX without sandbox, non-MOZ_SANDBOX) so that the handles are marked as inheritable. The handle is passed via the -prefsHandle flag. The -prefsLen flag is used on all platforms to indicate the size of the shared memory segment. - The patch also moves the serialization/deserialization of the prefs in/out of the shared memory into libpref, which is a better spot for it. (This means Preferences::MustSendToContentProcesses() can be removed.) MozReview-Commit-ID: 8fREEBiYFvc
d45bbc02ad0ddab649f1c7387c6942a1a19381a6: Bug 499025 - Don't open an error pop-up if the user cancels printing. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Tue, 06 Feb 2018 20:14:47 +0000 - rev 451532
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 499025 - Don't open an error pop-up if the user cancels printing. r=bobowen This fixes PrintTargetWindows::BeginPrinting to detect when the user cancels and have it return NS_ERROR_ABORT in that case. The rest of the changes are simply making sure that the various call points up the call stack don't print a warning message if NS_ERROR_ABORT is returned up from PrintTargetWindows::BeginPrinting. MozReview-Commit-ID: 6xZ5SPje6TT
f0ec180993d2b42e2d622c54efaadd33b70418c8: Bug 1261175. r=bobowen a=lizzard
Matt Woodrow <mwoodrow@mozilla.com> - Tue, 14 Nov 2017 10:31:36 +1300 - rev 450518
Push 147 by fmarier@mozilla.com at Mon, 19 Mar 2018 23:15:26 +0000
Bug 1261175. r=bobowen a=lizzard MozReview-Commit-ID: B9yAN0F01rj
9659c9a29139b0b66e1cfdeb26dd7735f4846006: Bug 1415160: Part 2 - Add mitigations to plugin process if not running from network drive r=bobowen
David Parks <dparks@mozilla.com> - Thu, 21 Dec 2017 12:36:02 -0800 - rev 448564
Push 140 by fmarier@mozilla.com at Tue, 20 Feb 2018 00:21:38 +0000
Bug 1415160: Part 2 - Add mitigations to plugin process if not running from network drive r=bobowen Adds MITIGATION_IMAGE_LOAD_NO_REMOTE and MITIGATION_IMAGE_LOAD_NO_LOW_LABEL to the plugin process if we aren't running from a networked drive. The same condition applies to these mitigations in the content process.
e6fc425cf9b479597aacc8646b1d21b2c529e299: Bug 1415160: Part 1 - Enable new NPAPI Windows Process Mitigations; r=bobowen
David Parks <dparks@mozilla.com> - Wed, 20 Dec 2017 22:58:26 -0800 - rev 448563
Push 140 by fmarier@mozilla.com at Tue, 20 Feb 2018 00:21:38 +0000
Bug 1415160: Part 1 - Enable new NPAPI Windows Process Mitigations; r=bobowen Enables new process mitigations that have been included from Chromium upstream.
202bc739dda8746e28808470a77a3892444e2483: Bug 1407693 - Part 1 - Expose method for sharing a HANDLE to a child process in the sandboxing API; r=bobowen
Alex Gaynor <agaynor@mozilla.com> - Mon, 27 Nov 2017 14:34:48 -0600 - rev 447994
Push 137 by fmarier@mozilla.com at Thu, 15 Feb 2018 20:52:22 +0000
Bug 1407693 - Part 1 - Expose method for sharing a HANDLE to a child process in the sandboxing API; r=bobowen MozReview-Commit-ID: 3LBCzPS6Mzg
6d91302395a30740e59deac0f9036467385b767b: Bug 1230910 Enable the sandbox for MinGW r=bobowen
Tom Ritter <tom@mozilla.com> - Tue, 23 Jan 2018 14:46:03 -0600 - rev 447527
Push 135 by fmarier@mozilla.com at Sat, 10 Feb 2018 02:56:15 +0000
Bug 1230910 Enable the sandbox for MinGW r=bobowen MozReview-Commit-ID: K3nj4eZZof7
f18e1e557cf67ba54300e198124f697389ef973f: Bug 1407693 - Part 1 - Expose method for sharing a HANDLE to a child process in the sandboxing API; r=bobowen
Alex Gaynor <agaynor@mozilla.com> - Mon, 27 Nov 2017 14:34:48 -0600 - rev 447420
Push 135 by fmarier@mozilla.com at Sat, 10 Feb 2018 02:56:15 +0000
Bug 1407693 - Part 1 - Expose method for sharing a HANDLE to a child process in the sandboxing API; r=bobowen MozReview-Commit-ID: 3LBCzPS6Mzg
cafa6e286cc522770fa311d01b67f8522d95aa3f: Bug 1426733: Use restricting SIDs in Windows NPAPI process r=bobowen
David Parks <dparks@mozilla.com> - Wed, 20 Dec 2017 21:35:26 -0800 - rev 447070
Push 133 by fmarier@mozilla.com at Thu, 08 Feb 2018 00:09:42 +0000
Bug 1426733: Use restricting SIDs in Windows NPAPI process r=bobowen Allow NPAPI sandbox to use restricting SIDs.
2ec583a00c078700add6a3615f6b6af12756695c: Bug 1435286 - Stop recording draw events for reference DrawTargets returned from PrintTarget. r=bobowen
Jonathan Watt <jwatt@jwatt.org> - Thu, 18 Jan 2018 12:45:18 +0000 - rev 446796
Push 132 by fmarier@mozilla.com at Wed, 07 Feb 2018 00:44:43 +0000
Bug 1435286 - Stop recording draw events for reference DrawTargets returned from PrintTarget. r=bobowen MozReview-Commit-ID: 1cE71hBCGx5
5506a531ce36201fb5a5432cc32856e39d5ef98d: Bug 1431803 Disable a specific __try block on MinGW r=bobowen
Tom Ritter <tom@mozilla.com> - Fri, 19 Jan 2018 13:26:22 -0600 - rev 446438
Push 128 by fmarier@mozilla.com at Fri, 02 Feb 2018 22:40:15 +0000
Bug 1431803 Disable a specific __try block on MinGW r=bobowen This function is a technique to name a thread for debugging purposes, and it always throws an exception (and then continues). On MinGW we don't want it to throw an exception, so we do nothing. This means on MinGW we won't get nice thread naming during debugging, but we'll limp along. MozReview-Commit-ID: JRKY4wp7sdu
c0de1027fbdab6f93e38854be19bbb936012339c: Bug 1431803 Turn __try into if(true) and __except into else in the chromium sandbox code r=bobowen,glandium
Tom Ritter <tom@mozilla.com> - Mon, 22 Jan 2018 12:18:51 -0600 - rev 446437
Push 128 by fmarier@mozilla.com at Fri, 02 Feb 2018 22:40:15 +0000
Bug 1431803 Turn __try into if(true) and __except into else in the chromium sandbox code r=bobowen,glandium MinGW doesn't support __try / __except. There are a few mechanisms available to hack around it and pseudo-support it, but these are untested in Firefox. What is tested (and works) is replacing them with if(true) and else. So we do that to neuter them in all places. There is only one situation where we need to actively modify the code (because it always throws an exception) and that situation is resolved in the other patch of this bug. MozReview-Commit-ID: IySnfxDlmW3
6067a5ed02a14505ba43b7a4b3c9e61f00b6dbbc: Bug 1431797 Fix capitalization in mozilla files so the sandbox can compile on MinGW r=bobowen
Tom Ritter <tom@mozilla.com> - Wed, 24 Jan 2018 14:27:21 -0600 - rev 445258
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1431797 Fix capitalization in mozilla files so the sandbox can compile on MinGW r=bobowen This patch also adds the capitalization patch file to the chromium patches MozReview-Commit-ID: BzAkEtCKAi4
8b4b24642ae391540f1366d06cc8f9a0589753db: Bug 1431797 Correct the capitalization of headers inside the chromium code so MinGW can compile r=bobowen
Tom Ritter <tom@mozilla.com> - Wed, 24 Jan 2018 14:25:59 -0600 - rev 445257
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1431797 Correct the capitalization of headers inside the chromium code so MinGW can compile r=bobowen MozReview-Commit-ID: DFlruq4iIUe
112289b0c7846d2b782cd14a011a8d3708842057: Bug 1432790 Fix MinGW Sandbox linking error about not being able to find _ReturnAddress() r=bobowen
Tom Ritter <tom@mozilla.com> - Tue, 23 Jan 2018 22:08:21 -0600 - rev 445248
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1432790 Fix MinGW Sandbox linking error about not being able to find _ReturnAddress() r=bobowen This reverts 6e41201152dd (Bug 1431621) which compiled but did not link. It also fixes the original issue by removing the stray \ at the end of the line that was causing the error. MozReview-Commit-ID: LgaxYK3EOwR
0530e041d7e641898e7f49b8b5c7361542ad502e: Bug 1432811 - remove duplicative #if clauses in process spawning; r=bobowen
Alex Gaynor <agaynor@mozilla.com> - Wed, 24 Jan 2018 10:48:33 -0500 - rev 445204
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1432811 - remove duplicative #if clauses in process spawning; r=bobowen MozReview-Commit-ID: FcvqEBbBxcW
c8f7369ca8f9e247073da3e683bc7cd37c380411: Bug 1432313 Convert the ui64 suffix to uLL r=bobowen
Tom Ritter <tom@mozilla.com> - Mon, 22 Jan 2018 16:16:08 -0600 - rev 445019
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1432313 Convert the ui64 suffix to uLL r=bobowen MinGW doesn't recognize the ui64 prefix, but uLL is equivalent. MozReview-Commit-ID: Do3hikKzxY7
8dd3b7fc54803ffd231f9336b829a7b0abe80799: Bug 1432295 Cast GetProcAddress to (void*) r=bobowen
Tom Ritter <tom@mozilla.com> - Tue, 23 Jan 2018 09:15:44 -0600 - rev 445018
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1432295 Cast GetProcAddress to (void*) r=bobowen error: invalid conversion from 'FARPROC {aka int (__attribute__((__stdcall__)) *)()}' to 'void*' [-fpermissive] According to http://stackoverflow.com/questions/13958081/, msvc does the fixup MozReview-Commit-ID: HTghe9uL0EP
b3ddabc679cf293abd89bea2c6548e0979e1993c: Bug 1432239 Declare operator new [](size_t, sandbox::AllocationType, void*) r=bobowen
Tom Ritter <tom@mozilla.com> - Wed, 08 Mar 2017 19:16:46 +0000 - rev 445017
Push 124 by fmarier@mozilla.com at Tue, 30 Jan 2018 01:38:36 +0000
Bug 1432239 Declare operator new [](size_t, sandbox::AllocationType, void*) r=bobowen MozReview-Commit-ID: GCKj5Ao2Y2n