searching for reviewer(ato)
3e89ff5068b74d316950337330b6c46cc7a50c5c: Bug 1430717 - Re-enable test_cli_arguments.py TestCommandLineArguments.test_startup_timeout. r=ato
Henrik Skupin <mail@hskupin.info> - Tue, 23 Oct 2018 10:55:47 +0000 - rev 490932
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1430717 - Re-enable test_cli_arguments.py TestCommandLineArguments.test_startup_timeout. r=ato Differential Revision: https://phabricator.services.mozilla.com/D9495
9234d32ec23c45c8ba1ebce723d57adcf784fc57: Bug 1397612 - [marionette] Re-enable test TestQuitRestart.test_in_app_restart_safe_mode. r=ato
Henrik Skupin <mail@hskupin.info> - Mon, 22 Oct 2018 14:16:38 +0000 - rev 490688
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1397612 - [marionette] Re-enable test TestQuitRestart.test_in_app_restart_safe_mode. r=ato Differential Revision: https://phabricator.services.mozilla.com/D9389
9a2be0efbc4c4f1931f39a1dfe4a082cec09b2e0: Bug 1500242 - [marionette] Obey the extended shutdown timeout for Firefox ASAN builds. r=ato
Henrik Skupin <mail@hskupin.info> - Fri, 19 Oct 2018 11:52:42 +0000 - rev 490489
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500242 - [marionette] Obey the extended shutdown timeout for Firefox ASAN builds. r=ato Firefox uses different shutdown timeouts for the terminator thread depending on the build type. For opt/debug builds this will be 60s, while for ASAN builds 180s are used. Currently Marionette only takes the 60s into account, and always kills the binary after 70s if a shutdown hasn't happened by that time. This actually prevents the background hang monitor to kill Firefox for ASAN builds, and to report a meaningful crash report for the shutdown hang. To inform clients about the correct shutdown timeout, a new vendor specific capability with the name `moz:shutdownTimeout` is used as part of the new session capabilities. Depends on D9227 Differential Revision: https://phabricator.services.mozilla.com/D9228
9645a734546be91c08cdba441d7003259e51bda8: Bug 1500242 - [marionette] Don't modify DEFAULT_SHUTDOWN_TIMEOUT constant. r=ato
Henrik Skupin <mail@hskupin.info> - Fri, 19 Oct 2018 11:54:13 +0000 - rev 490488
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500242 - [marionette] Don't modify DEFAULT_SHUTDOWN_TIMEOUT constant. r=ato Differential Revision: https://phabricator.services.mozilla.com/D9227
57877c614829ff051ed0e2b66f895292e904b207: Bug 1497898 - Update gecko wpt manifest update to use caches, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:42 +0000 - rev 490485
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Update gecko wpt manifest update to use caches, r=ato Depends on D8231 Differential Revision: https://phabricator.services.mozilla.com/D8232
22a06c8c8dc6ea3a7413904dc486eb2bc2ac2f92: Bug 1497898 - Update manifest before tests, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:40 +0000 - rev 490484
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Update manifest before tests, r=ato Depends on D8230 Differential Revision: https://phabricator.services.mozilla.com/D8231
7bba4d617db672ba06b026f3f5d9e067e0c01d0d: Bug 1497898 - Pass the manifest file directly into wpttest.from_manifest, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:38 +0000 - rev 490483
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Pass the manifest file directly into wpttest.from_manifest, r=ato Depends on D8229 Differential Revision: https://phabricator.services.mozilla.com/D8230
3a9a7760db5c9e1bf584657ef14f1afbdeee5a91: Bug 1497898 - Fix the .gitignore rules, r=ato
James Graham <james@hoppipolla.co.uk> - Thu, 11 Oct 2018 12:20:40 +0000 - rev 490482
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Fix the .gitignore rules, r=ato Depends on D8228 Differential Revision: https://phabricator.services.mozilla.com/D8229
c482d18cc0507e202e004238c15a3bb30b64a837: Bug 1497898 - Fix the cache lifecycle, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:34 +0000 - rev 490481
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Fix the cache lifecycle, r=ato The caches weren't being invalidated when the manifest itself changed. To fix this the manifest itself has to be written before the cache and the cache has to include data about the manifest that it's associated with (the mtime and path are used for this purpose). To make all this work requires a single method that can load the manifest, update it, write the manifest and write the caches. Therefore we introduce a single load_and_update method that is intended to replace all previous use of the load() or update() methods (and as a bonus handles manifest version mismatches in a single place). Depends on D8227 Differential Revision: https://phabricator.services.mozilla.com/D8228
2caa5633dea13f347932979888fc3424f50c4c77: Bug 1497898 - Add a custom implementation of os.walk, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:32 +0000 - rev 490480
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Add a custom implementation of os.walk, r=ato Compared to the normal os.walk this has a couple of differences: * It returns lists of (name, stat) for filenames and directories, allowing callers to reuse the stat data without going back to the system to re-request it. * Directories are always returned as paths relative to the root, and the root itself is returned as the empty string. * It is non-recursive. There are also a few features missing that aren't required for our use cases. Depends on D8226 Differential Revision: https://phabricator.services.mozilla.com/D8227
48be184d5377dd0aee94eca7ef5a3c4d369069c1: Bug 1497898 - Add manifest caches for the mtime and gitignore rules, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:30 +0000 - rev 490479
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Add manifest caches for the mtime and gitignore rules, r=ato When processing the manifest using the worktree, instead of reading all files to see if the content changed, instead only process files where the mtime has been updated since the previous run. Also cache the result of running gitignore, so we can save a couple of seconds processing the gitignore rules. Depends on D8225 Differential Revision: https://phabricator.services.mozilla.com/D8226
184bc31c33a6edba5ddb13d1daef81c39f87370f: Bug 1497898 - Update the lint to the new gitignore API, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:23 +0000 - rev 490478
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Update the lint to the new gitignore API, r=ato Depends on D8224 Differential Revision: https://phabricator.services.mozilla.com/D8225
c3cb0408498cd890dba6038de0debf247ba03324: Bug 1497898 - Update the gitignore implementation to work as an iterator filter, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:21 +0000 - rev 490477
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Update the gitignore implementation to work as an iterator filter, r=ato This updates the gitignore implemenation to take input like os.walk but with additional stat data for the files. It also makes several useful optimistaions: * Avoid using regex when just matching a literal * Identify patterns that can only match the final component of a path and run those against that component rather than the full path. * Add the possibility of providing a dictionary of paths to gitignore statuses as a cache. This dramatically reduces the amount of time we spend in gitignore processing when updating the manifest. Depends on D8223 Differential Revision: https://phabricator.services.mozilla.com/D8224
a6a89509add7962cae05fc9b7e504c42910a7147: Bug 1497898 - Allow the gitignore filter to work on name components only, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:19 +0000 - rev 490476
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Allow the gitignore filter to work on name components only, r=ato We end up with a lot of rules like (?:.*)/.*\.ext which are basically trying to find the last component in a path and match against that. These are rather slow to run so the easiest thing tdo is just pass in the last component of the path when we know that's the only thing the rule can match. The changes to surrounding code to use this API will be made in future commits. Depends on D8222 Differential Revision: https://phabricator.services.mozilla.com/D8223
9afac925aef8a815e674ffb2e56c4220f7913004: Bug 1497898 - Update the .gitignore file, r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 10 Oct 2018 17:51:17 +0000 - rev 490475
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Update the .gitignore file, r=ato Depends on D8221 Differential Revision: https://phabricator.services.mozilla.com/D8222
5e3b8ad4c8f42342d9d16723236261501aafd040: Bug 1497898 - Use testfile mtimes to pre-filter files iterated over for the manifest update, r=ato
Ahilya Sinha <ahilyasinha99@gmail.com> - Thu, 11 Oct 2018 12:26:30 +0000 - rev 490474
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497898 - Use testfile mtimes to pre-filter files iterated over for the manifest update, r=ato Differential Revision: https://phabricator.services.mozilla.com/D8221
228e7fe1545959bf5cedfe6e25c5e8dd91ec0a1a: Bug 1494229 - [marionette] Advertise Phabricator for submitting patches in the docs. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 18 Oct 2018 19:06:53 +0000 - rev 490334
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494229 - [marionette] Advertise Phabricator for submitting patches in the docs. r=ato DONTBUILD Depends on D8981 Differential Revision: https://phabricator.services.mozilla.com/D8982
17432131026dfd5e16a8a2935fa4421c56be585e: Bug 1494229 - [marionette] Improve documentation for new contributors. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 18 Oct 2018 19:06:25 +0000 - rev 490333
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494229 - [marionette] Improve documentation for new contributors. r=ato DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D8981
d4de0eb65962f0aa404ac7e632d46a8f7f296557: Bug 1481723 - Enable wpt css tests on Windows, r=ato
James Graham <james@hoppipolla.co.uk> - Thu, 19 Jul 2018 14:13:20 +0100 - rev 490230
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1481723 - Enable wpt css tests on Windows, r=ato MozReview-Commit-ID: ekP5TOSaRM Differential Revision: https://phabricator.services.mozilla.com/D7201
d7c8b670ac687fc3e7b98820a5a4fecc046f51b0: Bug 1494974 - Ensure the reftest canvas always maintains the same size, r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 11 Sep 2018 18:58:35 +0100 - rev 490228
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494974 - Ensure the reftest canvas always maintains the same size, r=ato Differential Revision: https://phabricator.services.mozilla.com/D7197
4dfb6e690645619a71da734ee66ea658a1ef253a: Bug 1490272 - Use the marionette reftest implemenation on Windows, r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 11 Sep 2018 11:23:22 +0100 - rev 490227
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1490272 - Use the marionette reftest implemenation on Windows, r=ato Differential Revision: https://phabricator.services.mozilla.com/D5519
ec819897ecf5bf71fdf6239ae17be5f9794e12ae: Bug 1494719 - Set hidechrome on reftest window, r=ato
James Graham <james@hoppipolla.co.uk> - Fri, 21 Sep 2018 18:07:34 +0100 - rev 489968
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494719 - Set hidechrome on reftest window, r=ato This fixes a problem caused by rounded corners on macOS. Differential Revision: https://phabricator.services.mozilla.com/D7199
24c9f26fc9924fb895e9884ebb19738210440247: Bug 1490096 - Don't make the wpt reftest window a Dialog, r=ato
James Graham <james@hoppipolla.co.uk> - Thu, 20 Sep 2018 14:26:48 +0100 - rev 489967
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1490096 - Don't make the wpt reftest window a Dialog, r=ato This seems to break it opening at the right dimensions on Windows 7 Differential Revision: https://phabricator.services.mozilla.com/D7198
463d82852c31d6709c4c176afd0da2be799d13b5: Bug 1397612 - [marionette] Re-enable test TestQuitRestart.test_in_app_restart_safe_mode. r=ato
Henrik Skupin <mail@hskupin.info> - Tue, 16 Oct 2018 14:16:40 +0000 - rev 489850
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1397612 - [marionette] Re-enable test TestQuitRestart.test_in_app_restart_safe_mode. r=ato Differential Revision: https://phabricator.services.mozilla.com/D8837
97be1d70d0cd4637a4bd02e984d179b3f1a600e8: Bug 1499135 - ensure 'no browsing context' test in clear.py isn't relying on the previous page runs, r=ato
Olli Pettay <Olli.Pettay@helsinki.fi> - Tue, 16 Oct 2018 07:19:31 -0400 - rev 489763
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499135 - ensure 'no browsing context' test in clear.py isn't relying on the previous page runs, r=ato
7b5cc9b80a3e2630baf823181caca717e2c80a8a: Bug 1494637 - [geckodriver] Remove custom serialization of JavascriptCommandParameters for Marionette. r=ato
Henrik Skupin <mail@hskupin.info> - Mon, 15 Oct 2018 20:35:33 +0000 - rev 489692
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494637 - [geckodriver] Remove custom serialization of JavascriptCommandParameters for Marionette. r=ato The argument "specialPowers" is no longer used in Marionette and as such can be removed from the serialization. The default value for "newSandbox" in Marionette is false, so it doesn't need to be explicitely set in geckodriver. By removing those two properties a custom serialization is no longer neccessary. Depends on D7210 Differential Revision: https://phabricator.services.mozilla.com/D7211
88d826bf6a68a5f9ead87b17f51ec3747b3e86a9: Bug 1497094 - Add missing attribute is_shutting_down to Marionette python client r=ato
David Burns <dburns@mozilla.com> - Mon, 15 Oct 2018 13:54:27 +0000 - rev 489652
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497094 - Add missing attribute is_shutting_down to Marionette python client r=ato Differential Revision: https://phabricator.services.mozilla.com/D8525
4204f9fab5fea59e25e6413726b65976540b3432: Bug 1433873 - Fix race condition in Marionette client for in_app quit and restart. r=ato
Henrik Skupin <mail@hskupin.info> - Fri, 05 Oct 2018 16:43:18 +0000 - rev 488186
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1433873 - Fix race condition in Marionette client for in_app quit and restart. r=ato Both methods are poorly handling the phase when the application is about to quit/restart. Especially when a callback is used to trigger the application shutdown. This patch makes sure that in case of an active shutdown the do_process_check decorator doesn't trigger a socket failure, and also correctly waits for the application to shutdown, or being restarted. Differential Revision: https://phabricator.services.mozilla.com/D7897
a1fc734c080fa60eb7da39941c56e9fb18e68f78: Bug 1496311 - [geckodriver] Fix broken formatting of table in Support.md. r=ato
Henrik Skupin <mail@hskupin.info> - Fri, 05 Oct 2018 12:45:43 +0000 - rev 488162
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496311 - [geckodriver] Fix broken formatting of table in Support.md. r=ato Differential Revision: https://phabricator.services.mozilla.com/D7859
2adff75db60c9f2f8bfaa7c72093757ed20adcc5: Bug 1495372 - Unify wpt manifest download and update, r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 02 Oct 2018 16:46:42 +0100 - rev 487916
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495372 - Unify wpt manifest download and update, r=ato The previous code split a lot of logic between the update and download parts, and exposed two different mach commands. In order to simplify things it's better to have a single entry point for manifest download and update, and ensure that's called consistently. Differential Revision: https://phabricator.services.mozilla.com/D7497
8660ad891a23c389512aa8d9d1fb122096df6741: Bug 1495372 - Unify wpt manifest download and update r=ato
James Graham <james@hoppipolla.co.uk> - Wed, 03 Oct 2018 15:43:44 +0000 - rev 487785
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495372 - Unify wpt manifest download and update r=ato The previous code split a lot of logic between the update and download parts, and exposed two different mach commands. In order to simplify things it's better to have a single entry point for manifest download and update, and ensure that's called consistently. Differential Revision: https://phabricator.services.mozilla.com/D7497
347e93fd4d032db27bd760140cee7dfd3ab5e6d4: Bug 1493832 - marionette: cleanup dead code from server.js r=ato
Andrey Lushnikov <aslushnikov@gmail.com> - Wed, 03 Oct 2018 15:11:43 +0000 - rev 487779
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493832 - marionette: cleanup dead code from server.js r=ato Differential Revision: https://phabricator.services.mozilla.com/D6732
d47b208203c898cff3172b9c05e72ee8a5dc8a4a: Bug 1495007 - Ensure that we capture stdio from executor subprocess r=ato
James Graham <james@hoppipolla.co.uk> - Mon, 01 Oct 2018 06:49:58 +0000 - rev 487291
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495007 - Ensure that we capture stdio from executor subprocess r=ato Multiprocessing on Linux and OSX implictly inherits the stdio handles into the subprocess. But on Windows that doesn't happen because it doesn't have fork() to abuse in the same way. So instead we need to ensure that we explicitly set up handling of stdio immediately after starting the executor subprocess to avoid gettin non-structured output. Differential Revision: https://phabricator.services.mozilla.com/D7186
ace8fc8c112ec192ae853157875f1be6ea43a755: Bug 1494308 - Use consistent logger in wpt commands r=ato
James Graham <james@hoppipolla.co.uk> - Sat, 29 Sep 2018 14:51:44 +0000 - rev 487248
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494308 - Use consistent logger in wpt commands r=ato Before we were using a different logger for the manifest download and the actual test run. This caused timestamps to get reset in a confusing way. Now create the logger early and share it for all the subseteps. Depends on D7171 Differential Revision: https://phabricator.services.mozilla.com/D7172
70f1b33a2dacf7798be831b35d0dec474ea5b067: Bug 1494960 - Remove wpt-reduce mach command r=ato
James Graham <james@hoppipolla.co.uk> - Sat, 29 Sep 2018 14:49:25 +0000 - rev 487247
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494960 - Remove wpt-reduce mach command r=ato As far as I know this was unused and hasn't been well maintained since it's not that useful. Differential Revision: https://phabricator.services.mozilla.com/D7171
77cf6aa75d7ebe8c871cd1fe5736d47b92e999e5: Bug 1494637 - [geckodriver] Only serialize non null arguments for Marionette. r=ato
Henrik Skupin <mail@hskupin.info> - Sat, 29 Sep 2018 15:34:38 +0000 - rev 487227
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494637 - [geckodriver] Only serialize non null arguments for Marionette. r=ato Differential Revision: https://phabricator.services.mozilla.com/D7210
daf8260b674ded70fddf2c8161d76563f95ef2d4: Bug 1494187 - Run the manifest download steps before trying to update the manifest, r=ato
James Graham <james@hoppipolla.co.uk> - Thu, 27 Sep 2018 14:37:47 +0100 - rev 487002
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494187 - Run the manifest download steps before trying to update the manifest, r=ato This ensures that we always start from a partial manifest where possible and also ensures that the configuration files are correctly created (a refactor to create these irrespective of whether we do a download would make sense, but this fixes the immediate problem) Depends on D7088 Differential Revision: https://phabricator.services.mozilla.com/D7089
b96612d7ee8811a94132f6f0b7e8e0a9e36e8ffa: Bug 1494187 - Ensure wpt metadata directory exists in objdir before trying to write there, r=ato
James Graham <james@hoppipolla.co.uk> - Thu, 27 Sep 2018 14:35:17 +0100 - rev 487001
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494187 - Ensure wpt metadata directory exists in objdir before trying to write there, r=ato Usually this directory is created by the build system. However if we run ./mach wpt-manifest-update before trying to do a build it can error out. Just creating the directory should be enough to fix this. Differential Revision: https://phabricator.services.mozilla.com/D7088
fc7d1d5fd6f63737b7f2f4e836ce04dd1e74e9ee: Bug 1494617 - [geckodriver] Fix evaluation of "desiredCapabilities" and "requiredCapabilities". r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 27 Sep 2018 12:06:00 +0000 - rev 486891
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494617 - [geckodriver] Fix evaluation of "desiredCapabilities" and "requiredCapabilities". r=ato The refactoring of the webdriver crate to use Serde (bug 1396821) caused this regression. By instructing Serde to correctly rename both properties fixes it. Differential Revision: https://phabricator.services.mozilla.com/D7079
6155b2f3b9c12681fc4767cc5961ec2c1c199e6b: Bug 1493149 - [geckodriver] "temporary" flag in AddonInstallParameters has to be optional. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 27 Sep 2018 08:37:29 +0000 - rev 486881
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493149 - [geckodriver] "temporary" flag in AddonInstallParameters has to be optional. r=ato With the Serde refactoring we have made this flag mandatory. This patch reverts that change, and allows it to be skipped. Differential Revision: https://phabricator.services.mozilla.com/D7050
8c84bd8283872a6ac2702c6956936a376a23f930: Bug 1494509 - disable geckodriver on aarch64 windows; r=ato
Nathan Froyd <froydnj@mozilla.com> - Thu, 27 Sep 2018 12:44:02 -0400 - rev 486847
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494509 - disable geckodriver on aarch64 windows; r=ato
f8d681cc1d4cdd5095853077c0acc95576baa6dd: Bug 1473814 - [wdspec] Add user prompt tests for more WebDriver commands. r=ato
Henrik Skupin <mail@hskupin.info> - Wed, 26 Sep 2018 17:16:36 +0000 - rev 486732
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1473814 - [wdspec] Add user prompt tests for more WebDriver commands. r=ato This adds the user prompt tests for those commands which clearly have to handle the prompt. But it still leaves out those commands where the behavior hasn't been clarified yet. Differential Revision: https://phabricator.services.mozilla.com/D6927
23601a34a9b2649071a75f9a230b9a76e7ae9e5a: Bug 1493546 - Only uppercase printable keys when shift modifier is set. r=ato
Henrik Skupin <mail@hskupin.info> - Tue, 25 Sep 2018 13:01:21 +0100 - rev 486712
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493546 - Only uppercase printable keys when shift modifier is set. r=ato Differential Revision: https://phabricator.services.mozilla.com/D6776
1a24a41b377e518c30cf2e3ba687af4debce2a01: Bug 1493546 - Only uppercase printable keys when shift modifier is set. r=ato
Henrik Skupin <mail@hskupin.info> - Wed, 26 Sep 2018 08:27:39 +0000 - rev 486673
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493546 - Only uppercase printable keys when shift modifier is set. r=ato Differential Revision: https://phabricator.services.mozilla.com/D6776
56894c8957aecf7ce0336691b24a55469bccbd06: Bug 1493674 - Use in-tree metadata rather than relying on links in the objdir r=ato
James Graham <james@hoppipolla.co.uk> - Tue, 25 Sep 2018 12:03:34 +0000 - rev 486505
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1493674 - Use in-tree metadata rather than relying on links in the objdir r=ato Differential Revision: https://phabricator.services.mozilla.com/D6673
bdb144bdca1649682b0a34712eb9aad3c4c799da: Bug 1405370 - [wdspec] Add test that shift modifier produces capital letters. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 20 Sep 2018 15:40:55 +0200 - rev 486052
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1405370 - [wdspec] Add test that shift modifier produces capital letters. r=ato
7c1a9d25aaf013ee3ec9b6856445dabe5ac484a1: Bug 1405370 - [wdspec] Reorganize key action tests for "Perform Actions". r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 20 Sep 2018 15:39:31 +0200 - rev 486051
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1405370 - [wdspec] Reorganize key action tests for "Perform Actions". r=ato
2998b10eb5a79d16557f5bf5b176482afe68522c: Bug 1405370 - [marionette] Synthesized key event for "Shift" has to capitalize typable characters. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 20 Sep 2018 12:24:27 +0200 - rev 486050
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1405370 - [marionette] Synthesized key event for "Shift" has to capitalize typable characters. r=ato The current code only capitalizes the "keyName" and not the "modifier.key" property. As such the capitalization gets lost, because in "event.createKeyboardEventDictionary_()" the "modifier.key" property gets precedence over "keyName". To not have to capitalize both at this level, it's better to move this code directly into "event.createKeyboardEventDictionary_()". This also makes the method "event.sendSingleKey()" useless, so it can be removed.
eec10aa9703c57236f64461c6b37ba9bbe06b4b8: Bug 1405370 - [marionette] Remove obsolete extra keypress event firing. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 20 Sep 2018 12:05:18 +0200 - rev 486049
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1405370 - [marionette] Remove obsolete extra keypress event firing. r=ato As already mentioned in the comment above the code it is all done automatically by "event.synthesizeKey()".
3125cc183560de4287dd3e2cdf4cb9edcc39eb7f: Bug 1405370 - [marionette] Add missing keys to virtual keyboard lookup table. r=ato
Henrik Skupin <mail@hskupin.info> - Thu, 20 Sep 2018 11:34:19 +0200 - rev 486048
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1405370 - [marionette] Add missing keys to virtual keyboard lookup table. r=ato Until now we only supported the internal Unicode to virtual key mapping at the standard and left location of the keyboard. This patch adds all the remaining special keys which are located at the right side and in the numpad area. This mapping table is somewhat equivalent to the normalized key translation, but is using the "VK_" prefix.