searching for reviewer(aosmond)
67bada7dcad029d68c0abe1d7c03fc225352f2ec: Bug 1501523 - part 2 - remove separate jpeg_nbits_table copies from assembly files; r=aosmond
Nathan Froyd <froydnj@mozilla.com> - Wed, 24 Oct 2018 16:06:48 -0400 - rev 491136
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501523 - part 2 - remove separate jpeg_nbits_table copies from assembly files; r=aosmond Continuing the theme from the first part, the optimized assembly files for x86-64 and i386 include their own private copies of jpeg_nbits_table. There's no need for them to do so; they can make use of the C copy that we commonized in the first patch.
cd76fd701f82dc9211bc8323e9948dedc866af9f: Bug 1501523 - part 1 - externalize jpeg_nbits_table from jpeg_nbits_table.h; r=aosmond
Nathan Froyd <froydnj@mozilla.com> - Wed, 24 Oct 2018 16:06:48 -0400 - rev 491135
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501523 - part 1 - externalize jpeg_nbits_table from jpeg_nbits_table.h; r=aosmond The current setup means that including jpeg_nbits_table.h creates a 64K static table in the current compilation unit...for every inclusion of jpeg_nbits_table.h. Since we have two such inclusions, we have two copies of this table, and the linker is not merging them; perhaps there is a limit on the size of identical blobs of data it will merge. In any event, this setup is suboptimal; instead, we should have a single instance of jpeg_nbits_table in some external source file, and the header can declare it like any other variable.
1dee16fa95e5257ecef4c8edf5e325732a4aa7dc: Bug 1500733 - Remove canvas.imagebitmap_extensions.enabled preference, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:44 +0200 - rev 490929
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500733 - Remove canvas.imagebitmap_extensions.enabled preference, r=aosmond
8b5a4cd42d40d1ff27ec63265960f7e6fd43dfea: Bug 1500733 - Remove tests, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:44 +0200 - rev 490928
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500733 - Remove tests, r=aosmond
e324b60281ddc58a514dc84db048431a64312a01: Bug 1500733 - Remove ImageBitmap.findOptimalFormat, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:44 +0200 - rev 490927
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500733 - Remove ImageBitmap.findOptimalFormat, r=aosmond
17ac83c08f67ff1e3846c375de8d5dd0851580b3: Bug 1500733 - Remove ImageBitmap.mappedDataLength, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:44 +0200 - rev 490926
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500733 - Remove ImageBitmap.mappedDataLength, r=aosmond
3c81d4cb6aea693144608f2f78eb4b893b2687f3: Bug 1500733 - Remove ImageBitmap.mapDataInto, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:44 +0200 - rev 490925
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500733 - Remove ImageBitmap.mapDataInto, r=aosmond
dac317f3cd311d70772b55ee65c5ba3051e60fe3: Bug 1500733 - Remove the support for BufferSource in createImageBitmap, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:43 +0200 - rev 490924
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500733 - Remove the support for BufferSource in createImageBitmap, r=aosmond
cdc621a21acc1cd486abd0342a5b3fec89f594a5: Bug 1497925 - CreateImageBitmap must ignore the Blob.type value, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:43 +0200 - rev 490923
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497925 - CreateImageBitmap must ignore the Blob.type value, r=aosmond
dcaf26b9678bf7183892c56fe3dfcb52f7c393d9: Bug 1500786 - createImageBitmap should throw InvalidStateError with already closed imageBitmap as input, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:43 +0200 - rev 490922
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500786 - createImageBitmap should throw InvalidStateError with already closed imageBitmap as input, r=aosmond
b273730d6149f687c46ed375ccc47674a3ef5afd: Bug 1500780 - CreateImageBitmap should handle OOM as InvalidState error, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:43 +0200 - rev 490921
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500780 - CreateImageBitmap should handle OOM as InvalidState error, r=aosmond
083f0be93a9f9da00b886cba36ca1e48fc168f5b: Bug 1500736 - CreateImageBitmap should throw InvalidStateError when the allocation fails, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 23:35:43 +0200 - rev 490920
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500736 - CreateImageBitmap should throw InvalidStateError when the allocation fails, r=aosmond
ce374302821c1a202263562910e7888ed455f5d8: Bug 1500734 - createImageBitmap should throw RangeError if sw or sh is 0 - r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 23 Oct 2018 08:17:28 +0200 - rev 490748
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500734 - createImageBitmap should throw RangeError if sw or sh is 0 - r=aosmond
ec0b10e9a616588eb248a72dd117582b00211fab: Bug 1256603. Change MultipartImage to use RequestDecode instead of GetFrame to avoid marking the frame as used. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sun, 14 Oct 2018 00:38:42 -0500 - rev 489482
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1256603. Change MultipartImage to use RequestDecode instead of GetFrame to avoid marking the frame as used. r=aosmond
2cc5b3f51ec4fa0501af01e4ece67be0eed814c4: Bug 1256603. Fix comment in ImageLoader. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:03 -0500 - rev 489366
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1256603. Fix comment in ImageLoader. r=aosmond
d8bb90ade0d68eaf309127cb51840c722e4008b5: Bug 1256603. Fix comment for imgIContainer::RequestDecodeForSize to match reality. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:03 -0500 - rev 489365
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1256603. Fix comment for imgIContainer::RequestDecodeForSize to match reality. r=aosmond
479653ce6d8c31dd5cddc815f9ad19a5b06b7fda: Bug 1256603. Make aMarkUsed parameters required everywhere. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:03 -0500 - rev 489364
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1256603. Make aMarkUsed parameters required everywhere. r=aosmond
8421b16c011ba49a2e495f81853b282413aa7650: Bug 1256603. Only mark images as used in the surface cache if we actually use them. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Sat, 13 Oct 2018 00:31:02 -0500 - rev 489363
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1256603. Only mark images as used in the surface cache if we actually use them. r=aosmond We were marking them used even if only a decode was requested. This can cause us to hold extra decoded copies of the image around because we have a tendency to request decode at the intrinsic size.
a3fa8bb51b3c4a1d3751fddf3db69bc770eb8aae: Bug 1425835 - Update libjpeg-turbo to version 2.0.0. r=aosmond
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 09 Oct 2018 15:23:57 +0000 - rev 488621
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1425835 - Update libjpeg-turbo to version 2.0.0. r=aosmond Also includes the fix for upstream issue #288 to avoid crashes on some older Win7 systems. Differential Revision: https://phabricator.services.mozilla.com/D7758
135eaacf1dfc66c289367a665473e67a650407b9: Bug 1495738 - Image cache entry should compare the window ID together with the loadID because the loadID can be a reused pointer, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 02 Oct 2018 17:05:21 +0200 - rev 487491
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495738 - Image cache entry should compare the window ID together with the loadID because the loadID can be a reused pointer, r=aosmond
912ad8891041d872998e36a7090ea60246310ceb: Bug 1490938. Pass the high quality scaling flag when we request decode of images in most cases. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Thu, 27 Sep 2018 18:30:17 -0500 - rev 487455
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1490938. Pass the high quality scaling flag when we request decode of images in most cases. r=aosmond If we do not pass the high quality scaling flag than the resulting surface will be marked as cannot substitute, which is not accurate, so we don't want. The only place that actually tries to be smart about the size is nsImageFrame::MaybeDecodeForPredictedSize. All other cases just ask for the intrinsic size. The two most likely cases are that there are no decoded copies of the image, or there is one decoded (or in progress) copy of the image. In the first case we will request decode at the instrinsic size, and then if we draw at a different size that draw will request the proper size. This doesn't change with this patch. In the second case there is a decoded copy already available, this is likely from a draw call on the image, and that is the surface size that we want. So we save a decode. If we are actually drawing the image at two different sizes the second size will be slightly delayed, but we have the wrongly sized copy of the image that we can draw until then. This seems like a good tradeoff to avoid always decoding an instrinic size copy of images.
0236f549f73f1e220ba0d44e7a3e350c252dd2a4: Bug 1434490. Avoid overflow in nsPNGEncoder::WriteCallback. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Fri, 28 Sep 2018 23:23:01 -0500 - rev 487177
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1434490. Avoid overflow in nsPNGEncoder::WriteCallback. r=aosmond
a94730ef300e11980098601d90b0f86d4ef87423: Bug 1494528 - Call GPUProcessManager::EnsureGPUReady() before accessing gfxVars::UseWebRender() r=aosmond
sotaro <sotaro.ikeda.g@gmail.com> - Fri, 28 Sep 2018 09:06:26 +0900 - rev 486935
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494528 - Call GPUProcessManager::EnsureGPUReady() before accessing gfxVars::UseWebRender() r=aosmond
4e5643db5a23372cc1095c5ef60eca76b958c493: Bug 1491467 - Update libpng to 1.6.35. r=aosmond
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 18 Sep 2018 18:33:11 +0000 - rev 485473
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491467 - Update libpng to 1.6.35. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D5913
7437e9e313b48aa491c877c249348c323c105a70: Bug 1487091 - remove an unused element from a graphics IPDL union; r=aosmond
Alex Gaynor <agaynor@mozilla.com> - Thu, 30 Aug 2018 00:35:08 +0000 - rev 482989
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1487091 - remove an unused element from a graphics IPDL union; r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D4543
58968b3702fd25b217a4eddf6d3348df8c1fcbc0: Bug 1476779. Remove expired IMAGE_ANIMATED_* telemetry. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Mon, 06 Aug 2018 22:40:31 -0500 - rev 478553
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1476779. Remove expired IMAGE_ANIMATED_* telemetry. r=aosmond It was added to monitor the impact of bug 686905. Which went as expected, no spikes or alerts since then. So no need to keep it.
42983355094d0bb4151673575907394b0b05b7c0: Bug 1476592 - Remove the cache from nsCSPContext - part 2 - sendViolationReports parameter, r=ckerschb, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 01 Aug 2018 06:35:24 +0200 - rev 477805
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1476592 - Remove the cache from nsCSPContext - part 2 - sendViolationReports parameter, r=ckerschb, r=aosmond
b09ee6fada54d69c9f0bfddc0ac8048683bd650f: Bug 1476058 - consider no image to be successful for wr. r=aosmond
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 24 Jul 2018 13:32:42 -0400 - rev 476667
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1476058 - consider no image to be successful for wr. r=aosmond MozReview-Commit-ID: 2fIz82TG1F5
6542094579891a14e768187fe020ae2161616441: Bug 1465452 Part 4 - Don't sort image loader requests and frames when recording/replaying, r=aosmond.
Brian Hackett <bhackett1024@gmail.com> - Mon, 23 Jul 2018 14:59:01 +0000 - rev 476111
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1465452 Part 4 - Don't sort image loader requests and frames when recording/replaying, r=aosmond.
40423bb8aa180813c4eb1cc58dcee9f0ad440841: Bug 1470108 - Write a test to see how the anti-tracking blocking works with cached images, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 04 Jul 2018 15:52:01 +0200 - rev 473249
Push 200 by fmarier@mozilla.com at Thu, 05 Jul 2018 23:51:35 +0000
Bug 1470108 - Write a test to see how the anti-tracking blocking works with cached images, r=aosmond
546b7b24b71b371321f0cd7b6b49babd09aeddd7: Bug 1472145 - Part 3. Initialize boolean WebP telemetry scalars to ensure accurate reporting. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Tue, 03 Jul 2018 08:12:17 -0400 - rev 473036
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1472145 - Part 3. Initialize boolean WebP telemetry scalars to ensure accurate reporting. r=aosmond
12a849d78301b32f4d800dfe50944fc6f4f810b4: Bug 1469000: Fix image to layout transform for invalidation. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 Jun 2018 17:51:53 +0200 - rev 472219
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1469000: Fix image to layout transform for invalidation. r=aosmond When computing image to layout transforms for invalidation, use the actual intrinsic size of the source image, instead of the layout intrinsic size, which may be scaled by ResponsiveImageSelector since bug 1149357. I have absolutely no idea how to write a test for this, suggestions welcome. MozReview-Commit-ID: LP6C9fSvMi2
2a94bdf78194df4c5ff16769310abe152534c98f: Bug 1268889 - Implement Clear-Site-Data header - part 4 - cleanup image cache, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 20 Jun 2018 11:57:50 -0400 - rev 471501
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1268889 - Implement Clear-Site-Data header - part 4 - cleanup image cache, r=aosmond
f1401b74761911baf8a453d26bfc2add5573e1e2: Bug 1461921 - Block storage access for third-parties on the tracking protection list - part 6 - Image cache, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 20 Jun 2018 13:38:22 -0400 - rev 471360
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1461921 - Block storage access for third-parties on the tracking protection list - part 6 - Image cache, r=aosmond
da427a67372e19b219eaec6fada813babfd6e4b2: Bug 1268889 - Implement Clear-Site-Data header - part 4 - cleanup image cache, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Wed, 20 Jun 2018 11:57:50 -0400 - rev 471351
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1268889 - Implement Clear-Site-Data header - part 4 - cleanup image cache, r=aosmond
e996438ca5008a3b569d03df4ddfce673b9ac0ab: Bug 1467311 - Fix linux64-ccov/opt beta test build bustage. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Thu, 07 Jun 2018 10:37:27 -0400 - rev 469995
Push 193 by fmarier@mozilla.com at Fri, 08 Jun 2018 00:53:54 +0000
Bug 1467311 - Fix linux64-ccov/opt beta test build bustage. r=aosmond
c8429320386e60f8da51d3df151fbb2c3abc2c99: Bug 1465496 - Backout part 9 of bug 1462355 to fix talos regressions. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Wed, 30 May 2018 19:35:40 -0400 - rev 468769
Push 185 by fmarier@mozilla.com at Mon, 04 Jun 2018 18:38:09 +0000
Bug 1465496 - Backout part 9 of bug 1462355 to fix talos regressions. r=aosmond
3880e9b11a7a0c8321baf6ab0bc86d3748e7d854: Backed out changeset 6c8bf287d25b (bug 1462431) for web platform reftest failure. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Fri, 18 May 2018 08:59:26 -0400 - rev 467034
Push 179 by fmarier@mozilla.com at Fri, 25 May 2018 23:33:48 +0000
Backed out changeset 6c8bf287d25b (bug 1462431) for web platform reftest failure. r=aosmond
1a6f6fdaa772538a85509ff524da1bf6ed3d44c3: Bug 1433037 - WindowsPreviewPerTab should use decodeImageAsync. r=aosmond, a=RyanVM
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 26 Mar 2018 17:59:11 +0200 - rev 464821
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1433037 - WindowsPreviewPerTab should use decodeImageAsync. r=aosmond, a=RyanVM
395d409b9bf52b975a8b29b81a3e00472c9f0f6e: Bug 1416726 Allocate TextureReadLock at TextureClient creation and drop file handles immediately after. r=aosmond a=jcristau
Ryan Hunt <rhunt@eqrion.net> - Mon, 12 Mar 2018 08:10:13 -0500 - rev 464593
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1416726 Allocate TextureReadLock at TextureClient creation and drop file handles immediately after. r=aosmond a=jcristau This changes the lifecycle and API for TextureReadLock to fix file descriptor exhaustion crashes. These changes are partially superficial and mostly align the API of TextureReadLocks with their actual usage. The changes are: 1. Create the TextureReadLock in the TextureClient constructor so it's available before IPC creation a. This is superficial as EnableReadLock was always called before IPC creation 2. Send the ReadLockDescriptor in the PTextureConstructor message and close the file handle 3. Receive the ReadLockDescriptor in TextureHost and close the file handle 4. Send a boolean flag in layer transactions if the texture is read locked instead of a descriptor 5. Use a boolean flag in TextureHost to determine if the ReadLock must be unlocked instead of a nullptr I believe that we can remove the InitReadLocks code from LayerTransaction as that was added to prevent file descriptor limits in IPDL messages and is no longer needed with this change. But that is a non-essential change and this patch is already big enough. MozReview-Commit-ID: DzHujrOQejH
7e3488313a539b11ad1c684490c68b52f6a89349: Bug 1460258 - Re-enable discarding of animated image frames. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Wed, 09 May 2018 08:42:58 -0400 - rev 462517
Push 166 by fmarier@mozilla.com at Thu, 10 May 2018 00:43:18 +0000
Bug 1460258 - Re-enable discarding of animated image frames. r=aosmond
b3e2845ac301da9d9d015d4a268eb6abc9f434b0: Bug 1425484 - Part 5. Correct prototype of TakeExternalSurfaces. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Sun, 29 Apr 2018 18:48:39 -0400 - rev 461194
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1425484 - Part 5. Correct prototype of TakeExternalSurfaces. r=aosmond
bba12a996009ac1727a0251fc4689027289848bc: Bug 1425484 - Part 4. Followup to fix shared surface lifetime issue with blob images. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Fri, 27 Apr 2018 09:05:40 -0400 - rev 460989
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1425484 - Part 4. Followup to fix shared surface lifetime issue with blob images. r=aosmond
8bcaeaf2a5a02a28e88a932c50fef64cd09df8b2: Bug 1430215 - Check on the principal in mozilla::dom::CheckSecurityForHTMLElements in case SurfaceFromElement returns an incomplete result, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 20 Apr 2018 07:29:12 +0200 - rev 459607
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1430215 - Check on the principal in mozilla::dom::CheckSecurityForHTMLElements in case SurfaceFromElement returns an incomplete result, r=aosmond
10424496394b06514993cd78c6521ef100795ebf: Backed out changeset 2efe54944e8c (bug 1453801) for linux64-qr awsy failures. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Tue, 17 Apr 2018 17:57:39 -0400 - rev 459114
Push 159 by fmarier@mozilla.com at Thu, 19 Apr 2018 00:14:50 +0000
Backed out changeset 2efe54944e8c (bug 1453801) for linux64-qr awsy failures. r=aosmond
19e60113f96dafd3931c8d1d852bdb3e64ac17dd: Backed out changeset e5336e51b77f (bug 1452467) for Windows static analysis build bustage on a CLOSED TREE. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Fri, 13 Apr 2018 10:14:12 -0400 - rev 458124
Push 159 by fmarier@mozilla.com at Thu, 19 Apr 2018 00:14:50 +0000
Backed out changeset e5336e51b77f (bug 1452467) for Windows static analysis build bustage on a CLOSED TREE. r=aosmond
e94fdbab0e4a65d4a25ab6d5749976ec51e465ef: Bug 1433037 - WindowsPreviewPerTab should use decodeImageAsync, r=aosmond
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 26 Mar 2018 17:59:11 +0200 - rev 454920
Push 151 by fmarier@mozilla.com at Thu, 05 Apr 2018 22:59:31 +0000
Bug 1433037 - WindowsPreviewPerTab should use decodeImageAsync, r=aosmond
c9cb048dfd438c26e58e416338a6cca24226ae80: Bug 1445802 - Disable broken asserts to unbreak Windows QR mda tests. r=aosmond
Andrew Osmond <aosmond@mozilla.com> - Thu, 15 Mar 2018 06:42:19 -0400 - rev 453229
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1445802 - Disable broken asserts to unbreak Windows QR mda tests. r=aosmond
28a7bf730789d1df2342f913938752f3e2409bbb: Remove ReadLockHandle and ReadLockInit code (bug 1445008, r=aosmond)
Ryan Hunt <rhunt@eqrion.net> - Tue, 13 Mar 2018 17:00:18 -0500 - rev 453103
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Remove ReadLockHandle and ReadLockInit code (bug 1445008, r=aosmond) This code is unused now that ReadLockDescriptors are not sent in layer transactions.
45b5743ae3adf8927ce620dc5f6ef02e7ba6c115: Allocate TextureReadLock at TextureClient creation and drop file handles immediately after. (bug 1416726, r=aosmond)
Ryan Hunt <rhunt@eqrion.net> - Mon, 12 Mar 2018 08:10:13 -0500 - rev 452588
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Allocate TextureReadLock at TextureClient creation and drop file handles immediately after. (bug 1416726, r=aosmond) This changes the lifecycle and API for TextureReadLock to fix file descriptor exhaustion crashes. These changes are partially superficial and mostly align the API of TextureReadLocks with their actual usage. The changes are: 1. Create the TextureReadLock in the TextureClient constructor so it's available before IPC creation a. This is superficial as EnableReadLock was always called before IPC creation 2. Send the ReadLockDescriptor in the PTextureConstructor message and close the file handle 3. Receive the ReadLockDescriptor in TextureHost and close the file handle 4. Send a boolean flag in layer transactions if the texture is read locked instead of a descriptor 5. Use a boolean flag in TextureHost to determine if the ReadLock must be unlocked instead of a nullptr I believe that we can remove the InitReadLocks code from LayerTransaction as that was added to prevent file descriptor limits in IPDL messages and is no longer needed with this change. But that is a non-essential change and this patch is already big enough. MozReview-Commit-ID: DzHujrOQejH