searching for reviewer(MattN)
03132dcf8ae5bf49bf58008bad7f97f0b9d3e4d4: Bug 1488011 - Set the checkbox label instead of using an adjacent XUL label so the checkbox focus ring appears correctly. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 24 Oct 2018 21:37:12 +0000 - rev 491224
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488011 - Set the checkbox label instead of using an adjacent XUL label so the checkbox focus ring appears correctly. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D9708
4c162e4eda0879b7ea1761c3db4679e403273479: Bug 1501478 - Fix payment dialog in browser.xhtml. r=MattN
Brendan Dahl <bdahl@mozilla.com> - Tue, 23 Oct 2018 22:43:12 +0000 - rev 491166
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501478 - Fix payment dialog in browser.xhtml. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D9602
740ead88dd207c38155800e176c693987a762d2d: Bug 1486954 - Part V, Prevent credit card record from being accessed if not initialize r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Thu, 18 Oct 2018 22:10:25 +0000 - rev 490745
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part V, Prevent credit card record from being accessed if not initialize r=MattN This patch changed the initialization of records so that we don't call into credit card AutofillRecords class if it is pref-off. Differential Revision: https://phabricator.services.mozilla.com/D9158
f5c7e2bc2d6315e9a28436c4a4849e0ae241c9a9: Bug 1486954 - Part IV, Recover from decryption errors in some places. r=MattN
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 22 Oct 2018 22:57:29 -0700 - rev 490744
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part IV, Recover from decryption errors in some places. r=MattN In case of loss of OS key store key, we should still allow users to go into the manage credit cards dialog and fill the numbers back in. This is not the migration strategy, see Part III. Differential Revision: https://phabricator.services.mozilla.com/D5083
91cb3b09931643fff6d036f70cbed3a711800a46: Bug 1486954 - Part III, Upgrade existing Nightly credit card records to OSKeyStore. r=MattN
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 22 Oct 2018 22:57:29 -0700 - rev 490743
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part III, Upgrade existing Nightly credit card records to OSKeyStore. r=MattN For Nightly users who already have credit cards saved in their profile, we will do a one-off upgrade of their encrypted credit card number. This only applies to users who have NO master password set, to avoid showing them the master password prompt when we migrate. For those who did, we would quietly delete their credit card record from the store. Differential Revision: https://phabricator.services.mozilla.com/D8029
21162d81c6d8252f629f537eb2b760f0bd2db8cb: Bug 1486954 - Part II, Remove OSKeyStore.isEnabled. r=MattN
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 22 Oct 2018 22:57:28 -0700 - rev 490742
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part II, Remove OSKeyStore.isEnabled. r=MattN Given that the new store is always considered enabled, the not-enabled code is now dead code. This patch removes them. Differential Revision: https://phabricator.services.mozilla.com/D5717
024dfb5b2d676ee40c45c9fb8b85674b8f6a04e1: Bug 1486954 - Part I, Encrypt credit card numbers with OS key store. r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:31:04 +0000 - rev 490741
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part I, Encrypt credit card numbers with OS key store. r=MattN This patch morphs MasterPassword.jsm to OSKeyStore.jsm while keeping the same API, as an adaptor between the API and the native API exposed as nsIOSKeyStore.idl. Noted that OS Key Store has the concept of "recovery phrase" that we won't be adopting here. The recovery phrase, together with our label, allow the user to re-create the same key in OS key store. Test case changes are needed because we have started asking for login in places where we'll only do previously when "master password is enabled". This also made some "when master password is enabled" tests invalid because it is always considered enabled. Some more test changes are needed simply because they previously rely on the stable order of microtask resolutions (and the stable # of promises for a specific operation). That has certainly changed with OSKeyStore. The credit card form autofill is only enabled on Nightly. Differential Revision: https://phabricator.services.mozilla.com/D4498
388806780facbc345aa5ce0e7cc6b6bc108b29e8: Bug 1494551 - Sort the formautofill data by the last used time. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 19 Oct 2018 17:00:31 +0000 - rev 490540
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1494551 - Sort the formautofill data by the last used time. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D9174
95fe4f9c32033b78245886e1e83f70675624977b: Bug 1420853 - Ensure only fields valid for the given country are saved. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 19 Oct 2018 16:36:45 +0000 - rev 490538
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1420853 - Ensure only fields valid for the given country are saved. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D9034
25594c3013c4852ee5441321b340983c2a8d6364: Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Diego Pino Garcia <dpino@igalia.com> - Thu, 18 Oct 2018 23:56:00 +0300 - rev 490397
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN Also require basicCardPage has a selectedStateKey
8b3b53341da242116ef6cba6a4d8439bad5b0fb2: Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Diego Pino Garcia <dpino@igalia.com> - Thu, 18 Oct 2018 15:25:49 -0700 - rev 490341
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN Also require basicCardPage has a selectedStateKey
afdfeb4c004cbba91d4d9e30a0e80e6dfb0dce60: Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 18 Oct 2018 03:42:59 +0000 - rev 490204
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8892
eb2a83cba95aafab7713af2a444de144320b31e9: Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN
Jared Wein <jwein@mozilla.com> - Wed, 17 Oct 2018 19:36:46 +0000 - rev 490155
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497039 - Put a placeholder in privacy.xul that will be used to inject the form-autofill section. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8892
3a4b8a6a0881ee031ce226f7a725d283e28f1137: Bug 1492671 - Disable screenshot capturing for triggering network requests in payments mochitests r=MattN
Andrei Oprea <andrei.br92@gmail.com> - Wed, 17 Oct 2018 15:08:50 +0000 - rev 490108
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492671 - Disable screenshot capturing for triggering network requests in payments mochitests r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8877
c895888bdddc97e36675e49844e7c115e0d6cc12: Bug 1486954 - Part IV, Recover from decryption errors in some places r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:34:22 +0000 - rev 489954
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part IV, Recover from decryption errors in some places r=MattN In case of loss of OS key store key, we should still allow users to go into the manage credit cards dialog and fill the numbers back in. This is not the migration strategy, see Part III. Differential Revision: https://phabricator.services.mozilla.com/D5083
27e9286503e8bfbb61ed2edfc374257b728fec6b: Bug 1486954 - Part III, Upgrade existing Nightly credit card records to OSKeyStore r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:33:02 +0000 - rev 489953
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part III, Upgrade existing Nightly credit card records to OSKeyStore r=MattN For Nightly users who already have credit cards saved in their profile, we will do a one-off upgrade of their encrypted credit card number. This only applies to users who have NO master password set, to avoid showing them the master password prompt when we migrate. For those who did, we would quietly delete their credit card record from the store. Differential Revision: https://phabricator.services.mozilla.com/D8029
87e64652386dd1fc08ebcc4ba7f1405805de20a1: Bug 1486954 - Part II, Remove OSKeyStore.isEnabled r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:32:05 +0000 - rev 489952
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part II, Remove OSKeyStore.isEnabled r=MattN Given that the new store is always considered enabled, the not-enabled code is now dead code. This patch removes them. Differential Revision: https://phabricator.services.mozilla.com/D5717
96a6e1ceb6977a32bc6a29f46f5a47622bfc4d50: Bug 1486954 - Part I, (Nighty-only feature) Encrypt credit card numbers with OS key store r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 17 Oct 2018 02:31:04 +0000 - rev 489951
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1486954 - Part I, (Nighty-only feature) Encrypt credit card numbers with OS key store r=MattN This patch morphs MasterPassword.jsm to OSKeyStore.jsm while keeping the same API, as an adaptor between the API and the native API exposed as nsIOSKeyStore.idl. Noted that OS Key Store has the concept of "recovery phrase" that we won't be adopting here. The recovery phrase, together with our label, allow the user to re-create the same key in OS key store. Test case changes are needed because we have started asking for login in places where we'll only do previously when "master password is enabled". This also made some "when master password is enabled" tests invalid because it is always considered enabled. Some more test changes are needed simply because they previously rely on the stable order of microtask resolutions (and the stable # of promises for a specific operation). That has certainly changed with OSKeyStore. The credit card form autofill is only enabled on Nightly. Differential Revision: https://phabricator.services.mozilla.com/D4498
73912f1633a16370d8b9410ebd35e6dc2532eb3d: Bug 1481971 - Enable PaymentRequest on Nightly for Windows/macOS for US/CA users on en-US builds r=MattN,baku,gandalf
Diego Pino Garcia <dpino@igalia.com> - Tue, 16 Oct 2018 16:14:12 -0700 - rev 489932
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1481971 - Enable PaymentRequest on Nightly for Windows/macOS for US/CA users on en-US builds r=MattN,baku,gandalf
4c98e1b28c388eed1ce835038f570cc0169ef389: Bug 1499474 - Check if the element has textContent before falling back to TestUtils.waitForCondition. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 16 Oct 2018 20:04:38 +0000 - rev 489884
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499474 - Check if the element has textContent before falling back to TestUtils.waitForCondition. r=MattN This patch reduced the time to run from 2 minutes to 15 seconds. Differential Revision: https://phabricator.services.mozilla.com/D8895
583d689d630e68cb1f2ae5ae1e7f27f2ca28f359: Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN
Sam Foster <sfoster@mozilla.com> - Tue, 16 Oct 2018 05:37:39 +0000 - rev 489752
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN * Change to isValidNumber to allow any number length in the range. This also removes 9 as a valid payment card number length * Amend form autocomplete test for sensitive 9 digit numbers. We no longer consider them valid cc numbers, test for 19 digit numbers instead * Fix intermittent issue in a session restore tests. It turns out Date.now().toString() can sometimes pass the Luhn algorithm and look like a valid credit card number. I believe this could lead to it being treated as sensitive data which is not saved and restored, failing the test Differential Revision: https://phabricator.services.mozilla.com/D8271
d545a48c1bfd7863036e179312f9fff45e335cff: Bug 1470199 - Add a tooltip for the CVV input. r=MattN
Jared Wein <jwein@mozilla.com> - Sat, 13 Oct 2018 00:39:02 +0000 - rev 489433
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1470199 - Add a tooltip for the CVV input. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7473
7de161eb2e1189967306da2a4f3f0b483b77a507: Bug 1496698 - Remove res/vendor from jar.mn; r=MattN
Mike Shal <mshal@mozilla.com> - Thu, 11 Oct 2018 22:13:34 +0000 - rev 489325
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496698 - Remove res/vendor from jar.mn; r=MattN Followup to remove the now non-existent directory from the manifest. MozReview-Commit-ID: 5grb4TgoBsT Differential Revision: https://phabricator.services.mozilla.com/D8466
31313cac4517c54061fe8207a965492cdde9b564: Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN
Sam Foster <sfoster@mozilla.com> - Thu, 11 Oct 2018 23:54:25 +0000 - rev 489160
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN * Change to isValidNumber to allow any number length in the range. This also removes 9 as a valid payment card number length * Amend form autocomplete test for sensitive 9 digit numbers. We no longer consider them valid cc numbers, test for 19 digit numbers instead * Fix intermittent issue in a session restore test. It turns out Date.now().toString() can sometimes pass the Luhn algorithm and look like a valid credit card number. I believe this could lead to it being treated as sensitive data which is not saved and restored, failing the test Differential Revision: https://phabricator.services.mozilla.com/D8271
e702628b7c514789f8372ac593da4ea9b445b7e2: Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 10 Oct 2018 23:23:11 +0000 - rev 488988
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1485105 - Allow 12-19 digit length card numbers. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D8271
e8f0ddeec2f167524896d22f4b4d4de4b88d1562: Bug 1451526 Convert mozscreenshots to a webextension r=MattN
Andrew Swan <aswan@mozilla.com> - Thu, 04 Oct 2018 21:41:06 +0000 - rev 488071
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1451526 Convert mozscreenshots to a webextension r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7613
32cde67dd330391a0fb6735be8309a64e646a5f7: Bug 1495530 - Use card icons in form autofill card preferences screen. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 03 Oct 2018 15:58:16 +0000 - rev 487788
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495530 - Use card icons in form autofill card preferences screen. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7334
bd55b04144dccce7c1875c165e3306ab86a743b6: Bug 1492950 - Get login prompter off of getBrowserForContentWindow. r=MattN
Mike Conley <mconley@mozilla.com> - Tue, 02 Oct 2018 17:52:54 +0000 - rev 487587
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492950 - Get login prompter off of getBrowserForContentWindow. r=MattN Depends on D6711 Differential Revision: https://phabricator.services.mozilla.com/D6712
bb9fc6495914b7176ce399f76df39caf2ba78472: Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r=Gijs,MattN
Mike Conley <mconley@mozilla.com> - Tue, 02 Oct 2018 17:50:42 +0000 - rev 487585
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492950 - Get rid of getTabModalPromptBox in browser.js. r=Gijs,MattN Depends on D6709 Differential Revision: https://phabricator.services.mozilla.com/D6710
44ab1f5c5056e853a345265d022c72402161bd6a: Bug 1473662 - Save button should be labelled 'Next' when adding a new address or card. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 28 Sep 2018 20:00:03 +0000 - rev 487162
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1473662 - Save button should be labelled 'Next' when adding a new address or card. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7209
04f74c53d537a5e826fb92bee20d75ecaac9e3d7: Bug 1477102 - Add third-party payment card logos, enable their use in official, branded builds. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 28 Sep 2018 16:53:49 +0000 - rev 487137
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1477102 - Add third-party payment card logos, enable their use in official, branded builds. r=MattN Depends on D7025 Differential Revision: https://phabricator.services.mozilla.com/D7026
6ce23e4daf8dcc0ec878f1620de85651755fc76b: Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 28 Sep 2018 16:53:37 +0000 - rev 487136
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D7025
3de6e1582de91e37bfaa1893aac4d026d1cebb7a: Bug 1470184 - Update the Preferences text and layout for Web Payments. r=flod,MattN
Jared Wein <jwein@mozilla.com> - Fri, 28 Sep 2018 08:29:01 +0000 - rev 487024
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1470184 - Update the Preferences text and layout for Web Payments. r=flod,MattN Differential Revision: https://phabricator.services.mozilla.com/D6937
e2f7985ef41dc4d5a4f088f49b74152c5323f95d: Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 27 Sep 2018 14:11:39 +0000 - rev 486906
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1470168 - Add tooltip beside 'Save to Firefox' checkbox. r=MattN I had to move the tooltip to appear above the help icon to make sure that it cause scrollbars to appear on the address form. Differential Revision: https://phabricator.services.mozilla.com/D6912
0871a9a488b510cdee45500335d1d5abf26e9bbf: Bug 1484325 Go back to chrome.manifest for formautofill locale registration r=MattN
Andrew Swan <aswan@mozilla.com> - Tue, 25 Sep 2018 06:03:20 +0000 - rev 486408
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1484325 Go back to chrome.manifest for formautofill locale registration r=MattN Differential Revision: https://phabricator.services.mozilla.com/D6690
b1fc8e9cb6010273e4d73b114d96f1f5271f3ceb: Bug 1490874: Update tests to comply with new script error logging mechanism. r=MattN
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Tue, 25 Sep 2018 07:52:30 +0200 - rev 486338
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1490874: Update tests to comply with new script error logging mechanism. r=MattN
29e7b5d5f5e4252ab268e176ee5576f4db146f7a: Bug 1481972 - Add remaining countries to address autofill countries list. r=MattN
Jared Wein <jwein@mozilla.com> - Sun, 23 Sep 2018 23:50:03 -0700 - rev 486169
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1481972 - Add remaining countries to address autofill countries list. r=MattN Saving and filling the countries via Form Autofill will still be limited to certain countries but this allows the storage to be useful for Web Payments in other countries. Differential Revision: https://phabricator.services.mozilla.com/D5194
75036af7d851f0fd893147f22aaab43483d6b65e: Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 21 Sep 2018 00:15:56 -0700 - rev 485994
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca> Differential Revision: https://phabricator.services.mozilla.com/D6420
29f6f86fb9cd6981a0677c3edc6ad30768909ca7: Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 21 Sep 2018 00:15:56 -0700 - rev 485932
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca> Differential Revision: https://phabricator.services.mozilla.com/D6420
e7e27205f4cd30ee985575ef54b20b0a55514df1: Bug 1478880 - payments/test/browser/head.js: fillInCardForm reliability fixes. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 20 Sep 2018 20:44:03 -0700 - rev 485889
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1478880 - payments/test/browser/head.js: fillInCardForm reliability fixes. r=MattN * Blur before focus to reset timer for filtering <select> * Wait for field to get focus before sending keys to it. * Compare unpadded strings Differential Revision: https://phabricator.services.mozilla.com/D6338
33a833eab4180576b7ffda7193b15f8d8f3eb508: Bug 1491791 - Update the Save button state after the 'change' event. r=MattN
Jared Wein <jwein@mozilla.com> - Thu, 20 Sep 2018 17:13:26 +0000 - rev 485855
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491791 - Update the Save button state after the 'change' event. r=MattN The validity of the cc-number field is only updated to a failure state after the 'change' event in the EditCreditCard class, but there was no code within basic-card-form.js to update the Save button enabled state after the 'change' event had been handled by EditCreditCard. Differential Revision: https://phabricator.services.mozilla.com/D6282
8889fed6e2cf56f4e6a9540c9477a7ecf0e39c02: Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 19 Sep 2018 22:10:50 +0000 - rev 485704
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D6318
45df249c38950c41434d43a376d8ecbd4dbfcaef: Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 19 Sep 2018 20:57:26 +0000 - rev 485701
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D6322
90201e199fea722a9255b82d0add65c6cf298caf: Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
Sam Foster <sfoster@mozilla.com> - Wed, 19 Sep 2018 18:15:11 +0000 - rev 485654
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN * A new accepted-cards element to represent the labeled list of card icons * Add the accepted cards section to the summary and card add/edit page * mochitest for the accepted-cards element * Make cc-type a required field and validate it against the list of supported networks * Add verification of the pay button disabling when card network is not supported Depends on D5823 Differential Revision: https://phabricator.services.mozilla.com/D5824
7351a4c8d1a12361238dc7df4fb8d5bfe03b2555: Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 14 Sep 2018 20:28:41 +0000 - rev 484821
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN * A new accepted-cards element to represent the labeled list of card icons * Add the accepted cards section to the summary and card add/edit page * mochitest for the accepted-cards element * Make cc-type a required field and validate it against the list of supported networks * Add verification of the pay button disabling when card network is not supported Depends on D5823 Differential Revision: https://phabricator.services.mozilla.com/D5824
a1a4703b84642dfa7250e68be0b26ec9b15df10c: Bug 1429181 - Fix serialization of payment method data. r=MattN
Sam Foster <sfoster@mozilla.com> - Fri, 14 Sep 2018 20:24:08 +0000 - rev 484820
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1429181 - Fix serialization of payment method data. r=MattN * Includes a workaround to explicitly cloneInto the paymentMethods data when we create the PaymentRequest object in the content window in tests. MozReview-Commit-ID: LFy0h3fIXXA Differential Revision: https://phabricator.services.mozilla.com/D5823
4b3b3a1db0dfbffe3e08e8d1e4f660fabf584ac4: Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 05 Sep 2018 17:54:48 +0000 - rev 483325
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN This also makes various AutofillRecords methods async, with the exception of remove() and removeAll(). Noted that I didn't implement any kind of "lock" for FormAutofillStorage -- please do not call these methods concurrently -- if you must please |await| for the last call to resolve. This most likely would happen in tests, and shouldn't happen in the real world, given that all user actions happen on macrotasks, and probably not at the next tick, unless Quicksilver is a Firefox user. FormAutofillStorage can be improved if there are complex use cases for it. Differential Revision: https://phabricator.services.mozilla.com/D4420
56aa054d4cc02a3c1c845d81ba8cc10f43260f05: Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
Timothy Guan-tin Chien <timdream@gmail.com> - Wed, 05 Sep 2018 00:32:57 +0000 - rev 483074
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN This also makes various AutofillRecords methods async, with the exception of remove() and removeAll(). Noted that I didn't implement any kind of "lock" for FormAutofillStorage -- please do not call these methods concurrently -- if you must please |await| for the last call to resolve. This most likely would happen in tests, and shouldn't happen in the real world, given that all user actions happen on macrotasks, and probably not at the next tick, unless Quicksilver is a Firefox user. FormAutofillStorage can be improved if there are complex use cases for it. Differential Revision: https://phabricator.services.mozilla.com/D4420
ad88fc39b67b3bfe04391548b84919e7f4624ea6: Bug 1484721 - Update the save button disabled state after changing the country select dropdown in the address-form. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 31 Aug 2018 16:15:51 +0000 - rev 482662
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484721 - Update the save button disabled state after changing the country select dropdown in the address-form. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D4470
ee00cb44157bcc4a066cb4a5275288e4782b2f4d: Bug 1480719 - Require credit card expiration month and year before saving credit cards. r=MattN
Jared Wein <jwein@mozilla.com> - Fri, 31 Aug 2018 16:36:34 +0000 - rev 482661
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1480719 - Require credit card expiration month and year before saving credit cards. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D4485