searching for reviewer(Honza)
a6499b00d6d6bac010206d457bb1643f7f68e1ed: Bug 1501674 - Update MDN HTTP doc mappings. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Thu, 25 Oct 2018 14:39:57 +0000 - rev 491340
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501674 - Update MDN HTTP doc mappings. r=Honza Update MDN HTTP doc mappings. Differential Revision: https://phabricator.services.mozilla.com/D9668
f266aa4cd4b04f7cec1fffeec4fccd1baafdf244: Bug 1438979 - Fix browser_webconsole_network_messages_expand.js intermittent; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 24 Oct 2018 06:14:16 +0000 - rev 491056
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1438979 - Fix browser_webconsole_network_messages_expand.js intermittent; r=Honza. This is an attempt to fix the intermittent on this test. It looks like we were setting the listeners on some events after the request message was received, which might have made us missed some events. We take this bug as an opportunity to do some cleanup on the test. Differential Revision: https://phabricator.services.mozilla.com/D9075
9a6f5e359f1d3a281253b5cfa18f4f7502dd4d5e: Bug 1500475 - Fix browser_jsterm_content_defined_helpers.js intermittent; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 22 Oct 2018 14:23:55 +0000 - rev 490690
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500475 - Fix browser_jsterm_content_defined_helpers.js intermittent; r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D9360
527ac367e301ec8b55b4b226ceeca47cb87d130f: Bug 1340100 - Set 'request cause' according to the original request. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Mon, 22 Oct 2018 13:48:47 +0000 - rev 490679
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1340100 - Set 'request cause' according to the original request. r=Honza Set 'request cause' according to the original request. Differential Revision: https://phabricator.services.mozilla.com/D8126
aa628ce24d80d9966a0bcdfce6bc0469da509c34: Bug 1498531 - Localize Webconsole WebReplay Jump icon; r=loganfsmyth,Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 22 Oct 2018 05:26:33 +0000 - rev 490627
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498531 - Localize Webconsole WebReplay Jump icon; r=loganfsmyth,Honza. This patch adds localization for the WebReplay Jump icon, and uses the same terminology as the one used in the context menu that triggers the same action. The Jump button was used in-place of the existing level icons (Error, Warning, …), and was only displayed when the message was hovered. We now ensure the level icon is always visible and that we only show the Jump icon when the message is hovered. Finally, the button was styled targeting the title attribute in CSS, which seemed a little brittle. We now use a dedicated class which should be safer and more future proof. Differential Revision: https://phabricator.services.mozilla.com/D8533
1ef10ec64cb7993648efa0b5a0dab01ea2be53e7: Bug 1493837 - Fix intermittent on browser_jsterm_await.js; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Fri, 19 Oct 2018 07:06:12 +0000 - rev 490432
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1493837 - Fix intermittent on browser_jsterm_await.js; r=Honza. The test is failing because the result of the last evaluation is received before we expect it. Since we had a 500ms delay between each promise resolution, it might happen than the time it takes to execute the command execedes this delay, making our expected message order wrong. Increasing the delay between each Promise resolution seems to resolve the issue, although it makes the test a lot longer too. This is why a new test was created to only cover the concurrent await case. Differential Revision: https://phabricator.services.mozilla.com/D8698
646f2d021c1163ac0c58c3878aa6921dc92311cb: Bug 1499042 - "Fix learn more links in the Network panel". r=Honza
<lba_2> - Thu, 18 Oct 2018 06:54:00 +0300 - rev 490398
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499042 - "Fix learn more links in the Network panel". r=Honza
5be96992e33cfdbd85374a419aeb1b8734a2edab: Bug 1499614 - Enable top-level await support on every release channel; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Oct 2018 10:10:37 +0000 - rev 490250
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499614 - Enable top-level await support on every release channel; r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D8955
c645265aa5b827fac52c3692991cbd55558d5821: Bug 1499070 - Fix timestamp for evaluation result; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 18 Oct 2018 09:41:53 +0000 - rev 490249
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499070 - Fix timestamp for evaluation result; r=Honza. When sending a command to the server, a timestamp is computed before evaluating the string, and is then sent back to the client in the packet. However, if top-level await, or somme :commands, the evaluation takes more time, which means the timestamp is now innacurate. For those cases, we update the timestamp before sending the packet to the client. Differential Revision: https://phabricator.services.mozilla.com/D8734
4fa33210cbc490a1dc353e2288b507138de81772: Bug 1356536 - Add file type icons in network monitor. r=Honza
Amy Chan <amy_yyc@yahoo.com> - Tue, 16 Oct 2018 10:30:23 +0000 - rev 489788
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1356536 - Add file type icons in network monitor. r=Honza Added request type icons in File column of Network Monitor Differential Revision: https://phabricator.services.mozilla.com/D7697
9c535988954c0b2afacafe47597cfc5c884d3e20: Bug 1361739 - Fix Params Panel to display empty values when multiple values exist for one parameter. r=Honza
tossj <tossj@outlook.com> - Mon, 08 Oct 2018 21:11:00 -0400 - rev 489554
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1361739 - Fix Params Panel to display empty values when multiple values exist for one parameter. r=Honza
7035f4405e02b2dbcea1934aef9efe534e9ad549: Bug 1396680 - Add HLS M3U8 MIME types to netmonitor "media" request filter. r=Honza
tossj <tossj@outlook.com> - Wed, 10 Oct 2018 11:10:28 -0400 - rev 489552
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1396680 - Add HLS M3U8 MIME types to netmonitor "media" request filter. r=Honza
baa2b88b3ed1cd04fbae4d7ec20124c4ee2b87e6: Bug 1490092 - Clean opened tabs after Open request in tab test; r=Honza
Tom Glowka <glowka.tom@gmail.com> - Wed, 10 Oct 2018 10:18:07 +0000 - rev 488836
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1490092 - Clean opened tabs after Open request in tab test; r=Honza Differential Revision: https://phabricator.services.mozilla.com/D5511
0243cebc7b3c8a63b20acca77e3802c4c6ecc907: Bug 1451494 - Simplify edition of the "method" field in netmonitor edit and resend panel; r=Honza
Vincent Lequertier <vi.le@autistici.org> - Wed, 10 Oct 2018 10:08:38 +0000 - rev 488829
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1451494 - Simplify edition of the "method" field in netmonitor edit and resend panel; r=Honza Differential Revision: https://phabricator.services.mozilla.com/D6981
c9d9dd203994cd2251869d7b470564281d5d995f: Bug 1437435 - Added isBase64, isEmpty method, cleaned up typos and format of comments. r=Honza
tanhengyeow <E0032242@u.nus.edu> - Tue, 09 Oct 2018 15:56:18 +0000 - rev 488809
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1437435 - Added isBase64, isEmpty method, cleaned up typos and format of comments. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D6148
1292fd4850a754a543f04b3b5f399f2b73597d23: Bug 1496025 - Remove unused methods on ObjectClient related to promises r=Honza,gl
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 08 Oct 2018 11:12:42 +0000 - rev 488417
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1496025 - Remove unused methods on ObjectClient related to promises r=Honza,gl MozReview-Commit-ID: BPsMPaLz8AM Depends on D7689 Differential Revision: https://phabricator.services.mozilla.com/D7690
c6e6514203c9172dd1cbc99c505d42ae84e8b32a: Bug 1492730 - network: show resent XHR when filtering r=honza
meagonqz <meag.harty@gmail.com> - Tue, 25 Sep 2018 00:31:09 -0400 - rev 488295
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1492730 - network: show resent XHR when filtering r=honza
3f01040106719f099339ebe65ff98690a65ee9f0: Bug 1494162 - Part 29: Avoid calling toolsidebar show with an id when the default tab is already selected. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 28 Sep 2018 16:43:03 -0400 - rev 487124
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494162 - Part 29: Avoid calling toolsidebar show with an id when the default tab is already selected. r=Honza
b2a9c00cdfefa1c9b739e8efad0b5113f632a3e0: Bug 1494162 - Part 31: Lazy load the Reps in the layout panel. r=Honza
Gabriel Luong <gabriel.luong@gmail.com> - Fri, 28 Sep 2018 11:30:53 -0400 - rev 487015
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494162 - Part 31: Lazy load the Reps in the layout panel. r=Honza
71c746601621b203ba1c8d81db53fa30631c8d29: Bug 1487602 - Tracking icon is not visible when selected; r=Honza
Kenji Okamoto <kenokamo@outlook.com> - Thu, 27 Sep 2018 09:40:04 -0700 - rev 486987
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1487602 - Tracking icon is not visible when selected; r=Honza
5b121e9271ba357481111def62e1b93019c6c268: Bug 1403883 - The Learn More corresponding link exceeds the button's boundaries. r=Honza
Aanchal Agarwal <aanchal120btcse16@igdtuw.ac.in> - Fri, 28 Sep 2018 01:35:00 +0530 - rev 486986
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1403883 - The Learn More corresponding link exceeds the button's boundaries. r=Honza
241b06f4daf2fe4d33362b1eb70ded785b088b36: Bug 1494545 - Make Ctrl+Space open the autocomplete popup in the console; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 27 Sep 2018 16:36:11 +0000 - rev 486914
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1494545 - Make Ctrl+Space open the autocomplete popup in the console; r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D7049
3ecd0d2e00066a452e905d339c7cb598e14a21ad: Bug 1476656 - Trigger autocomplete on bracket; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 26 Sep 2018 13:54:35 +0000 - rev 486684
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1476656 - Trigger autocomplete on bracket; r=Honza. This patch adds the ability to open the autocomplete popup when typing an opening bracket (i.e. `[`]) in the console input. This impacts a significant amount of function where we assumed that the only way to get a completion was to use a dot. We uses the rename `anylyzeInputString` function to get the completion part from an input, as well as if the user is performing an element access (i.e., using the bracket). We then send that information to the webconsole actor, which send it to the client. This allows us to rely on a single parse of the input and gives us access to this information everywhere we need to, be it on the client or on the server. We allow the user to type property name without quotes, and we add them when the user accept an autocompletion. We also automatically add a closing bracket (i.e. `]`), when it's needed. Some test are added. On the server side to make sure the actor's autocomplete function returns what's expected. We take that as an opportunity to add test for commands. On the client side, tests are added to ensure the different behavior works as expected (check the completion text and the input after accepting the completion when the user entered some letters, or not, with or without quotes, with different quotes, hitting the autocomplete cache, …). A test which accesses the autocomplete cache was modified since the shape of the cache changed to include the last matchProp as well as the isElementAccess boolean. Differential Revision: https://phabricator.services.mozilla.com/D6128
255ba5eac28341ed24c6a88327cb18b0fc9c124b: Bug 1479421 - Making the response panel visible; r=Honza
Amy Chan <amy_yyc@yahoo.com> - Wed, 26 Sep 2018 07:14:33 +0000 - rev 486669
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1479421 - Making the response panel visible; r=Honza Making the response panel visible Differential Revision: https://phabricator.services.mozilla.com/D4636
f5baad77e684203185b7cc17e60aaf794058d7bb: Bug 1469533 - Remove sorting parameters r=Honza
Amir Sabbaghi <asaba90@gmail.com> - Wed, 04 Jul 2018 00:02:53 -0700 - rev 486637
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1469533 - Remove sorting parameters r=Honza
315f887ca1849f694be69f79f72ea5453e0fc702: Bug 1472875 - HTTP response text missing in devtools/network/headers panel r=Honza
Lucas Luna Souza <lucas.lunasouza@mail.utoronto.ca> - Sun, 15 Jul 2018 04:59:30 -0400 - rev 486634
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1472875 - HTTP response text missing in devtools/network/headers panel r=Honza
cce1c1845bbce89339b2e8761bb45026c800cd18: Bug 1490927 - Stop sharing maps in NetworkMonitor between all instances. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 19 Sep 2018 23:26:05 +0000 - rev 486514
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1490927 - Stop sharing maps in NetworkMonitor between all instances. r=Honza When opening a web console and a browser console, we instantiate two NetworkMonitor instances in the same process and they need independant states. Differential Revision: https://phabricator.services.mozilla.com/D6054
705f3c3d5d60ed20c255fbe33d79e0fc8f1e4526: Bug 1488206 - TelemetryStopwatch: error requesting elapsed time for nonexisting stopwatch r=Honza
Michael Ratcliffe <mratcliffe@mozilla.com> - Thu, 20 Sep 2018 11:06:58 +0000 - rev 485817
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1488206 - TelemetryStopwatch: error requesting elapsed time for nonexisting stopwatch r=Honza Because firefox can be closed with the toolbox in a half initialized state telemetry can throw if it expects a tool to be closing when no tools are fully initialized although this is completely expected. Here we simply choose not to report those errors because this is expected behaviour. Differential Revision: https://phabricator.services.mozilla.com/D4869
7bb7b47854be51f7dbba28b48ceac60ad8ae27d2: Bug 1420256 - Make longStrings wrap; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 18 Sep 2018 12:50:16 +0000 - rev 485437
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1420256 - Make longStrings wrap; r=Honza. This makes long strings without spaces wrap in the console output. Also fixes object with long string properties. Differential Revision: https://phabricator.services.mozilla.com/D6040
536dcedd614e75a221885afc58588df4b9e80b1c: Bug 1478361 - Simplify custom headers editing to prevent caret reset; r=Honza
Tom Glowka <glowka.tom@gmail.com> - Mon, 17 Sep 2018 13:04:37 +0000 - rev 485101
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1478361 - Simplify custom headers editing to prevent caret reset; r=Honza Differential Revision: https://phabricator.services.mozilla.com/D5410
5c8ae3b994b5e903d9617939795fe2de0cdd58ae: Bug 1448938 - Set fixture pref for reverse search in mocha tests; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 17 Sep 2018 13:29:06 +0000 - rev 485093
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1448938 - Set fixture pref for reverse search in mocha tests; r=Honza. The tests were failing without this. Differential Revision: https://phabricator.services.mozilla.com/D6028
7b200a07194605e04fea303eeb1ba3e453810d92: Bug 1491763 - Fix React warnings in ReverseSearchInput.js; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 17 Sep 2018 12:10:24 +0000 - rev 485085
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1491763 - Fix React warnings in ReverseSearchInput.js; r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D5996
7e20ccab359d5c5d7eae66544e26b8e7cc16af8b: Bug 1490027 - Fix Network info panel layout in the console; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 12 Sep 2018 12:24:25 +0000 - rev 484457
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1490027 - Fix Network info panel layout in the console; r=Honza. The overflow we are applying was impacting the layout of the panel which is visible when a request is expanded. Differential Revision: https://phabricator.services.mozilla.com/D5434
06ce1febd1fc254e480e7b87288c2ee4fd7046b9: Bug 1481732 - Fixed netmonitor request parameter parsing so equals signs are not removed from value field. r=Honza
tossj <tossj@outlook.com> - Thu, 23 Aug 2018 13:34:39 -0400 - rev 483815
Push 241 by fmarier@mozilla.com at Mon, 24 Sep 2018 21:48:02 +0000
Bug 1481732 - Fixed netmonitor request parameter parsing so equals signs are not removed from value field. r=Honza
f8a7ea258709cd10976898c25e8618d470ae5a39: Bug 1479421 - Making the response panel visible; r=Honza
Amy Chan <amy_yyc@yahoo.com> - Wed, 05 Sep 2018 11:34:55 +0000 - rev 483802
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1479421 - Making the response panel visible; r=Honza Making the response panel visible Differential Revision: https://phabricator.services.mozilla.com/D4636
0661deed0ac493e0df241b81560ea9bfa822e3a3: Bug 1473220 - Use original content-type when opening request in tab in Netmonitor r=Honza
Tom Glowka <glowka.tom@gmail.com> - Mon, 10 Sep 2018 11:48:27 +0000 - rev 483800
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1473220 - Use original content-type when opening request in tab in Netmonitor r=Honza Before this change it was hardcoded to "application/x-www-form-urlencoded", now original type is simply forwarded. Differential Revision: https://phabricator.services.mozilla.com/D5220
a2d23dacc52cd9987428e0d90ff46a235d5e6c99: Bug 1489554 - Do not open the autocomplete popup if there's a letter right after the cursor; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 10 Sep 2018 10:17:12 +0000 - rev 483793
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1489554 - Do not open the autocomplete popup if there's a letter right after the cursor; r=Honza. Differential Revision: https://phabricator.services.mozilla.com/D5396
0ed60b04e7eb64214d1e476f8ff704e55c9bbce8: Bug 1481002 - Developer tools network panel transferred total should ignore cached data. r=Honza
Hemakshi Sachdev <sachdev.hemakshi@gmail.com> - Thu, 06 Sep 2018 01:13:00 +0300 - rev 483401
Push 239 by fmarier@mozilla.com at Mon, 10 Sep 2018 17:01:34 +0000
Bug 1481002 - Developer tools network panel transferred total should ignore cached data. r=Honza
bc074d42aa91767597d1cc10d56305620672f38f: Bug 1217198 - Better autocompletion for template literals; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 05 Sep 2018 11:37:33 +0000 - rev 483103
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1217198 - Better autocompletion for template literals; r=Honza. Add a new template literal state to findCompletionBeginning so we can better handle the autocompletion for them. Differential Revision: https://phabricator.services.mozilla.com/D4853
80282ed4858572c6cbe9e2de75d933c8ab2056e8: Bug 1486159 - fix devtools to use openWebLinkIn. r=Honza
Jonathan Kingston <jkt@mozilla.com> - Thu, 30 Aug 2018 11:06:26 +0000 - rev 482407
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1486159 - fix devtools to use openWebLinkIn. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D4393
9550be79a88ef8807582722835275c4d20c83a4a: Bug 1486768 - Fix mocha tests;r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 30 Aug 2018 10:42:43 +0000 - rev 482404
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1486768 - Fix mocha tests;r=Honza. Some tests were failing because of change in the code: - arrow icon don't have an expanded class anymore but use aria-expanded - executionPoint property wasn't set on the ConsoleMessageType - networkUpdateRequest action expects a second argument - requestHeadersFromUploadStream is retrieved from requestPostData.uploadHeaders Differential Revision: https://phabricator.services.mozilla.com/D4444
4c603c11ce8c0cdb1b16735f2148ab0277fe39ed: Bug 672733 - Make autocomplete search case insensitive; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 27 Aug 2018 16:08:56 +0000 - rev 481918
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 672733 - Make autocomplete search case insensitive; r=Honza. This patch adds a smarter heuristic for autocompletion results: if the input first letter is lowercased, then we'll filter matching properties case insensitively. But if the user starts with an uppercase, we assume they know the property they want and thus respect the casing. For example: `win` will return both `window` and `Window`, but `Win` will return `Window` only. Due to this behavior, we change the order of the autocomplete results so lowercased property are displayed before the uppercased one. If we take are example again, it's likely that if a user type `win`, they want `window`, but the alphabetical order would return `Window` first which would annoy user. Now, since we return results that does not match exactly the user input, we need to modify the frontend. Usually, we only show the autocompletion popup if there are at least 2 matching items, since 1 matching item will still be displayed using the autocompletion text. But now, since the input might not match, we want to still display the popup if there is one matching item, but starts differentely than what the user entered. For example, the user typed `window.addeve`, which matches `addEventListener`. The completion text will make it looks like it will be completed to `window.addeventListener`, which would be undefined. So showing the popup with the actual matching property might avoid some confusion for the user. A test was added to make sure the frontend works as expected. Some test cases were added in the server test to make sure the actor returns expected results. Other tests needed some adjustement because of the insensitive case matches and the new order of results. Differential Revision: https://phabricator.services.mozilla.com/D4061
3cd4ee02dfc35984f84fddc0d04c724e2c53a4a3: Bug 1026583 - Prevent emitting webconsole event when its actor is already destroyed. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Aug 2018 05:40:08 -0700 - rev 481832
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1026583 - Prevent emitting webconsole event when its actor is already destroyed. r=Honza Summary: Depends On D4330 Reviewers: Honza! Tags: #secure-revision Bug #: 1026583 Differential Revision: https://phabricator.services.mozilla.com/D4331 MozReview-Commit-ID: 5yGFUQq4J9W
7dee3ca1609f27bc1945c5ecef2b9333f776460e: Bug 1026583 - Avoid sending network monitor events when the related actors are already destroyed. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 27 Aug 2018 05:32:26 -0700 - rev 481831
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1026583 - Avoid sending network monitor events when the related actors are already destroyed. r=Honza Summary: Depends On D4329 Reviewers: Honza! Tags: #secure-revision Bug #: 1026583 Differential Revision: https://phabricator.services.mozilla.com/D4330 MozReview-Commit-ID: H8j43mSIUnc
d377aa2d4f9823616f9584852bc6f40510f9279e: Bug 1481669 - Fix DEVTOOLS_*_TIME_ACTIVE_SECONDS probes to report in seconds again r=Honza
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 24 Aug 2018 13:30:16 +0000 - rev 481656
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1481669 - Fix DEVTOOLS_*_TIME_ACTIVE_SECONDS probes to report in seconds again r=Honza Differential Revision: https://phabricator.services.mozilla.com/D4211
9fcfb36da6fe80f1b1647700eb2e9b55d5db9a07: Bug 1484682 - Ensure the sidebar can overflow; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 23 Aug 2018 09:46:02 +0000 - rev 481470
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484682 - Ensure the sidebar can overflow; r=Honza. The sidebar regressed at some point and wasn't showing a scrollbar when it was needed. This patch fixes that by making the sidebar overflow and adds a test to make sure we don't regress. Differential Revision: https://phabricator.services.mozilla.com/D3976
6fe10cab33ca07a9b6ce8e9a0ce5e41a672945e5: Bug 1485300 - Remove duplicated implementation of NetworkObserver. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 22 Aug 2018 12:16:23 +0000 - rev 481450
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485300 - Remove duplicated implementation of NetworkObserver. r=Honza MozReview-Commit-ID: F3yDYfmsv59 Differential Revision: https://phabricator.services.mozilla.com/D3970
28d5979962b7aacb307fbbaf1ce438d5560044ce: Bug 1483880 - Always hide the autocompletion popup in acceptProposedCompletion; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 22 Aug 2018 11:40:09 +0000 - rev 481178
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483880 - Always hide the autocompletion popup in acceptProposedCompletion; r=Honza. When hitting enter, if there was no autocompletionText shown (because the input was matching a proposed value), then the autocompletion popup wasn't closed. We now close it every time, and only check the completionText to insert a possible string after the cursor. A test case is added to make sure we don't regress this. Differential Revision: https://phabricator.services.mozilla.com/D3763
6bfff0d1a5a429717625871d7f7f866d55817070: Bug 1484764 - Prevent netmonitors is undefined exception when closing tools during page load. r=Honza
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 21 Aug 2018 17:06:19 +0000 - rev 481165
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1484764 - Prevent netmonitors is undefined exception when closing tools during page load. r=Honza Differential Revision: https://phabricator.services.mozilla.com/D3863
fd86a6388333a146b2ca7dcea00f3e3343aae139: Bug 1465644 - Part 3. Hide Splitter if the network panel detail has not opened. r=honza
Mantaroh Yoshinaga <mantaroh@gmail.com> - Wed, 22 Aug 2018 16:08:27 +0900 - rev 481073
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1465644 - Part 3. Hide Splitter if the network panel detail has not opened. r=honza Network monitor has the splitter box. This splitter is displayed between the request list panel and network details panel. However, this splitter is displayed even if the network details panel has not displayed. This patch will set the spliter size to zero if the network details panel is collapsed.