searching for reviewer(AutomatedTester)
2025f3b4871b7030c10a69b2386d1fe406774bf8: Bug 1500001 - Fixup using non-firefox browsers via mach wpt, r=automatedtester
James Graham <james@hoppipolla.co.uk> - Thu, 18 Oct 2018 13:39:23 +0000 - rev 490293
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500001 - Fixup using non-firefox browsers via mach wpt, r=automatedtester We need to pass in the extra kwargs that wpt run understands but wptrunner does not. Ideally we could switch to using the run frontend always and allow users to actually supply these kwargs, although that might have some unwanted behaviour, and is a larger change. For now this gets things working again. Depends on D9081 Differential Revision: https://phabricator.services.mozilla.com/D9082
048da8a3c95146d4d94d8a8a47d2ff723792abdf: Bug 1500001 -Fix some differences with upstream in wpt tooling, r=automatedtester
James Graham <james@hoppipolla.co.uk> - Thu, 18 Oct 2018 13:42:43 +0000 - rev 490292
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500001 -Fix some differences with upstream in wpt tooling, r=automatedtester These came from a combination of botched merges and cases where we fixed up a commit for upstream CI failures and didn't apply the changes correctly. Differential Revision: https://phabricator.services.mozilla.com/D9081
7cf3a024e668a21da95252827dca09e193e6f3e7: Bug 1500081 - Use --install-fonts to install fonts for wptrunner, r=automatedtester
James Graham <james@hoppipolla.co.uk> - Thu, 18 Oct 2018 13:44:36 +0000 - rev 490291
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500081 - Use --install-fonts to install fonts for wptrunner, r=automatedtester This replaces a previous Firefox-only method except on Windows 7 where it seems that we have some issues with the registry. Differential Revision: https://phabricator.services.mozilla.com/D9091
1d7feb40277692c23edf72c421558d0177480256: Bug 1500081 - Use --install-fonts to install fonts for wptrunner, r=AutomatedTester
James Graham <james@hoppipolla.co.uk> - Thu, 11 Oct 2018 16:39:01 +0100 - rev 490231
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1500081 - Use --install-fonts to install fonts for wptrunner, r=AutomatedTester This replaces a previous Firefox-only method except on Windows 7 where it seems that we have some issues with the registry. Differential Revision: https://phabricator.services.mozilla.com/D9091
5095c0fdd000de42f501b7fea62a313871eca327: Bug 1495430 - Use AndroidMixin in web_platform_tests.py mozharness script; r=bc,automatedtester
Geoff Brown <gbrown@mozilla.com> - Thu, 11 Oct 2018 09:47:56 -0600 - rev 489019
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1495430 - Use AndroidMixin in web_platform_tests.py mozharness script; r=bc,automatedtester
11f33f3c73b4d58511d16cc0fbfcf8fa9363084f: Bug 1497566 - Remove logcat functionality from mozrunner; r=automatedtester
Geoff Brown <gbrown@mozilla.com> - Thu, 11 Oct 2018 09:47:55 -0600 - rev 489017
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
Bug 1497566 - Remove logcat functionality from mozrunner; r=automatedtester When testing locally, logcat can be run easily; in CI, mozharness scripts manage logcat and save the logcat as a test artifact.
868591df372ee71a7919a8926fdb53a43c15606a: bug 1496987: geckodriver: turn off arm7hf builds; r=automatedtester
Andreas Tolfsen <ato@sny.no> - Tue, 09 Oct 2018 12:46:33 +0000 - rev 488600
Push 246 by fmarier@mozilla.com at Sat, 13 Oct 2018 00:15:40 +0000
bug 1496987: geckodriver: turn off arm7hf builds; r=automatedtester The intent to turn off ARMv7 HF builds before the geckodriver 1.0 release was announced in https://lists.mozilla.org/pipermail/tools-marionette/2018-September/000035.html. In order to create as few surprises as possible before 1.0, we should turn off ARMv7 HF builds on Travis first. Differential Revision: https://phabricator.services.mozilla.com/D7964
ff6be2623035cfa8b70f514aab2e4f8dbcb43756: Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:11:23 +0100 - rev 478671
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
684c928574c6896fde319a7a947e2125ca37a366: Bug 1473614 - Fix exported symbols in sync. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:53 +0100 - rev 478670
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Fix exported symbols in sync. r=automatedtester The "exported" keyword is no longer needed.
c76d0cb71ad460386bf10e8c09ece7f6d2d76ec3: Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:23 +0100 - rev 478669
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester This adds a new public API to the Marionette sync module that can "pause" async functions for an arbitrary amount of hardcoded time. This can be useful for debugging purposes.
075c87b1393a66c60f796383efd8f697d36893a1: Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:08:45 +0100 - rev 478668
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester This patch introduces stricted type checks for the sync module's PollPromise and TimedPromise. This may seem excessive, but we have had real and severe bugs in this area before.
541bad93631c1dfbb89fd0c7c32fb11662df2d40: Bug 1480810 - Drop PREF_COMPLEX from Marionette prefs module. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:33:56 +0100 - rev 478483
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1480810 - Drop PREF_COMPLEX from Marionette prefs module. r=automatedtester A warning appears in the console when you run xpcshell tests that the PREF_COMPLEX type is no longer, and we should therefore remove it from Marionette as well.
027922b5ef0442e4ebb07043d2b57961e6195a78: Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:11:23 +0100 - rev 478482
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Expose API docs for MessageManagerDestroyedPromise and Sleep. r=automatedtester
1d28e128807c3969771d1722bc567713606add73: Bug 1473614 - Fix exported symbols in sync. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:53 +0100 - rev 478481
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Fix exported symbols in sync. r=automatedtester The "exported" keyword is no longer needed.
1ee58097b1412972a3ce2a6be6114025747f3f0a: Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:10:23 +0100 - rev 478480
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Add sync function Sleep for pausing async functions. r=automatedtester This adds a new public API to the Marionette sync module that can "pause" async functions for an arbitrary amount of hardcoded time. This can be useful for debugging purposes.
87a0ebcd004ffb9c15716b36635286bb4e3bd167: Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 03 Aug 2018 16:08:45 +0100 - rev 478479
Push 215 by fmarier@mozilla.com at Fri, 10 Aug 2018 00:07:31 +0000
Bug 1473614 - Add type checks to PollPromise and TimedPromise. r=automatedtester This patch introduces stricted type checks for the sync module's PollPromise and TimedPromise. This may seem excessive, but we have had real and severe bugs in this area before.
0ad9872c27e07e5f9dbbb62ec41e5be180e98f05: Bug 1470659 - Move timeouts test to separate file. r=automatedtester,whimboo
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:35:23 +0100 - rev 477892
Push 212 by fmarier@mozilla.com at Fri, 03 Aug 2018 00:39:34 +0000
Bug 1470659 - Move timeouts test to separate file. r=automatedtester,whimboo For similar reasons as for platformName, tests for configuring the timeouts object do not belong in the same parent test as those for response body structure.
e99e43a1e400b532ae84c36519da8e0cbc7143ac: Bug 1470659 - Add setWindowRect capability to geckodriver. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 18:32:01 +0100 - rev 477890
Push 212 by fmarier@mozilla.com at Fri, 03 Aug 2018 00:39:34 +0000
Bug 1470659 - Add setWindowRect capability to geckodriver. r=automatedtester It will never be possible to configure setWindowRect, and trying to do so will cause geckodriver to return with an error.
e9d0102d718ffcb48ecf4882528d69e1c3946893: Bug 1475279 - Remove copy-pasted algorithmic steps from wdspec tests. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 12 Jul 2018 17:17:55 +0100 - rev 476276
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1475279 - Remove copy-pasted algorithmic steps from wdspec tests. r=automatedtester We agreed some time ago that it would not be possible to keep the copy-pasted specification algorithm steps up-to-date in the WPT wdspec tests. This patch removes all such steps.
666d7dc7a32cbcacb8ef4b0120cf849a7ca8a911: Bug 1477476 - Drop geckodriver check for malformed sessionId from Marionette. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 14:17:35 +0100 - rev 476275
Push 211 by fmarier@mozilla.com at Wed, 01 Aug 2018 21:19:47 +0000
Bug 1477476 - Drop geckodriver check for malformed sessionId from Marionette. r=automatedtester Marionette used to return a session UUID starting with "{" and ending with "}" from the uuid-generator in Gecko. It has not done this for a very long time rendering this geckodriver check needless.
0a9411bc7b5dcfac1c3e2deacaa8d0b65d5b3a85: Bug 1477474 - Return moz:geckodriverVersion on session creation. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 14:09:53 +0100 - rev 476232
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1477474 - Return moz:geckodriverVersion on session creation. r=automatedtester This introduces a new extension capability, moz:geckodriverVersion, that will be returned on session creation with the geckodriver version number.
eacc31a62f16f7585f847981e0b48269db66ec5f: Bug 1477474 - Stop logging geckodriver version on startup. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Sat, 21 Jul 2018 14:09:02 +0100 - rev 476231
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1477474 - Stop logging geckodriver version on startup. r=automatedtester Any info-level log entries emitted before session creation will not be subject to the requested log level from moz:firefoxOptions. This can confuse users, so instead of logging the geckodriver version number on starting the program, we can return it later during session creation as an extension capability. Additionally this patch reduces the log level of the port geckodriver listens to from info to debug for similar reasons.
abc2e543c4972a763438bb502549bcc7e42278f1: Bug 1476305 - Add pref to not truncate Marionette log messages. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Tue, 17 Jul 2018 16:35:22 +0100 - rev 476229
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1476305 - Add pref to not truncate Marionette log messages. r=automatedtester Marionette currently truncates a selection of log messages that exceed 250 characters. It is however sometimes, usually when debugging locally, to not truncate logs so one can see exactly what is sent to and fro the server.
b4cd5a640564cee2dda926724bf2faeb8934d702: Bug 1447977 - Handle cyclic references in element prototypes. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 20:08:37 +0100 - rev 474401
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1447977 - Handle cyclic references in element prototypes. r=automatedtester JavaScript objects can be nested to any depth, and as such we must check that the value to be serialised contains a cyclic structure before attempting to marshaling it. We handle this correctly for collections and arbitrary objects by relying on JSON.stringify. For example with arrays: let arr = []; arr.push(arr); And for objects: let obj = {}; obj.reference = obj; However, members of the different element prototypes (HTMLElement, SVGElement, XULElement, et al.) may also contain cyclic references via user-defined own properties: let body = document.documentElement; body.reference = body; JSON.stringify enumerates an object's own properties, which means it picks up on body's "reference" property in the above example. Marionette needs to special case element prototypes because we want to marshal them as web elements. This patch replaces JSON.stringify with a custom function for testing if a value contains cyclic structures that special-cases elements. MozReview-Commit-ID: 1TQtHrjf401
cbb958819d32f25d41d0e6fe61105d57a882b3eb: Bug 1447977 - Move cyclic object test function to evaluate. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 18:35:21 +0100 - rev 474400
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1447977 - Move cyclic object test function to evaluate. r=automatedtester Moves the innards of assert.acyclic to evaluate.isCyclic so it can be called externally without throwing. It makes more sense for this function to be exposed on the evaluate module, since other behaviour related to JSON marshaling is also defined there. MozReview-Commit-ID: 4WjEy8Sjqrm
dccb4ac6468a39d0266039d5c0ad0ca9cbe2c462: Bug 1447977 - Move evaluate module API docs to RST. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Fri, 06 Jul 2018 16:36:19 +0100 - rev 474399
Push 204 by fmarier@mozilla.com at Wed, 25 Jul 2018 00:48:09 +0000
Bug 1447977 - Move evaluate module API docs to RST. r=automatedtester MozReview-Commit-ID: I5Pj8EsNyFc
6637d206368f4e1186d1042ab4e0fcfb2c88e411: Bug 1471201 - Increase webdriver HTTPD Keep-Alive timeout to 90s. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 05 Jul 2018 12:50:33 +0100 - rev 473460
Push 201 by fmarier@mozilla.com at Sat, 07 Jul 2018 02:45:18 +0000
Bug 1471201 - Increase webdriver HTTPD Keep-Alive timeout to 90s. r=automatedtester Increasing geckodriver's Keep-Alive timeout duration to 90 seconds, from the default five seconds, will reduce the number of HTTP connections a persistent-enabled client will have to make, potentially boosting performance. In more recent hyper versions the default is 90 seconds, which means we can get rid of this line when hyper is upgraded. This will help mitigate https://github.com/mozilla/geckodriver/issues/1304 but not fundamentally resolve it, due to a standard library bug in Python 2.7's urllib. MozReview-Commit-ID: 98AFDQgWfpw
6c187edf1253d37cf6a61b8e52ab13c4d7a02fca: Bug 1472112 - [geckodriver] Fix build job on Travis for win32 platform. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Fri, 29 Jun 2018 11:02:49 +0200 - rev 472711
Push 198 by fmarier@mozilla.com at Wed, 04 Jul 2018 00:35:04 +0000
Bug 1472112 - [geckodriver] Fix build job on Travis for win32 platform. r=automatedtester Upgrading the docker image from the unsupported Ubuntu 15.10 release to the 16.04 LTS release let us build the win32 binary successfully. DON'T BUILD MozReview-Commit-ID: 9Z0MPsMqyTu
c4fe0ca380a6309d37e9df5c0692e64a455e76ce: Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r=automatedtester a=test-only
Andreas Tolfsen <ato@sny.no> - Thu, 22 Feb 2018 11:26:01 +0000 - rev 464281
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1433463 - WebDriver:ElementSendKeys should not run unfocussing steps. r=automatedtester a=test-only According to the WebDriver standard the Element Send Keys command should not run the unfocussing steps. Not blurring the element causes the DOM "change" event not to fire, but the specification only expects the "input" event to fire. The standard does, however, expect the Element Clear command to run the unfocussing steps and to blur the element for historical reasons. MozReview-Commit-ID: FHD1whho0jT
8306ccb1dd271181c80e9eba2129e4d563f5f204: Bug 1375637 - Make test_async_script_timeout less likely to fail. r=automatedtester, a=test-only
Andreas Tolfsen <ato@sny.no> - Wed, 07 Feb 2018 18:15:20 +0000 - rev 464252
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1375637 - Make test_async_script_timeout less likely to fail. r=automatedtester, a=test-only By increasing the duration before setTimeout fires the callback and the execute_async_script call returns control to the user we are less likely that there is a race condition between the relatively short 100 ms interruption time. MozReview-Commit-ID: BVKRiU7a2gK
a2d90d0ba332bf27937a98b46a26f9a31a057a44: Bug 1433422 - Add basic form control tests for Element Send Keys. r=automatedtester, a=test-only
Andreas Tolfsen <ato@sny.no> - Fri, 02 Feb 2018 06:17:00 -0500 - rev 463915
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1433422 - Add basic form control tests for Element Send Keys. r=automatedtester, a=test-only We are apparently missing even the most basic tests for Element Send Keys. This is a moderate contribution. MozReview-Commit-ID: 9uWtTJ7MFZx
923317a339b0395ffa98d093c630b7f27fbef87f: Bug 1433422 - Fix interaction.moveCaretToEnd element conditions. r=automatedtester, a=test-only
Andreas Tolfsen <ato@sny.no> - Fri, 02 Feb 2018 06:17:00 -0500 - rev 463914
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1433422 - Fix interaction.moveCaretToEnd element conditions. r=automatedtester, a=test-only Bug 1432864 introduced a regression where the element conditions for moving the caret to the end of the textual input were wrong. Apparently if conditions are hard. MozReview-Commit-ID: KlRv6sCroXW
c70cc6ea1e7b887074bddf128b83ac7dd305c17b: Bug 1433422 - Move caret after focussing element. r=automatedtester, a=test-only
Andreas Tolfsen <ato@sny.no> - Fri, 02 Feb 2018 06:17:00 -0500 - rev 463913
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1433422 - Move caret after focussing element. r=automatedtester, a=test-only Focussing the element changes the selection range. MozReview-Commit-ID: JW68aZupkly
11887cd21e75fcb2a1dd94ad7bd49d81a2acbfe3: Bug 1432864 - Unfocussing steps will target <body> element. r=automatedtester a=test-only
Andreas Tolfsen <ato@sny.no> - Thu, 01 Feb 2018 09:04:00 +0200 - rev 463884
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1432864 - Unfocussing steps will target <body> element. r=automatedtester a=test-only The WebDriver Element Send Keys command is meant to run the HTML unfocussing steps after clearing the element. When HTMLElement.blur() is called on the root document element (<html>) it is the <body> that is in focus when the unfocussing steps have run. The same applies in the case of typing into an <iframe> element. The controlling element of the <iframe> is the <body>, as this is the element ath will receive focus should you blur the frame. MozReview-Commit-ID: 19Ox3W9CF8O
cc6e54bee19e7153ae5ac6cc7887805f001c2470: Bug 1432864 - Run unfocussing steps after interaction. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 01 Feb 2018 09:04:00 +0200 - rev 463883
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1432864 - Run unfocussing steps after interaction. r=automatedtester A couple of commands were not running the appropriate unfocussing steps as the WebDriver standards says they should. MozReview-Commit-ID: FyuRvkct19m
feae5d29e679fb637a0ca44800464fee9f1bc91f: Bug 1432864 - Run native focussing steps on interaction commands. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 01 Feb 2018 09:04:00 +0200 - rev 463882
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1432864 - Run native focussing steps on interaction commands. r=automatedtester Instead of generating custom focus events when interacting with elements, we can run the HTMLElement.focus() function will do the correct thing. Before this patch we only simulated focus events, whereas this patch will actually focus the element. MozReview-Commit-ID: IoBV2ngqOA5
a25a343d7937b33a5771db430776c724870e6c8c: Bug 1432864 - Decouple focussing from moving caret in textual form controls. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Thu, 01 Feb 2018 09:05:00 +0200 - rev 463881
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1432864 - Decouple focussing from moving caret in textual form controls. r=automatedtester Renames the interaction.focusElement, which also happened to move the caret in textual form controls, to interaction.moveCaretToEnd, focussed solely on moving the caret. It doesn't make sense to coalesce these two operations into one function. MozReview-Commit-ID: 2QxV8FllW8J
4320ff21043330b71defec7a93448c4bf25f339e: Bug 1430571 - Fire DOM change event on WebDriver:ElementClear. r=automatedtester a=test-only
Andreas Tolfsen <ato@sny.no> - Wed, 24 Jan 2018 17:27:26 +0000 - rev 463764
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1430571 - Fire DOM change event on WebDriver:ElementClear. r=automatedtester a=test-only When clearing an element using the WebDriver Element Clear command, the DOM change event should be fired. MozReview-Commit-ID: 94iG8bsRe4S
bf5501f121c806a37fcf6fd503074f02ab0c8380: Bug 1418227 - Socket timeout is lost in TcpTransport.connect(). r=automatedtester, a=test-only
Henrik Skupin <mail@hskupin.info> - Fri, 17 Nov 2017 10:15:13 +0100 - rev 462792
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1418227 - Socket timeout is lost in TcpTransport.connect(). r=automatedtester, a=test-only The socket_timeout getter should not return the timeout directly from the socket instance, because right after socket.socket() it is set to "None" internally, which will cause the original value as requested by Marionette to be lost. MozReview-Commit-ID: DkmvvJ4bDF9
4eb0dd155ef28ef6a3b55d91cfa175d0ae919b03: Bug 1418227 - Indicate that sock instance is private. r=automatedtester, a=test-only
Henrik Skupin <mail@hskupin.info> - Fri, 17 Nov 2017 10:24:38 +0100 - rev 462791
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1418227 - Indicate that sock instance is private. r=automatedtester, a=test-only The sock instance in TcpTransport should not be modified by code outside of the class. As such indicate it least as private. MozReview-Commit-ID: FGgZHYj7EdV
c0da1f29b298e22178bcf71405f17528a5afe2fb: Bug 1418227 - TcpTransport.sock should not be used by consumers. r=automatedtester, a=test-only
Henrik Skupin <mail@hskupin.info> - Fri, 17 Nov 2017 10:48:57 +0100 - rev 462790
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1418227 - TcpTransport.sock should not be used by consumers. r=automatedtester, a=test-only The socket is managed by TcpTransport and as such the latter should be used to retrieve the socket timeout. MozReview-Commit-ID: EzXCwDtfGvR
6663aafca6f9928e71bb30f4ec1ab15a1b5836d3: Bug 1413852 - Improve failure message for socket connection attempts. r=automatedtester, a=test-only
Henrik Skupin <mail@hskupin.info> - Thu, 02 Nov 2017 12:03:03 +0100 - rev 462607
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1413852 - Improve failure message for socket connection attempts. r=automatedtester, a=test-only Instead of a general socket timeout failure indicate that no hello data has been received through the socket right after the call to connect(). MozReview-Commit-ID: EPNiCLNyFFH
dfe84dae4564aa573b81dbd7d72cd802d6f16bbf: Bug 1413852 - TcpTransport.receive() doesn't obey current socket timeout. r=automatedtester, a=test-only
Henrik Skupin <mail@hskupin.info> - Thu, 02 Nov 2017 11:33:23 +0100 - rev 462606
Push 177 by fmarier@mozilla.com at Thu, 24 May 2018 16:58:35 +0000
Bug 1413852 - TcpTransport.receive() doesn't obey current socket timeout. r=automatedtester, a=test-only The getter for socket_timeout should always return the current socket timeout from the socket instance first, and only fallback to the private property if no socket instance exists. This ensures that all methods will always operate on the current socket timeout value. Also using a timeout of 2s for receiving the hello string might be too less for slow running builds. To prevent intermittent failures for start_session, a good value might be 60s. MozReview-Commit-ID: HywjFfClrRr
2e0af0221a8ea76a9445c51e9f86b025766e7721: Bug 1457054 - [wdspec] Align formatting of custom delete cookie command. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Thu, 26 Apr 2018 11:08:05 +0200 - rev 461082
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1457054 - [wdspec] Align formatting of custom delete cookie command. r=automatedtester MozReview-Commit-ID: KPePHYHT0CP
149859d8a23d280e1e8b62ce9747dbbf71e18a85: Bug 1457054 - [wdspec] Remove unwanted docstrings with reference to the spec. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Thu, 26 Apr 2018 11:06:06 +0200 - rev 461081
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1457054 - [wdspec] Remove unwanted docstrings with reference to the spec. r=automatedtester MozReview-Commit-ID: 8pxozHr4gZs
ab7307312bb7ded67672b9d8cb2ec723dea1f23d: Bug 1457054 - [wdspec] Use correct assertions for delete cookie tests. r=automatedtester
Henrik Skupin <mail@hskupin.info> - Thu, 26 Apr 2018 11:05:01 +0200 - rev 461080
Push 165 by fmarier@mozilla.com at Mon, 30 Apr 2018 23:50:51 +0000
Bug 1457054 - [wdspec] Use correct assertions for delete cookie tests. r=automatedtester MozReview-Commit-ID: HsqeIkF5Wq7
672e7d5d8f40a04ccd87b0f84eb4ade0f19cbdd4: Bug 1428795 - Reset Marionette state when initialisation fails. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:37:58 +0000 - rev 451031
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1428795 - Reset Marionette state when initialisation fails. r=automatedtester If Marionette throws inside try...catch block that spawns the TCP listener, we fail to reset the altered recommended preferences to their original state, leaving a possibility of tainting the profile. By calling the uninitialisation code when an error is thrown we ensure all relevant state gets reset. MozReview-Commit-ID: XiiIEFMZQY
d1cb6c61dcf8dee823bf9416cd7046af8c1dd00b: Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:36:29 +0000 - rev 451030
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1428795 - Uninitalise Marionette on xpcom-will-shutdown. r=automatedtester Marionette was previously uninitialised when xpcom-shutdown fired. This may be too late to reset preferences and other state related to the browser. This patch moves Marionette to run uninitialisation code on xpcom-will-shutdown. MozReview-Commit-ID: 3ytX2k2rrOp
6f92c0b0abe832829cafc4342a773f2cafeed242: Bug 1428795 - Set MOZ_MARIONETTE in component. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:34:54 +0000 - rev 451029
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1428795 - Set MOZ_MARIONETTE in component. r=automatedtester Setting the MOZ_MARIONETTE environment variable is not a task that naturally belongs to the TCP listener. This patch moves it to the Marionette XPCOM component. MozReview-Commit-ID: 7896Sv91wFy
65fa19a430ba699ea4a0b01fb33eb02e59ef8fd8: Bug 1428795 - Move recommended prefs to component. r=automatedtester
Andreas Tolfsen <ato@sny.no> - Mon, 26 Feb 2018 20:31:19 +0000 - rev 451028
Push 148 by fmarier@mozilla.com at Thu, 29 Mar 2018 23:06:47 +0000
Bug 1428795 - Move recommended prefs to component. r=automatedtester Setting the recommended preferences is not a task specific to the TCP listener. It makes more sense to set these in the Marionette XPCOM component where we manage the Marionette lifetime. MozReview-Commit-ID: G2RuLhKnX9X