ed12aa2eac651f3a9c874a96e26471c4966e865a: Backed out 6 changesets (bug 1409148) for failing mochitest caps/tests/mochitest/test_bug292789.html on Android. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 10 Nov 2017 02:59:06 +0200 - rev 435691
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Backed out 6 changesets (bug 1409148) for failing mochitest caps/tests/mochitest/test_bug292789.html on Android. r=backout on a CLOSED TREE Backed out changeset 6fe2a24e51ca (bug 1409148) Backed out changeset 0b032b6e0655 (bug 1409148) Backed out changeset 78eebd668bf1 (bug 1409148) Backed out changeset acfd8cf8c4ec (bug 1409148) Backed out changeset 4d486418cd55 (bug 1409148) Backed out changeset 0da5d54d003c (bug 1409148)
9cfbc1e51e537ad1b6338ca219ce036bf5de8bde: merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 10 Nov 2017 02:46:00 +0200 - rev 435690
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
0d4ab54bbb571429f2364452689854e6deeee888: Bug 1403593 - Change containers preference page to use command instead of click r=jaws
Jonathan Kingston <jkt@mozilla.com> - Tue, 07 Nov 2017 16:46:11 +0000 - rev 435689
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1403593 - Change containers preference page to use command instead of click r=jaws MozReview-Commit-ID: 95f9yOLVof5
5f3ad5cd80602d9d2b9e912be92776b445a8332a: Bug 1416020 - Remove echo-variable-% target from client.mk; r=nalexander
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 14:26:55 -0800 - rev 435688
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1416020 - Remove echo-variable-% target from client.mk; r=nalexander AFAICT this is unused. There are some mozharness consumers that evaluate an echo-variable-* target. However, I believe they are hitting the target from debugmake.mk and not going through client.mk. MozReview-Commit-ID: 9XjykFMRpsT
db9cecd33c001423851c33bcc78ab43575ea4e83: Bug 1416020 - Remove unused variables from client.mk; r=nalexander
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 14:19:41 -0800 - rev 435687
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1416020 - Remove unused variables from client.mk; r=nalexander The last use of PERL was removed recently. The last use of comma was removed by c8276e89a513 in 2008. The last use of SH was... never AFAICT. The variable was defined but unused in the initial import of client.mk from CVS in 1998. MozReview-Commit-ID: LFqcVRf36wf
512bc6565c8065cd0ff9a933f2705047e72bd7f7: Bug 1415971 - Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL; r=nalexander
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 13:56:48 -0800 - rev 435686
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415971 - Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL; r=nalexander After removing sccache.mk, there are no more references to these variables. Let's nuke them. MozReview-Commit-ID: LH1oHm59SnU
109cb09f0123190631b18be2aa4e7f7e81eeb44d: Bug 1415971 - Inline sccache.mk into client.mk; r=nalexander
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 14:59:06 -0800 - rev 435685
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415971 - Inline sccache.mk into client.mk; r=nalexander sccache.mk is the only thing that uses MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL. We're trying to kill client.mk and these variables are next on the chopping block. This commit essentially moves the logic of sccache.mk inline into client.mk. Initially, I wanted to move the management of the sccache daemon to Python as part of what `mach build` invokes. However, the sccache daemon needs access to the make jobserver. Since we don't have an active make process in `mach`, this is obviously problematic. The sccache daemon is also used by configure, which is launched from client.mk. So the best we can do right now is move the sccache daemon logic into client.mk. As part of the port, we pass the path to the sccache binary via an environment variable. This feels slightly better than hardcoding the path that automation uses. MozReview-Commit-ID: zcOYR4I1OG
30fbe1a0ce8c60da004dac0f9edc234ddbf18081: Bug 1415971 - Dedent warning printing code; r=nalexander
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 13:13:09 -0800 - rev 435684
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415971 - Dedent warning printing code; r=nalexander This doesn't need to run when the context manager is active. MozReview-Commit-ID: DV3SZyUwxlM
688d2bdee4ccec4159063600a224805947b45def: Bug 1415971 - Stop build output monitor earlier; r=nalexander
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 12:12:31 -0800 - rev 435683
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415971 - Stop build output monitor earlier; r=nalexander We currently print compiler warnings summary then stop the build output manager, which basically stops resource monitoring. A future commit will refactor this code a bit and it will be easier to have the monitor.stop() call directly after the build finishes. MozReview-Commit-ID: 3uWFWG6ELnH
2f0bc3e7c2eb74d4fda96d50ec7aab6a3fe5d73a: Bug 1415614 - Move configure invocation out of mach_commands.py; r=nalexander
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 12:19:16 -0800 - rev 435682
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415614 - Move configure invocation out of mach_commands.py; r=nalexander While we're here, also move the low-level code to invoke configure to a proper Python module. MozReview-Commit-ID: 4rlCxOwcVu1
fe26063c28857c36df295ab5088c476f29eb1b06: Bug 1415614 - Move code for invoking build system out of mach_commands.py; r=nalexander
Gregory Szorc <gps@mozilla.com> - Wed, 08 Nov 2017 15:52:17 -0800 - rev 435681
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415614 - Move code for invoking build system out of mach_commands.py; r=nalexander The goal is to move this lower-level code somewhere where it can be reused. The only meaningful code change as part of the move was handling of the mach context. Before, we could access self._mach_context. After, we need to pass it as an argument. This also uncovered a bug where "telemetry_handler" could be None but we called it unconditionally. We now guard this call with an "if." MozReview-Commit-ID: FWw4l6H1ayS
36302dd731b3a498a9acb2e2bb0dc5efaf665d76: Bug 1415614 - Move build output processing code out of mach_commands.py; r=nalexander
Gregory Szorc <gps@mozilla.com> - Wed, 08 Nov 2017 14:45:07 -0800 - rev 435680
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415614 - Move build output processing code out of mach_commands.py; r=nalexander In general, we shouldn't have so much business logic in mach_commands.py files. I'd like to move more of the low-level "perform a build" logic out of mach_commands.py to facilitate some future work. That code makes use of this output processing code. So as the first step in moving the build code, we move its dependencies. As part of this, I also cleaned up some random unused imports around lines that were touched. No meaningful code changes were performed as part of the code move. MozReview-Commit-ID: 96mGWUJ7oLb
ab3c555c62ea1684fae9e8082d2a19b48eba9181: Bug 1415614 - Add an API to log all structured messages; r=mshal
Gregory Szorc <gps@mozilla.com> - Thu, 09 Nov 2017 15:09:52 -0800 - rev 435679
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415614 - Add an API to log all structured messages; r=mshal Currently, marking a logger as a structured logger will require a subsequent function call in order for the logger to be hooked up to active handlers. This behavior is not intuitive and makes it easy to not have handlers for newly-registered loggers. This means messages may not be logged anywhere. In addition, we have to manually specify which named loggers to enable structured logging for. This can be annoying. We change the behavior of register_structured_logger() to automatically add existing terminal and json handlers to the logger being marked as structured. We also introduce an API to enable structured logging for all loggers. Existing consumers of registered_structured_logger() in mozbuild have been updated to use this API. A new consumer has been added for the `mach configure` command because it should have been there before. We stop short of making enable_all_structured_loggers() the default. This is because various commands interact with the log manager in ways that will result in duplicate logging of messages and dropping of structured messages. There is a bit of a rabbit hole here and addressing it can be done as a follow-up. MozReview-Commit-ID: 1aU6eJvTSMP
e99a07820f599d62436b9e28c89b7bddabbe47be: Bug 1415614 - Don't assign mach logger to instance variable; r=nalexander
Gregory Szorc <gps@mozilla.com> - Wed, 08 Nov 2017 14:28:19 -0800 - rev 435678
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415614 - Don't assign mach logger to instance variable; r=nalexander We don't use this attribute outside of this function. Besides, you can easily obtain a handle on the logger by calling ``logging.getLogger('mach')``. MozReview-Commit-ID: 41vdn6McowW
9dcac9671005e62e7cb6608cdeb39c7b611f1c09: Bug 1415621: Support checking comm-central in mozharness windows builds. r=dustin
Tom Prince <mozilla@hocat.ca> - Tue, 24 Oct 2017 13:53:08 -0600 - rev 435677
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415621: Support checking comm-central in mozharness windows builds. r=dustin MozReview-Commit-ID: ChFc93tzoEE
0489e522ece134137434a449539228dad4849678: Bug 1415621: Refactor checking out vcs repos in taskcluster mozharness builds. r=dustin
Tom Prince <mozilla@hocat.ca> - Thu, 26 Oct 2017 12:03:23 -0600 - rev 435676
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415621: Refactor checking out vcs repos in taskcluster mozharness builds. r=dustin MozReview-Commit-ID: LyZ5bmEleoW
c60bbbbc53d3b798cec0b578ea3c4b7e41f720bd: Bug 1415957 - Remove MozMill from TPS. r=tcsc
Edouard Oger <eoger@fastmail.com> - Thu, 09 Nov 2017 15:34:06 -0500 - rev 435675
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1415957 - Remove MozMill from TPS. r=tcsc MozReview-Commit-ID: HyBXrNqhzIf
6fe2a24e51cad359aa5d42f8792b434f61a38bb6: Bug 1409148 - Add test to ensure that the plugin overlay is displayed in the correct style. r=johannh
Felipe Gomes <felipc@gmail.com> - Thu, 09 Nov 2017 20:17:04 -0200 - rev 435674
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1409148 - Add test to ensure that the plugin overlay is displayed in the correct style. r=johannh MozReview-Commit-ID: E9AkKe21JSq
0b032b6e065532885aca02c8e84b07e9a8079bb9: Bug 1409148 - Add dynamic sizing on the plugin overlay. r=dthayer,johannh
Felipe Gomes <felipc@gmail.com> - Thu, 09 Nov 2017 18:39:54 -0200 - rev 435673
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1409148 - Add dynamic sizing on the plugin overlay. r=dthayer,johannh MozReview-Commit-ID: 75jMomIPAuA
78eebd668bf1564cb31b64a508bab84a618fb05c: Bug 1409148 - Improve styling of the plugin Click-to-Play overlay. r=johannh
Felipe Gomes <felipc@gmail.com> - Thu, 09 Nov 2017 18:35:14 -0200 - rev 435672
Push 117 by fmarier@mozilla.com at Tue, 28 Nov 2017 20:17:16 +0000
Bug 1409148 - Improve styling of the plugin Click-to-Play overlay. r=johannh MozReview-Commit-ID: I3P65jCm06j
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip