de6fb9a3d7a5dcf98798c833994c68f2ac83526c: Bug 1499239 - Use a smaller scroll range for the frameset. r=gbrown
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 16 Oct 2018 20:12:20 +0000 - rev 489885
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499239 - Use a smaller scroll range for the frameset. r=gbrown The size of the frameset on the emulator is smaller than I expected, so we can't scroll the full range of SCROLL_Y even when we've zoomed in somewhat. Because SCROLL_Y has a maximum of 400 and the scroll got truncated to 292, we divide the number in half. So we don't have to generate yet another hard-coded scroll string for this case, we switch to generating them on the fly from the test data for the respective sub test. Differential Revision: https://phabricator.services.mozilla.com/D8894
4c98e1b28c388eed1ce835038f570cc0169ef389: Bug 1499474 - Check if the element has textContent before falling back to TestUtils.waitForCondition. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 16 Oct 2018 20:04:38 +0000 - rev 489884
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499474 - Check if the element has textContent before falling back to TestUtils.waitForCondition. r=MattN This patch reduced the time to run from 2 minutes to 15 seconds. Differential Revision: https://phabricator.services.mozilla.com/D8895
af0263577e4d16da5c44df23ef5a44685c07a4d0: Bug 1495892 - Aggregates in c++2a can't have deleted ctors. r=dholbert
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 16 Oct 2018 19:39:37 +0000 - rev 489883
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1495892 - Aggregates in c++2a can't have deleted ctors. r=dholbert GLContextSymbols previously had a deleted default ctor to prevent accidentally leaving its members uninitialized, instead of zeroing with aggregate initialization. Differential Revision: https://phabricator.services.mozilla.com/D8796
963840088024c60bc7e52d6046312989a2935705: Bug 1496558 - Part 2: Move MozLength and MaxLength into generics r=emilio
Boris Chiou <boris.chiou@gmail.com> - Tue, 16 Oct 2018 01:07:41 +0000 - rev 489882
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496558 - Part 2: Move MozLength and MaxLength into generics r=emilio Move MozLength and MaxLength into generics, and drop the manual implementation of ToComputedValue. Depends on D8290 Differential Revision: https://phabricator.services.mozilla.com/D8291
7afc10b1bea13050b90796bcea2c66493e799f96: Bug 1496558 - Part 1: Store the correct computed values for keywords for sizing properties r=mats
Boris Chiou <boris.chiou@gmail.com> - Tue, 16 Oct 2018 19:38:41 +0000 - rev 489881
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496558 - Part 1: Store the correct computed values for keywords for sizing properties r=mats In order to get the correct computed value of these keywords, we have to make sure we store the correct computed values in sizing properties in both inline axis and block axis. -moz-max-content and -moz-min-content should behave as the property's initial value in block axis. -moz-fit-content and -moz-available are not supported in block axis, so we also treat them as initial values. Differential Revision: https://phabricator.services.mozilla.com/D8290
a552ab852b35f17b53441f1ce51f95a215f6329f: Bug 1492943 - Part 2 - Update copy for HSTS certificate errors. r=nhnt11
Johann Hofmann <jhofmann@mozilla.com> - Tue, 16 Oct 2018 18:50:37 +0000 - rev 489880
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492943 - Part 2 - Update copy for HSTS certificate errors. r=nhnt11 Copy changes as outlined in https://docs.google.com/document/d/18mKAiSSLRTVcjJ1C9rIMQRnQ7eMwqqXPPN0xIyW6DDI/edit?ts=5bbfbfbb# - New heading - Slightly updated description - Replace "More..." with "More Information" - Remove the "Recommended" label on the return button Differential Revision: https://phabricator.services.mozilla.com/D8831
dc57e840695b4534ce98f817f3bf2a42c35fd6d4: Bug 1492943 - Part 1 - Visually distinguish potentially dangerous certificate errors. r=nhnt11
Johann Hofmann <jhofmann@mozilla.com> - Tue, 16 Oct 2018 18:50:38 +0000 - rev 489879
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492943 - Part 1 - Visually distinguish potentially dangerous certificate errors. r=nhnt11 Differential Revision: https://phabricator.services.mozilla.com/D8253
ed09a03420aef61b84d91d1977ec969fb01cf94a: Bug 1495792: Add a profile first-run time to the telemetry environment. r=janerik
Dave Townsend <dtownsend@oxymoronical.com> - Mon, 15 Oct 2018 16:09:12 +0000 - rev 489878
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1495792: Add a profile first-run time to the telemetry environment. r=janerik Differential Revision: https://phabricator.services.mozilla.com/D8464
d71434f407554db9cf5320fbf8098c2a767f91e4: Bug 1496069 - Properly pass noValidate to EditAddress and set @novalidate. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 16 Oct 2018 18:01:35 +0000 - rev 489877
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1496069 - Properly pass noValidate to EditAddress and set @novalidate. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D8808
e0aa704cdd63d38f2cf4137240d9f7bb5f7a3829: Bug 1497523 - Link to '#privacy-form-autofill' prefs instead of '#privacy' from autofill. r=jaws
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 16 Oct 2018 17:47:38 +0000 - rev 489876
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497523 - Link to '#privacy-form-autofill' prefs instead of '#privacy' from autofill. r=jaws Differential Revision: https://phabricator.services.mozilla.com/D8599
3289b676c65b7338ad244ae43b7de1191d496927: Bug 1488012 - Update devtools frame picker button; r=jdescottes
Florens Verschelde <florens@fvsch.com> - Tue, 16 Oct 2018 17:42:43 +0000 - rev 489875
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1488012 - Update devtools frame picker button; r=jdescottes Differential Revision: https://phabricator.services.mozilla.com/D4820
d667abe7240c3d83c7e19cbe1fbc2f7ce1aa0abf: Bug 1497739 - Check blur event target is HTMLInputElement before shouldIgnoreLoginManagerEvent. r=Gijs
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Tue, 16 Oct 2018 13:11:59 +0000 - rev 489874
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497739 - Check blur event target is HTMLInputElement before shouldIgnoreLoginManagerEvent. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D8803
f0952bbb167111d8939b718024e1ae133ca0dd8f: Bug 1499361 - skip Prio telemetry tests if prio.enabled is false r=janerik
Robert Helmer <rhelmer@mozilla.com> - Tue, 16 Oct 2018 16:37:09 +0000 - rev 489873
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499361 - skip Prio telemetry tests if prio.enabled is false r=janerik Differential Revision: https://phabricator.services.mozilla.com/D8879
7413b2c7cdb4f45da50d2130a9403978977a36ed: Bug 1498854 - Rework dismissing of TabHistoryFragment. r=jchen
Jan Henning <jh+bugzilla@buttercookie.de> - Tue, 16 Oct 2018 16:17:18 +0000 - rev 489872
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498854 - Rework dismissing of TabHistoryFragment. r=jchen 1. The patch from bug 1476710 was nonsense and had the same effect as simply deleting that line, because the ChildFragmentManager is only of interest if the TabHistoryFragment loaded further Fragments itself. 2. The issue at hand is that under some circumstances the TabHistoryFragment will be trying to dismiss itself while its responsible FragmentManager is already busy transacting some Fragment state changes. More precisely, the fact that the Fragment is calling popBackStack*Immediately*, which isn't allowed if the FragmentManager is already handling some other transaction. 3. The dismiss() calls in response to the onClick() handlers are unproblematic, because they won't trigger any FragmentManager activity through any route other than the dismiss() call itself. 4. The dismiss() calls in onPause() *are* problematic because the Fragment- Manager will already be busy pausing the TabHistoryFragment, so triggering a further synchronous transaction is not allowed (and originally caused bug 1476710). 5. If the onPause() call happened because some external entity was attempting to remove the fragment (either BrowserApp directly, or indirectly by forwarding a back button press to the FragmentManager), then the Fragment trying to additionally remove itself is unnecessary. 6. If the onPause() call happens because the containing activity itself is being paused, then the Fragment being dismissed is the desired outcome (see bug 1093209), however the Fragment won't be able to remove itself because a) A synchronous transaction is illegal at that point in time. b) An async transaction would be possible, but might not complete until after onSaveInstanceState() had subsequently already been called, which again would be illegal because of state loss. c) An async transaction allowing state loss would succeed in any case, but would mean that if BrowserApp was subsequently destroyed while in back- ground and then later recreated from the savedInstanceState, the Tab- HistoryFragment would be recreated as well, which is undesired. 7. Therefore, the only way to dismiss the TabHistoryFragment when the containing activity is pausing is to synchronously dismiss the Fragment from inside the activity, *before* the onPause() call is forwarded to the FragmentManager. 8. Calling dismiss() in response to onDestroy() is unnecessary, because the Fragment is already irrevocably being removed as soon as we hit onPause(). 9. Because it doesn't make sense to have multiple TabHistoryFragments active at the same time, we also change the logic such that any attempt to show a new TabHistoryFragment will now replace the previous fragment. This is also useful in view of the fact that in order to close the Fragment, BrowserApp retrieves it by calling findFragmentByTag(), which simply returns the first matching Fragment, i.e. wouldn't properly handle things if we ever accidentally ended up with multiple Fragment instances active at the same time. Differential Revision: https://phabricator.services.mozilla.com/D8680
6fa9b4e512fa5fadcf300634e5da2ae8b1d12ed2: Merge mozilla-central to autoland. a=merge
Cosmin Sabou <csabou@mozilla.com> - Tue, 16 Oct 2018 19:27:54 +0300 - rev 489871
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Merge mozilla-central to autoland. a=merge
8eaeb557ba9f438afb0d6a7bd3bfc19f7b6df098: Bug 1498849 - Check for SDK compatibility on CollectionInfo.obtain(). r=jchen
Eitan Isaacson <eitan@monotonous.org> - Tue, 16 Oct 2018 16:00:15 +0000 - rev 489870
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498849 - Check for SDK compatibility on CollectionInfo.obtain(). r=jchen One method signature was introduced in API 19, and another, with selectionMode was introduced in 21. Differential Revision: https://phabricator.services.mozilla.com/D8788
6fc4224069b26bb408ee1b835a74fe1df9c676ed: bug 1498351 - add interface to allow OS-specific user re-authentication r=franziskus
Dana Keeler <dkeeler@mozilla.com> - Tue, 16 Oct 2018 16:06:30 +0000 - rev 489869
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
bug 1498351 - add interface to allow OS-specific user re-authentication r=franziskus This patch introduces the interface with a stub implementation that does nothing. Follow-up bugs will add platform-specific implementations. Differential Revision: https://phabricator.services.mozilla.com/D8480
f992e8a4e7e61a599e8007bf6dfdcb15a3b132f8: Bug 1005268 - Remove "datetime" UI from Fennec and fix capitalization issue r=jchen
Rob Wu <rob@robwu.nl> - Tue, 16 Oct 2018 15:57:26 +0000 - rev 489868
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1005268 - Remove "datetime" UI from Fennec and fix capitalization issue r=jchen `<input type=datetime>` was dropped from the spec many years ago, and is not supported by the platform. To JS code, it looks like a regular text input box. With removed support for "datetime" inputs, we can also fix a bug in the InputWidgetHelper. Due to the use of getAttribute, if the attribute value was capitalized, then the special date/time picker UI would not be shown. This is corrected by using the "type" property instead. I verified on Android Nougat that all other input types (date, datetime-local, week, month, time) still work as intended. Depends on D8668 Differential Revision: https://phabricator.services.mozilla.com/D8666
12fcdbe6ef8d97441fe879432bd664bf1c048ba4: Bug 1498787 - Support seconds in time inputs r=jchen
Rob Wu <rob@robwu.nl> - Tue, 16 Oct 2018 15:59:24 +0000 - rev 489867
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498787 - Support seconds in time inputs r=jchen When a time input expects seconds, e.g. via `<input type=time step=1>`, then the UI should show a way to input seconds. On Nougat, `data:text/html,<input type=time step=1>`, the UI used to show a clock to select hours and minutes. As of this commit, three spinners are shown (HH mm ss), and if 24-hour mode is disabled, four of them (HH mm ss AM). Depends on D8667 Differential Revision: https://phabricator.services.mozilla.com/D8668
d530c99c2be5dc8f5cfa39f1f965bb9751f274e2: Bug 1498787 - Support seconds in datetime-local inputs r=jchen
Rob Wu <rob@robwu.nl> - Tue, 16 Oct 2018 16:04:08 +0000 - rev 489866
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498787 - Support seconds in datetime-local inputs r=jchen The "seconds" field is now supported for type="datetime-local". Examples, tested on Android Nougat (7.0): ``` No seconds because step is a whole minute: data:text/html,<input type="datetime-local" step="60"> No seconds because datetime is not a supported type (it is treated like input type=text by the DOM, but somehow a datepicker still appears): data:text/html,<input type="datetime" step="0"> Seconds because step is a second: data:text/html,<input type="datetime-local" step="1"> ``` The UI looks only slightly different: After "HH mm" there is now a "ss" spinner, optionally followed by AM/PM. Differential Revision: https://phabricator.services.mozilla.com/D8667
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 tip