d17c68d95b1630adf72fe81ff214b0acdf4cd590: Bug 1479813 - Remove unnecessary test for delazification. r=jimb
Tooru Fujisawa <arai_a@mac.com> - Thu, 23 Aug 2018 15:48:07 +0900 - rev 481299
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1479813 - Remove unnecessary test for delazification. r=jimb
6ad53d2f8d3239a222e57a23a4351170bd5d00f1: Bug 1478995: Disable nodejs in source tasks; r=Callek
Tom Prince <mozilla@hocat.ca> - Wed, 22 Aug 2018 09:54:07 -0600 - rev 481298
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1478995: Disable nodejs in source tasks; r=Callek Differential Revision: https://phabricator.services.mozilla.com/D3988
6d30bac7078b1c9eb2e16ed7702204b8d41fc43e: Bug 1483761 - Enable clang's -Wtautological-overlap-compare warning. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Tue, 14 Aug 2018 22:39:03 -0700 - rev 481297
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483761 - Enable clang's -Wtautological-overlap-compare warning. r=glandium -Wtautological-overlap-compare is an opt-in warning added in clang 3.5. It warns about overlapping comparisons that are always true or false, such as: if (x > 4 || x < 10) {} // warning! always true int b = x < 2 && x > 5; // warning! always false return x > 4 || x < 10; // warning! always true https://clang.llvm.org/docs/DiagnosticsReference.html#wtautological-overlap-compare There are currently no -Wtautological-overlap-compare warnings in mozilla-central. Differential Revision: https://phabricator.services.mozilla.com/D3477
f41a14a1b4de976d7a36094644195847007f9b35: Bug 1483761 - Enable clang's -Wshadow-field-in-constructor warnings. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Mon, 20 Aug 2018 10:10:57 -0700 - rev 481296
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483761 - Enable clang's -Wshadow-field-in-constructor warnings. r=glandium This opt-in warning catches bugs where a constructor modifies a constructor parameter that shadows member variable name. The code probably intended to change the member variable value, not the paramter. There are currently no -Wshadow-field-in-constructor warnings in mozilla-central. https://clang.llvm.org/docs/DiagnosticsReference.html#wshadow-field-in-constructor-modified Differential Revision: https://phabricator.services.mozilla.com/D3822
36f6bab3d669cef41b9b2089e9081af388ce1c2b: Bug 1483761 - Enable clang's -Wfloat-(overflow|zero)-conversion warnings. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Tue, 14 Aug 2018 23:03:52 -0700 - rev 481295
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483761 - Enable clang's -Wfloat-(overflow|zero)-conversion warnings. r=glandium -Wfloat-overflow-conversion detects when a constant floating point value is converted to an integer type and will overflow the target type. https://clang.llvm.org/docs/DiagnosticsReference.html#wfloat-overflow-conversion -Wfloat-zero-conversion detects when a non-zero floating point value is converted to a zero integer value. https://clang.llvm.org/docs/DiagnosticsReference.html#wfloat-zero-conversion There are currently no -Wfloat-overlap-conversion warnings in mozilla-central. There is one -Wfloat-zero-conversion warning in a webrtc test. It doesn't block enabling this check because the webrtc tests are not compiled with warnings-as-errors. media/webrtc/trunk/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc:255:54 [-Wfloat-zero-conversion] implicit conversion from 'const float' to 'int' changes non-zero value from 0.045000002 to 0 We can't enable all -Wfloat-conversion warnings (for any implicit conversion of a floating-point number into an integer) because there are currently over 1400 warnings. I spot checked a few of these -Wfloat-conversion warnings. I didn't find any obvious bugs, but there is some suspicious code, such as implicit conversions of floats to bools. Differential Revision: https://phabricator.services.mozilla.com/D3476
f9a890fba236bdcd13e72cbede68c9d6755f3b78: Bug 1483761 - Enable clang's -Wc++2a-compat warnings. r=glandium
Chris Peterson <cpeterson@mozilla.com> - Wed, 15 Aug 2018 10:02:07 -0700 - rev 481294
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483761 - Enable clang's -Wc++2a-compat warnings. r=glandium Warn about C++ constructs whose meaning change in C++2a. https://clang.llvm.org/docs/DiagnosticsReference.html#wc-2a-compat So far the only -Wc++2a-compat check that I know of is for valid pre-C++2a code that inadvertently parses as C++2a's new <=> "spaceship" comparison operator. `f<&A::operator<=>();` is an example of a warning reported for a real project on GitHub. That code can be rewritten as `f< &operator<= >();`. There are currently no -Wc++2a-compat warnings in mozilla-central. Differential Revision: https://phabricator.services.mozilla.com/D3478
96c84ecff48708165d27b56260f11d60c04166d2: Merge mozilla-central to inbound. a=merge CLOSED TREE
Brindusan Cristian <cbrindusan@mozilla.com> - Thu, 23 Aug 2018 06:45:33 +0300 - rev 481293
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Merge mozilla-central to inbound. a=merge CLOSED TREE
5f1db4de173d8d8d160742138c8afc847485bf67: Merge inbound to mozilla-central. a=merge
Brindusan Cristian <cbrindusan@mozilla.com> - Thu, 23 Aug 2018 06:41:38 +0300 - rev 481292
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Merge inbound to mozilla-central. a=merge
338526a054586a6e6b7c1ed4330c1029647a9572: Merge autoland to mozilla-central. a=merge
Brindusan Cristian <cbrindusan@mozilla.com> - Thu, 23 Aug 2018 06:39:25 +0300 - rev 481291
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Merge autoland to mozilla-central. a=merge
2b2cc1983172a567ec81830d4cc530616eb2aa74: Bug 1485499 - Reduce size of js::Symbol r=sfink
Ted Campbell <tcampbell@mozilla.com> - Thu, 23 Aug 2018 01:34:37 +0000 - rev 481290
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485499 - Reduce size of js::Symbol r=sfink MozReview-Commit-ID: 4mEHixUnUax Differential Revision: https://phabricator.services.mozilla.com/D4017
bb9759881cd75c2a0cba3510f35166d160074e79: Bug 1483703 - part4 : modify current telemtry scalar because we won't block media without audio track anymore. r=cpearce,francois
alwu <alwu@mozilla.com> - Wed, 22 Aug 2018 22:54:05 +0000 - rev 481289
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483703 - part4 : modify current telemtry scalar because we won't block media without audio track anymore. r=cpearce,francois Since we don't block media without audio track anymore, the original telemetry scalar becomes useless. We need to change its meaning in order to know the number of allowed autoplay without audio track. Differential Revision: https://phabricator.services.mozilla.com/D3673
d915d805e9642c0e4cab3db3042bd9bdf5f2c5b7: Bug 1483703 - part3 : modify test. r=cpearce
alwu <alwu@mozilla.com> - Wed, 22 Aug 2018 22:52:04 +0000 - rev 481288
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483703 - part3 : modify test. r=cpearce Differential Revision: https://phabricator.services.mozilla.com/D3672
3326c0e920d4c9a180a26561a1a9d49b886c0eb7: Bug 1483703 - part2 : add telemetry for the media which was blocked before loading metadata and ended up being without audio track. r=cpearce,francois
alwu <alwu@mozilla.com> - Wed, 22 Aug 2018 22:50:54 +0000 - rev 481287
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483703 - part2 : add telemetry for the media which was blocked before loading metadata and ended up being without audio track. r=cpearce,francois Add two telemetry scarlar, "MEDIA_BLOCKED_NO_METADATA" records how many media which was blocked because it hadn't loaded metadata yet. "MEDIA_BLOCKED_NO_METADATA_ENDUP_NO_AUDIO_TRACK" records how many media which was blocked because it hadn't loaded metadata and ended up for being no audio track. By collecting those data, we can know the proportion of media which should be autoplay but was blocked because of lacking metadata. Differential Revision: https://phabricator.services.mozilla.com/D3671
71ad474cdeeb928e303c2fb7eb5322402529b48b: Bug 1483703 - part1 : allow media without audio track to autoplay. r=cpearce
alwu <alwu@mozilla.com> - Wed, 22 Aug 2018 23:31:58 +0000 - rev 481286
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483703 - part1 : allow media without audio track to autoplay. r=cpearce We would allow media without audio track to autoplay after it had loaded the metadata. If media hasn't loaded metadata yet, we would treat it as audible media and then block it. Differential Revision: https://phabricator.services.mozilla.com/D3670
a28f7398ddff28f51ee1ac68203a02286bca6367: Backed out changeset ffe0fc382b2f (bug 1369209) for bc failures on browser_ext_management.js. CLOSED TREE
Narcis Beleuzu <nbeleuzu@mozilla.com> - Thu, 23 Aug 2018 02:28:19 +0300 - rev 481285
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Backed out changeset ffe0fc382b2f (bug 1369209) for bc failures on browser_ext_management.js. CLOSED TREE
cc2cb08f3759f4c0250c081c5696d13c5a86725a: Bug 1482224 Crash in Shutdown due to ProxyAutoConfig still aiming to resolve addressThis crash has arisen due to a loop in ProxyAutoConfig which spins until apending PAC request is complete, even when the ProxyAutoConfig object is beingshut... r=valentin
Polly Shaw <polly.shaw@gmail.com> - Wed, 22 Aug 2018 23:23:08 +0000 - rev 481284
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1482224 Crash in Shutdown due to ProxyAutoConfig still aiming to resolve addressThis crash has arisen due to a loop in ProxyAutoConfig which spins until apending PAC request is complete, even when the ProxyAutoConfig object is beingshut... r=valentin ...down. The remedy to prevent the crash is to exit the loop when the mShutdown flag is set. This does not attempt to address the underlying cause of why the request continues to be pending, although this is also a concern. Files changed: netwerk/base/ProxyAutoConfig.cpp - expanded lambda containing logic of when to stop waiting for the request to complete to include a check to the mShutdown flag. Also logged a warning if the loop is exited because of mShutdown. Differential Revision: https://phabricator.services.mozilla.com/D3977
265d09efe73f674a364194d4ad16dfd77d0aab57: Bug 1483122 - "https" is pushed off left edge of address bar (overlapping buttons!) for long URLs with broken cert configurations r=Gijs
Drew Willcoxon <adw@mozilla.com> - Wed, 22 Aug 2018 22:29:52 +0000 - rev 481283
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483122 - "https" is pushed off left edge of address bar (overlapping buttons!) for long URLs with broken cert configurations r=Gijs Bug 1470910 broke the positioning because it changed the tag name of .urlbar-input-box but didn't update the related rule in browser.css, and then bug 1480355 landed and made it worse. This patch fixes the first problem by updating the tag name in the CSS, and it fixes the second problem (and bug 1480355) by setting `direction: ltr` on .urlbar-input-box. Differential Revision: https://phabricator.services.mozilla.com/D4015
d57a6d415507fb7e43cad18c2755aa124b84bbbe: Bug 1485472 - Avoid a couple addref / release in ParseStyleAttribute. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 22:27:12 +0000 - rev 481282
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1485472 - Avoid a couple addref / release in ParseStyleAttribute. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D4008
cd6a42517bb9e60c45b6441a986b53d8da7fb147: Bug 1483703 - part1 : allow media without audio track to autoplay. r=cpearce
alwu <alwu@mozilla.com> - Tue, 21 Aug 2018 20:58:26 +0000 - rev 481281
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1483703 - part1 : allow media without audio track to autoplay. r=cpearce We would allow media without audio track to autoplay after it had loaded the metadata. If media hasn't loaded metadata yet, we would treat it as audible media and then block it. Differential Revision: https://phabricator.services.mozilla.com/D3670
d77ca862636da2f413aa0b3a6e98c11c45ecae15: Bug 1435045 - Don't make CSS filters on the <svg> element use fallback. r=jrmuizel
Markus Stange <mstange@themasta.com> - Wed, 22 Aug 2018 22:06:24 +0000 - rev 481280
Push 232 by fmarier@mozilla.com at Wed, 05 Sep 2018 20:45:54 +0000
Bug 1435045 - Don't make CSS filters on the <svg> element use fallback. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D4018
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip