d0d1ccfded5ddefa99bb206ffac2235b457abffe: Bug 1498151 - part 1: Make IUnknownImpl.h define ATTRIBUTE_UNUSED as __attribute__((unused)) when built with clang r=Jamie
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 23 Oct 2018 07:13:33 +0000 - rev 491045
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1498151 - part 1: Make IUnknownImpl.h define ATTRIBUTE_UNUSED as __attribute__((unused)) when built with clang r=Jamie IMPL_IUNKNOWN_QUERY_HEAD defines HRESULT as hr. However, if its user uses IMPL_IUNKNOWN_QUERY_TAIL_AGGREGATED, it's never used. Therefore, it causes unused variable warning. hr is defined with ATTRIBUTE_UNUSED. However, this is empty when built with clang. IUnknownImpl.h already defines ATTRIBUTE_UNUSED as __attribute__((unused)) when built with gcc. So, same warnings should be prevented when built with clang too. Differential Revision: https://phabricator.services.mozilla.com/D8510
3b8a9abe2766c4bdc68c143416a3aafe85083be4: Backed out changeset bee1c344cb47 (bug 1491909) for failures in browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_control.js
Noemi Erli <nerli@mozilla.com> - Wed, 24 Oct 2018 04:23:13 +0300 - rev 491044
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Backed out changeset bee1c344cb47 (bug 1491909) for failures in browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_control.js
8ff4dac9916d9bd908611963de3ec8883befea5f: Bug 1448880 - Part 7: Fix hasAnyLiveHooks to include onStep handlers on suspended frames. r=sfink
Jason Orendorff <jorendorff@mozilla.com> - Wed, 24 Oct 2018 01:08:19 +0000 - rev 491043
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448880 - Part 7: Fix hasAnyLiveHooks to include onStep handlers on suspended frames. r=sfink Depends on D6988 Differential Revision: https://phabricator.services.mozilla.com/D6990
6c8949f053e0e9c6216329d9b3f081fc0b6b2936: Bug 1448880 - Part 6: Re-enable stepping when an async or generator frame with an .onStep hook is resumed. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:24:11 +0000 - rev 491042
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448880 - Part 6: Re-enable stepping when an async or generator frame with an .onStep hook is resumed. r=jimb That is, don't put it off until Debugger::getFrame() is called. The effect is subtle, as indicated by the test changes: the onEnterFrame hooks in those tests were causing getFrame to be called very early during generator resumption, which made the tests pass. With this patch, we no longer adjust the step mode count when suspending or resuming. This change is necessary to make the frame->isDebuggee() call in Debugger::onResumeFrame the right criterion for calling slowPathOnResumeFrame. It's true if the step mode count on the script is nonzero. (This approach also simplifies error handling, as resuming a Debugger.Frame is now idempotent: we don't have to worry about adjusting the step mode count too much or not enough on error.) Depends on D6986 Differential Revision: https://phabricator.services.mozilla.com/D6988
27b0121d9e314b26e2c11857b18409f5dabbd75b: Bug 1448880 - Part 5: Tell removeFromFrameMapsAndClearBreakpointsIn() if we are suspending. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:36:35 +0000 - rev 491041
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448880 - Part 5: Tell removeFromFrameMapsAndClearBreakpointsIn() if we are suspending. r=jimb Since the argument is not used yet, this too is a pure refactoring, with no change in behavior yet. Depends on D6985 Differential Revision: https://phabricator.services.mozilla.com/D6986
61031045a58cad9c96f2051a858031bf37443769: Bug 1448880 - Part 4: Split Debugger::onResumeFrame from onEnterFrame. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:23:15 +0000 - rev 491040
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448880 - Part 4: Split Debugger::onResumeFrame from onEnterFrame. r=jimb Pure refactoring, no change in behavior. This is in anticipation of doing additional work in onResumeFrame. Depends on D6984 Differential Revision: https://phabricator.services.mozilla.com/D6985
9c03b503909a6d03150869a782d5e148870c20f5: Bug 1448880 - Part 3: AbstractFramePtr::isGeneratorFrame(). r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:23:07 +0000 - rev 491039
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448880 - Part 3: AbstractFramePtr::isGeneratorFrame(). r=jimb This proves handy in several places, later in the stack. Depends on D6983 Differential Revision: https://phabricator.services.mozilla.com/D6984
64810935a7516678a1e655b8d1034ac8700b53d7: Bug 1448880 - Part 2: Persist Debugger.Frame objects for generators across yield/await. r=jimb.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:22:00 +0000 - rev 491038
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448880 - Part 2: Persist Debugger.Frame objects for generators across yield/await. r=jimb. This is the minimal patch, but it leaves two bugs: 1. When a generator or async function is resumed, stepping is reenabled in Debugger::getFrame, which isn't necessarily called. The onStep tests in this patch work because they all use an onEnterFrame hook, which causes getFrame to be called as soon as the generator is resumed. 2. .onStep and .onPop hooks on suspended Frames do not survive GC if there are no other references to the Frame or the Debugger object. The behavior is safe, but the hooks can just mysteriously stop firing when GC happens. The next three patches in this stack lay the groundwork for fixing these bugs, without changing behavior; part 6 fixes the first bug; and part 7 fixes the second. Depends on D6982 Differential Revision: https://phabricator.services.mozilla.com/D6983
2f3da01d8816a0117e39eca43cd4c52c0a381a4d: Bug 1448880 - Part 1: Always close a generator on early forced return. r=jimb
Jason Orendorff <jorendorff@mozilla.com> - Tue, 23 Oct 2018 23:21:01 +0000 - rev 491037
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1448880 - Part 1: Always close a generator on early forced return. r=jimb The previous code failed to close the generator in the case where JSOP_GENERATOR had run but JSOP_INITIAL_YIELD had not, a bit of sloppiness that created yet another special case. Things will get more complicated when we start keeping frames live while suspended; it's better to not have this special case. Differential Revision: https://phabricator.services.mozilla.com/D6982
faaec607a74f01e81bc5a6b54d0c4141ad5cf8f5: Bug 1501073 - Test expectation adjustments. r=kats
Bobby Holley <bobbyholley@gmail.com> - Wed, 24 Oct 2018 00:49:16 +0000 - rev 491036
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501073 - Test expectation adjustments. r=kats Depends on D9610 Differential Revision: https://phabricator.services.mozilla.com/D9611
61b89032c551c59ab82f64689c1b271c5c0d2263: Bug 1501319 - Update webrender to commit e7d340b0f39bbd0046e983a75245bdde54013cdb. r=kats
WR Updater Bot <graphics-team@mozilla.staktrace.com> - Wed, 24 Oct 2018 00:48:58 +0000 - rev 491035
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501319 - Update webrender to commit e7d340b0f39bbd0046e983a75245bdde54013cdb. r=kats Differential Revision: https://phabricator.services.mozilla.com/D9610
9f15c79e58d135c7e710210a9d0242eb42d9f5bc: Backed out changeset b283e9a224e0 (bug 1402282) build bustages on RandomNum.cpp.
Cosmin Sabou <csabou@mozilla.com> - Wed, 24 Oct 2018 03:00:42 +0300 - rev 491034
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Backed out changeset b283e9a224e0 (bug 1402282) build bustages on RandomNum.cpp.
b283e9a224e0450ff9880af7b7366f9e73661ac5: Bug 1402282 - Move CSPRNG logic to common area r=froydnj
Cosmin Sabou <csabou@mozilla.com> - Wed, 24 Oct 2018 02:49:33 +0300 - rev 491033
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1402282 - Move CSPRNG logic to common area r=froydnj
f99c22e6f6b1e8820eb20936aee362dc86dbd454: Bug 1499254 - fake-multi-dep is no longer needed. r=tomprince
Aki Sasaki <asasaki@mozilla.com> - Tue, 23 Oct 2018 19:33:09 +0000 - rev 491032
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499254 - fake-multi-dep is no longer needed. r=tomprince Depends on D9200 Differential Revision: https://phabricator.services.mozilla.com/D9201
848914c4c934be47a40a70fc09c5c26cd8df0ec4: Bug 1499254 - beetmover_repackage{,_l10n} multi-dep. r=tomprince
Aki Sasaki <asasaki@mozilla.com> - Tue, 23 Oct 2018 21:12:39 +0000 - rev 491031
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499254 - beetmover_repackage{,_l10n} multi-dep. r=tomprince Depends on D9198 Differential Revision: https://phabricator.services.mozilla.com/D9200
2eea4d6c1597ce9a997eca8bc5fdb78119d7aced: Bug 1499254 - add primary-dependency support. r=tomprince,Callek
Aki Sasaki <asasaki@mozilla.com> - Tue, 23 Oct 2018 21:12:51 +0000 - rev 491030
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499254 - add primary-dependency support. r=tomprince,Callek Depends on D9194 Differential Revision: https://phabricator.services.mozilla.com/D9196
6f85b1efc3d27984fda22198353a56fee1cdd994: Bug 1499254 - sort reverse_chunk_deps for easier diffing. r=tomprince
Aki Sasaki <asasaki@mozilla.com> - Tue, 23 Oct 2018 19:28:16 +0000 - rev 491029
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499254 - sort reverse_chunk_deps for easier diffing. r=tomprince Differential Revision: https://phabricator.services.mozilla.com/D9194
dce16565d2a8c37e885b9e105ffcb78a0e6458db: Bug 1501426 - Add 'sw-e10s' to run_info_extras r=jmaher
Wes Kocher <wkocher@mozilla.com> - Tue, 23 Oct 2018 23:33:31 +0000 - rev 491028
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501426 - Add 'sw-e10s' to run_info_extras r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D9585
2793e042041cecfd63b3a66f9930bf49c6ac3aa0: Bug 1499865 - Make loadedModules and loadedComponents into array attributes. r=kmag
Andrew McCreight <continuation@gmail.com> - Tue, 23 Oct 2018 23:28:44 +0000 - rev 491027
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499865 - Make loadedModules and loadedComponents into array attributes. r=kmag Differential Revision: https://phabricator.services.mozilla.com/D9561
75f6d479fdaf74ea269f22c7f3e6ffe91133c726: Bug 1501428 - Enable test_scrollbar_colors.html on Linux. r=karlt
Xidorn Quan <me@upsuper.org> - Tue, 23 Oct 2018 23:25:32 +0000 - rev 491026
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1501428 - Enable test_scrollbar_colors.html on Linux. r=karlt Differential Revision: https://phabricator.services.mozilla.com/D9595
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 tip