3ea646bde4de4772a439a31798406287d2be685e: Bug 1499542 part 2: Skip frozen flex items when recording grow-vs-shrink state and deltas. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 17 Oct 2018 18:52:33 +0000 - rev 490404
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499542 part 2: Skip frozen flex items when recording grow-vs-shrink state and deltas. r=bradwerth Frozen flex items have already been clamped to their min/max sizes, so their size-change isn't a "how much we want to flex" measurement, and it's not useful for determining whether the rest of the line is shrinking. This patch is just adding a `if (!item->IsFrozen())` check around some code, and reindenting that code, and adjusting a few comments. This change is necessary to avoid failing the "GrowthState" assertions, because (for example) a flex item that's clamped to a small max-width could fool us into thinking we're in a "shrinking" state (since its final size is smaller than its base size), even though really we're in a "growth" state and the item was simply clamped. We avoid this problem by skipping (potentially-clamped) frozen items when determining the line's GrowthState. Depends on D8922 Differential Revision: https://phabricator.services.mozilla.com/D9018
52bd865d757c2787845e1bb79ed3936484d6ce3b: Bug 1499542 part 1: Don't do early-freeze of flexible-but-doomed-to-be-clamped flex items, if devtools are active. r=bradwerth
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 18 Oct 2018 23:44:42 +0000 - rev 490403
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499542 part 1: Don't do early-freeze of flexible-but-doomed-to-be-clamped flex items, if devtools are active. r=bradwerth We'd like to be able to record the "desired" (pre-clamped) delta size from tentatively flexing for these items. That size would be computed during a loop of the flex layout algorithm -- but we can't do that if we freeze them before we start flexing. So let's bypass this early freeze so they get a chance to compute this tentative size, even though they can never have it. Differential Revision: https://phabricator.services.mozilla.com/D8922
12527d50a493ce5a8c96bd7e6990d751ce9846e6: Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 18 Oct 2018 22:54:10 +0000 - rev 490402
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499209 - Send abbreviated source bundles with accessibility events. r=Jamie Depends on D8778 Differential Revision: https://phabricator.services.mozilla.com/D8779
4b8f36f9896b04d3e10f598383edd019feb1ce73: Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie
Eitan Isaacson <eitan@monotonous.org> - Thu, 18 Oct 2018 22:54:06 +0000 - rev 490401
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499209 - Refactor AccessibleWrap::ToBundle 1/2. r=Jamie This refactor does a few things: 1. Unifies the composition of the GeckoBundle, so that some tricky edge cases don't need to be implemented twice. 2. Allows us to be more frugal with round trip sync ipc calls. Instead of retrieving everything from the start, only progressivley retrieve what we need. 3. Sets the groundwork for the next patch that will return from this function earlier with a smaller bundle. Differential Revision: https://phabricator.services.mozilla.com/D8778
d0d593bf9772b1eb99547d114c9c6533e87bcd56: Bug 1499809 - l10n bumper should touch a status file on success. r=nthomas
Aki Sasaki <asasaki@mozilla.com> - Thu, 18 Oct 2018 22:05:51 +0000 - rev 490400
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499809 - l10n bumper should touch a status file on success. r=nthomas Differential Revision: https://phabricator.services.mozilla.com/D9017
b969cbe46b14814c397199ef84db2ed18d252107: Bug 1492656 - move Telemetry Coverage ping in-tree r=janerik
Robert Helmer <rhelmer@mozilla.com> - Thu, 04 Oct 2018 14:15:11 +0000 - rev 490399
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1492656 - move Telemetry Coverage ping in-tree r=janerik Differential Revision: https://phabricator.services.mozilla.com/D6359
646f2d021c1163ac0c58c3878aa6921dc92311cb: Bug 1499042 - "Fix learn more links in the Network panel". r=Honza
<lba_2> - Thu, 18 Oct 2018 06:54:00 +0300 - rev 490398
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499042 - "Fix learn more links in the Network panel". r=Honza
25594c3013c4852ee5441321b340983c2a8d6364: Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Diego Pino Garcia <dpino@igalia.com> - Thu, 18 Oct 2018 23:56:00 +0300 - rev 490397
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN Also require basicCardPage has a selectedStateKey
f35ac5e55bb4ea3a74c53b964bec3627c984961b: Bug 1499906 (attempt 2) - Use template literals where suitable. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:11:43 +1100 - rev 490396
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Use template literals where suitable. r=erahm
1752794d80abffc53fe6ffa689fcd1648195b6af: Bug 1499906 (attempt 2) - Put some parameters in `aFoo` form. erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:11:41 +1100 - rev 490395
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Put some parameters in `aFoo` form. erahm
d8c9c172c24599b14ce744fd5b9f01f5916e5ae9: Bug 1499906 (attempt 2) - Use String.prototype.padStart(). r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:11:39 +1100 - rev 490394
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Use String.prototype.padStart(). r=erahm
edee090da6bdce1e744b951145b0afa4ac4bd9d4: Bug 1499906 (attempt 2) - Use toLocaleString(). r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:11:36 +1100 - rev 490393
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Use toLocaleString(). r=erahm
838f16e6dcf2239d5b94dc5d5086f22558467dba: Bug 1499906 (attempt 2) - Change `var` to `let`. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:09:46 +1100 - rev 490392
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Change `var` to `let`. r=erahm
51a3a633315cebea2c31fb871d6c35300b529313: Bug 1499906 (attempt 2) - Use for..of loops where possible. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:09:46 +1100 - rev 490391
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Use for..of loops where possible. r=erahm
d091653eec100d84b4c1e7fd78e05aa9257a5f08: Bug 1499906 (attempt 2) - Improve treeline handling. r=erahm.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:09:46 +1100 - rev 490390
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Improve treeline handling. r=erahm.
2c53f4bdf597569fcc308a770d2adb6711b48723: Bug 1499906 (attempt 2) - Use non-ASCII chars directly in the code. r=erahm
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 19 Oct 2018 15:09:41 +1100 - rev 490389
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Bug 1499906 (attempt 2) - Use non-ASCII chars directly in the code. r=erahm
a5db777b44d0cd1ceb747fb3bdd8401bffd5a6f5: Merge mozilla-central to mozilla-inbound. a=merge
Cosmin Sabou <csabou@mozilla.com> - Fri, 19 Oct 2018 07:22:06 +0300 - rev 490388
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Merge mozilla-central to mozilla-inbound. a=merge
7d74c59053843bd79ed1456e830a760fdf82656b: Merge mozilla-inbound to mozilla-central. a=merge
Cosmin Sabou <csabou@mozilla.com> - Fri, 19 Oct 2018 07:17:09 +0300 - rev 490387
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Merge mozilla-inbound to mozilla-central. a=merge
eeb16056d57a64fd44999a4f81d4e5dd6538d1c0: Merge autoland to mozilla-central. a=merge
Cosmin Sabou <csabou@mozilla.com> - Fri, 19 Oct 2018 07:15:45 +0300 - rev 490386
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Merge autoland to mozilla-central. a=merge
74ce6fcac2111570473f580669c536d93f816133: Backed out changeset 89663382dd1e (bug 1499209),for Android build bustages on AccessibleWrap.cpp:416
arthur.iakab <aiakab@mozilla.com> - Fri, 19 Oct 2018 01:27:24 +0300 - rev 490385
Push 247 by fmarier@mozilla.com at Sat, 27 Oct 2018 01:06:44 +0000
Backed out changeset 89663382dd1e (bug 1499209),for Android build bustages on AccessibleWrap.cpp:416
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 tip