Bug 1036367 - Fix dangerous public destructors in purple/ for dynamic prpls. r=florian
authorPatrick Cloke <clokep@gmail.com>
Wed, 09 Jul 2014 16:34:16 -0400
changeset 738 890a12044644de90709937000071a76dd51442c7
parent 737 b0681d7c96db64cdbdd931e01ffe43d65a23e0e5
child 739 956f01125ef6e067196fe4a9d40fc58170055a45
push id18
push userclokep@gmail.com
push dateWed, 09 Jul 2014 20:35:19 +0000
reviewersflorian
bugs1036367
Bug 1036367 - Fix dangerous public destructors in purple/ for dynamic prpls. r=florian
libpurple/protocols/xpcomModule.cpp.in
--- a/libpurple/protocols/xpcomModule.cpp.in
+++ b/libpurple/protocols/xpcomModule.cpp.in
@@ -20,20 +20,21 @@
 
 extern "C" {
   gboolean purple_plugin_register_self();
 }
 
 class @PROTOCOL@: public purpleIPlugin {
 public:
   @PROTOCOL@();
-  virtual ~@PROTOCOL@();
-
   NS_DECL_ISUPPORTS
   NS_DECL_PURPLEIPLUGIN
+
+private:
+  virtual ~@PROTOCOL@();
 };
 
 @PROTOCOL@::@PROTOCOL@()
 {
 }
 @PROTOCOL@::~@PROTOCOL@()
 {
 }