note reviews, and update commit messages
authorDaniel Holbert <dholbert@cs.stanford.edu>
Mon, 03 May 2010 19:01:35 -0700
changeset 1554 7a792acb48c78defe41fb9f47813a3cd30344b7a
parent 1553 a90c9f5a484093563543bc21cc9a3bad9e5dbdfb
child 1555 919d2f65c65b14eeb88b0d0de07840414c8da814
push id1252
push userdholbert@mozilla.com
push dateTue, 04 May 2010 02:01:38 +0000
note reviews, and update commit messages
tokenizer_allowOtherChars
tokenizer_allowSeparatorToBeOptional
tokenizer_fixOldUses
tokenizer_useInSVGAndSMIL
--- a/tokenizer_allowOtherChars
+++ b/tokenizer_allowOtherChars
@@ -1,10 +1,10 @@
 From: Daniel Holbert <dholbert@cs.stanford.edu>
-Bug 562310 Part 2: Convert nsCommaSeparatedTokenizer class into a custom SeparatorChar version, nsCharSeparatedTokenizer. r=NOT_REVIEWED_YET
+Bug 562310 Part 2: Convert nsCommaSeparatedTokenizer class into a custom-SeparatorChar version, nsCharSeparatedTokenizer. r=roc
 
 diff --git a/content/html/content/src/nsHTMLMediaElement.cpp b/content/html/content/src/nsHTMLMediaElement.cpp
 --- a/content/html/content/src/nsHTMLMediaElement.cpp
 +++ b/content/html/content/src/nsHTMLMediaElement.cpp
 @@ -1324,17 +1324,17 @@ static CanPlayStatus GetCanPlay(const ns
    PRBool expectMoreTokens = PR_FALSE;
    while (tokenizer.hasMoreTokens()) {
      const nsSubstring& token = tokenizer.nextToken();
--- a/tokenizer_allowSeparatorToBeOptional
+++ b/tokenizer_allowSeparatorToBeOptional
@@ -1,10 +1,10 @@
 From: Daniel Holbert <dholbert@cs.stanford.edu>
-Bug 562310 Part 3: Extend nsCharSeparatedTokenizer to allow separator to be optional. r=NOT_REVIEWED_YET
+Bug 562310 Part 3: Extend nsCharSeparatedTokenizer to allow separator to be optional. r=roc
 
 diff --git a/xpcom/ds/nsCharSeparatedTokenizer.h b/xpcom/ds/nsCharSeparatedTokenizer.h
 --- a/xpcom/ds/nsCharSeparatedTokenizer.h
 +++ b/xpcom/ds/nsCharSeparatedTokenizer.h
 @@ -54,20 +54,28 @@
   * "foo , bar hi , baz" -> "foo" "bar hi" "baz"
   * "foo, ,bar,baz" ->      "foo" "" "bar" "baz"
   * "foo,,bar,baz" ->       "foo" "" "bar" "baz"
--- a/tokenizer_fixOldUses
+++ b/tokenizer_fixOldUses
@@ -1,10 +1,10 @@
 From: Daniel Holbert <dholbert@cs.stanford.edu>
-Bug 562310 Part 4: Remove nsCommaSeparatedTokenizer typedef, and replace its uses with nsCharSeparatedTokenizer<','>. r=NOT_REVIEWED_YET
+Bug 562310 Part 4: Remove nsCommaSeparatedTokenizer typedef, and replace its uses with nsCharSeparatedTokenizer(','). r=roc
 
 diff --git a/content/html/content/src/nsHTMLMediaElement.cpp b/content/html/content/src/nsHTMLMediaElement.cpp
 --- a/content/html/content/src/nsHTMLMediaElement.cpp
 +++ b/content/html/content/src/nsHTMLMediaElement.cpp
 @@ -1315,17 +1315,17 @@ static CanPlayStatus GetCanPlay(const ns
    rv = parser.GetParameter("codecs", codecs);
    if (NS_FAILED(rv))
      // Parameter not found or whatever
--- a/tokenizer_useInSVGAndSMIL
+++ b/tokenizer_useInSVGAndSMIL
@@ -1,10 +1,10 @@
 From: Daniel Holbert <dholbert@cs.stanford.edu>
-Bug 562310 Part 5: Use nsCharSeparatedTokenizer to simplify/fix existing parsing code in SVG and SMIL. r=NOT_REVIEWED_YET
+Bug 562310 Part 5: Use nsCharSeparatedTokenizer to simplify/fix existing parsing code in SVG and SMIL. r=roc
 
 diff --git a/content/smil/nsSMILParserUtils.cpp b/content/smil/nsSMILParserUtils.cpp
 --- a/content/smil/nsSMILParserUtils.cpp
 +++ b/content/smil/nsSMILParserUtils.cpp
 @@ -43,16 +43,17 @@
  #include "nsSMILTypes.h"
  #include "nsSMILRepeatCount.h"
  #include "nsContentUtils.h"