ce82e2d625e41db68079785e3d9f5e96b56df162: No bug, Automated HSTS preload list update from host bld-linux64-spot-302 - a=hsts-update
ffxbld - Wed, 28 Feb 2018 12:02:16 -0800 - rev 444717
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
No bug, Automated HSTS preload list update from host bld-linux64-spot-302 - a=hsts-update
cdb1de7522a998937acd695942aaa63f158357f4: Bug 1440465 - initialize more things in AutoPointerEventTargetUpdater; r=dholbert
Nathan Froyd <froydnj@mozilla.com> - Wed, 28 Feb 2018 15:00:04 -0500 - rev 444716
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1440465 - initialize more things in AutoPointerEventTargetUpdater; r=dholbert
341f20ef2627e0b19a324de14f9b32ed743bda92: Bug 1436845: Part 3 - Add support for ModuleSignatureInfo field in .extra file on Windows builds; r=ted
Aaron Klotz <aklotz@mozilla.com> - Tue, 13 Feb 2018 16:04:01 -0700 - rev 444715
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1436845: Part 3 - Add support for ModuleSignatureInfo field in .extra file on Windows builds; r=ted We want to send information about the organization whose cert was used to sign modules in our address space. Originally I had written this code to accumulate that info within Firefox, but I realized that a better option is to do this from the minidump analyzer: (1) This way does not affect browser performance; (2) This way allows us to properly gather cert info even from startup crashes. This functionality was reviewed for data collection via bug 1430857.
a9c97aa6d78903db203f80a1d6d78b1547f15297: Bug 1436845: Part 2 - Link minidump-analyzer with mozglue on Windows; r=ted
Aaron Klotz <aklotz@mozilla.com> - Tue, 13 Feb 2018 16:03:38 -0700 - rev 444714
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1436845: Part 2 - Link minidump-analyzer with mozglue on Windows; r=ted I have already implemented code to check binary signatures in mozglue so that we can do so from both firefox.exe and xul.dll. Rather than including yet another implementation elsewhere, I'd rather just reuse that code by building minidump-analyzer as a GeckoProgram with Null XPCOM linkage, thus making it capable of using the mozglue implementation too. I'd also like to add this signature stuff to Mac builds at some point, so I'm trying to make this functionality as easy as possible to expand and reuse in the future.
ff7e21c630eb634a2d59910d8f9b95388fc35c0d: Bug 1436845: Part 1 - Add BasicDllServices; r=jimm
Aaron Klotz <aklotz@mozilla.com> - Tue, 13 Feb 2018 16:03:11 -0700 - rev 444713
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1436845: Part 1 - Add BasicDllServices; r=jimm BasicDllServices is a simplified implementation that allows programs other than Firefox to link against mozglue and access DLL services without requiring any XPCOM baggage.
724aad27fd444a8b1a01eb96284079aae7cfbd25: Bug 1428839 - Part 8 - Fix the sliding transition when views are reordered. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Wed, 28 Feb 2018 13:43:51 +0000 - rev 444712
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 8 - Fix the sliding transition when views are reordered. r=Gijs Views moved to a different panel and then moved back could be placed after the subviews they give access to, if the other subviews were not moved. The transition would be incorrect when these subviews are opened later. MozReview-Commit-ID: 6JJa0p0McxL
39605c4715d10ef1c0eece86c6a7663d34ad719b: Bug 1428839 - Part 7 - Reduce calls to _cleanupTransitionPhase. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 22:56:15 +0000 - rev 444711
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 7 - Reduce calls to _cleanupTransitionPhase. r=Gijs The transition code now returns early if the panel was closed during an "await" statement. Given that transitions can only be interrupted when closing the panel, and the _cleanupTransitionPhase method handles exclusively state related to the panel rather than the individual views, it is now possible to call the _cleanupTransitionPhase method only when the panel is hidden or at the end of a transition. MozReview-Commit-ID: GYRKyyhJBPK
9ca146d063f1a5f39cd30fc3d8b0ff25a0cb1d45: Bug 1428839 - Part 6 - Remove previous workaround for the panel resizing at the end of the transition. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 16:13:48 +0000 - rev 444710
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 6 - Remove previous workaround for the panel resizing at the end of the transition. r=Gijs This was added in bug 1354141 and is not needed anymore. MozReview-Commit-ID: 42oF7LpCa6R
1c4d69669156774e5e06b48a19cbe7f20b66cae2: Bug 1428839 - Part 5 - Open the anchor when subview navigation starts and close it asynchronously afterwards. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 15:52:07 +0000 - rev 444709
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 5 - Open the anchor when subview navigation starts and close it asynchronously afterwards. r=Gijs The anchor state does not need to be cleaned up synchronously, so we can handle it seperately from the transition state. MozReview-Commit-ID: 1CBP9OS5WmM
96dd6c0d53b9be1532119e23876d21e9d51b9078: Bug 1428839 - Part 4 - Avoid re-entrancy in PanelMultiView navigation functions. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 15:33:33 +0000 - rev 444708
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 4 - Avoid re-entrancy in PanelMultiView navigation functions. r=Gijs We now use the "active" property of views to track whether navigation is possible. This has the advantage of being already handled correctly when views are moved to a different panel, and is in line with the purpose of the "active" state. The note about using the "popupshown" event for navigation has been updated accordingly. Keyboard navigation is also linked to the "active" property now, so there is no need to track the state of the "_transitioning" property anymore. Since the goBack and showSubView methods can only be called when the view is active, we don't need to check for attempts to start a transition while the panel is closed anymore. MozReview-Commit-ID: 3KT3A5EwGFy
288b230b356c58e0a4980e1f4cd3642d3fa2d872: Bug 1428839 - Part 3 - Clean up view properties when opening them. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 15:35:42 +0000 - rev 444707
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 3 - Clean up view properties when opening them. r=Gijs This allows the state to be handled correctly when views are moved to a different panel. The "margin-inline-start" style property on the view stack is also reset unconditionally, allowing less state to be stored in the transition details object. MozReview-Commit-ID: IpgnYsVvx0w
0605579057e6b57aac46deecae3ead4084575427: Bug 1428839 - Part 2 - Add a function to determine if a view is still open. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 15:27:27 +0000 - rev 444706
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 2 - Add a function to determine if a view is still open. r=Gijs This makes the intent of the code clearer and hides the details of how the association is made. MozReview-Commit-ID: C2L0vsjhxNO
f579f320031ce52c558112299431b758df5706fa: Bug 1428839 - Part 1 - Remove previous workaround for flickering at the end of the transition. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 15:17:29 +0000 - rev 444705
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1428839 - Part 1 - Remove previous workaround for flickering at the end of the transition. r=Gijs This was originally introduced in bug 1374749 but isn't needed anymore, and removing this allows making the _cleanupTransitionPhase method synchronous. MozReview-Commit-ID: 6v78QoPXZoU
d0ecce89ac1aaf60e826afa9be9a92fbdb29a194: Bug 1441284 - Part 8 - Remove the "_mainView" and "_mainViewId" properties. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 14:17:10 +0000 - rev 444704
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1441284 - Part 8 - Remove the "_mainView" and "_mainViewId" properties. r=Gijs The null check for the "node" property can also be removed since the caller already checks it synchronously. MozReview-Commit-ID: 7FaCdtWTz20
cd1250f642803879894ad3e39362a9548b248096: Bug 1441284 - Part 7 - Remove the "_ephemeral" property. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 26 Feb 2018 19:50:19 +0000 - rev 444703
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1441284 - Part 7 - Remove the "_ephemeral" property. r=Gijs The "ephemeral" attribute was not actually used anymore, because it is redundant with the "viewCacheId" attribute. MozReview-Commit-ID: 6zxf2DmcEfI
3e819acb990a3ec8c9c8448eae9278266118642f: Bug 1441284 - Part 6 - Do not move out subviews when the window is closing. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 26 Feb 2018 19:47:29 +0000 - rev 444702
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1441284 - Part 6 - Do not move out subviews when the window is closing. r=Gijs Since we control the code path that invokes the PanelMultiView destructor, it is now possible to call the _moveOutKids function only as needed, avoiding some unnecessary DOM modifications when the browser window is closing. MozReview-Commit-ID: JTJQmhZKFOh
c4b46b5edc28678ca60daaeccedd3e566e811b70: Bug 1441284 - Part 5 - Remove the "_panelViewCache" property. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 26 Feb 2018 19:36:12 +0000 - rev 444701
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1441284 - Part 5 - Remove the "_panelViewCache" property. r=Gijs MozReview-Commit-ID: IjTCdzr6gZ5
63cfc3426678cc22dec17a2544f8035e2e9d95db: Bug 1441284 - Part 4 - Remove redundant calls before _moveOutKids and simplify the function. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 26 Feb 2018 19:14:31 +0000 - rev 444700
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1441284 - Part 4 - Remove redundant calls before _moveOutKids and simplify the function. r=Gijs The main view is already included in the children of the view stack, so the code that moves it out separately can be removed. The "mainview" attribute is already set to the correct value the next time the view is opened. MozReview-Commit-ID: B8LMAxWvvTb
00d855c4d71defeebf6050454ac0ea675527531b: Bug 1441284 - Part 3 - Remove the "showingSubView" property. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Tue, 27 Feb 2018 14:08:58 +0000 - rev 444699
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1441284 - Part 3 - Remove the "showingSubView" property. r=Gijs The value "single" for the "closemenu" attribute on panel buttons is unused, so the only consumer of the "showingSubView" property can be removed. MozReview-Commit-ID: 2jf5YE4Uyd
a81851454a368ff8b23b7df497b0d88699be050b: Bug 1441284 - Part 2 - Remove the "_currentSubView" property. r=Gijs
Paolo Amadini <paolo.mozmail@amadzone.org> - Mon, 26 Feb 2018 18:43:43 +0000 - rev 444698
Push 8 by bugmail@asutherland.org at Sat, 11 Aug 2018 16:11:21 +0000
Bug 1441284 - Part 2 - Remove the "_currentSubView" property. r=Gijs MozReview-Commit-ID: Aua3V8hOT39
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip