Bug 685655: Add parentheses to pymake's shell metacharacter blocklist. r=ted
authorKyle Huey <khuey@kylehuey.com>
Sun, 09 Oct 2011 18:23:11 -0400
changeset 297 476b9db400026a42545e7b83a0ef50b8f584b649
parent 296 04fee3d7bdecea2179367449a2d88b15d57c8330
child 298 75d1479a66882fa50a132b7a267ceca33e36d5c8
push id178
push userkhuey@mozilla.com
push dateSun, 09 Oct 2011 22:23:17 +0000
reviewersted
bugs685655
Bug 685655: Add parentheses to pymake's shell metacharacter blocklist. r=ted
pymake/process.py
tests/parentheses.mk
--- a/pymake/process.py
+++ b/pymake/process.py
@@ -10,17 +10,17 @@ import subprocess, shlex, re, logging, s
 subprocess._cleanup = lambda: None
 import command, util
 if sys.platform=='win32':
     import win32process
 
 _log = logging.getLogger('pymake.process')
 
 _escapednewlines = re.compile(r'\\\n')
-_blacklist = re.compile(r'[$><;[{~`|&]')
+_blacklist = re.compile(r'[$><;[{~`|&()]')
 _needsglob = re.compile(r'[\*\?]')
 def clinetoargv(cline):
     """
     If this command line can safely skip the shell, return an argv array.
     @returns argv, badchar
     """
 
     str = _escapednewlines.sub('', cline)
new file mode 100644
--- /dev/null
+++ b/tests/parentheses.mk
@@ -0,0 +1,2 @@
+all:
+	@(echo TEST-PASS)