author Benjamin Smedberg <>
Wed, 18 Feb 2009 17:27:01 -0500
changeset 133 7df5ab3b364fac50aea2c025d3a973801ca7670e
child 134 ca40dbbeb55a00109b5c3d76c64c2d23b8364550
permissions -rw-r--r--
Skip the shell when there aren't any special metacharacters to worry about.

Skipping shell invocations is good, when possible. This wrapper around subprocess does dirty work of
parsing command lines into argv and making sure that no shell magic is being used.

import subprocess, shlex, re, logging

_log = logging.getLogger('pymake.execution')

blacklist = re.compile(r'[=\\$><;*?[{~`]')
def clinetoargv(cline):
    If this command line can safely skip the shell, return an argv array.

    if is not None:
        return None

    return shlex.split(cline, comments=True)

def call(cline, env, cwd, loc):
    argv = clinetoargv(cline)
    if argv is None:
        _log.debug("%s: Running command through shell because of shell metacharacters" % (loc,))
        return, shell=True, env=env, cwd=cwd)

    _log.debug("%s: skipping shell, no metacharacters found" % (loc,))
    return, shell=False, env=env, cwd=cwd)