Bug 1501066 - part 2 - Simplify flexibility info and bail out when useless; r=mtigley
authorPatrick Brosset <pbrosset@mozilla.com>
Wed, 31 Oct 2018 17:49:14 +0000
changeset 10697 39f508ce22f8877b3c4cc2231236db7a9bc5cd02
parent 10696 aca571ce2b0970304313100fadf40f22c78b4f40
child 10698 3ab0791c99ea932d05f77858cfa7fcc39e7a5b51
child 10701 d2e556b3f024bc5e068678ac76dc53b4d63ac2ff
push id47
push userfrancesco.lodolo@mozillaitalia.org
push dateThu, 01 Nov 2018 05:10:33 +0000
reviewersmtigley
bugs1501066
Bug 1501066 - part 2 - Simplify flexibility info and bail out when useless; r=mtigley In cases where an item did not grow or shrink, devtools doesn't really have access to any useful information about how the item might have wanted to flex. So in this change, I'm just making sure we don't attempt to display this info at all, because it's basically incorrect otherwise. Depends on D10235 Differential Revision: https://phabricator.services.mozilla.com/D10236 X-Channel-Repo: mozilla-central X-Channel-Converted-Revision: 7c5dc48aa9dcf9472a4ffa2a6ee1b3db042f2149 X-Channel-Repo: releases/mozilla-beta X-Channel-Revision: 848cf6354160ca6e2dccbeb859f64b6b9e67e4cc X-Channel-Repo: releases/mozilla-release X-Channel-Revision: 18d4c09e9378f1fca26c074a10195589248c88c0
devtools/client/layout.properties
--- a/devtools/client/layout.properties
+++ b/devtools/client/layout.properties
@@ -75,16 +75,32 @@ flexbox.itemSizing.notEnoughRoomOnLine=There wasn’t enough room available on the flex line.
 # LOCALIZATION NOTE (flexbox.itemSizing.growthAttemptWhenClamped): Label shown in the
 # flexbox item sizing panel. It tells users that a given item attempted to grow by a
 # certain amount but ended up being clamped by a max size.
 # (note that clamp is a common word in flexbox terminology. It refers to constraining an
 # item's size to some defined min/max-width/height set on the element, even though there
 # might have been room for it to grow, or reason for it to shrink more).
 flexbox.itemSizing.growthAttemptWhenClamped=The item wanted to grow, but it was clamped.
 
+# LOCALIZATION NOTE (flexbox.itemSizing.growthAttemptButMaxClamped): Label shown in the
+# flexbox item sizing panel. It tells users that a given item attempted to grow by a
+# certain amount but ended up being clamped to a smaller max size.
+# (Note that clamp is a common word in flexbox terminology. It refers to constraining an
+# item's size to some defined min/max-width/height set on the element, even though there
+# might have been room for it to grow, or reason for it to shrink more).
+flexbox.itemSizing.growthAttemptButMaxClamped=The item wanted to grow more, but it was clamped to its maximum size.
+
+# LOCALIZATION NOTE (flexbox.itemSizing.growthAttemptButMinClamped): Label shown in the
+# flexbox item sizing panel. It tells users that a given item attempted to grow by a
+# certain amount but ended up being clamped to a larger min size.
+# (Note that clamp is a common word in flexbox terminology. It refers to constraining an
+# item's size to some defined min/max-width/height set on the element, even though there
+# might have been room for it to grow, or reason for it to shrink more).
+flexbox.itemSizing.growthAttemptButMinClamped=The item wanted to grow less, but it was clamped to its minimum size.
+
 # LOCALIZATION NOTE (flexbox.itemSizing.shrinkAttemptWhenClamped): Label shown in the
 # flexbox item sizing panel. It tells users that a given item attempted to shrink by a
 # certain amount but ended up being clamped by a min size.
 flexbox.itemSizing.shrinkAttemptWhenClamped=The item wanted to shrink, but it was clamped.
 
 # LOCALIZATION NOTE (flexbox.itemSizing.shrinkAttemptButCouldnt): Label shown in the
 # flexbox item sizing panel. It tells users that a given item attempted to shrink by a
 # certain amount but could not