bug 1540655: remote: ignore non-vendored Node.js assets; r=remote-protocol-reviewers,jdescottes draft
authorpulselistener
Fri, 16 Aug 2019 13:22:16 +0000
changeset 2220729 eac66660e5ed3d22817c9a37f662c0a6e45a6142
parent 2220728 1c85cbf0c5308ba92ecb7f46a17aab3f40305067
child 2220730 5de2f4622f3ce60ef9bf2ce100e35c229fc2dea0
push id406994
push userreviewbot
push dateFri, 16 Aug 2019 13:23:14 +0000
treeherdertry@5f50de08beda [default view] [failures only]
reviewersremote-protocol-reviewers, jdescottes
bugs1540655
milestone70.0a1
bug 1540655: remote: ignore non-vendored Node.js assets; r=remote-protocol-reviewers,jdescottes We vendor the Puppeteer library, but not its dependencies. When "npm install" is called in remote/test/puppeteer/, it puts its dependencies under remote/test/puppeteer/node_modules/ and generates a remote/test/puppeteer/package-lock.json file. We do not want these to be checked in. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D37010 Differential Diff: PHID-DIFF-x6fjowgun6fpxnn4gsk5
.hgignore
remote/.gitignore
--- a/.hgignore
+++ b/.hgignore
@@ -94,16 +94,20 @@ compile_commands\.json
 
 # Ignore chrome.manifest files from the devtools loader
 ^devtools/client/chrome.manifest$
 ^devtools/shared/chrome.manifest$
 
 # Ignore node_modules directories in devtools
 ^devtools/.*/node_modules/
 
+# Ignore node_module directories and npm artifacts
+^remote/test/puppeteer/package-lock.json
+^remote/test/puppeteer/node_modules/
+
 # git checkout of libstagefright
 ^media/libstagefright/android$
 
 # Tag files generated by GNU Global
 (^|/)GTAGS$
 (^|/)GRTAGS$
 (^|/)GSYMS$
 (^|/)GPATH$
new file mode 100644
--- /dev/null
+++ b/remote/.gitignore
@@ -0,0 +1,2 @@
+test/puppeteer/package-lock.json
+test/puppeteer/node_modules/