Bug 1288649 - 2-arg ctors shouldn't be explicit.
authorJeff Gilbert <jgilbert@mozilla.com>
Thu, 21 Jul 2016 23:29:19 -0700
changeset 805859 e73b2b78cad260cc5564019843eab752b1a4756d
parent 805858 4c241d379525934dbb5d2bd6fd43eb7a52062e33
child 805860 15fb408b51b3d5474eff28d90f7c0e565a0375eb
push id135272
push userjgilbert@mozilla.com
push dateFri, 22 Jul 2016 07:57:05 +0000
treeherdertry@f78cff863d60 [default view] [failures only]
bugs1288649
milestone50.0a1
Bug 1288649 - 2-arg ctors shouldn't be explicit. MozReview-Commit-ID: 8yZeVcOj3Et
dom/canvas/WebGLBuffer.h
dom/canvas/WebGLSampler.h
dom/canvas/WebGLTexture.h
dom/canvas/WebGLTimerQuery.h
dom/canvas/WebGLTransformFeedback.h
--- a/dom/canvas/WebGLBuffer.h
+++ b/dom/canvas/WebGLBuffer.h
@@ -27,17 +27,17 @@ class WebGLBuffer final
 public:
 
     enum class Kind {
         Undefined,
         ElementArray,
         OtherData
     };
 
-    explicit WebGLBuffer(WebGLContext* webgl, GLuint buf);
+    WebGLBuffer(WebGLContext* webgl, GLuint buf);
 
     void BindTo(GLenum target);
     Kind Content() const { return mContent; }
 
     void Delete();
 
     size_t SizeOfIncludingThis(mozilla::MallocSizeOf mallocSizeOf) const;
 
--- a/dom/canvas/WebGLSampler.h
+++ b/dom/canvas/WebGLSampler.h
@@ -18,17 +18,17 @@ class WebGLSampler final
     , public WebGLRefCountedObject<WebGLSampler>
     , public LinkedListElement<WebGLSampler>
     , public WebGLContextBoundObject
 {
     friend class WebGLContext2;
     friend class WebGLTexture;
 
 public:
-    explicit WebGLSampler(WebGLContext* webgl, GLuint sampler);
+    WebGLSampler(WebGLContext* webgl, GLuint sampler);
 
     const GLuint mGLName;
 
     void Delete();
     WebGLContext* GetParentObject() const;
 
     virtual JSObject* WrapObject(JSContext* cx, JS::Handle<JSObject*> givenProto) override;
 
--- a/dom/canvas/WebGLTexture.h
+++ b/dom/canvas/WebGLTexture.h
@@ -196,17 +196,17 @@ public:
 
     ImageInfo mImageInfoArr[kMaxLevelCount * kMaxFaceCount];
 
     ////////////////////////////////////
 public:
     NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(WebGLTexture)
     NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(WebGLTexture)
 
-    explicit WebGLTexture(WebGLContext* webgl, GLuint tex);
+    WebGLTexture(WebGLContext* webgl, GLuint tex);
 
     void Delete();
 
     bool HasEverBeenBound() const { return mTarget != LOCAL_GL_NONE; }
     TexTarget Target() const { return mTarget; }
 
     WebGLContext* GetParentObject() const {
         return mContext;
--- a/dom/canvas/WebGLTimerQuery.h
+++ b/dom/canvas/WebGLTimerQuery.h
@@ -35,17 +35,17 @@ public:
   virtual JSObject* WrapObject(JSContext* cx, JS::Handle<JSObject*> givenProto) override;
 
   const GLenum mGLName;
 
   NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(WebGLTimerQuery)
   NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_NATIVE_CLASS(WebGLTimerQuery)
 
 private:
-  explicit WebGLTimerQuery(WebGLContext* webgl, GLuint name);
+  WebGLTimerQuery(WebGLContext* webgl, GLuint name);
   ~WebGLTimerQuery();
 
   GLenum mTarget;
   bool mCanBeAvailable;
 
   friend class WebGLExtensionDisjointTimerQuery;
 };
 
--- a/dom/canvas/WebGLTransformFeedback.h
+++ b/dom/canvas/WebGLTransformFeedback.h
@@ -17,17 +17,17 @@ class WebGLTransformFeedback final
     , public WebGLRefCountedObject<WebGLTransformFeedback>
     , public LinkedListElement<WebGLTransformFeedback>
     , public WebGLContextBoundObject
 {
     friend class WebGLContext;
     friend class WebGL2Context;
 
 public:
-    explicit WebGLTransformFeedback(WebGLContext* webgl, GLuint tf);
+    WebGLTransformFeedback(WebGLContext* webgl, GLuint tf);
 
     void Delete();
     WebGLContext* GetParentObject() const;
     virtual JSObject* WrapObject(JSContext* cx, JS::Handle<JSObject*> givenProto) override;
 
     const GLuint mGLName;
 
     NS_INLINE_DECL_CYCLE_COLLECTING_NATIVE_REFCOUNTING(WebGLTransformFeedback)