bug 1540655: remote: document how to vendor Puppeteer; r=remote-protocol-reviewers,jdescottes draft
authorpulselistener
Fri, 16 Aug 2019 13:22:37 +0000
changeset 2220735 bee8fd5008cf93078ae46febc4feda5c0eaafdba
parent 2220734 25a68646e90c19ae4509bd3ed25a94b346576458
child 2220736 5f50de08bedab43beb86f290dd770deb748323ca
push id406994
push userreviewbot
push dateFri, 16 Aug 2019 13:23:14 +0000
treeherdertry@5f50de08beda [default view] [failures only]
reviewersremote-protocol-reviewers, jdescottes
bugs1540655
milestone70.0a1
bug 1540655: remote: document how to vendor Puppeteer; r=remote-protocol-reviewers,jdescottes Differential Revision: https://phabricator.services.mozilla.com/D39660 Differential Diff: PHID-DIFF-y3vyxwt723wzgrk4taaw
remote/doc/PuppeteerVendor.md
remote/doc/index.rst
new file mode 100644
--- /dev/null
+++ b/remote/doc/PuppeteerVendor.md
@@ -0,0 +1,35 @@
+Vendoring Puppeteer
+===================
+
+As mentioned in the chapter on [Testing], we run the full [Puppeteer
+test suite] on try.  These tests are vendored in central under
+_remote/test/puppeteer/_ and we have a script to pull in the most
+recent changes.
+
+We currently use [a fork of Puppeteer] with a small number of tweaks
+and workaround to make them run against Firefox.  These changes
+will be upstreamed to Puppeteer when we feel more comfortable about
+compatibility with Chrome.
+
+To update the vendored copy of Puppeteer under _remote/test/puppeteer/_:
+
+	% ./mach vendor puppeteer
+	 0:00.40 Removing old checkout from remote/test/puppeteer
+	 0:00.56 Checking out firefox from https://github.com/andreastt/puppeteer.git to remote/test/puppeteer
+	 0:03.35 Removing unnecessary files
+	 0:03.35 Updating remote/test/puppeteer/moz.yaml
+	 0:03.35 Registering changes with version control
+	 0:03.73 Updated Puppeteer to firefox
+
+This will replace the current checkout with a fresh copy from
+the predefined remote, which currently is the `firefox` branch on
+https://github.com/andreastt/puppeteer.git.  You can override which
+remote and commit to use with the `--remote` and `--committish` flags:
+
+	  -c COMMITISH, --commitish COMMITISH
+	                        Repository tag or commit to update to.
+	  --remote REMOTE       Remote git repository.
+	  --ignore-modified     Ignore modified files in current checkout.
+
+[Testing]: ./Testing.html
+[Puppeteer test suite]: https://github.com/GoogleChrome/puppeteer/tree/master/test
--- a/remote/doc/index.rst
+++ b/remote/doc/index.rst
@@ -33,16 +33,17 @@ Developers
   :maxdepth: 1
 
   Building.md
   Debugging.md
   Testing.md
   Architecture.md
   Prefs.md
   CodeStyle.md
+  PuppeteerVendor.md
 
 
 Bugs
 ====
 
 Bugs are tracked under the `Remote Protocol product`_.
 
 .. _Remote Protocol product: https://bugzilla.mozilla.org/describecomponents.cgi?product=Remote%20Protocol