Bug 1520458 - Run ./mach raptor with Python 3, r?#perftest-reviewers draft
authorAndrew Halberstadt <ahal@mozilla.com>
Mon, 22 Mar 2021 14:53:33 +0000
changeset 3619924 4b5b9147089602d27bc797885a98d366e3397cb4
parent 3619876 729eaf579f2827239182db122d59e42730ea540f
child 3619925 1a68a4f13a194957909ece4babc3dbde3e1943ee
push id671365
push userreviewbot
push dateMon, 22 Mar 2021 14:54:07 +0000
treeherdertry@1a68a4f13a19 [default view] [failures only]
bugs1520458
milestone88.0a1
Bug 1520458 - Run ./mach raptor with Python 3, r?#perftest-reviewers Summary: Differential Revision: https://phabricator.services.mozilla.com/D108828 Test Plan: Reviewers: #perftest-reviewers Subscribers: Bug #: 1520458 Differential Diff: PHID-DIFF-vdqxkaea7rfccxxqejpd
mach
testing/raptor/raptor/browsertime/base.py
--- a/mach
+++ b/mach
@@ -7,18 +7,16 @@
 # such that the script starts with the shell and is reexecuted with
 # the right Python.
 
 # Embeds a shell script inside a Python triple quote. This pattern is valid
 # shell because `''':'`, `':'` and `:` are all equivalent, and `:` is a no-op.
 ''':'
 # Commands that are to be run with Python 2.
 py2commands="
-    raptor
-    raptor-test
     telemetry-tests-client
 "
 
 # Commands that are to be run with the system Python 3 instead of the
 # virtualenv.
 nativecmds="
     bootstrap
     create-mach-environment
--- a/testing/raptor/raptor/browsertime/base.py
+++ b/testing/raptor/raptor/browsertime/base.py
@@ -428,16 +428,17 @@ class Browsertime(Perftest):
                 else:
                     LOG.info(msg)
 
             if self.browsertime_visualmetrics and self.run_local:
                 # Check if visual metrics is installed correctly before running the test
                 self.vismet_failed = False
 
                 def _vismet_line_handler(line):
+                    line = line.decode("utf-8")
                     LOG.info(line)
                     if "FAIL" in line:
                         self.vismet_failed = True
 
                 proc = self.process_handler(
                     [sys.executable, self.browsertime_vismet_script, "--check"],
                     processOutputLine=_vismet_line_handler,
                     env=env,