Bug 1653659 - Part 4: Turn on Wasm sandboxing for hunspell draft
authorDeian Stefan <deian@cs.ucsd.edu>
Wed, 12 May 2021 06:06:18 +0000
changeset 3755391 49a0b75f549ad12d27bc8d8bd9733c690d2d74fa
parent 3755390 59854b7b39fc5ab5d5f8287a530e3a82e4f2163c
child 3755392 52566e4f0f650bf6d04f6f64944d6a66aa90c2e8
push id691528
push userreviewbot
push dateWed, 12 May 2021 06:07:59 +0000
treeherdertry@52566e4f0f65 [default view] [failures only]
bugs1653659
milestone86.0a1
Bug 1653659 - Part 4: Turn on Wasm sandboxing for hunspell Summary: Differential Revision: https://phabricator.services.mozilla.com/D94931 Depends on D114925 Test Plan: Reviewers: Subscribers: Bug #: 1653659 Differential Diff: PHID-DIFF-r565p7fsrvxoz573ojna
build/mozconfig.wasm-sandboxing
toolkit/mozapps/installer/unify.py
--- a/build/mozconfig.wasm-sandboxing
+++ b/build/mozconfig.wasm-sandboxing
@@ -1,9 +1,9 @@
 # Tell the build system about bits to build sandboxed wasm libraries.
 case "$PERFHERDER_EXTRA_OPTIONS" in
 base-toolchains*)
     # Clang versions < 8.0 don't support wasm.
     ;;
 *)
-    export WASM_SANDBOXED_LIBRARIES=graphite,ogg
+    export WASM_SANDBOXED_LIBRARIES=graphite,ogg,hunspell
     ;;
 esac
--- a/toolkit/mozapps/installer/unify.py
+++ b/toolkit/mozapps/installer/unify.py
@@ -27,16 +27,17 @@ from mozpack.unify import UnifiedBuildFi
 
 # At the moment, rlbox is not supported on aarch64, so we need to allow
 # the files to be missing on the aarch64 half of the build. This also
 # means the precomplete file doesn't match, and we want to keep the x86_64
 # version which contains the extra lines for the wasm libs.
 WASM_LIBS = (
     "Contents/MacOS/liboggwasm.dylib",
     "Contents/MacOS/libgraphitewasm.dylib",
+    "Contents/MacOS/libhunspellwasm.dylib",
 )
 
 
 class UnifiedBuildFinderWasmHack(UnifiedBuildFinder):
     def unify_file(self, path, file1, file2):
         if path in WASM_LIBS:
             # When this assert hits, it means rlbox is supported on aarch64,
             # and this override, as well as precomplete below, can be removed.