Bug 1586019 - Remove textbox .plain class support. r=bgrins
authorTim Nguyen <ntim.bugs@gmail.com>
Thu, 03 Oct 2019 16:21:42 +0000
changeset 2366670 1cfb94153f548ea78f67e65478d6df36ecbfc14b
parent 2366669 9bb8a933334ca990dfc5d914f9a95454166eb304
child 2366671 f8cec7bebba9a6c55618c3848fedbe4ef8e8041a
push id431209
push userpdahiya@mozilla.com
push dateThu, 03 Oct 2019 22:13:27 +0000
treeherdertry@c74f2276d8b2 [default view] [failures only]
reviewersbgrins
bugs1586019
milestone71.0a1
Bug 1586019 - Remove textbox .plain class support. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D48074
editor/reftests/xul/input.css
editor/reftests/xul/plain-1.xul
editor/reftests/xul/plain-ref.xul
editor/reftests/xul/reftest.list
toolkit/themes/linux/global/textbox.css
toolkit/themes/osx/global/textbox.css
toolkit/themes/windows/global/textbox.css
--- a/editor/reftests/xul/input.css
+++ b/editor/reftests/xul/input.css
@@ -29,13 +29,8 @@ html|input.empty {
 html|input.num {
   text-align: end;
 }
 
 /* .textbox-input has 1px extra padding on Linux */
 #linux html|input.num {
   padding-inline-end: 3px;
 }
-
-html|div.plainfield {
-  color: -moz-fieldtext;
-  white-space: pre;
-}
deleted file mode 100644
--- a/editor/reftests/xul/plain-1.xul
+++ /dev/null
@@ -1,12 +0,0 @@
-<?xml version="1.0"?>
-<?xml-stylesheet href="chrome://global/skin" type="text/css"?>
-
-<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
-        xmlns:html="http://www.w3.org/1999/xhtml"
-        title="Textbox tests">
-
-  <script type="text/javascript" src="platform.js"/>
-
-  <textbox value=" test" class="plain"/>
-      
-</window>
deleted file mode 100644
--- a/editor/reftests/xul/plain-ref.xul
+++ /dev/null
@@ -1,13 +0,0 @@
-<?xml version="1.0"?>
-<?xml-stylesheet href="chrome://global/skin" type="text/css"?>
-<?xml-stylesheet href="resource://reftest/input.css" type="text/css"?>
-
-<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
-        xmlns:html="http://www.w3.org/1999/xhtml"
-        title="Textbox tests">
-
-  <script type="text/javascript" src="platform.js"/>
-
-  <html:div class="plainfield"> test</html:div>
-      
-</window>
--- a/editor/reftests/xul/reftest.list
+++ b/editor/reftests/xul/reftest.list
@@ -1,13 +1,12 @@
 fails-if(Android) skip-if(winWidget) == chrome://reftest/content/editor/reftests/xul/empty-1.xul chrome://reftest/content/editor/reftests/xul/empty-ref.xul # Windows: bug 1239170
 != chrome://reftest/content/editor/reftests/xul/empty-2.xul chrome://reftest/content/editor/reftests/xul/empty-ref.xul
 fails-if(Android) skip-if(winWidget) == chrome://reftest/content/editor/reftests/xul/emptytextbox-1.xul chrome://reftest/content/editor/reftests/xul/emptytextbox-ref.xul # Windows: bug 1239170
 fails-if(Android) skip-if(winWidget) == chrome://reftest/content/editor/reftests/xul/emptytextbox-2.xul chrome://reftest/content/editor/reftests/xul/emptytextbox-ref.xul # Windows: bug 1239170
 != chrome://reftest/content/editor/reftests/xul/emptytextbox-4.xul chrome://reftest/content/editor/reftests/xul/emptytextbox-ref.xul
 fails-if(Android) skip-if(winWidget) == chrome://reftest/content/editor/reftests/xul/passwd-1.xul chrome://reftest/content/editor/reftests/xul/passwd-ref.xul # Windows: bug 1239170
 fails-if(Android) skip-if(winWidget) == chrome://reftest/content/editor/reftests/xul/passwd-2.xul chrome://reftest/content/editor/reftests/xul/passwd-ref.xul # Windows: bug 1239170
 != chrome://reftest/content/editor/reftests/xul/passwd-3.xul chrome://reftest/content/editor/reftests/xul/passwd-ref.xul
-fails-if(Android) == chrome://reftest/content/editor/reftests/xul/plain-1.xul chrome://reftest/content/editor/reftests/xul/plain-ref.xul # bug 783658
 fails-if(Android) skip-if(winWidget) == chrome://reftest/content/editor/reftests/xul/textbox-1.xul chrome://reftest/content/editor/reftests/xul/textbox-ref.xul # Windows: bug 1239170
 != chrome://reftest/content/editor/reftests/xul/textbox-disabled.xul chrome://reftest/content/editor/reftests/xul/textbox-ref.xul
 # Read-only textboxes look like normal textboxes in windows Vista/7 default theme
 fails-if(windowsDefaultTheme&&/^Windows\x20NT\x20(6\.[012]|10\.0)/.test(http.oscpu)) skip-if(winWidget) != chrome://reftest/content/editor/reftests/xul/textbox-readonly.xul chrome://reftest/content/editor/reftests/xul/textbox-ref.xul # Windows: bug 1239170
--- a/toolkit/themes/linux/global/textbox.css
+++ b/toolkit/themes/linux/global/textbox.css
@@ -52,30 +52,16 @@ search-textbox[readonly="true"] {
 
 textbox[disabled="true"],
 search-textbox[disabled="true"] {
   cursor: default;
   background-color: -moz-Dialog;
   color: GrayText;
 }
 
-/* ::::: plain textbox ::::: */
-
-textbox.plain {
-  -moz-appearance: none !important;
-  background-color: transparent;
-  padding: 0px !important;
-  margin: 0px !important;
-  border: none !important;
-}
-
-textbox.plain html|*.textbox-input {
-  padding: 0px !important;
-}
-
 /* ::::: search textbox ::::: */
 
 search-textbox:not([searchbutton]) > .textbox-search-sign {
   list-style-image: url(chrome://global/skin/icons/search-textbox.svg);
   margin-inline-end: 5px;
 }
 
 .textbox-search-icon[searchbutton] {
--- a/toolkit/themes/osx/global/textbox.css
+++ b/toolkit/themes/osx/global/textbox.css
@@ -44,28 +44,16 @@ search-textbox[readonly="true"] {
 
 textbox[disabled="true"],
 search-textbox[disabled="true"] {
   cursor: default;
   background-color: -moz-Dialog;
   color: GrayText;
 }
 
-textbox.plain {
-  -moz-appearance: none !important;
-  background-color: transparent;
-  padding: 0px !important;
-  margin: 0px !important;
-  border: none !important;
-}
-
-textbox.plain html|*.textbox-input {
-  padding: 0px !important;
-}
-
 /* ::::: search box ::::: */
 
 search-textbox {
   -moz-appearance: searchfield;
   padding: 1px;
   font-size: 12px;
 }
 
--- a/toolkit/themes/windows/global/textbox.css
+++ b/toolkit/themes/windows/global/textbox.css
@@ -58,30 +58,16 @@ search-textbox[readonly="true"] {
 
 textbox[disabled="true"],
 search-textbox[disabled="true"] {
   cursor: default;
   background-color: -moz-Dialog;
   color: GrayText;
 }
 
-/* ::::: plain textbox ::::: */
-
-textbox.plain {
-  -moz-appearance: none !important;
-  background-color: transparent;
-  padding: 0px !important;
-  margin: 0px !important;
-  border: none !important;
-}
-
-textbox.plain html|*.textbox-input {
-  padding: 0px !important;
-}
-
 /* ::::: search textbox ::::: */
 
 search-textbox:not([searchbutton]) > .textbox-search-sign {
   list-style-image: url(chrome://global/skin/icons/search-textbox.svg);
   margin-inline-end: 5px;
 }
 
 .textbox-search-icon[searchbutton] {