Bug 1667456, fix pageproxystate handling in the url bar, r=johannh a=RyanVM FIREFOX_78_10_0esr_BUILD1 FIREFOX_78_10_0esr_RELEASE
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 01 Mar 2021 14:48:20 +0000
changeset 3667598 0dac34b853c6879d421456128afa3c4a5a4e86ff
parent 3667597 417b2c469f81be1dfb02397d2e4e39e59c307e2e
child 3667599 03e4ab915fc0e1c614b5ad614e6d449dccb99a94
push id683120
push userryanvm@gmail.com
push dateMon, 19 Apr 2021 16:37:58 +0000
treeherdertry@681366c51506 [default view] [failures only]
reviewersjohannh, RyanVM
bugs1667456
milestone78.10.0
Bug 1667456, fix pageproxystate handling in the url bar, r=johannh a=RyanVM
browser/base/content/browser-siteIdentity.js
--- a/browser/base/content/browser-siteIdentity.js
+++ b/browser/base/content/browser-siteIdentity.js
@@ -817,26 +817,16 @@ var gIdentityHandler = {
   /**
    * Updates the identity block user interface with the data from this object.
    */
   refreshIdentityBlock() {
     if (!this._identityBox) {
       return;
     }
 
-    // If this condition is true, the URL bar will have an "invalid"
-    // pageproxystate, which will hide the security indicators. Thus, we can
-    // safely avoid updating the security UI.
-    //
-    // This will also filter out intermediate about:blank loads to avoid
-    // flickering the identity block and doing unnecessary work.
-    if (this._hasInvalidPageProxyState()) {
-      return;
-    }
-
     this._refreshIdentityIcons();
 
     this._refreshPermissionIcons();
 
     // Hide the shield icon if it is a chrome page.
     gProtectionsHandler._trackingProtectionIconContainer.classList.toggle(
       "chromeUI",
       this._isSecureInternalUI