Bug 1551696 - Add edit icon. r=MattN draft
authorpulselistener
Sat, 18 May 2019 06:43:52 +0000
changeset 2008530 0374feb1c8fec21e7bc44e68549b7508db224b94
parent 2008529 a8b34a6778190d334e53d63596e56828dcdd91d8
child 2008531 ce3efbc4d54f4fd4b66522c61d8d36d8d8cf7b87
push id363921
push userreviewbot
push dateSat, 18 May 2019 06:44:53 +0000
treeherdertry@feb98ece6f65 [default view] [failures only]
reviewersMattN
bugs1551696
milestone68.0a1
Bug 1551696 - Add edit icon. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D31288 Differential Diff: PHID-DIFF-6k62dqltp4pc3uiymha3
browser/components/aboutlogins/content/components/login-item.css
browser/components/aboutlogins/content/icons/edit.svg
browser/components/aboutlogins/jar.mn
--- a/browser/components/aboutlogins/content/components/login-item.css
+++ b/browser/components/aboutlogins/content/components/login-item.css
@@ -19,27 +19,38 @@
 }
 
 .title {
   margin-top: 0;
   margin-bottom: 0;
   flex: auto;
 }
 
-.delete-button {
-  background-image: url("chrome://browser/content/aboutlogins/icons/delete.svg");
+.delete-button,
+.edit-button {
   background-repeat: no-repeat;
   background-position: 8px;
-  padding-inline-start: 30px; /* 8px on each side, and 14px for icon width */
   -moz-context-properties: fill;
   fill: currentColor;
+  min-width: auto;
+}
+
+.delete-button:dir(rtl),
+.edit-button:dir(rtl) {
+  background-position: right 8px center;
 }
 
-.delete-button:dir(rtl) {
-  background-position: right 8px center;
+.delete-button {
+  background-image: url("chrome://browser/content/aboutlogins/icons/delete.svg");
+  padding-inline-start: 30px; /* 8px on each side, and 14px for icon width */
+}
+
+.edit-button {
+  background-image: url("chrome://browser/content/aboutlogins/icons/edit.svg");
+  padding-inline-start: 32px; /* 8px on each side, and 16px for icon width */
 }
 
 .detail-row {
   display: flex;
   margin-bottom: 20px;
 }
 
 .detail-row > label {
new file mode 100644
--- /dev/null
+++ b/browser/components/aboutlogins/content/icons/edit.svg
@@ -0,0 +1,6 @@
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16" fill="context-fill">
+  <path d="M14.354,2.353 L13.646,1.646 C12.8634135,0.869077203 11.6005865,0.869077203 10.818,1.646 L10.439,2.025 C10.243809,2.22024993 10.243809,2.53675007 10.439,2.732 L13.268,5.561 C13.4632499,5.75619097 13.7797501,5.75619097 13.975,5.561 L14.354,5.182 C15.1310392,4.39907156 15.1310392,3.13592844 14.354,2.353 L14.354,2.353 Z M9.732,3.439 C9.53675007,3.24380903 9.22024993,3.24380903 9.025,3.439 L3.246,9.218 C3.04609788,9.4202372 2.89195626,9.66304436 2.794,9.93 L1.038,14.32 C0.978937968,14.4730418 0.998703668,14.64532 1.09089211,14.7810086 C1.18308054,14.9166972 1.33596355,14.998534 1.5,15 C1.56446593,14.9999016 1.62830455,14.9873376 1.688,14.963 L6.07,13.211 C6.33884461,13.1135406 6.58319198,12.9586052 6.786,12.757 L12.565,6.979 C12.760191,6.78375007 12.760191,6.46724993 12.565,6.272 L9.732,3.439 Z M5.161,12.5 L2.612,13.52 C2.57485383,13.5348687 2.53242052,13.5261642 2.50412814,13.4978719 C2.47583577,13.4695795 2.46713127,13.4271462 2.482,13.39 L3.5,10.831 C3.51340062,10.80154 3.54023032,10.780387 3.5720041,10.7742308 C3.60377787,10.7680746 3.63656633,10.7776766 3.66,10.8 L5.2,12.335 C5.22422581,12.3595088 5.23412532,12.3947644 5.22619838,12.4283014 C5.21827143,12.4618385 5.1936351,12.488931 5.161,12.5 L5.161,12.5 Z"/>
+</svg>
--- a/browser/components/aboutlogins/jar.mn
+++ b/browser/components/aboutlogins/jar.mn
@@ -10,11 +10,12 @@ browser.jar:
   content/browser/aboutlogins/components/login-list.css        (content/components/login-list.css)
   content/browser/aboutlogins/components/login-list.js         (content/components/login-list.js)
   content/browser/aboutlogins/components/login-list-item.css   (content/components/login-list-item.css)
   content/browser/aboutlogins/components/login-list-item.js    (content/components/login-list-item.js)
   content/browser/aboutlogins/components/modal-input.css       (content/components/modal-input.css)
   content/browser/aboutlogins/components/modal-input.js        (content/components/modal-input.js)
   content/browser/aboutlogins/components/reflected-fluent-element.js  (content/components/reflected-fluent-element.js)
   content/browser/aboutlogins/icons/delete.svg  (content/icons/delete.svg)
+  content/browser/aboutlogins/icons/edit.svg    (content/icons/edit.svg)
   content/browser/aboutlogins/aboutLogins.css   (content/aboutLogins.css)
   content/browser/aboutlogins/aboutLogins.js    (content/aboutLogins.js)
   content/browser/aboutlogins/aboutLogins.html  (content/aboutLogins.html)