searching for reviewer(snorp)
8da116322bed91f8239cc718a1057006474a0c82: Bug 1556556 - Use initial-scale=1 in clickToReload.html. r=snorp draft
Botond Ballo <botond@mozilla.com> - Fri, 29 Nov 2019 18:43:36 -0500 - rev 2613138
Push 480885 by bballo@mozilla.com at Tue, 28 Jan 2020 12:39:44 +0000
Bug 1556556 - Use initial-scale=1 in clickToReload.html. r=snorp This ensures that CSS coordinates (which is what the synthesizeTap test case passes to GeckoSessionTestRule.synthesizeTap()) are equal to Screen coordinates (which is what that function expects). An alternative approach would be to query the resolution and convert from CSS to Screen coordinates, either in the test case or inside synthesizeTap().
5c1cbb5434277963d33680d61fe64c28987135cb: Bug 1597793 - Use setTabActive in GVE. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 07:27:19 +0000 - rev 2611803
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Use setTabActive in GVE. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D60943
1aecf00f2b3b24e4080d05c1b41e0924ca9d543f: Bug 1597793 - Don't return a tabId for non-tab windows. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 07:27:17 +0000 - rev 2611802
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Don't return a tabId for non-tab windows. r=snorp If the window is a popup there is no WebExtension tab object present. Differential Revision: https://phabricator.services.mozilla.com/D60942
bb84c78d3f3b002456c8f972ac1d5cadad79ae6c: Bug 1597793 - Track tab activation in GeckoViewTab. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 07:27:14 +0000 - rev 2611801
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Track tab activation in GeckoViewTab. r=snorp This avoids initialization issues with the previous approach. Differential Revision: https://phabricator.services.mozilla.com/D60941
01769e564085e48c1f882e0333cff94cdf801170: Bug 1597793 - Support tabs.onActivated in GeckoView r=snorp,agi
Christoph Walcher <christoph-wa@gmx.de> - Sat, 25 Jan 2020 07:27:12 +0000 - rev 2611800
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Support tabs.onActivated in GeckoView r=snorp,agi Differential Revision: https://phabricator.services.mozilla.com/D60041
371b23a6a66559c958155b02ad4cf03a8231e6f6: Bug 1597793 - Check if a window is not a popup in ext-utils's onLocationChange. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 07:27:10 +0000 - rev 2611799
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Check if a window is not a popup in ext-utils's onLocationChange. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D60986
d8132aa16234043252741d8c356665460cddf591: Bug 1597793 - Use setTabActive in GVE. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 02:17:08 +0000 - rev 2611797
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Use setTabActive in GVE. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D60943
79aaf28b5ceaf5375c6dfc429e1002a6b582394c: Bug 1597793 - Don't return a tabId for non-tab windows. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 02:17:06 +0000 - rev 2611796
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Don't return a tabId for non-tab windows. r=snorp If the window is a popup there is no WebExtension tab object present. Differential Revision: https://phabricator.services.mozilla.com/D60942
4de3746c478ebf64a986f7c9ed8b9f91d0718953: Bug 1597793 - Track tab activation in GeckoViewTab. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 02:17:04 +0000 - rev 2611795
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Track tab activation in GeckoViewTab. r=snorp This avoids initialization issues with the previous approach. Differential Revision: https://phabricator.services.mozilla.com/D60941
0e9c04f18e3cd886a228c367f1b11d559fd8bc11: Bug 1597793 - Support tabs.onActivated in GeckoView r=snorp,agi
Christoph Walcher <christoph-wa@gmx.de> - Sat, 25 Jan 2020 04:13:30 +0000 - rev 2611794
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Support tabs.onActivated in GeckoView r=snorp,agi Differential Revision: https://phabricator.services.mozilla.com/D60041
b830ae752c939716001c79a614132f2a991ec1d6: Bug 1597793 - Check if a window is not a popup in ext-utils's onLocationChange. r=snorp
Agi Sferro <agi@sferro.dev> - Sat, 25 Jan 2020 02:16:56 +0000 - rev 2611793
Push 480531 by reviewbot at Sat, 25 Jan 2020 21:39:13 +0000
Bug 1597793 - Check if a window is not a popup in ext-utils's onLocationChange. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D60986
0d25ba0ac108e8751b9335cf0f824884b4887e84: Bug 1610974 - Drop colorValue in LookAndFeelInt. r=geckoview-reviewers,snorp
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 24 Jan 2020 15:01:48 +0000 - rev 2611623
Push 480479 by hikezoe.birchill@mozilla.com at Sat, 25 Jan 2020 10:22:31 +0000
Bug 1610974 - Drop colorValue in LookAndFeelInt. r=geckoview-reviewers,snorp It should have been dropped in bug 1606503, I did foget it. Differential Revision: https://phabricator.services.mozilla.com/D60776
970c96636f40564a2968e285258c72e5e962a93b: Bug 1601660 - Part 1: Make GeckoView to get the content blocking log in the parent process. r=geckoview-reviewers,Ehsan,snorp
Tim Huang <tihuang@mozilla.com> - Fri, 24 Jan 2020 11:06:39 +0000 - rev 2611145
Push 480341 by reviewbot at Fri, 24 Jan 2020 21:53:08 +0000
Bug 1601660 - Part 1: Make GeckoView to get the content blocking log in the parent process. r=geckoview-reviewers,Ehsan,snorp This patch is doing two things. 1. Make GeckoView directly gets the ContentBlockingLog in the parent process when it gets the bundle event 'ContentBlocking:RequestLog'. It will get the top-level browsingContext and get the log from the WindowGlobal of this browsingContext. 2. Remove the GeckoViewContentBlockingChild. The child module of ContentBlocking is no longer needed since it serves nothing after we move the functionality of getting log to the parent process. Differential Revision: https://phabricator.services.mozilla.com/D57464
282778a58d0b3b676d77a56235259514e074d959: Bug 1610353 - [3.0] Add Login Storage onLoginUsed test. r=geckoview-reviewers,snorp
Eugen Sawin <esawin@mozilla.com> - Thu, 23 Jan 2020 20:03:57 +0000 - rev 2609207
Push 479775 by wptsync@mozilla.com at Thu, 23 Jan 2020 20:33:47 +0000
Bug 1610353 - [3.0] Add Login Storage onLoginUsed test. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D60442
d45cb482844208fa91c7f821bfe398c2def06592: Bug 1610353 - [1.0] Add LoginStorage onLoginUsed API. r=snorp,geckoview-reviewers,MattN,agi
Eugen Sawin <esawin@mozilla.com> - Thu, 23 Jan 2020 20:03:40 +0000 - rev 2609205
Push 479775 by wptsync@mozilla.com at Thu, 23 Jan 2020 20:33:47 +0000
Bug 1610353 - [1.0] Add LoginStorage onLoginUsed API. r=snorp,geckoview-reviewers,MattN,agi Differential Revision: https://phabricator.services.mozilla.com/D60440
370ab9fe968d4cb394cca2c40be819a165ae2a59: Bug 1595834: Make GeckoProcessManager interface e10s-multi aware; r=snorp
Aaron Klotz <aklotz@mozilla.com> - Thu, 23 Jan 2020 18:12:51 +0000 - rev 2609021
Push 479711 by bpeers@mozilla.com at Thu, 23 Jan 2020 18:39:31 +0000
Bug 1595834: Make GeckoProcessManager interface e10s-multi aware; r=snorp This patch does not change any of the *internals* of process management in `GeckoProcessManager`, however it upgrades the interface in preparation for such changes. * We add a java equivalent to Gecko's `GeckoProcessType` enumeration; * We add the `GeckoProcessType.Selector` class which will be used for identifying running content processes; * We update `ContentParent::MarkAsDead` to use `GeckoProcessType.Selector` for indicating which process should be marked. Differential Revision: https://phabricator.services.mozilla.com/D60539
d6cb8a4946eeb776cb10dcdaf87cff0a9728d605: Bug 1595834: Make GeckoProcessManager interface e10s-multi aware; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Thu, 23 Jan 2020 18:13:16 +0000 - rev 2608964
Push 479696 by reviewbot at Thu, 23 Jan 2020 18:13:37 +0000
Bug 1595834: Make GeckoProcessManager interface e10s-multi aware; r=snorp Summary: This patch does not change any of the *internals* of process management in `GeckoProcessManager`, however it upgrades the interface in preparation for such changes. * We add a java equivalent to Gecko's `GeckoProcessType` enumeration; * We add the `GeckoProcessType.Selector` class which will be used for identifying running content processes; * We update `ContentParent::MarkAsDead` to use `GeckoProcessType.Selector` for indicating which process should be marked. Differential Revision: https://phabricator.services.mozilla.com/D60539 Test Plan: Reviewers: snorp Subscribers: Bug #: 1595834 Differential Diff: PHID-DIFF-i4t5nu6hmfn7vpmeh3ky
f4130854e6e5846351671a81791f854f0076d3c6: Bug 1533406 - Add tests for gecko view private mode. r=snorp
Brendan Dahl <bdahl@mozilla.com> - Wed, 22 Jan 2020 22:07:08 +0000 - rev 2608084
Push 479439 by reviewbot at Thu, 23 Jan 2020 10:09:28 +0000
Bug 1533406 - Add tests for gecko view private mode. r=snorp 1) Adds a basic functionality test. 2) Adds a tests to ensure storage is shared across private mode sessions. Differential Revision: https://phabricator.services.mozilla.com/D60546
5c18e356921476180dce0402bcc0708df20c88aa: Bug 1533406 - Add tests for gecko view private mode. r=snorp draft
Brendan Dahl <bdahl@mozilla.com> - Wed, 22 Jan 2020 22:08:02 +0000 - rev 2607576
Push 479236 by reviewbot at Wed, 22 Jan 2020 22:08:28 +0000
Bug 1533406 - Add tests for gecko view private mode. r=snorp 1) Adds a basic functionality test. 2) Adds a tests to ensure storage is shared across private mode sessions. Differential Revision: https://phabricator.services.mozilla.com/D60546 Differential Diff: PHID-DIFF-kcntoxwzt4ao7kpiams7
1b67df42fdf241d90676a57966a76f1ceeb3a5ac: Bug 1533406 - Add tests for gecko view private mode. r=snorp
Brendan Dahl <bdahl@mozilla.com> - Tue, 21 Jan 2020 21:50:35 +0000 - rev 2607452
Push 479190 by bclary@mozilla.com at Wed, 22 Jan 2020 21:08:53 +0000
Bug 1533406 - Add tests for gecko view private mode. r=snorp 1) Adds a basic functionality test. 2) Adds a tests to ensure storage is shared across private mode sessions. Depends on D60330 Differential Revision: https://phabricator.services.mozilla.com/D60546
03aa8dbc3ae91532a1f81b2d5286cef5764e032b: Bug 1610914 - Handle theme_icons in Icon. r=snorp
Agi Sferro <agi@sferro.dev> - Wed, 22 Jan 2020 19:19:48 +0000 - rev 2607431
Push 479190 by bclary@mozilla.com at Wed, 22 Jan 2020 21:08:53 +0000
Bug 1610914 - Handle theme_icons in Icon. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D60726
06001b30f6cdd142d99aab4a6bd6f084f1fbbc5f: Bug 1601660 - Part 1: Make GeckoView to get the content blocking log in the parent process. r=geckoview-reviewers,Ehsan,snorp
Tim Huang <tihuang@mozilla.com> - Mon, 06 Jan 2020 20:00:16 +0000 - rev 2607104
Push 479117 by bclary@mozilla.com at Wed, 22 Jan 2020 19:06:34 +0000
Bug 1601660 - Part 1: Make GeckoView to get the content blocking log in the parent process. r=geckoview-reviewers,Ehsan,snorp This patch is doing two things. 1. Make GeckoView directly gets the ContentBlockingLog in the parent process when it gets the bundle event 'ContentBlocking:RequestLog'. It will get the top-level browsingContext and get the log from the WindowGlobal of this browsingContext. 2. Remove the GeckoViewContentBlockingChild. The child module of ContentBlocking is no longer needed since it serves nothing after we move the functionality of getting log to the parent process. Differential Revision: https://phabricator.services.mozilla.com/D57464
fc73b18a8145b2301d6ca11783a14fecbc251138: Bug 1533406 - Add tests for gecko view private mode. r=snorp draft
Brendan Dahl <bdahl@mozilla.com> - Tue, 21 Jan 2020 10:26:46 -0800 - rev 2606975
Push 479075 by bdahl@mozilla.com at Wed, 22 Jan 2020 17:40:28 +0000
Bug 1533406 - Add tests for gecko view private mode. r=snorp 1) Adds a basic functionality test. 2) Adds a tests to ensure storage is shared across private mode sessions. Differential Revision: https://phabricator.services.mozilla.com/D60546
5ed6fc2b4997c9e55f8a16c0ba6d50d4b37b3907: Bug 1579440 - Set browser.tabs.remote.autostart to true for geckoview. r=snorp
Agi Sferro <agi@sferro.dev> - Tue, 21 Jan 2020 23:46:32 +0000 - rev 2606249
Push 478842 by reviewbot at Wed, 22 Jan 2020 10:10:44 +0000
Bug 1579440 - Set browser.tabs.remote.autostart to true for geckoview. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D60332
9c1226ccebef9c6fac3170d3e2eb3446227bc8d2: Bug 1533406 - Add tests for gecko view private mode. r=snorp draft
Brendan Dahl <bdahl@mozilla.com> - Tue, 21 Jan 2020 18:31:13 +0000 - rev 2604790
Push 478470 by reviewbot at Tue, 21 Jan 2020 18:31:35 +0000
Bug 1533406 - Add tests for gecko view private mode. r=snorp 1) Adds a basic functionality test. 2) Adds a tests to ensure storage is shared across private mode sessions. Differential Diff: PHID-DIFF-tovw74dhkqh7rhaigy42
8289373a3e549d1de72d344a3174e8eb6f4b01e9: Bug 1533406 - Add tests for gecko view private mode. r=snorp draft
Brendan Dahl <bdahl@mozilla.com> - Tue, 21 Jan 2020 10:26:46 -0800 - rev 2604785
Push 478468 by bdahl@mozilla.com at Tue, 21 Jan 2020 18:30:04 +0000
Bug 1533406 - Add tests for gecko view private mode. r=snorp 1) Adds a basic functionality test. 2) Adds a tests to ensure storage is shared across private mode sessions. Differential Revision: https://phabricator.services.mozilla.com/D60546
bc4306cbba027a79a8bf6613faeba15465197441: Bug 1595834: Make GeckoProcessManager interface e10s-multi aware; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Tue, 21 Jan 2020 17:59:47 +0000 - rev 2604549
Push 478430 by reviewbot at Tue, 21 Jan 2020 18:00:21 +0000
Bug 1595834: Make GeckoProcessManager interface e10s-multi aware; r=snorp Summary: This patch does not change any of the *internals* of process management in `GeckoProcessManager`, however it upgrades the interface in preparation for such changes. * We add a java equivalent to Gecko's `GeckoProcessType` enumeration; * We add the `GeckoProcessType.Selector` class which will be used for identifying running content processes; * We update `ContentParent::MarkAsDead` to use `GeckoProcessType.Selector` for indicating which process should be marked. Test Plan: Reviewers: snorp Subscribers: Bug #: 1595834 Differential Diff: PHID-DIFF-7twalsjz2o4pyl67sbqu
4287ea98207d8c830c876c64de5d475fdbafbc14: Bug 1574307 - Part 4. Notify GV of viewport-fit. r=geckoview-reviewers,snorp
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 20 Jan 2020 08:42:05 +0000 - rev 2603992
Push 478282 by mbrodesser@mozilla.com at Tue, 21 Jan 2020 13:49:33 +0000
Bug 1574307 - Part 4. Notify GV of viewport-fit. r=geckoview-reviewers,snorp `viewport-fit` is hint that browser application can use cutout area. So we should expose it to GeckoView application to set `layoutInDisplayCutoutMode`. When meta element is found or changed, `ContentDelegate.onMetaviewportFitChange` is called. Even if nothing, it will be called after DOMContentLoaded is fired. Depends on D57398 Differential Revision: https://phabricator.services.mozilla.com/D55610
7f57347511768e0b8d07b041b19f355c400fbbb9: Bug 1556556 - Use initial-scale=1 in clickToReload.html. r=snorp draft
Botond Ballo <botond@mozilla.com> - Fri, 29 Nov 2019 18:43:36 -0500 - rev 2603095
Push 478063 by bballo@mozilla.com at Mon, 20 Jan 2020 21:26:58 +0000
Bug 1556556 - Use initial-scale=1 in clickToReload.html. r=snorp This ensures that CSS coordinates (which is what the synthesizeTap test case passes to GeckoSessionTestRule.synthesizeTap()) are equal to Screen coordinates (which is what that function expects). An alternative approach would be to query the resolution and convert from CSS to Screen coordinates, either in the test case or inside synthesizeTap().
36e0d5bd26a40a3f684e62f7ea5bbaef476527a2: Bug 1556556 - Use initial-scale=1 in clickToReload.html. r=snorp draft
Botond Ballo <botond@mozilla.com> - Fri, 29 Nov 2019 18:43:36 -0500 - rev 2602915
Push 478016 by bballo@mozilla.com at Mon, 20 Jan 2020 18:07:17 +0000
Bug 1556556 - Use initial-scale=1 in clickToReload.html. r=snorp This ensures that CSS coordinates (which is what the synthesizeTap test case passes to GeckoSessionTestRule.synthesizeTap()) are equal to Screen coordinates (which is what that function expects). An alternative approach would be to query the resolution and convert from CSS to Screen coordinates, either in the test case or inside synthesizeTap().
47aae290cc07a7c24a7e38bbc8e603aa66f14663: Bug 1298921 - [marionette] Don't restrict Marionette:Quit to Firefox only. r=ato,snorp,agi, a=RyanVM
Nick Alexander <nalexander@mozilla.com> - Wed, 11 Sep 2019 15:07:28 +0000 - rev 2602485
Push 477896 by sgiesecke@mozilla.com at Mon, 20 Jan 2020 13:13:10 +0000
Bug 1298921 - [marionette] Don't restrict Marionette:Quit to Firefox only. r=ato,snorp,agi, a=RyanVM Formerly this assertion for Firefox was added because it didn't work for Fennec, and other mobile apps. Meanwhile we shouldn't have this hard restriction anymore, given that no exception is thrown by the code when running with GeckoView based app, and also the Thunderbird support would benefit from it. As we know this method doesn't quit the GeckoView app, and geckodriver itself has to ensure to gracefully/force stop the process on Android. Differential Revision: https://phabricator.services.mozilla.com/D39811
bf89cb3c01429f0be745287bdb43be60fa7446f7: Bug 1600663: Hook GV process management into ContentParent; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:46:33 +0000 - rev 2602052
Push 477813 by mbrodesser@mozilla.com at Mon, 20 Jan 2020 10:43:56 +0000
Bug 1600663: Hook GV process management into ContentParent; r=geckoview-reviewers,snorp We need to propagate `ContentParent::MarkAsDead` up to the Android java layer so that it has a view of the state of content processes that is consistent with the view of Gecko's content process management. Differential Revision: https://phabricator.services.mozilla.com/D58564
6fcef35f1cf4f16c4fbf1e716c6e0c42f7817591: Bug 1594820: Part 4 - Modify GeckoThread.preload to directly call into the process manager; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:45:55 +0000 - rev 2602050
Push 477813 by mbrodesser@mozilla.com at Mon, 20 Jan 2020 10:43:56 +0000
Bug 1594820: Part 4 - Modify GeckoThread.preload to directly call into the process manager; r=geckoview-reviewers,snorp Now that everything in `GeckoProcessManager` runs on the XPCOM launcher thread, `GeckoThread` should just call `GeckoProcessManager.preload()` directly. Differential Revision: https://phabricator.services.mozilla.com/D57840
de9a496180f996d2497114c42d015c0ca423579f: Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:44:45 +0000 - rev 2602048
Push 477813 by mbrodesser@mozilla.com at Mon, 20 Jan 2020 10:43:56 +0000
Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp This patch adds a `Dispatcher` implementation that allows us to create `GeckoResult`s that will dispatch to the XPCOM launcher thread. Differential Revision: https://phabricator.services.mozilla.com/D57838
2f6df46484dcaad8567a6ad1da998c55a2e64b9a: Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:44:07 +0000 - rev 2602047
Push 477813 by mbrodesser@mozilla.com at Mon, 20 Jan 2020 10:43:56 +0000
Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp Since `XPCOMEventTarget` uses JNI, this patch makes it possible for consumers to retrieve and invoke methods on one without needing to worry about whether JNI is actually up yet. To achieve this, we create the `IXPCOMEventTarget` interface, and observe that both of its methods can be handled by a proxy if JNI is not ready: * Calls to `dispatch` may be enqueued until JNI is up; * Observe that, when JNI is not up yet, the result of `isOnCurrentThread` can never be `true`. Once JNI is up and the event targets have been resolved, the proxies are replaced with the real, concrete `XPCOMEventTarget`s and are no longer used for the remainder of the Gecko instance's lifetime. Differential Revision: https://phabricator.services.mozilla.com/D57837
3eee56e1c3d8583ee081233fec7191def99821c9: Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:47:20 +0000 - rev 2601924
Push 477771 by reviewbot at Mon, 20 Jan 2020 07:47:54 +0000
Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp Summary: This patch adds a `Dispatcher` implementation that allows us to create `GeckoResult`s that will dispatch to the XPCOM launcher thread. Differential Revision: https://phabricator.services.mozilla.com/D57838 Depends on D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-efireo74h2ifldymv4bu
17313375a386c9cbf647b2e75bc3ae183b146fc7: Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:47:17 +0000 - rev 2601923
Push 477771 by reviewbot at Mon, 20 Jan 2020 07:47:54 +0000
Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp Summary: Since `XPCOMEventTarget` uses JNI, this patch makes it possible for consumers to retrieve and invoke methods on one without needing to worry about whether JNI is actually up yet. To achieve this, we create the `IXPCOMEventTarget` interface, and observe that both of its methods can be handled by a proxy if JNI is not ready: * Calls to `dispatch` may be enqueued until JNI is up; * Observe that, when JNI is not up yet, the result of `isOnCurrentThread` can never be `true`. Once JNI is up and the event targets have been resolved, the proxies are replaced with the real, concrete `XPCOMEventTarget`s and are no longer used for the remainder of the Gecko instance's lifetime. Differential Revision: https://phabricator.services.mozilla.com/D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-vwgwzgnzkaxxxsgfgb5r
525540020e7061fb13f19670b93bc510c4e7ba18: Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:46:30 +0000 - rev 2601919
Push 477770 by reviewbot at Mon, 20 Jan 2020 07:46:59 +0000
Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp Summary: This patch adds a `Dispatcher` implementation that allows us to create `GeckoResult`s that will dispatch to the XPCOM launcher thread. Differential Revision: https://phabricator.services.mozilla.com/D57838 Depends on D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-efireo74h2ifldymv4bu
dd1cec34016cefcfbadcecb3887f34faa2638246: Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:46:27 +0000 - rev 2601918
Push 477770 by reviewbot at Mon, 20 Jan 2020 07:46:59 +0000
Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp Summary: Since `XPCOMEventTarget` uses JNI, this patch makes it possible for consumers to retrieve and invoke methods on one without needing to worry about whether JNI is actually up yet. To achieve this, we create the `IXPCOMEventTarget` interface, and observe that both of its methods can be handled by a proxy if JNI is not ready: * Calls to `dispatch` may be enqueued until JNI is up; * Observe that, when JNI is not up yet, the result of `isOnCurrentThread` can never be `true`. Once JNI is up and the event targets have been resolved, the proxies are replaced with the real, concrete `XPCOMEventTarget`s and are no longer used for the remainder of the Gecko instance's lifetime. Differential Revision: https://phabricator.services.mozilla.com/D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-vwgwzgnzkaxxxsgfgb5r
7fd2fc7cfadb69b688f3618b943a708a69bbe959: Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:45:54 +0000 - rev 2601915
Push 477769 by reviewbot at Mon, 20 Jan 2020 07:46:18 +0000
Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp Summary: This patch adds a `Dispatcher` implementation that allows us to create `GeckoResult`s that will dispatch to the XPCOM launcher thread. Differential Revision: https://phabricator.services.mozilla.com/D57838 Depends on D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-efireo74h2ifldymv4bu
c69188ee93055a431f5302b01144027092527b1f: Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:45:51 +0000 - rev 2601914
Push 477769 by reviewbot at Mon, 20 Jan 2020 07:46:18 +0000
Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp Summary: Since `XPCOMEventTarget` uses JNI, this patch makes it possible for consumers to retrieve and invoke methods on one without needing to worry about whether JNI is actually up yet. To achieve this, we create the `IXPCOMEventTarget` interface, and observe that both of its methods can be handled by a proxy if JNI is not ready: * Calls to `dispatch` may be enqueued until JNI is up; * Observe that, when JNI is not up yet, the result of `isOnCurrentThread` can never be `true`. Once JNI is up and the event targets have been resolved, the proxies are replaced with the real, concrete `XPCOMEventTarget`s and are no longer used for the remainder of the Gecko instance's lifetime. Differential Revision: https://phabricator.services.mozilla.com/D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-vwgwzgnzkaxxxsgfgb5r
0b2b38b19685284ce0e374f365affcb2d2ff17b9: Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:45:16 +0000 - rev 2601912
Push 477768 by reviewbot at Mon, 20 Jan 2020 07:45:39 +0000
Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp Summary: This patch adds a `Dispatcher` implementation that allows us to create `GeckoResult`s that will dispatch to the XPCOM launcher thread. Differential Revision: https://phabricator.services.mozilla.com/D57838 Depends on D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-efireo74h2ifldymv4bu
07ec4805f0460cdb3cd004b868ba6381cb3cfecf: Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:45:13 +0000 - rev 2601911
Push 477768 by reviewbot at Mon, 20 Jan 2020 07:45:39 +0000
Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp Summary: Since `XPCOMEventTarget` uses JNI, this patch makes it possible for consumers to retrieve and invoke methods on one without needing to worry about whether JNI is actually up yet. To achieve this, we create the `IXPCOMEventTarget` interface, and observe that both of its methods can be handled by a proxy if JNI is not ready: * Calls to `dispatch` may be enqueued until JNI is up; * Observe that, when JNI is not up yet, the result of `isOnCurrentThread` can never be `true`. Once JNI is up and the event targets have been resolved, the proxies are replaced with the real, concrete `XPCOMEventTarget`s and are no longer used for the remainder of the Gecko instance's lifetime. Differential Revision: https://phabricator.services.mozilla.com/D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-vwgwzgnzkaxxxsgfgb5r
cc5771ff1f7f6e5569adc237afcd4a26d56778d5: Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Mon, 20 Jan 2020 07:44:37 +0000 - rev 2601909
Push 477767 by reviewbot at Mon, 20 Jan 2020 07:44:55 +0000
Bug 1594820: Part 1 - Modify XPCOMEventTarget to accept method calls before JNI is ready; r=snorp Summary: Since `XPCOMEventTarget` uses JNI, this patch makes it possible for consumers to retrieve and invoke methods on one without needing to worry about whether JNI is actually up yet. To achieve this, we create the `IXPCOMEventTarget` interface, and observe that both of its methods can be handled by a proxy if JNI is not ready: * Calls to `dispatch` may be enqueued until JNI is up; * Observe that, when JNI is not up yet, the result of `isOnCurrentThread` can never be `true`. Once JNI is up and the event targets have been resolved, the proxies are replaced with the real, concrete `XPCOMEventTarget`s and are no longer used for the remainder of the Gecko instance's lifetime. Differential Revision: https://phabricator.services.mozilla.com/D57837 Test Plan: Reviewers: snorp Subscribers: Bug #: 1594820 Differential Diff: PHID-DIFF-vwgwzgnzkaxxxsgfgb5r
5261ea86fa26aa2d6870526edab036bff2b46d0a: Bug 1579440 - Set browser.tabs.remote.autostart to true everywhere. r=snorp
Agi Sferro <agi@sferro.dev> - Sun, 19 Jan 2020 16:55:20 +0000 - rev 2601800
Push 477730 by hkirschner@mozilla.com at Sun, 19 Jan 2020 23:23:19 +0000
Bug 1579440 - Set browser.tabs.remote.autostart to true everywhere. r=snorp Now that Fennec is gone we can finally do this. Differential Revision: https://phabricator.services.mozilla.com/D60332
f4cc06c140903d7781f0a8431e40137a40dbd937: Bug 1534287 - Catch exception when sending a11y event when platform a11y is disabled. r=geckoview-reviewers,snorp
Eitan Isaacson <eitan@monotonous.org> - Fri, 10 Jan 2020 15:35:06 +0000 - rev 2600294
Push 477325 by reviewbot at Fri, 17 Jan 2020 16:20:43 +0000
Bug 1534287 - Catch exception when sending a11y event when platform a11y is disabled. r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D59419
984ecd9e9bc8187f7b1820a8c2baacda02db7376: Bug 1608296 - Attach DelegateController to WebExtension created by ExtensionStore. r=snorp
Agi Sferro <agi@sferro.dev> - Thu, 16 Jan 2020 18:25:47 +0000 - rev 2598975
Push 476934 by egao@mozilla.com at Thu, 16 Jan 2020 19:31:54 +0000
Bug 1608296 - Attach DelegateController to WebExtension created by ExtensionStore. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D60061
b1eaffa34ee77ccb8abe7354d3cb5446488f2583: Bug 1587552 - Update GeckoView content blocking exception API and add better support for removing exceptions. r=esawin,Ehsan,geckoview-reviewers,snorp
Dylan Roeh <droeh@mozilla.com> - Thu, 16 Jan 2020 18:09:45 +0000 - rev 2598974
Push 476934 by egao@mozilla.com at Thu, 16 Jan 2020 19:31:54 +0000
Bug 1587552 - Update GeckoView content blocking exception API and add better support for removing exceptions. r=esawin,Ehsan,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D58828
ed897659fea2e590f1373cc391cb5eb86bdef860: Bug 1588150 - Add Install AddOn to GVE. r=snorp
Agi Sferro <agi@sferro.dev> - Wed, 15 Jan 2020 22:03:13 +0000 - rev 2598104
Push 476684 by reviewbot at Thu, 16 Jan 2020 09:49:06 +0000
Bug 1588150 - Add Install AddOn to GVE. r=snorp This patch adds a new menu item to GVE that allows users to install an arbitrary extension given it's URL (usually from a.m.o, but we don't really verify that). Differential Revision: https://phabricator.services.mozilla.com/D59973
910e0bca28511183e2e9a88eff55900d5ed6879a: Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp draft
Aaron Klotz <aklotz@mozilla.com> - Wed, 20 Nov 2019 14:50:06 -0700 - rev 2598028
Push 476658 by aklotz@mozilla.com at Thu, 16 Jan 2020 07:43:26 +0000
Bug 1594820: Part 2 - Make GeckoResult compatible with XPCOMEventTarget; r=snorp This patch adds a `Dispatcher` implementation that allows us to create `GeckoResult`s that will dispatch to the XPCOM launcher thread. Differential Revision: https://phabricator.services.mozilla.com/D57838