searching for reviewer(njn)
1e2f7d1f21eace810cb18b8337919e57e4b4ea17: Bug 1358214 - gettid wrapper is not provided by any libc in linux r=njn
Jory A. Pratt <anarchy@gentoo.org> - Fri, 14 Jun 2019 07:16:31 +0000 - rev 2106172
Push 379805 by reviewbot at Thu, 20 Jun 2019 11:16:04 +0000
Bug 1358214 - gettid wrapper is not provided by any libc in linux r=njn BIONIC is only platform that actually supports gettid. Easiest solution is to check for linux and disable for BIONIC platform. This includes the change requested by Gerald to keep the two profilers sync'd. Differential Revision: https://phabricator.services.mozilla.com/D34919
8567a308ac7a8e2087903aedd1d92032c9c7eb60: Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 19 Jun 2019 05:58:15 +0000 - rev 2104022
Push 379286 by reviewbot at Wed, 19 Jun 2019 08:56:15 +0000
Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn Both for symmetry with other string APIs, and also to prevent footguns (since I debugged for a while a typo where I wrote nsGkAtoms::empty rather than nsGkAtoms::_empty). We could use null here, but that will not be possible in the future when I use the rust representation of more grid data structures (at least without increasing memory usage). So I think I'll keep using ::_empty as a signaling value for "no grid identifier". Differential Revision: https://phabricator.services.mozilla.com/D35120
cbb787b3832d401d363ab3cd5aac89e0889d4558: Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn draft
pulselistener - Wed, 19 Jun 2019 06:05:39 +0000 - rev 2103984
Push 379272 by reviewbot at Wed, 19 Jun 2019 06:06:08 +0000
Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn Both for symmetry with other string APIs, and also to prevent footguns (since I debugged for a while a typo where I wrote nsGkAtoms::empty rather than nsGkAtoms::_empty). We could use null here, but that will not be possible in the future when I use the rust representation of more grid data structures (at least without increasing memory usage). So I think I'll keep using ::_empty as a signaling value for "no grid identifier". Differential Revision: https://phabricator.services.mozilla.com/D35120 Differential Diff: PHID-DIFF-53j7pskqmwwxwmiq3tdz
5f0f3775605323d865539da3a7c4cb3d1fd36ff2: Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 18 Jun 2019 11:26:25 +0000 - rev 2103890
Push 379244 by bclary@mozilla.com at Wed, 19 Jun 2019 02:44:21 +0000
Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r=njn We can avoid testing if we are running in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D35125
535345f0ff55c22fe512ea1cae5e7cb29378601d: Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 18 Jun 2019 11:25:21 +0000 - rev 2103889
Push 379244 by bclary@mozilla.com at Wed, 19 Jun 2019 02:44:21 +0000
Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r=njn This allows for the compiler to inline the code where appropriate. Differential Revision: https://phabricator.services.mozilla.com/D35124
0e9ad048cf87798281ef056c25f3926599ffdf88: Bug 1559675 - P1. Initialize StaticPrefs early in non-parent process. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 19 Jun 2019 00:22:33 +0000 - rev 2103887
Push 379244 by bclary@mozilla.com at Wed, 19 Jun 2019 02:44:21 +0000
Bug 1559675 - P1. Initialize StaticPrefs early in non-parent process. r=njn We can initialize the StaticPrefs as soon as the SharedMap object is created outside the parent process. Additionally when resetting the preferences to their default values, we no longer modify the `Once` StaticPrefs as they are immutable, only the underlying preference. Differential Revision: https://phabricator.services.mozilla.com/D35263
38061e4147ef46571d9001bd2c5d5dd1b2dbd5e3: Bug 1559675 - P1. Initialize StaticPrefs early in non-parent process. r?njn! draft
pulselistener - Tue, 18 Jun 2019 20:13:39 +0000 - rev 2103224
Push 379052 by reviewbot at Tue, 18 Jun 2019 20:14:38 +0000
Bug 1559675 - P1. Initialize StaticPrefs early in non-parent process. r?njn! We can initialize the StaticPrefs as soon as the SharedMap object is created outside the parent process. Additionally when resetting the preferences to their default values, we no longer modify the `Once` StaticPrefs as they are immutable, only the underlying preference. Differential Diff: PHID-DIFF-25up5gpytqex7ptytgs6
dbef82c588acbeab145e9bd26629cbec88f39ff2: Bug 1559675 - P1. Initialize StaticPrefs early in non-parent process. r?njn! draft
pulselistener - Tue, 18 Jun 2019 20:11:11 +0000 - rev 2103222
Push 379051 by reviewbot at Tue, 18 Jun 2019 20:12:00 +0000
Bug 1559675 - P1. Initialize StaticPrefs early in non-parent process. r?njn! We can initialize the StaticPrefs as soon as the SharedMap object is created outside the parent process. Additionally when resetting the preferences to their default values, we no longer modify the `Once` StaticPrefs as they are immutable, only the underlying preference. Differential Diff: PHID-DIFF-25up5gpytqex7ptytgs6
f39a035e504b8bbf3687e37a7b525e3c59a112d4: Bug 1559675 - P2. Initialize StaticPrefs early in non-parent process. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 16 Jun 2019 23:26:49 +1000 - rev 2102706
Push 378896 by jyavenard@mozilla.com at Tue, 18 Jun 2019 06:43:12 +0000
Bug 1559675 - P2. Initialize StaticPrefs early in non-parent process. r?njn! We can initialize the StaticPrefs as soon as the SharedMap object is created outside the parent process. This also allows to simplify the code flow as we only ever need to call StaticPrefs::InitAll() in the parent process. Additionally when resetting the preferences to their default values, we no longer modify the `Once` StaticPrefs as they are immutable, only the underlying preference.
9c625a1332b10412e7657739a7373b77147af40c: Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 15 Jun 2019 03:15:47 +0200 - rev 2102520
Push 378835 by emilio@crisal.io at Mon, 17 Jun 2019 16:54:21 +0000
Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn Both for symmetry with other string APIs, and also to prevent footguns (since I debugged for a while a typo where I wrote nsGkAtoms::empty rather than nsGkAtoms::_empty). We could use null here, but that will not be possible in the future when I use the rust representation of more grid data structures (at least without increasing memory usage). So I think I'll keep using ::_empty as a signaling value for "no grid identifier". Differential Revision: https://phabricator.services.mozilla.com/D35120
d4f8e348a5b081b4d5ed4aa9a8625044ae111ed4: Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 15 Jun 2019 03:15:47 +0200 - rev 2101907
Push 378758 by emilio@crisal.io at Mon, 17 Jun 2019 05:52:00 +0000
Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn Both for symmetry with other string APIs, and also to prevent footguns (since I debugged for a while a typo where I wrote nsGkAtoms::empty rather than nsGkAtoms::_empty). We could use null here, but that will not be possible in the future when I use the rust representation of more grid data structures (at least without increasing memory usage). So I think I'll keep using ::_empty as a signaling value for "no grid identifier". Differential Revision: https://phabricator.services.mozilla.com/D35120
4919d8c16ca48c93b325d4fb157a86dd63dde53a: Bug 1559675 - P2. Initialize StaticPrefs early in non-parent process. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 16 Jun 2019 23:26:49 +1000 - rev 2101700
Push 378715 by jyavenard@mozilla.com at Sun, 16 Jun 2019 20:21:25 +0000
Bug 1559675 - P2. Initialize StaticPrefs early in non-parent process. r?njn! We can initialize the StaticPrefs as soon as the SharedMap object is created outside the parent process.
a58d0107d98ebd861b6b666bf2cfa803b0e8db01: Bug 1559675 - P2. Initialize StaticPrefs early in non-parent process. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 16 Jun 2019 23:26:49 +1000 - rev 2101661
Push 378700 by jyavenard@mozilla.com at Sun, 16 Jun 2019 13:29:17 +0000
Bug 1559675 - P2. Initialize StaticPrefs early in non-parent process. r?njn! We can initialize the StaticPrefs as soon as the SharedMap object is created outside the parent process.
06c087a62b65b6c70de9d1338a193c1cbd7086d2: Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 15 Jun 2019 16:26:19 +1000 - rev 2101659
Push 378700 by jyavenard@mozilla.com at Sun, 16 Jun 2019 13:29:17 +0000
Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! We can avoid testing if we are running in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D35125
8f7420f97c86663eb3266f42811f12dc01926927: Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 15 Jun 2019 15:26:27 +1000 - rev 2101658
Push 378700 by jyavenard@mozilla.com at Sun, 16 Jun 2019 13:29:17 +0000
Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! This allows for the compiler to inline the code where appropriate. Differential Revision: https://phabricator.services.mozilla.com/D35124
f5062e83c4217f7b36a5e48fe59a07e444a41afa: Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! draft
pulselistener - Sat, 15 Jun 2019 09:39:20 +0000 - rev 2065989
Push 378587 by reviewbot at Sat, 15 Jun 2019 09:39:44 +0000
Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! We can avoid testing if we are running in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D35125 Differential Diff: PHID-DIFF-uo326xkgfafr6pagt6t5
218b0536eb41e8687585538ff7dc81871a27285e: Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! draft
pulselistener - Sat, 15 Jun 2019 09:39:16 +0000 - rev 2065988
Push 378587 by reviewbot at Sat, 15 Jun 2019 09:39:44 +0000
Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! This allows for the compiler to inline the code where appropriate. Differential Diff: PHID-DIFF-7ztyu6yddllhc2cqx32g
cb82836cd16c570422c961754708b01dcffeb3cb: Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 15 Jun 2019 16:26:19 +1000 - rev 2065984
Push 378585 by jyavenard@mozilla.com at Sat, 15 Jun 2019 09:12:12 +0000
Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! We can avoid testing if we are running in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D35125
431308e5a40d590aca6b00cd799646124d22d327: Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! draft
pulselistener - Sat, 15 Jun 2019 06:30:18 +0000 - rev 2065619
Push 378576 by reviewbot at Sat, 15 Jun 2019 06:30:44 +0000
Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! We can avoid testing if we are running in the parent process. Differential Diff: PHID-DIFF-nmczan64nr342ypqsder
9491d5ae405ea42f30383c3df48a056df4fb701c: Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! draft
pulselistener - Sat, 15 Jun 2019 06:30:15 +0000 - rev 2065618
Push 378576 by reviewbot at Sat, 15 Jun 2019 06:30:44 +0000
Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! This allows for the compiler to inline the code where appropriate. Differential Diff: PHID-DIFF-7ztyu6yddllhc2cqx32g
d2209ba944e93ed1f88421d6727a4f6d9b457761: Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 15 Jun 2019 16:26:19 +1000 - rev 2065616
Push 378575 by jyavenard@mozilla.com at Sat, 15 Jun 2019 06:29:47 +0000
Bug 1559563 - P2. Small optimization of `Once` StaticPrefs accessor. r?njn! We can avoid testing if we are running in the parent process. Differential Revision: https://phabricator.services.mozilla.com/D35125
a64742647de6410d5cd06e120cfc2704575e2cda: Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 15 Jun 2019 15:26:27 +1000 - rev 2065615
Push 378575 by jyavenard@mozilla.com at Sat, 15 Jun 2019 06:29:47 +0000
Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! This allows for the compiler to inline the code where appropriate. Differential Revision: https://phabricator.services.mozilla.com/D35124
cbaf7a1bd1a88db23cb7cfe7e8d976de60fee0ea: Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! draft
pulselistener - Sat, 15 Jun 2019 06:28:50 +0000 - rev 2065613
Push 378574 by reviewbot at Sat, 15 Jun 2019 06:29:21 +0000
Bug 1559563 - P1. Move StaticPrefs accessor back to header file. r?njn! This allows for the compiler to inline the code where appropriate. Differential Diff: PHID-DIFF-7ztyu6yddllhc2cqx32g
689fbb4aeddd82f942baf68c9fe1e2909fa2648f: Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 15 Jun 2019 03:15:47 +0200 - rev 2065578
Push 378560 by emilio@crisal.io at Sat, 15 Jun 2019 03:47:41 +0000
Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn Both for symmetry with other string APIs, and also to prevent footguns (since I debugged for a while a typo where I wrote nsGkAtoms::empty rather than nsGkAtoms::_empty). We could use null here, but that will not be possible in the future when I use the rust representation of more grid data structures (at least without increasing memory usage). So I think I'll keep using ::_empty as a signaling value for "no grid identifier". Differential Revision: https://phabricator.services.mozilla.com/D35120
00af9e90d65bebf7262d76b1d1d6e0c11ffe3bd2: Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 15 Jun 2019 03:15:47 +0200 - rev 2065531
Push 378540 by emilio@crisal.io at Sat, 15 Jun 2019 01:51:35 +0000
Bug 1559546 - Introduce nsAtom::IsEmpty. r=njn Both for symmetry with other string APIs, and also to prevent footguns (since I debugged for a while a typo where I wrote nsGkAtoms::empty rather than nsGkAtoms::_empty). We could use null here, but that will not be possible in the future when I use the rust representation of more grid data structures (at least without increasing memory usage). So I think I'll keep using ::_empty as a signaling value for "no grid identifier". Differential Revision: https://phabricator.services.mozilla.com/D35120
98ed23b12852ef0cda1fd040e9e9e4e511874862: Bug 1556131 - P3. Enable check on automation. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Jun 2019 08:26:45 +0000 - rev 2063679
Push 378045 by reviewbot at Fri, 14 Jun 2019 09:59:16 +0000
Bug 1556131 - P3. Enable check on automation. r=njn Differential Revision: https://phabricator.services.mozilla.com/D34475
d97d53e8c4f95ead053e32c5a9e8bb31c8d42ed8: Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Jun 2019 08:15:15 +0000 - rev 2063678
Push 378045 by reviewbot at Fri, 14 Jun 2019 09:59:16 +0000
Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r=njn For now we limit the scope to cleaning-up the `Once` StaticPrefs only as there's much less of them. Duplicated definions, and in particular different default values between all.js and StaticPrefList.h triggers the anti-footgun assertions introduced by bug 1556131 due to how preferences are first initialised. 1- Initialise using StaticPrefList.h defaults. 2- Initialise using all.js defaults. Should `Once` StaticPrefs be set, when we reset the StaticPrefs, step 1 will cause to assert as the values are different. Differential Revision: https://phabricator.services.mozilla.com/D34980
41a91796def7250fabae16e0f53032d6fed41440: Bug 1556131 - P3. Enable check on automation. r=njn draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 20:12:52 +0000 - rev 2063620
Push 378026 by jyavenard@mozilla.com at Fri, 14 Jun 2019 09:29:43 +0000
Bug 1556131 - P3. Enable check on automation. r=njn Differential Revision: https://phabricator.services.mozilla.com/D34475
b3fa2369829298cffb33f7e466dafbf5b5a189ba: Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Jun 2019 12:32:44 +1000 - rev 2063618
Push 378026 by jyavenard@mozilla.com at Fri, 14 Jun 2019 09:29:43 +0000
Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! For now we limit the scope to cleaning-up the `Once` StaticPrefs only as there's much less of them. Duplicated definions, and in particular different default values between all.js and StaticPrefList.h triggers the anti-footgun assertions introduced by bug 1556131 due to how preferences are first initialised. 1- Initialise using StaticPrefList.h defaults. 2- Initialise using all.js defaults. Should `Once` StaticPrefs be set, when we reset the StaticPrefs, step 1 will cause to assert as the values are different. Differential Revision: https://phabricator.services.mozilla.com/D34980
18d6aaf2a5ff642b223adac38f8afdbd4046e3ca: Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! draft
pulselistener - Fri, 14 Jun 2019 08:16:57 +0000 - rev 2063568
Push 378001 by reviewbot at Fri, 14 Jun 2019 08:17:43 +0000
Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! For now we limit the scope to cleaning-up the `Once` StaticPrefs only as there's much less of them. Duplicated definions, and in particular different default values between all.js and StaticPrefList.h triggers the anti-footgun assertions introduced by bug 1556131 due to how preferences are first initialised. 1- Initialise using StaticPrefList.h defaults. 2- Initialise using all.js defaults. Should `Once` StaticPrefs be set, when we reset the StaticPrefs, step 1 will cause to assert as the values are different. Differential Revision: https://phabricator.services.mozilla.com/D34980 Differential Diff: PHID-DIFF-lc2tu4tsrgi7bdb4lqkk
9f934685bbb0047db23882c8275a2bbbd27ba049: Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Jun 2019 12:32:44 +1000 - rev 2063476
Push 377963 by jyavenard@mozilla.com at Fri, 14 Jun 2019 06:47:03 +0000
Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! For now we limit the scope to cleaning-up the `Once` StaticPrefs only as there's much less of them. Duplicated definions, and in particular different default values between all.js and StaticPrefList.h triggers the anti-footgun assertions introduced by bug 1556131 due to how preferences are first initialised. 1- Initialise using StaticPrefList.h defaults. 2- Initialise using all.js defaults. Should `Once` StaticPrefs be set, when we reset the StaticPrefs, step 1 will cause to assert as the values are different. Differential Revision: https://phabricator.services.mozilla.com/D34980
4b5f7f855b057c14f88b5eb9dd39bbf0b5d0b03f: Bug 1556131 - P3. Enable check on automation. r=njn draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 20:12:52 +0000 - rev 2063475
Push 377963 by jyavenard@mozilla.com at Fri, 14 Jun 2019 06:47:03 +0000
Bug 1556131 - P3. Enable check on automation. r=njn Differential Revision: https://phabricator.services.mozilla.com/D34475
08a92d2b683417039c073eda8c893cd99a059920: Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Jun 2019 12:32:44 +1000 - rev 2063462
Push 377958 by jyavenard@mozilla.com at Fri, 14 Jun 2019 06:33:11 +0000
Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! For now we limit the scope to cleaning-up the `Once` StaticPrefs only as there's much less of them. Duplicated definions, and in particular different default values between all.js and StaticPrefList.h triggers the anti-footgun assertions introduced by bug 1556131 due to how preferences are first initialised. 1- Initialise using StaticPrefList.h defaults. 2- Initialise using all.js defaults. Should `Once` StaticPrefs be set, when we reset the StaticPrefs, step 1 will cause to assert as the values are different. Differential Revision: https://phabricator.services.mozilla.com/D34980
5b033f6c8e1937e3b65406f77fae68b423ab2a33: Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 14 Jun 2019 12:32:44 +1000 - rev 2063296
Push 377898 by jyavenard@mozilla.com at Fri, 14 Jun 2019 02:36:18 +0000
Bug 1558358 - Remove duplicated preference definitions for `Once` StaticPrefs. r?njn! For now we limit the scope to cleaning-up the `Once` StaticPrefs only as there's much less of them. Duplicated definions, and in particular different default values between all.js and StaticPrefList.h triggers the anti-footgun assertions introduced by bug 1556131 due to how preferences are first initialised. 1- Initialise using StaticPrefList.h defaults. 2- Initialise using all.js defaults. Should `Once` StaticPrefs be set, when we reset the StaticPrefs, step 1 will cause to assert as the values are different. Differential Revision: https://phabricator.services.mozilla.com/D34980
fa63e2f59ed0c9ef14055ab87880f4d5d3de2935: Bug 1556131 - P3. Enable check on automation. r=njn draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 20:12:52 +0000 - rev 2061359
Push 377414 by jyavenard@mozilla.com at Thu, 13 Jun 2019 11:35:56 +0000
Bug 1556131 - P3. Enable check on automation. r=njn Differential Revision: https://phabricator.services.mozilla.com/D34475
66746137158d54ca77d7028a947b577f8deab555: Bug 1556131 - P2. Enable check on automation. r=njn draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 20:12:52 +0000 - rev 2061294
Push 377391 by jyavenard@mozilla.com at Thu, 13 Jun 2019 10:48:30 +0000
Bug 1556131 - P2. Enable check on automation. r=njn Depends on D34107 Differential Revision: https://phabricator.services.mozilla.com/D34475
e1f13b42b7a54910a845baf5a1ff7f9b4825cfb2: Bug 1556131 - P2. Enable check on automation. r=njn draft
pulselistener - Thu, 13 Jun 2019 10:31:28 +0000 - rev 2061256
Push 377378 by reviewbot at Thu, 13 Jun 2019 10:32:18 +0000
Bug 1556131 - P2. Enable check on automation. r=njn Depends on D34107 Differential Revision: https://phabricator.services.mozilla.com/D34475 Differential Diff: PHID-DIFF-5uqxy5se3qacmfema3ee
54580ad69ccb9c36654bbe593e9e3d54da6392dc: Bug 1556131 - P1. Potentially assert that a `Once` StaticPref stays in sync with underlying preference. r=njn draft
pulselistener - Thu, 13 Jun 2019 10:31:20 +0000 - rev 2061255
Push 377378 by reviewbot at Thu, 13 Jun 2019 10:32:18 +0000
Bug 1556131 - P1. Potentially assert that a `Once` StaticPref stays in sync with underlying preference. r=njn When testing, the Preference behing a `Once` StaticPrefs should never get modified as this indicate that this StaticPrefs should have a `Live` policy instead. This is placed behind the preferences.check.once.policy which will get enabled during automated testing. Differential Revision: https://phabricator.services.mozilla.com/D34107 Differential Diff: PHID-DIFF-z6bvhc4v64f3szjey76e
5eb157b876119f667629e24657ed58bfaeb40a4f: Bug 1556131 - P2. Enable check on automation. r=njn draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 20:12:52 +0000 - rev 2061216
Push 377371 by jyavenard@mozilla.com at Thu, 13 Jun 2019 10:16:44 +0000
Bug 1556131 - P2. Enable check on automation. r=njn Depends on D34107 Differential Revision: https://phabricator.services.mozilla.com/D34475
f2fa56561f9e80dc2c2b8561e8b12baa650d326e: Bug 1556131 - P2. Enable check on automation. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 12 Jun 2019 21:49:50 +0000 - rev 2060640
Push 377199 by reviewbot at Thu, 13 Jun 2019 02:41:35 +0000
Bug 1556131 - P2. Enable check on automation. r=njn Depends on D34107 Differential Revision: https://phabricator.services.mozilla.com/D34475
867d2bcfbba76a42cabdf72ee8e07ff0988ebb75: Bug 1556131 - P2. Enable check on automation. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 16:46:10 +1000 - rev 2059877
Push 377018 by jyavenard@mozilla.com at Wed, 12 Jun 2019 22:05:49 +0000
Bug 1556131 - P2. Enable check on automation. r?njn! Differential Revision: https://phabricator.services.mozilla.com/D34475
5cfc07de1f4e880cf22045f6efe9f9cca0d0ba6e: Bug 1557789 - Expose subcategory information in the profile JSON. r?njn draft
pulselistener - Wed, 12 Jun 2019 18:24:41 +0000 - rev 2059366
Push 376853 by reviewbot at Wed, 12 Jun 2019 18:25:11 +0000
Bug 1557789 - Expose subcategory information in the profile JSON. r?njn This was reviewed before in bug 1500692. Differential Revision: https://phabricator.services.mozilla.com/D11338 Differential Diff: PHID-DIFF-curiwrb2scjauy5bqfum
64ba1e5a243b9e08305c26cb15c58ad5f949119d: Bug 1557630 - P1. Simplify Preferences' getters code. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 12 Jun 2019 08:01:08 +0000 - rev 2058540
Push 376617 by igoldan@mozilla.com at Wed, 12 Jun 2019 12:22:56 +0000
Bug 1557630 - P1. Simplify Preferences' getters code. r=njn We use templates where appropriate instead. Differential Revision: https://phabricator.services.mozilla.com/D34272
adda952213094effa2c19aa770b6262bed2a1543: Bug 1556131 - P3. Enable check on automation. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 16:46:10 +1000 - rev 2058480
Push 376593 by jyavenard@mozilla.com at Wed, 12 Jun 2019 11:43:50 +0000
Bug 1556131 - P3. Enable check on automation. r?njn! Differential Revision: https://phabricator.services.mozilla.com/D34475
fcb6300b7f269477ba60cf295e67aafbd837c0af: Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 08 Jun 2019 19:32:08 +1000 - rev 2058478
Push 376593 by jyavenard@mozilla.com at Wed, 12 Jun 2019 11:43:50 +0000
Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! We use templates where appropriate instead. Differential Revision: https://phabricator.services.mozilla.com/D34272
e172e8d64bc34343904a2cd8c56ca43f26093dbd: Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 08 Jun 2019 19:32:08 +1000 - rev 2058106
Push 376476 by jyavenard@mozilla.com at Wed, 12 Jun 2019 08:03:41 +0000
Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! We use templates where appropriate instead. Differential Revision: https://phabricator.services.mozilla.com/D34272
20e0d2fdaec68035a0fcb3515cb1dee41c366a0f: Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! draft
pulselistener - Wed, 12 Jun 2019 08:01:38 +0000 - rev 2058104
Push 376475 by reviewbot at Wed, 12 Jun 2019 08:02:05 +0000
Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! We use templates where appropriate instead. Differential Revision: https://phabricator.services.mozilla.com/D34272 Differential Diff: PHID-DIFF-iqazale53csmx7ro2jz5
897b2192cbd6c37d422e37acb807d8d63d99e316: Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 08 Jun 2019 19:32:08 +1000 - rev 2058074
Push 376462 by jyavenard@mozilla.com at Wed, 12 Jun 2019 07:32:50 +0000
Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! We use templates where appropriate instead. Differential Revision: https://phabricator.services.mozilla.com/D34272
c0931707a4917c63aabe0d66049b7661c0844421: Bug 1556131 - P2. Enable check on automation. r=njn
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 11 Jun 2019 20:12:52 +0000 - rev 2057980
Push 376441 by opoprus@mozilla.com at Wed, 12 Jun 2019 06:04:59 +0000
Bug 1556131 - P2. Enable check on automation. r=njn Depends on D34107 Differential Revision: https://phabricator.services.mozilla.com/D34475
129a23e69faa4173cf6ea31189ea1d98932b3bfe: Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Sat, 08 Jun 2019 19:32:08 +1000 - rev 2057677
Push 376348 by jyavenard@mozilla.com at Wed, 12 Jun 2019 00:48:49 +0000
Bug 1557630 - P1. Simplify Preferences' getters code. r?njn! We use templates where appropriate instead. Differential Revision: https://phabricator.services.mozilla.com/D34272