searching for reviewer(nika)
49028e60c0d4ce7540dcd33da1a0dc47f1e68aa5: Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika
Bas Schouten <bschouten@mozilla.com> - Tue, 21 May 2019 21:01:31 +0200 - rev 2065540
Push 378544 by bhackett@mozilla.com at Sat, 15 Jun 2019 02:13:12 +0000
Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika Differential Revision: https://phabricator.services.mozilla.com/D32039
9c0ec08273195b246f7d71647bc3c147e2830c2b: Bug 1532795: Implement basic SpecialPowers.spawn as a replacement for ContentTask. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Thu, 13 Jun 2019 21:26:18 -0700 - rev 2064873
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1532795: Implement basic SpecialPowers.spawn as a replacement for ContentTask. r=nika With out-of-process iframes, we'll need similar functionality to the ContentTask helpers that can be used in any process, with any type of frame. Using ContentTask directly in unprivileged contexts will, I think, be a bit too combersome given how often it's needed, so this patch adds an API directly to SpecialPowers instead. The environment provided to the task is currently pretty basic, and doesn't provide the assertion helpers currently available to ContentTask tasks, but it can grow as we find it necessary. Differential Revision: https://phabricator.services.mozilla.com/D35058
1ec5a07e9e31b0ed17ce9e2bca191349a62f486c: Bug 1541557: Part 7 - Convert SpecialPowers to use JSWindowActors rather than framescripts. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Wed, 12 Jun 2019 10:48:29 -0700 - rev 2064872
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1541557: Part 7 - Convert SpecialPowers to use JSWindowActors rather than framescripts. r=nika Differential Revision: https://phabricator.services.mozilla.com/D35057
50430bf1fd39c098fc6436ed066b929d507fa257: Bug 1541557: Part 6 - Read scripts for loadChromeScript in child process rather than parent. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Thu, 13 Jun 2019 17:01:10 -0700 - rev 2064871
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1541557: Part 6 - Read scripts for loadChromeScript in child process rather than parent. r=nika `loadChromeScript` is often called with http: URLs pointing to mochitest resources, which need to be read synchronously before they can be executed. Unfortunately, while the API for this pretends to be synchronous, it really spins the event loop underneath. When we attempt to use it in the parent, that means that we spin the event loop and process messages from the child before the script has been executed. And since those messages often contain messages intended for the chrome script, that causes problems. When the chrome script APIs use sync messaging, this doesn't matter much, since the `loadChromeScript` call blocks the caller until the message handler in the parent returns. When it uses async messaging, though, we have no such luck, and the messages intended for the script get sent to the parent immediately. Loading the script contents in the child solves this problem, since it reliably blocks the child callers until the script contents are ready, and doesn't give them a chance to try to send messages to the script while it's still being read. Differential Revision: https://phabricator.services.mozilla.com/D35056
aa73d4fb2b0d38ef0689b3e7de0e182799997d04: Bug 1541557: Part 5 - Update callers of ChromeScript.sendSyncMessage to use sendQuery instead. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Wed, 12 Jun 2019 12:40:51 -0700 - rev 2064870
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1541557: Part 5 - Update callers of ChromeScript.sendSyncMessage to use sendQuery instead. r=nika Since JSWindowActors don't have direct access to synchronous messaging, ChromeScript callers are going to need to migrate to asynchronous messaging and queries instead. Since there's no comparable API to sendQuery for frame message managers, this patch adds a stub that uses synchronous messaging, but makes the API appear asynchronous, and migrates callers to use it instead of direct synchronous messaging. This will be replaced with a true synchronous API in the actor migration. Fortunately, most of the time, this actually leads to simpler code. The `sendQuery` API doesn't have the odd return value semantics of `sendSyncMessage`, and can usually just be used as a drop-in replacement. Many of the `sendSyncMessage` callers don't actually use the result, and can just be changed to `sendAsyncMessage`. And many of the existing async messaging users can be changed to just use `sendQuery` rather than sending messages and adding response listeners. However, the APZ code is an exception. It relies on intricate properties of the event loop, and doesn't have an easy way to slot in promise handlers, so I migrated it to using sync messaging via process message managers instead. Differential Revision: https://phabricator.services.mozilla.com/D35055
7d66746aeedd31031356a24f661c3335b31b7e63: Bug 1541557: Part 4 - Stop relying on synchronous preference getters/setters. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Thu, 13 Jun 2019 09:34:39 -0700 - rev 2064869
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1541557: Part 4 - Stop relying on synchronous preference getters/setters. r=nika The SpecialPowers set*Pref/get*Pref APIs currently use synchronous messaging to set and get preference values from the parent process. Aside from directly affecting callers of those APIs, it also affects callers of `pushPrefEnv`, which is meant to be asynchronous, but is in practice usually synchronous due to the synchronous messaging it uses. This patch updates the getPref APIs to use the in-process preference service (which most callers are expecting anyway), and also updates the callers of the setPref and pushPrefEnv APIs to await the result if they're relying on it taking effect immediately. Unfortunately, there are some corner cases in tests that appear to only work because of the quirks of the current sync messaging approach. The synchronous setPref APIs, for instance, trigger preference changes in the parent instantly, but don't update the values in the child until we've returned to the event loop and had a chance to process the notifications from the parent. The differnce in timing leads some tests to fail in strange ways, which this patch works around by just adding timeouts. There should be follow-ups for test owners to fix the flakiness. Differential Revision: https://phabricator.services.mozilla.com/D35054
40b026598bc9ab1f0616063be6cf385165333286: Bug 1541557: Part 3 - Update callers of sync SpecialPowers functions to await the return value. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Wed, 12 Jun 2019 11:41:32 -0700 - rev 2064868
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1541557: Part 3 - Update callers of sync SpecialPowers functions to await the return value. r=nika When we migrate SpecialPowers to a JSWindowActor, it will no longer be able to use synchronous IPC messaging, which means that its current synchronous APIs will have to become asynchronous. This patch doesn't change the behavior of those functions, but it does change their callers to `await` their return values rather than using them directly. This pattern will work the same whether the functions return a promise or a plain value, which simplifies the migration. Differential Revision: https://phabricator.services.mozilla.com/D35053
d9bc1278e6d9d2463d13792df011074771c59ed3: Bug 1541557: Part 2 - Stop sending uninitialized StructuredCloneData objects. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Thu, 13 Jun 2019 15:01:05 -0700 - rev 2064867
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1541557: Part 2 - Stop sending uninitialized StructuredCloneData objects. r=nika There are a couple of places where JSWindowActor currently sends uninitialized StructuredCloneData objects in places where it wants the message data to be undefined. The problem with this is that it causes an error when trying to read the data, which leads to odd behavior like `sendQuery` promises never being settled if the message handler throws, or `sendAsyncMessage` and `sendQuery` failing to decode the message if the caller doesn't pass a second argument. The errors reported for these problems also have no context, which means it's very hard for a developer to figure out the source of the problem. And, to make matters worse, the errors look the same as structured clone encoding errors, so there isn't even the clue that the error is happening on decode. This patch updates the offending code to always explicitly initialize the structured clone data with `undefined` when that's what it wants, and adds assertions to make it more obvious where the decode errors are actually happening. Differential Revision: https://phabricator.services.mozilla.com/D35052
ea7d0d0a0ec95b4d50e73cfa44672035f543af9a: Bug 1541557: Part 1 - Use correct globals for JSWindowActors not in the shared JSM global. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Wed, 12 Jun 2019 16:06:40 -0700 - rev 2064866
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1541557: Part 1 - Use correct globals for JSWindowActors not in the shared JSM global. r=nika The current JSWindowActor code assumes that all actors will be created in the shared JSM global. This has a few problems: 1) For actors in other scopes, it enters the wrong compartment before decoding messages, which leads to a compartment checker error when trying to call message handlers. That could be fixed by just wrapping the result for the caller, but that would lead to other problems. Aside from the efficiency concerns of having to deal with cross-compartment wrappers, SpecialPowers in particular would not be able to pass the resulting objects to unprivileged scopes, since only SpecialPowers compartments have permissive CCWs enabled. 2) It also leads to the prototype objects for the actor instances being created in the shared JSM scope, even when the actors themselves are defined in other compartments. Again, aside from CCW efficiency issues, this prevents the SpecialPowers instances from being accessed by the unprivileged scopes that they're exposed to, since the prototype objects live in privileged scopes which don't have permissive CCWs enabled. This patch changes child actors to always create their objects in the global of their constructors. The parent objects are still created in the shared JSM global, but they now wrap values for the appropriate compartment before trying to call message handlers. Differential Revision: https://phabricator.services.mozilla.com/D35051
89e4040c3d90961572c7adae436bf9906d079a2b: Bug 1558298: Part 10 - Stop loading MozillaLogger.js from SpecialPowers. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Tue, 11 Jun 2019 11:37:52 -0700 - rev 2064862
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1558298: Part 10 - Stop loading MozillaLogger.js from SpecialPowers. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34599
93aa2e90532ab19e564bfc730fb0ee5e73dd9ac1: Bug 1558298: Part 9 - Make MozillaLogger.js less insane. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Tue, 11 Jun 2019 11:28:47 -0700 - rev 2064861
Push 378350 by maglione.k@gmail.com at Fri, 14 Jun 2019 19:11:44 +0000
Bug 1558298: Part 9 - Make MozillaLogger.js less insane. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34598
ba9fd871977dddb2eaccef9e62f10bf6e3704293: Bug 1554680 - Use WindowGlobalParent::IsInitialDocument instead of WindowGlobalParent::DocumentPrincipal to figure out if the page is the initial about:blank r=nika draft
pulselistener - Fri, 14 Jun 2019 09:54:47 +0000 - rev 2063653
Push 378044 by reviewbot at Fri, 14 Jun 2019 09:55:45 +0000
Bug 1554680 - Use WindowGlobalParent::IsInitialDocument instead of WindowGlobalParent::DocumentPrincipal to figure out if the page is the initial about:blank r=nika For a popup, the principal will be that of the opener, so we can't use that to determine if the window is about:blank. Differential Revision: https://phabricator.services.mozilla.com/D33249 Differential Diff: PHID-DIFF-tdfhyyusuyxrn53wkwbu
3af9aa55ead0f9f510823ed983ab01a902559be0: Bug 1555036 - If there is a Cross-Origin-Opener-Policy mismatch and the SANDBOXED_AUXILIARY_NAVIGATION is set navigate to a network error r=nika draft
pulselistener - Fri, 14 Jun 2019 09:00:12 +0000 - rev 2063587
Push 378012 by reviewbot at Fri, 14 Jun 2019 09:01:05 +0000
Bug 1555036 - If there is a Cross-Origin-Opener-Policy mismatch and the SANDBOXED_AUXILIARY_NAVIGATION is set navigate to a network error r=nika Differential Revision: https://phabricator.services.mozilla.com/D34420 Differential Diff: PHID-DIFF-uzggdeusnqw4zifnktuh
a30ecde306ef98ed23aeab8b9018a70f65dcb0e1: Bug 1555287 - Make sure to detach browsing context children early. r=nika
Andreas Farre <farre@mozilla.com> - Thu, 13 Jun 2019 16:11:47 +0000 - rev 2062804
Push 377746 by reviewbot at Thu, 13 Jun 2019 21:24:18 +0000
Bug 1555287 - Make sure to detach browsing context children early. r=nika Waiting for docshells and frameloaders to destroy will leave attached browsing contexts attached too long. In case the children of a browsing contexts cannot be cached we want to detach all of them as soon as possible. Also normalizes the use of BrowsingContext::mGroup. Differential Revision: https://phabricator.services.mozilla.com/D33602
0a1d0653490a0d6dbcbe231efeb7ca2108555c87: Bug 1554244 - Tolerate multiple calls to MessageChannel::Close. r=nika
Jed Davis <jld@mozilla.com> - Thu, 13 Jun 2019 15:40:58 +0000 - rev 2062388
Push 377629 by reviewbot at Thu, 13 Jun 2019 18:24:48 +0000
Bug 1554244 - Tolerate multiple calls to MessageChannel::Close. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34804
c807d0b9d8727c30c39ed43c4faf7f61d9eecb14: Bug 1555287 - Make sure to detach browsing context children early. r=nika
Andreas Farre <farre@mozilla.com> - Wed, 12 Jun 2019 15:35:17 +0000 - rev 2061121
Push 377337 by reviewbot at Thu, 13 Jun 2019 09:16:33 +0000
Bug 1555287 - Make sure to detach browsing context children early. r=nika Waiting for docshells and frameloaders to destroy will leave attached browsing contexts attached too long. In case the children of a browsing contexts cannot be cached we want to detach all of them as soon as possible. Also normalizes the use of BrowsingContext::mGroup. Differential Revision: https://phabricator.services.mozilla.com/D33602
735636367c35ec16a95c27e0c9d298d1f88aa440: Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r=yzen,nika
James Teh <jteh@mozilla.com> - Thu, 13 Jun 2019 02:19:42 +0000 - rev 2060641
Push 377199 by reviewbot at Thu, 13 Jun 2019 02:41:35 +0000
Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r=yzen,nika Previously, BrowserBridgeChild::SendSetEmbedderAccessible was only called when an OuterDocAccessible was constructed. However, it's also possible that the BrowserBridgeChild is created *after* the OuterDocAccessible. Therefore, we must also do this when a BrowserBridgeChild is created if the OuterDocAccessible already exists. Differential Revision: https://phabricator.services.mozilla.com/D34474
b5df002db72caa3fbd70ffcbcf886c6d94cd9e12: Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r=yzen,nika
James Teh <jteh@mozilla.com> - Wed, 12 Jun 2019 14:57:40 +0000 - rev 2060621
Push 377199 by reviewbot at Thu, 13 Jun 2019 02:41:35 +0000
Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r=yzen,nika Previously, BrowserBridgeChild::SendSetEmbedderAccessible was only called when an OuterDocAccessible was constructed. However, it's also possible that the BrowserBridgeChild is created *after* the OuterDocAccessible. Therefore, we must also do this when a BrowserBridgeChild is created if the OuterDocAccessible already exists. Differential Revision: https://phabricator.services.mozilla.com/D34474
37611e89109cc07668e53208a65c16ba3587a8f5: Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika draft
pulselistener - Thu, 13 Jun 2019 02:25:00 +0000 - rev 2060534
Push 377186 by reviewbot at Thu, 13 Jun 2019 02:25:32 +0000
Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika Previously, BrowserBridgeChild::SendSetEmbedderAccessible was only called when an OuterDocAccessible was constructed. However, it's also possible that the BrowserBridgeChild is created *after* the OuterDocAccessible. Therefore, we must also do this when a BrowserBridgeChild is created if the OuterDocAccessible already exists. Differential Revision: https://phabricator.services.mozilla.com/D34474 Differential Diff: PHID-DIFF-itcgiuiyzkrlog2e2myx
73bc6c194203366cf57579b7cee3862ad3c02546: Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika draft
James Teh <jteh@mozilla.com> - Tue, 11 Jun 2019 16:10:24 +1000 - rev 2060423
Push 377152 by jteh@mozilla.com at Thu, 13 Jun 2019 01:14:44 +0000
Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika Previously, BrowserBridgeChild::SendSetEmbedderAccessible was only called when an OuterDocAccessible was constructed. However, it's also possible that the BrowserBridgeChild is created *after* the OuterDocAccessible. Therefore, we must also do this when a BrowserBridgeChild is created if the OuterDocAccessible already exists. Differential Revision: https://phabricator.services.mozilla.com/D34474
d7a2206abb261c09f30aa3b5fc05141650d1613f: Bug 1554244 - Tolerate multiple calls to MessageChannel::Close. r?nika draft
pulselistener - Thu, 13 Jun 2019 01:06:52 +0000 - rev 2060408
Push 377146 by reviewbot at Thu, 13 Jun 2019 01:07:23 +0000
Bug 1554244 - Tolerate multiple calls to MessageChannel::Close. r?nika Differential Diff: PHID-DIFF-fttoubrwavhvtx56w3qb
1da3d0464849264e35eb7e39b1eb77ca7669859f: Bug 1558298: Part 10 - Stop loading MozillaLogger.js from SpecialPowers. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Tue, 11 Jun 2019 11:37:52 -0700 - rev 2060198
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 10 - Stop loading MozillaLogger.js from SpecialPowers. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34599
cb294ecdf49c9a298be8a4872a9c63ca355300d1: Bug 1558298: Part 9 - Make MozillaLogger.js less insane. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Tue, 11 Jun 2019 11:28:47 -0700 - rev 2060197
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 9 - Make MozillaLogger.js less insane. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34598
89f94dd508fa815e6fd02d86e0e10093b376738d: Bug 1558298: Part 8 - Convert SpecialPowersObserverAPI and sub-classes to ES6 classes. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 15:42:36 -0700 - rev 2060196
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 8 - Convert SpecialPowersObserverAPI and sub-classes to ES6 classes. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34597
55672d5f040599f225da179a266c3bd17025a844: Bug 1558298: Part 7 - Convert SpecialPowersAPI and sub-classes to ES6 classes. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 15:15:37 -0700 - rev 2060195
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 7 - Convert SpecialPowersAPI and sub-classes to ES6 classes. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34596
3b512a8677d24f6d773e2266a9c2f14200b582ff: Bug 1558298: Part 6 - Remove some arrant nonsense from ChromePowers.js. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 14:57:58 -0700 - rev 2060194
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 6 - Remove some arrant nonsense from ChromePowers.js. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34595
c43dd676f569f8e5ecabb9f06371de926718a656: Bug 1558298: Part 5 - Let ChromePowers.js handle its own SpecialPowers imports. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 14:15:47 -0700 - rev 2060193
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 5 - Let ChromePowers.js handle its own SpecialPowers imports. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34594
0c94f4afe398116ef4f376649d7f8356e728d949: Bug 1558298: Part 4 - Cleanup some cruft in SpecialPowersObserver.jsm. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 14:04:27 -0700 - rev 2060192
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 4 - Cleanup some cruft in SpecialPowersObserver.jsm. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34593
b0a04e1d5cf94b324c94adcf09a66b7391af3b77: Bug 1558298: Part 3 - Always load specialpowers.js as a JSM. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 13:31:19 -0700 - rev 2060191
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 3 - Always load specialpowers.js as a JSM. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34592
d12fd699c9d288a75996e6a773c4a112f7d885cd: Bug 1558298: Part 2 - Always load specialpowersAPI.js as a JSM. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 13:12:00 -0700 - rev 2060190
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 2 - Always load specialpowersAPI.js as a JSM. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34591
4eac9d9b1d899b2770a5f7790ad6567a020efe0c: Bug 1558298: Part 1 - Move SpecialPowers wrapping code to separate module. r=nika draft
Kris Maglione <maglione.k@gmail.com> - Mon, 10 Jun 2019 12:46:43 -0700 - rev 2060189
Push 377108 by maglione.k@gmail.com at Thu, 13 Jun 2019 00:10:19 +0000
Bug 1558298: Part 1 - Move SpecialPowers wrapping code to separate module. r=nika Differential Revision: https://phabricator.services.mozilla.com/D34590
543dd6765964bb2545d895b84f156b617869b53b: Bug 1555287 - Make sure to detach browsing context children early. r=nika draft
Andreas Farre <farre@mozilla.com> - Wed, 05 Jun 2019 10:50:10 +0200 - rev 2058454
Push 376581 by afarre@mozilla.com at Wed, 12 Jun 2019 11:16:19 +0000
Bug 1555287 - Make sure to detach browsing context children early. r=nika Waiting for docshells and frameloaders to destroy will leave attached browsing contexts attached too long. In case the children of a browsing contexts cannot be cached we want to detach all of them as soon as possible. Also normalizes the use of BrowsingContext::mGroup. Differential Revision: https://phabricator.services.mozilla.com/D33602
e56150085522bc8dec94547b9c65802f39c2b167: Bug 1555287 - Make sure to detach browsing context children early. r=nika draft
Andreas Farre <farre@mozilla.com> - Wed, 05 Jun 2019 10:50:10 +0200 - rev 2058048
Push 376452 by afarre@mozilla.com at Wed, 12 Jun 2019 06:54:15 +0000
Bug 1555287 - Make sure to detach browsing context children early. r=nika Waiting for docshells and frameloaders to destroy will leave attached browsing contexts attached too long. In case the children of a browsing contexts cannot be cached we want to detach all of them as soon as possible. Also normalizes the use of BrowsingContext::mGroup. Differential Revision: https://phabricator.services.mozilla.com/D33602
d9b95f0b3eb2e6295c297bbc3934716917088c02: Bug 1557448 - Add this value for invocation callback; r=nika
John Dai <jdai@mozilla.com> - Mon, 10 Jun 2019 17:53:22 +0000 - rev 2057985
Push 376441 by opoprus@mozilla.com at Wed, 12 Jun 2019 06:04:59 +0000
Bug 1557448 - Add this value for invocation callback; r=nika Differential Revision: https://phabricator.services.mozilla.com/D34219
95ae3976557d87f875d73d62c4552d6c941a776a: Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika draft
pulselistener - Tue, 11 Jun 2019 06:18:25 +0000 - rev 2055384
Push 375699 by reviewbot at Tue, 11 Jun 2019 06:18:50 +0000
Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika Previously, BrowserBridgeChild::SendSetEmbedderAccessible was only called when an OuterDocAccessible was constructed. However, it's also possible that the BrowserBridgeChild is created *after* the OuterDocAccessible. Therefore, we must also do this when a BrowserBridgeChild is created if the OuterDocAccessible already exists. Differential Revision: https://phabricator.services.mozilla.com/D34474 Differential Diff: PHID-DIFF-72o265zq5gawmiw2btli
730eda2aff9c797896cfb763d387e73de6d8c509: Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika draft
James Teh <jteh@mozilla.com> - Tue, 11 Jun 2019 16:10:24 +1000 - rev 2055382
Push 375698 by jteh@mozilla.com at Tue, 11 Jun 2019 06:15:08 +0000
Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika Previously, BrowserBridgeChild::SendSetEmbedderAccessible was only called when an OuterDocAccessible was constructed. However, it's also possible that the BrowserBridgeChild is created *after* the OuterDocAccessible. Therefore, we must also do this when a BrowserBridgeChild is created if the OuterDocAccessible already exists. Differential Revision: https://phabricator.services.mozilla.com/D34474
919b2065ce39f1c65f70bf48e086a9907daaa2fa: Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika draft
pulselistener - Tue, 11 Jun 2019 06:11:32 +0000 - rev 2055380
Push 375697 by reviewbot at Tue, 11 Jun 2019 06:12:10 +0000
Bug 1558390: For OOP iframes, also send the embedder accessible when the BrowserBridgeChild is created. r?yzen,nika Previously, BrowserBridgeChild::SendSetEmbedderAccessible was only called when an OuterDocAccessible was constructed. However, it's also possible that the BrowserBridgeChild is created *after* the OuterDocAccessible. Therefore, we must also do this when a BrowserBridgeChild is created if the OuterDocAccessible already exists. Differential Diff: PHID-DIFF-4luwijxdg7yqedxfp3kw
b21c3d2b73f9b1d93436f7caad89f07215a3c146: Bug 1555036 - If there is a Cross-Origin-Opener-Policy mismatch and the SANDBOXED_AUXILIARY_NAVIGATION is set navigate to a network error r=nika draft
pulselistener - Mon, 10 Jun 2019 21:06:53 +0000 - rev 2054586
Push 375467 by reviewbot at Mon, 10 Jun 2019 21:07:21 +0000
Bug 1555036 - If there is a Cross-Origin-Opener-Policy mismatch and the SANDBOXED_AUXILIARY_NAVIGATION is set navigate to a network error r=nika Differential Diff: PHID-DIFF-wzctvxzphks6pae222ah
bf5936dc3807e466c5a4d1eb583492408093ce05: Bug 1557808 - Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach. r=nika
Andrew McCreight <continuation@gmail.com> - Mon, 10 Jun 2019 15:13:24 +0000 - rev 2053865
Push 375286 by reviewbot at Mon, 10 Jun 2019 16:44:27 +0000
Bug 1557808 - Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach. r=nika The nsFrameLoader for the BrowserParent is always the toplevel <xul:browser>'s, but we actaully want to skip the detach for the browsing context for the current browser child. Differential Revision: https://phabricator.services.mozilla.com/D34237
bd7b19350b5a63d77f42c433e54da0e1e12f39bf: Bug 1557807 - Remove null check of sourceBc ContentChild::RecvWindowPostMessage(). r=nika
Andrew McCreight <continuation@gmail.com> - Mon, 10 Jun 2019 15:13:07 +0000 - rev 2053864
Push 375286 by reviewbot at Mon, 10 Jun 2019 16:44:27 +0000
Bug 1557807 - Remove null check of sourceBc ContentChild::RecvWindowPostMessage(). r=nika This can happen if the post message is sent to content by chrome. Differential Revision: https://phabricator.services.mozilla.com/D34236
fc77bf40c866ca6e66351264a71520c0130db955: Bug 1555963 - Add WindowGlobalParent.getSecurityInfo(). r=nika!,mconley! draft
Johann Hofmann <jhofmann@mozilla.com> - Mon, 10 Jun 2019 16:40:00 +0200 - rev 2053673
Push 375234 by jhofmann@mozilla.com at Mon, 10 Jun 2019 14:45:06 +0000
Bug 1555963 - Add WindowGlobalParent.getSecurityInfo(). r=nika!,mconley! This adds an API for fetching security info per frame, no matter if we have a certificate error or a valid certificate. I tried to make this work in a Fission-compatible way, let me know if this is the right approach. Differential Revision: https://phabricator.services.mozilla.com/D34354
0ab60f12dc90e3c442c10896795135f2469b3ee8: Bug 1555963 - Add WindowGlobalParent.getSecurityInfo(). r=nika!,mconley! draft
pulselistener - Mon, 10 Jun 2019 14:43:47 +0000 - rev 2053671
Push 375233 by reviewbot at Mon, 10 Jun 2019 14:44:34 +0000
Bug 1555963 - Add WindowGlobalParent.getSecurityInfo(). r=nika!,mconley! This adds an API for fetching security info per frame, no matter if we have a certificate error or a valid certificate. I tried to make this work in a Fission-compatible way, let me know if this is the right approach. Differential Diff: PHID-DIFF-2icb4dtkztd452b2gxox
d233afc387148395bf9a54e15273f3ef4a3089e2: Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika draft
pulselistener - Sun, 09 Jun 2019 20:29:47 +0000 - rev 2052765
Push 375002 by reviewbot at Sun, 09 Jun 2019 20:30:26 +0000
Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika Differential Revision: https://phabricator.services.mozilla.com/D32039 Differential Diff: PHID-DIFF-ehyzy7giyupw6av5atr5
cbc0b36d37408cb889df024b36f2419d1297a290: Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika draft
pulselistener - Sun, 09 Jun 2019 20:28:11 +0000 - rev 2052762
Push 375001 by reviewbot at Sun, 09 Jun 2019 20:28:51 +0000
Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika Differential Revision: https://phabricator.services.mozilla.com/D32039 Differential Diff: PHID-DIFF-ehyzy7giyupw6av5atr5
e6100a90a55df6cc52ff2e4942a7f72a815264a1: Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika draft
pulselistener - Sun, 09 Jun 2019 20:26:29 +0000 - rev 2052760
Push 375000 by reviewbot at Sun, 09 Jun 2019 20:27:02 +0000
Bug 1553254 - Part 1: Allow low-overhead selective collection of internal performance probes through ChromeUtils. r=brennie,nika Differential Revision: https://phabricator.services.mozilla.com/D32039 Differential Diff: PHID-DIFF-ehyzy7giyupw6av5atr5
242e08464aca0ee531796721b65adfa91680c4fc: Bug 1557254 - Enable char range check on Nightly/DevEdition and make warnings more dire. r?nika draft
pulselistener - Sun, 09 Jun 2019 15:16:46 +0000 - rev 2052661
Push 374972 by reviewbot at Sun, 09 Jun 2019 15:17:25 +0000
Bug 1557254 - Enable char range check on Nightly/DevEdition and make warnings more dire. r?nika Differential Diff: PHID-DIFF-gxwwzgktgq43oxudi3ip
8ae2df9c9015837edbb652dda68bedf9b7378194: Bug 1557808 - Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach. r=Nika draft
pulselistener - Fri, 07 Jun 2019 22:24:03 +0000 - rev 2051621
Push 374668 by reviewbot at Fri, 07 Jun 2019 22:24:53 +0000
Bug 1557808 - Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach. r=Nika The nsFrameLoader for the BrowserParent is always the toplevel <xul:browser>'s, but we actaully want to skip the detach for the browsing context for the current browser child. Differential Diff: PHID-DIFF-yznp7xkebvo6zavze6ww
0501226b80ff8253399f5056eec45935dd1dbfa3: Bug 1557807 - Remove null check of sourceBc ContentChild::RecvWindowPostMessage(). r=Nika draft
pulselistener - Fri, 07 Jun 2019 22:15:48 +0000 - rev 2051604
Push 374663 by reviewbot at Fri, 07 Jun 2019 22:16:26 +0000
Bug 1557807 - Remove null check of sourceBc ContentChild::RecvWindowPostMessage(). r=Nika This can happen if the post message is sent to content by chrome. Differential Diff: PHID-DIFF-ydutxzfxkoviauebjplp
dbadba1173067794fc3136c7d9f8624e4f9aa653: Bug 1557448 - Add this value for invocation callback; r=nika draft
pulselistener - Fri, 07 Jun 2019 20:44:04 +0000 - rev 2051421
Push 374601 by reviewbot at Fri, 07 Jun 2019 20:44:39 +0000
Bug 1557448 - Add this value for invocation callback; r=nika Differential Diff: PHID-DIFF-wxcag5kuu5e5r63rx6sm
ec7e71e43e11a35806ee1efc642667c5cf7de8af: Bug 1557808 - Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach. r=Nika draft
Andrew McCreight <continuation@gmail.com> - Fri, 07 Jun 2019 10:24:09 -0700 - rev 2051363
Push 374586 by amccreight@mozilla.com at Fri, 07 Jun 2019 20:16:58 +0000
Bug 1557808 - Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach. r=Nika The nsFrameLoader for the BrowserParent is always the toplevel <xul:browser>'s, but we actaully want to skip the detach for the browsing context for the current browser child.